Re: [target:for-next 20/20] drivers/scsi/virtio_scsi.c:531:48: error: dereferencing pointer to incomplete type

2014-05-23 Thread Paolo Bonzini
Il 22/05/2014 22:46, Nicholas A. Bellinger ha scritto: Hi Fengguang, On Thu, 2014-05-22 at 11:13 +0800, kbuild test robot wrote: tree: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git for-next head: 4baaa7d589e24bfe87dfd6c7a1229108be404a28 commit: 4baaa7d589e24bfe87dfd6

Re: dangling pointers and/or reentrancy in scmd_eh_abort_handler?

2014-05-23 Thread Paolo Bonzini
Il 23/05/2014 03:28, Elliott, Robert (Server Storage) ha scritto: Depending on the transport, there may be a race condition between the command status and the ABORT TASK response; the ABORT TASK response might get back first. I think that means scsi_eh_abort_handler's call to scsi_finish_command

Re: [PATCH RFC] Remove the cancel_delayed_work() call from scsi_put_command()

2014-05-23 Thread Paolo Bonzini
Il 23/05/2014 08:09, Hannes Reinecke ha scritto: And when freeing a command we absolutely need to make sure that the workqueue is empty. So calling cancel_delayed_work() was the obvious thing to do. You would need cancel_delayed_work_sync, but if it really happened that the work item is runni

Kei n D isp ok red it von Ihrer Hausbank?

2014-05-23 Thread Carina Busch
Einen schönen guten Tag, will die Bank nicht mitziehen, wenn Sie jetzt einen Kr edi t brauchen? Bleiben Sie bei Ihrer Bank, aber holen Sie sich Ihr Ge ld woanders. Auch bei schlechter Auskunft und zuvor von Ihrer eigenen Bank zurückgewiesenem Antrag können wir Ihnen frisches Geld vermitteln zu

Re: [PATCH RFC] Remove the cancel_delayed_work() call from scsi_put_command()

2014-05-23 Thread Bart Van Assche
On 05/23/14 11:24, Paolo Bonzini wrote: > Il 23/05/2014 08:09, Hannes Reinecke ha scritto: >> >> And when freeing a command we absolutely need to make sure that >> the workqueue is empty. >> So calling cancel_delayed_work() was the obvious thing to do. > > You would need cancel_delayed_work_sync,

Re: [PATCH RFC] Remove the cancel_delayed_work() call from scsi_put_command()

2014-05-23 Thread Paolo Bonzini
Il 23/05/2014 12:37, Bart Van Assche ha scritto: On 05/23/14 11:24, Paolo Bonzini wrote: Il 23/05/2014 08:09, Hannes Reinecke ha scritto: And when freeing a command we absolutely need to make sure that the workqueue is empty. So calling cancel_delayed_work() was the obvious thing to do. You

Re: [PATCH RFC] Remove the cancel_delayed_work() call from scsi_put_command()

2014-05-23 Thread Hannes Reinecke
On 05/23/2014 01:28 PM, Paolo Bonzini wrote: Il 23/05/2014 12:37, Bart Van Assche ha scritto: On 05/23/14 11:24, Paolo Bonzini wrote: Il 23/05/2014 08:09, Hannes Reinecke ha scritto: And when freeing a command we absolutely need to make sure that the workqueue is empty. So calling cancel_dela

[PATCH] virtio-scsi: replace target spinlock with seqcount

2014-05-23 Thread Ming Lei
The spinlock of tgt_lock is only for serializing read and write req_vq, one lockless seqcount is enough for the purpose. On one 16core VM with vhost-scsi backend, the patch can improve IOPS with 3% on random read test. Cc: Paolo Bonzini Signed-off-by: Ming Lei --- drivers/scsi/virtio_scsi.c |

Re: [PATCH] virtio-scsi: replace target spinlock with seqcount

2014-05-23 Thread Paolo Bonzini
Il 23/05/2014 15:28, Ming Lei ha scritto: The spinlock of tgt_lock is only for serializing read and write req_vq, one lockless seqcount is enough for the purpose. On one 16core VM with vhost-scsi backend, the patch can improve IOPS with 3% on random read test. Nice. :) The patch looks good, t

[PATCH 2/2] ibmvscsi: Add memory barriers for send / receive

2014-05-23 Thread Brian King
Add a memory barrier prior to sending a new command to the VIOS to ensure the VIOS does not receive stale data in the command buffer. Also add a memory barrier when processing the CRQ for completed commands. Signed-off-by: Brian King --- drivers/scsi/ibmvscsi/ibmvscsi.c | 10 ++ 1 fi

[PATCH 1/2] ibmvscsi: Abort init sequence during error recovery

2014-05-23 Thread Brian King
If a CRQ reset is triggered for some reason while in the middle of performing VSCSI adapter initialization, we don't want to call the done function for the initialization MAD commands as this will only result in two threads attempting initialization at the same time, resulting in failures. Signed

Re: [PATCH 1/2] ibmvscsi: Abort init sequence during error recovery

2014-05-23 Thread Brian King
Please ignore this, its broken... will resend... -Brian -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majord

[PATCHv2 1/2] ibmvscsi: Abort init sequence during error recovery

2014-05-23 Thread Brian King
If a CRQ reset is triggered for some reason while in the middle of performing VSCSI adapter initialization, we don't want to call the done function for the initialization MAD commands as this will only result in two threads attempting initialization at the same time, resulting in failures. Signed

[PATCHv2 2/2] ibmvscsi: Add memory barriers for send / receive

2014-05-23 Thread Brian King
Add a memory barrier prior to sending a new command to the VIOS to ensure the VIOS does not receive stale data in the command buffer. Also add a memory barrier when processing the CRQ for completed commands. Signed-off-by: Brian King --- drivers/scsi/ibmvscsi/ibmvscsi.c | 10 ++ 1 fi

Re: [PATCH 3/5] lpfc 10.2.8001.0: Removed obsolete PCI IDs from the driver

2014-05-23 Thread Hannes Reinecke
On 05/19/2014 07:39 PM, James Smart wrote: :) for those distros, that want to pull only upstream'd patches, and where customers expect someone to take phone calls on any hardware recognized by the distro... the patch is to remove the hardware Emulex/the distro won't answer any questions for anym

Re: [PATCHv2 1/2] ibmvscsi: Abort init sequence during error recovery

2014-05-23 Thread Bart Van Assche
On 05/23/14 17:52, Brian King wrote: > If a CRQ reset is triggered for some reason while in the middle > of performing VSCSI adapter initialization, we don't want to > call the done function for the initialization MAD commands as > this will only result in two threads attempting initialization > at

Re: [PATCH 1/5] ibmvstgt: remove

2014-05-23 Thread Brian King
On 04/15/2014 05:26 AM, Christoph Hellwig wrote: > The IBM virtual SCSI protocol has been obsoleted by ibmvfc, and there > are no reported of the driver left. Both ibmvscsi and ibmvfc are still very much in use on IBM Power hardware. ibmvfc is specific to NPIV configurations, while ibmvscsi can us

Re: [PATCHv2 1/2] ibmvscsi: Abort init sequence during error recovery

2014-05-23 Thread Brian King
On 05/23/2014 11:03 AM, Bart Van Assche wrote: > On 05/23/14 17:52, Brian King wrote: >> If a CRQ reset is triggered for some reason while in the middle >> of performing VSCSI adapter initialization, we don't want to >> call the done function for the initialization MAD commands as >> this will only

Re: [target:for-next 20/20] drivers/scsi/virtio_scsi.c:531:48: error: dereferencing pointer to incomplete type

2014-05-23 Thread Nicholas A. Bellinger
On Fri, 2014-05-23 at 11:20 +0200, Paolo Bonzini wrote: > Il 22/05/2014 22:46, Nicholas A. Bellinger ha scritto: > > Hi Fengguang, > > > > On Thu, 2014-05-22 at 11:13 +0800, kbuild test robot wrote: > >> tree: > >> git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git > >> for-ne

Get designer watches for less

2014-05-23 Thread Linux msdos
I now know where to get my trusted branded goods http://smilingsoulcoaching.com/llltdud.php -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] iser-target: Add missing target_put_sess_cmd for ImmedateData failure

2014-05-23 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch addresses a bug where an early exception for SCSI WRITE with ImmediateData=Yes was missing the target_put_sess_cmd() call to drop the extra se_cmd->cmd_kref reference obtained during the normal iscsit_setup_scsi_cmd() codepath execution. This bug was manifesti

[PATCH] qla2xxx: Convert to percpu_ida session tag pre-allocation

2014-05-23 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch converts qla2xxx target code to use generic percpu_ida tag allocation provided by target-core, thus removing the original kmem_cache_zalloc() for each struct qla_tgt_cmd descriptor in the incoming ATIO packet fast-path. This includes the conversion of qlt_hand

[PATCH] virtio-scsi: Implement change_queue_depth for virtscsi targets

2014-05-23 Thread Venkatesh Srinivas
change_queue_depth allows changing per-target queue depth via sysfs. It also allows the SCSI midlayer to ramp down the number of concurrent inflight requests in response to a SCSI BUSY status response and allows the midlayer to ramp the count back up to the device maximum when the BUSY condition h

Re: [PATCH] qla2xxx: Convert to percpu_ida session tag pre-allocation

2014-05-23 Thread Nicholas A. Bellinger
Hi Qlogic folks, A question for you below.. On Sat, 2014-05-24 at 00:43 +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > This patch converts qla2xxx target code to use generic percpu_ida > tag allocation provided by target-core, thus removing the original > kmem_cache_zalloc()