Re: scsi-mq

2014-06-17 Thread Jens Axboe
On 2014-06-17 07:27, Bart Van Assche wrote: On 06/12/14 15:48, Christoph Hellwig wrote: Bart and Robert have helped with some very detailed measurements that they might be able to send in reply to this, although these usually involve significantly reworked low level drivers to avoid other bottle

Re: [PATCH] pm80xx: Fix hibernation issue

2014-06-17 Thread Bradley Grove
James, The sleep is there to delay until the work kicked off by the scan start is complete. Jack Wang and I are working on a different fix that won't require the delay. Brad On 06/16/2014 08:04 PM, James Bottomley wrote: On Mon, 2014-06-16 at 15:30 -0400, bradley.gr...@gmail.com wrote: F

[PATCH 1/1] drivers/scsi/aic94xx/aic94xx_init.c: remove null test before kfree

2014-06-17 Thread Fabian Frederick
Fix checkpatch warning: WARNING: kfree(NULL) is safe this check is probably not required Cc: "James E.J. Bottomley" Cc: linux-scsi@vger.kernel.org Signed-off-by: Fabian Frederick --- drivers/scsi/aic94xx/aic94xx_init.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/driver

Re: [PATCH 11/24] drviers/scsi: check sysfs init return value via IS_ERR at iscsi_boot_create_kset

2014-06-17 Thread Greg KH
On Tue, Jun 17, 2014 at 10:34:50PM +0800, Jeff Liu wrote: > From: Jie Liu > > kset_create_and_add() has been fixed to return the actual error ptr > than NULL on failure, update iscsi_boot_create_kset() to check the > return value via IS_ERR() accordingly. > > Cc: James E.J. Bottomley > Cc: Greg

Re: [PATCH v2 2/2] ata: Fix the dma state machine lockup for the IDENTIFY DEVICE PIO mode command.

2014-06-17 Thread Tejun Heo
On Mon, Jun 16, 2014 at 03:05:36PM +0530, Suman Tripathi wrote: > This patch fixes the dma state machine lockup due to the IDENTIFY DEVICE PIO > mode command. The controller is unable to clear the BSY bit after receiving > the PIO setup FIS and results the dma state machine to go into the > CMFa

Re: [PATCH v2 1/2] libahci: Implement the function ahci_restart_engine to restart the port dma engine.

2014-06-17 Thread Tejun Heo
Hello, On Mon, Jun 16, 2014 at 03:05:35PM +0530, Suman Tripathi wrote: > This patch implements the function ahci_restart_engine function to restart > the port dma engine. Please fit the text under 80 column. > --- I can't apply w/o your SOB. > +int ahci_restart_engine(struct ata_port *ap) > +

[PATCH 11/24] drviers/scsi: check sysfs init return value via IS_ERR at iscsi_boot_create_kset

2014-06-17 Thread Jeff Liu
From: Jie Liu kset_create_and_add() has been fixed to return the actual error ptr than NULL on failure, update iscsi_boot_create_kset() to check the return value via IS_ERR() accordingly. Cc: James E.J. Bottomley Cc: Greg Kroah-Hartman Signed-off-by: Jie Liu --- drivers/scsi/iscsi_boot_sysfs

Re: scsi-mq

2014-06-17 Thread Bart Van Assche
On 06/12/14 15:48, Christoph Hellwig wrote: > Bart and Robert have helped with some very detailed measurements that they > might be able to send in reply to this, although these usually involve > significantly reworked low level drivers to avoid other bottle necks. In case someone would like to se

Re: [PATCH] pm8001: Fix potential null pointer dereference and memory leak.

2014-06-17 Thread Jack Wang
On 06/17/2014 01:15 PM, Maurizio Lombardi wrote: > The pm8001_get_phy_settings_info() function does not check > the kzalloc() return value and does not free the allocated memory. > > Signed-off-by: Maurizio Lombardi Looks good, thanks Acked-by: Jack Wang > --- > drivers/scsi/pm8001/pm8001_init

[PATCH] pm8001: Fix potential null pointer dereference and memory leak.

2014-06-17 Thread Maurizio Lombardi
The pm8001_get_phy_settings_info() function does not check the kzalloc() return value and does not free the allocated memory. Signed-off-by: Maurizio Lombardi --- drivers/scsi/pm8001/pm8001_init.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/pm8