On Thu, Jun 26, 2014 at 8:47 PM, Tomas Henzl wrote:
> In the driver two different functions are used to free the same resource,
> this patch makes the code easier to read. In addittion to that, some
> minor optimisations were made too.
>
> Signed-off-by: Tomas Henzl
Thanks Tomas. Looks good
Ack
On Thu, Jun 26, 2014 at 8:47 PM, Tomas Henzl wrote:
> The driver ignores the return value in a lot of places, fix it at
> least somewhere (and release the resources in such cases), to avoid
> that bad things happen.
>
> Signed-off-by: Tomas Henzl
> ---
> drivers/scsi/pm8001/pm8001_hwi.c | 27
On Thu, Jun 26, 2014 at 8:47 PM, Tomas Henzl wrote:
> The driver ignores the return value in a lot of places, fix
> it at least somewhere (and release the resources in such cases),
> to avoid that bad things happen.
> A memory leak is fixed too.
>
> Signed-off-by: Tomas Henzl
Thanks Tomas. Look
On Fri, Jun 27, 2014 at 3:51 PM, Tomas Henzl wrote:
> On 06/27/2014 08:09 AM, Viswas G wrote:
>> HI Tomas,
>>
>> This lock is not needed as we are already protecting the tag
>> allocation and freeing with the pm8001_ha->lock. We are always acquiring
>> this lock before calling pm8001_tag_alloc
Hi doug,
> ChangeLog:
> - add host_lock option whose default value is 0 which
> removes the host_lock around all queued commands
Any reason why we'd want to keep this? You suggest below that the PI
parts might need locking, but in that case we should keept it there
undconditionally until M
This patch addresses the dma state machine lockup for APM X-Gene SoC.
Signed-off-by: Loc Ho
Signed-off-by: Suman Tripathi
---
Suman Tripathi (2):
libahci: Implement the function ahci_restart_engine to restart the
port dma engine.
ata: Fix the dma state machine lockup for the IDENTIFY DE
This patch fixes the dma state machine lockup due to the processing
of IDENTIFY DEVICE PIO mode command. The X-Gene AHCI controller
has an errata in which it cannot clear the BSY bit after the PIO setup
FIS. The dma state machine enters CMFatalErrorUpdate state and locks
up. This patch also removes
This patch adds an function to restart the port dma engine.
This patch also exports the function ahci_qc_issue. The subsequent
patches will make use of them.
Signed-off-by: Loc Ho
Signed-off-by: Suman Tripathi
---
drivers/ata/ahci.h| 3 ++-
drivers/ata/libahci.c | 16 ++--
2 fi
On 01/07/14 9:54 pm, "micha...@cs.wisc.edu" wrote:
>From: Mike Christie
>
>The custom stats is an array with custom_length indicating the length
>of the array. This patch fixes bnx2i and be2iscsi's setting of the
>custom stats length. They both just have the one, eh_abort_cnt, so that
>should
Hi Sreekanth,
should I treat your replies as an Reviewd-by: or Acked-by: tag?
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 07/01/2014 06:16 AM, Paolo Bonzini wrote:
> Il 24/06/2014 16:28, Christoph Hellwig ha scritto:
>>> > Adding Paul and Nathan to cc here. I'm pretty sure the backend for
>>> > ibmvscsi in
>>> > KVM was all done in qemu and there is no dependency on ibmvstgt.
>>> >
>
> FWIW the ibmvscsi backend i
Hi Sagi
Your commit d77e65350f2d82dfa0557707d505711f5a43c8fd causes crash on SCSI
WRITE SAME command (it can be triggered by issuing the BLKZEROOUT ioctl).
The crash happens in iscsi_tcp_segment_done because sg_next returns NULL.
Before that commit, there was this code in iscsi_prep_scsi_cmd_pd
On Wed, Jul 02, 2014 at 02:05:14PM -0400, Mikulas Patocka wrote:
> Hi Sagi
>
> Your commit d77e65350f2d82dfa0557707d505711f5a43c8fd causes crash on SCSI
> WRITE SAME command (it can be triggered by issuing the BLKZEROOUT ioctl).
> The crash happens in iscsi_tcp_segment_done because sg_next retur
On Wed, 2 Jul 2014, Christoph Hellwig wrote:
> On Wed, Jul 02, 2014 at 02:05:14PM -0400, Mikulas Patocka wrote:
> > Hi Sagi
> >
> > Your commit d77e65350f2d82dfa0557707d505711f5a43c8fd causes crash on SCSI
> > WRITE SAME command (it can be triggered by issuing the BLKZEROOUT ioctl).
> > The c
On Wed, Jul 02, 2014 at 02:29:05PM -0400, Mikulas Patocka wrote:
> And what about protection information for commands that transfer partial
> sectors? (for example, UMAP transfers 24 bytes). Should
> scsi_transfer_length return 24 or 32 in this case?
As far as I understand so far PI is only defi
Hi Saran,
can you please test the patch below?
---
From: Christoph Hellwig
Subject: block: don't assume last put of shared tags is for the host
There is no inherent reason why the last put of a tag structure must be
the one for the Scsi_Host, as device model objects can be held for
arbitrary pe
On 07/02/2014 05:15 PM, Alex Williamson wrote:
> On Sat, 2014-06-28 at 10:47 -0700, Greg Kroah-Hartman wrote:
>> > 3.15-stable review patch. If anyone has any objections, please let me
>> > know.
>> >
>> > --
>> >
>> > From: Sagi Grimberg
>> >
>> > commit d77e65350f2d82dfa0557
On Wed, 2014-07-02 at 17:44 -0500, Mike Christie wrote:
> On 07/02/2014 05:15 PM, Alex Williamson wrote:
> > On Sat, 2014-06-28 at 10:47 -0700, Greg Kroah-Hartman wrote:
> >> > 3.15-stable review patch. If anyone has any objections, please let me
> >> > know.
> >> >
> >> > --
> >
On Wed, 2014-07-02 at 17:44 -0500, Mike Christie wrote:
> On 07/02/2014 05:15 PM, Alex Williamson wrote:
> > On Sat, 2014-06-28 at 10:47 -0700, Greg Kroah-Hartman wrote:
> >> > 3.15-stable review patch. If anyone has any objections, please let me
> >> > know.
> >> >
> >> > --
> >
On Wed, 2014-07-02 at 15:52 -0700, James Bottomley wrote:
> On Wed, 2014-07-02 at 17:44 -0500, Mike Christie wrote:
> > On 07/02/2014 05:15 PM, Alex Williamson wrote:
> > > On Sat, 2014-06-28 at 10:47 -0700, Greg Kroah-Hartman wrote:
> > >> > 3.15-stable review patch. If anyone has any objections,
On Wed, 2014-07-02 at 17:19 -0600, Alex Williamson wrote:
> On Wed, 2014-07-02 at 15:52 -0700, James Bottomley wrote:
> > On Wed, 2014-07-02 at 17:44 -0500, Mike Christie wrote:
> > > On 07/02/2014 05:15 PM, Alex Williamson wrote:
> > > > On Sat, 2014-06-28 at 10:47 -0700, Greg Kroah-Hartman wrote:
Am I dreaming, or was it formerly possible to view 20 SATA hard drives through
4 SATA port multipliers connected to 1 SAS board?
If it used to work, why did it stop working? Is this the reason:
[isci PATCH v2 15/18] libsas: drop sata port multiplier infrastructure
http://www.spinics.net/lists/l
On 14-07-02 06:15 AM, Christoph Hellwig wrote:
Hi doug,
ChangeLog:
- add host_lock option whose default value is 0 which
removes the host_lock around all queued commands
Any reason why we'd want to keep this? You suggest below that the PI
parts might need locking, but in that case we
Hi Hans,
please test the path below:
---
From: Christoph Hellwig
Subject: block: don't assume last put of shared tags is for the host
There is no inherent reason why the last put of a tag structure must be
the one for the Scsi_Host, as device model objects can be held for
arbitrary periods. Me
On Wed, Jul 02, 2014 at 04:48:37PM -0600, Alex Williamson wrote:
> Thanks for the pointer. It's curious why there was no objection to this
> going into stable if it's been known to be broken for a week.
I've never seen the stable patch on linux-scsi. IMHO it should never
have been proposed for -
On Wed, Jul 02, 2014 at 03:52:35PM -0700, James Bottomley wrote:
> In which case it's not marked for stable backport ... I assume it should
> be?
Only if the patch that regression went to stable, which it shouldn't,
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the b
26 matches
Mail list logo
