RE: [PATCH] qla4xxx: Return -ENOMEM on memory allocation failure

2014-07-04 Thread Julia Lawall
On Fri, 4 Jul 2014, Julia Lawall wrote: > > > On Fri, 4 Jul 2014, Elliott, Robert (Server Storage) wrote: > > > > > > > > -Original Message- > > > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > > > ow...@vger.kernel.org] On Behalf Of Himangi Saraogi > > > Sent: Friday,

RE: [PATCH] qla4xxx: Return -ENOMEM on memory allocation failure

2014-07-04 Thread Julia Lawall
On Fri, 4 Jul 2014, Elliott, Robert (Server Storage) wrote: > > > > -Original Message- > > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > > ow...@vger.kernel.org] On Behalf Of Himangi Saraogi > > Sent: Friday, 04 July, 2014 1:28 PM > > To: Vikas Chaudhary; iscsi-dri...@ql

RE: [PATCH 1/2] Use sdev_scsi2lun for SCSI parallel drivers

2014-07-04 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Douglas Gilbert > Sent: Friday, 04 July, 2014 2:44 PM > To: Hannes Reinecke; James Bottomley > Cc: Christoph Hellwig; linux-scsi@vger.kernel.org > Subject: Re: [PATCH 1/

RE: [PATCH] qla4xxx: Return -ENOMEM on memory allocation failure

2014-07-04 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Himangi Saraogi > Sent: Friday, 04 July, 2014 1:28 PM > To: Vikas Chaudhary; iscsi-dri...@qlogic.com; James E.J. Bottomley; linux- > s...@vger.kernel.org; linux-ker...@v

Re: [PATCH 1/2] Use sdev_scsi2lun for SCSI parallel drivers

2014-07-04 Thread Douglas Gilbert
On 14-07-04 07:54 AM, Hannes Reinecke wrote: SCSI-2 defines only up to 256 LUNs with a flat namespace. My SCSI-2 draft (revision 10b from August 1989) only has 3 bit LUNs placed in byte 1 of the command block, in the top 3 bits. There are also things called LUNTARs and LUNTRNs at the message le

RE: [PATCH] scsi: break from queue depth adjusting loops when device found

2014-07-04 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Friday, 04 July, 2014 5:53 AM > To: Christoph Hellwig; Stephen M. Cameron > Cc: james.bottom...@parallels.com; Elliott, Robert (Server Storage); > stephenmcame...@gmail.com; linux-scsi@vger.kernel.org; Vasu Dev; Mi

[PATCH 1/1] aic79xx: replace kmalloc/memset 0 by kzalloc

2014-07-04 Thread Fabian Frederick
Cc: Hannes Reinecke Cc: "James E.J. Bottomley" Cc: linux-scsi@vger.kernel.org Signed-off-by: Fabian Frederick --- drivers/scsi/aic7xxx/aic79xx_core.c | 3 +-- drivers/scsi/aic7xxx/aic79xx_osm.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/aic7xxx/aic79xx

Re: [PATCH] scsi: break from queue depth adjusting loops when device found

2014-07-04 Thread Douglas Gilbert
On 14-07-03 01:21 PM, Mike Christie wrote: On 07/03/2014 12:11 PM, Christoph Hellwig wrote: On Thu, Jul 03, 2014 at 10:05:57AM -0500, Stephen M. Cameron wrote: From: Stephen M. Cameron Don't loop through all the devices even after finding the one we're looking for The comments in the code s

[PATCH] qla4xxx: Return -ENOMEM on memory allocation failure

2014-07-04 Thread Himangi Saraogi
In this code, 0 is returned on memory allocation failure, even though other failures return -ENOMEM or other similar values. A simplified version of the Coccinelle semantic match that finds this problem is as follows: // @@ expression ret; expression x,e1,e2,e3; identifier alloc; @@ ret = 0 ...

Re: [PATCH 2/2] ib_srp: 64bit LUN fixes

2014-07-04 Thread Bart Van Assche
On 07/04/14 16:41, Hannes Reinecke wrote: > On 07/04/2014 04:38 PM, Bart Van Assche wrote: >> On 07/04/14 16:12, Hannes Reinecke wrote: >>> On 07/04/2014 03:48 PM, Christoph Hellwig wrote: I think storing the struct scsi_lun in the scsi_device is the right way to go ahead. Any "accessors

Re: Some question about usb scsi storage driver

2014-07-04 Thread Alan Stern
On Fri, 4 Jul 2014, loody wrote: > hi all: > when I trace kernel driver source about usb scsi storage driver, I > have below 2 questions: > 1. in sd.c -> static int sd_probe(struct device *dev) > we use below macro to get scsi_device. >struct scsi_device *sdp = to_scsi_device(dev);

Re: Some question about usb scsi storage driver

2014-07-04 Thread Maurizio Lombardi
On 07/04/2014 04:44 PM, loody wrote: > > 2. at the end of sd.c -> sd_probe, why we call async_schedule_domain like > below > async_schedule_domain(sd_probe_async, sdkp, &scsi_sd_probe_domain); > to finish scsi device initialization? > Couldn't we put what sd_probe_async directly i

uas - kernel panic on drive connection

2014-07-04 Thread Jonathan
Beginning with kernel 3.15.1, I am getting hard lockups every time I connect a drive to my USB 3 HDD dock with ASMedia ASM1051E UASP compliant chipset. The only way I am able work around this is to set the quirk to ignore uas for the device. Here are the kernel messages during connection followe

uas - kernel panic on drive connection

2014-07-04 Thread Jonathan
Beginning with kernel 3.15.1, I am getting hard lockups every time I connect a drive to my USB 3 HDD dock with ASMedia ASM1051E UASP compliant chipset. The only way I am able work around this is to set the quirk to ignore uas for the device. Here are the kernel messages during connection followed b

Some question about usb scsi storage driver

2014-07-04 Thread loody
hi all: when I trace kernel driver source about usb scsi storage driver, I have below 2 questions: 1. in sd.c -> static int sd_probe(struct device *dev) we use below macro to get scsi_device. struct scsi_device *sdp = to_scsi_device(dev); take usb for example, is usb storage dri

Re: [PATCH 2/2] ib_srp: 64bit LUN fixes

2014-07-04 Thread Hannes Reinecke
On 07/04/2014 04:38 PM, Bart Van Assche wrote: On 07/04/14 16:12, Hannes Reinecke wrote: On 07/04/2014 03:48 PM, Christoph Hellwig wrote: I think storing the struct scsi_lun in the scsi_device is the right way to go ahead. Any "accessors" for 8 or 32-bit LUNs should be simply enough by just ig

Re: [PATCH 2/2] ib_srp: 64bit LUN fixes

2014-07-04 Thread Bart Van Assche
On 07/04/14 16:12, Hannes Reinecke wrote: > On 07/04/2014 03:48 PM, Christoph Hellwig wrote: >> I think storing the struct scsi_lun in the scsi_device is the right way >> to go ahead. Any "accessors" for 8 or 32-bit LUNs should be simply >> enough by just ignoring bits in the array, so there's ver

virtio_scsi LUN usage

2014-07-04 Thread Hannes Reinecke
Hi Paolo, virtio_scsi has this: static void virtio_scsi_init_hdr(struct virtio_scsi_cmd_req *cmd, struct scsi_cmnd *sc) { cmd->lun[0] = 1; cmd->lun[1] = sc->device->id; cmd->lun[2] = (sc->device->lun >> 8) | 0x40; cmd->lun[3] = sc-

Re: [PATCH 2/2] ib_srp: 64bit LUN fixes

2014-07-04 Thread Hannes Reinecke
On 07/04/2014 03:48 PM, Christoph Hellwig wrote: On Fri, Jul 04, 2014 at 03:01:40PM +0200, Hannes Reinecke wrote: What I would like to do is to provide accessor functions for the scsi lun; I've started this already for the older SCSI parallel drivers (see my earlier patch). Once everything is mo

Re: [PATCH 1/2] Use sdev_scsi2lun for SCSI parallel drivers

2014-07-04 Thread Hannes Reinecke
On 07/04/2014 03:44 PM, Christoph Hellwig wrote: On Fri, Jul 04, 2014 at 01:54:34PM +0200, Hannes Reinecke wrote: SCSI-2 defines only up to 256 LUNs with a flat namespace. This patch introduces an accessor 'sdev_scsi2lun' which should be used for these drivers to avoid problems when using 64-bit

Re: [PATCH 2/2] ib_srp: 64bit LUN fixes

2014-07-04 Thread Christoph Hellwig
On Fri, Jul 04, 2014 at 03:01:40PM +0200, Hannes Reinecke wrote: > What I would like to do is to provide accessor functions for the scsi lun; > I've started this already for the older SCSI parallel drivers (see my > earlier patch). > Once everything is moved over to accessors it should be trivial t

Re: [PATCH 1/2] Use sdev_scsi2lun for SCSI parallel drivers

2014-07-04 Thread Christoph Hellwig
On Fri, Jul 04, 2014 at 01:54:34PM +0200, Hannes Reinecke wrote: > SCSI-2 defines only up to 256 LUNs with a flat namespace. > This patch introduces an accessor 'sdev_scsi2lun' which should be > used for these drivers to avoid problems when using 64-bit LUNs > internally. So what would be set in t

Re: [PATCH 2/2] ib_srp: 64bit LUN fixes

2014-07-04 Thread Hannes Reinecke
On 07/04/2014 02:31 PM, Bart Van Assche wrote: On 07/04/14 13:54, Hannes Reinecke wrote: SRP is capable of handling 64bit LUNs, so as we now have proper support for it we can modify the driver to use the standard functions. Cc: Bart van Assche Signed-off-by: Hannes Reinecke --- drivers/infi

Re: [PATCH 2/2] ib_srp: 64bit LUN fixes

2014-07-04 Thread Bart Van Assche
On 07/04/14 13:54, Hannes Reinecke wrote: > SRP is capable of handling 64bit LUNs, so as we now have proper > support for it we can modify the driver to use the standard functions. > > Cc: Bart van Assche > Signed-off-by: Hannes Reinecke > --- > drivers/infiniband/ulp/srp/ib_srp.c | 9 ++-- >

[PATCH 2/2] ib_srp: 64bit LUN fixes

2014-07-04 Thread Hannes Reinecke
SRP is capable of handling 64bit LUNs, so as we now have proper support for it we can modify the driver to use the standard functions. Cc: Bart van Assche Signed-off-by: Hannes Reinecke --- drivers/infiniband/ulp/srp/ib_srp.c | 9 ++-- drivers/infiniband/ulp/srpt/ib_srpt.c | 81 +

[PATCH 0/2] Fixed for 64bit LUNs

2014-07-04 Thread Hannes Reinecke
Hi Christoph, here are some more fixes for 64bit LUNs, which should fix the latest built issues from Fengguang. Most notably I've introduced a new accessor 'sdev_scsi2lun' for those devices which are not capable of handling LUNs higher than 255. And I've removed the custom LUN handling code from i

Re: how to firing device event when SD card inserting usb card reader

2014-07-04 Thread loody
hi Alan: 2014-06-26 23:57 GMT+08:00 Alan Stern : > On Thu, 26 Jun 2014, loody wrote: > >> hi all: >> I try below flow: >> 1. plug in usb card reader >> 2. wait 2 seconds >> 3. plug in SD card >> >> on ubuntu PC system, the udev can get SD plug in event >> but on my embedded system, there is no ude

Re: tgt infrastructure removal

2014-07-04 Thread Hannes Reinecke
On 07/04/2014 11:52 AM, Paolo Bonzini wrote: Il 04/07/2014 11:36, Christoph Hellwig ha scritto: I got an older Ack from Tomo for the removal, and some sort of acks for the ibmvscsi target removal from Brian, Paolo and Nathan. Can I get some formal reviews for the code removal patches (1-4) so I

Re: [PATCH] scsi: break from queue depth adjusting loops when device found

2014-07-04 Thread Hannes Reinecke
On 07/03/2014 07:11 PM, Christoph Hellwig wrote: On Thu, Jul 03, 2014 at 10:05:57AM -0500, Stephen M. Cameron wrote: From: Stephen M. Cameron Don't loop through all the devices even after finding the one we're looking for The comments in the code seem to indicate that we want to modify the q

Re: tgt infrastructure removal

2014-07-04 Thread Paolo Bonzini
Il 04/07/2014 11:36, Christoph Hellwig ha scritto: I got an older Ack from Tomo for the removal, and some sort of acks for the ibmvscsi target removal from Brian, Paolo and Nathan. Can I get some formal reviews for the code removal patches (1-4) so I can queue this up for 3.17? Not that there'

Re: [PATCH 5/5] scsi: remove various exports that were only used by scsi_tgt

2014-07-04 Thread Paolo Bonzini
Il 15/04/2014 12:26, Christoph Hellwig ha scritto: Signed-off-by: Christoph Hellwig --- drivers/scsi/scsi.c | 10 +++--- drivers/scsi/scsi_lib.c | 10 -- include/scsi/scsi_cmnd.h |5 - include/scsi/scsi_host.h |2 -- 4 files changed, 7 insertions(+), 20 deletio

Re: tgt infrastructure removal

2014-07-04 Thread Christoph Hellwig
I got an older Ack from Tomo for the removal, and some sort of acks for the ibmvscsi target removal from Brian, Paolo and Nathan. Can I get some formal reviews for the code removal patches (1-4) so I can queue this up for 3.17? I'll have to redo patch 5 for various changes and will resend it in t