Re: [PATCH] bnx2fc: fix incorrect DMA memory mapping in bnx2fc_map_sg()

2014-08-22 Thread Maurizio Lombardi
Hi Eddie, On 08/20/2014 07:35 PM, Eddie Wai wrote: On Mon, 2014-08-04 at 10:20 +0200, Maurizio Lombardi wrote: In the bnx2fc_map_sg() function, the original behaviour is to allocate the DMA memory by directly calling dma_map_sg() instead of using scsi_dma_map(). In contrast,

Re: [PATCH V5 2/5] Add XEN pvSCSI protocol description

2014-08-22 Thread David Vrabel
On 18/08/14 10:31, jgr...@suse.com wrote: - add support for larger SG-lists by putting them in an own granted page As a reminder, this can't be acked until this protocol change has been applied to Xen copy of this header. David -- To unsubscribe from this list: send the line unsubscribe

Re: [Xen-devel] [PATCH V5 2/5] Add XEN pvSCSI protocol description

2014-08-22 Thread Christoph Hellwig
On Fri, Aug 22, 2014 at 06:18:03AM +0200, Juergen Gross wrote: The resulting number of struct scsiif_request_segment is the sum of seg[0..nr_segments-1].length / sizeof(struct scsiif_request_segment). Where the nr_segments can only go Up to VSCSIIF_SG_TABLESIZE, so the max total SG entries

Re: [PATCH] bnx2fc: fix incorrect DMA memory mapping in bnx2fc_map_sg()

2014-08-22 Thread Chad Dupuis
Eddie, Maurizio, Since it looks like there can be a difference in the pdev would it make sense instead to convert the unmap function to use the bare DMA API so we're consistent in our use of hba-pcidev-dev? Maybe something like this: diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c

Re: [PATCH] bnx2fc: fix incorrect DMA memory mapping in bnx2fc_map_sg()

2014-08-22 Thread Christoph Hellwig
On Fri, Aug 22, 2014 at 08:08:33AM -0400, Chad Dupuis wrote: Eddie, Maurizio, Since it looks like there can be a difference in the pdev would it make sense instead to convert the unmap function to use the bare DMA API so we're consistent in our use of hba-pcidev-dev? Maybe something like

[Bug 81861] Oops by mvsas v0.8.16: sas: ataX: end_device-Y:0:Z: dev error handler - general protection fault, RIP: mvs_task_prep_ata+0x80/0x3a0

2014-08-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=81861 --- Comment #6 from linux-...@crashplan.pro --- When connecting just a single 4 drive group to the good ports (for example 2C) of the external PCIe expander card: cold boot = doesn't detect any of the 4 PUIS drives warm boot = does detect all 4

[Bug 81861] Oops by mvsas v0.8.16: sas: ataX: end_device-Y:0:Z: dev error handler - general protection fault, RIP: mvs_task_prep_ata+0x80/0x3a0

2014-08-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=81861 --- Comment #7 from linux-...@crashplan.pro --- Created attachment 147751 -- https://bugzilla.kernel.org/attachment.cgi?id=147751action=edit smartctl -a /dev/sdb (HDS5C3020BLE630) -- You are receiving this mail because: You are watching the

[Bug 81861] Oops by mvsas v0.8.16: sas: ataX: end_device-Y:0:Z: dev error handler - general protection fault, RIP: mvs_task_prep_ata+0x80/0x3a0

2014-08-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=81861 --- Comment #8 from linux-...@crashplan.pro --- Comment on attachment 145681 -- https://bugzilla.kernel.org/attachment.cgi?id=145681 Dmesg output from boot This is without loading the mvsas kernel module. -- You are receiving this mail

[PATCH] drivers: scsi: #define missing include guards

2014-08-22 Thread Rasmus Villemoes
The four files aha1542.h, aha1740.h, gvp11.h and mvme147.h under drivers/scsi/ contain two-thirds of an include guard, but do not elsewhere. Signed-off-by: Rasmus Villemoes li...@rasmusvillemoes.dk --- drivers/scsi/aha1542.h | 1 + drivers/scsi/aha1740.h | 1 + drivers/scsi/gvp11.h | 1 +

[PATCH] drivers: target: target_core_ua_h: Add #define of include guard

2014-08-22 Thread Rasmus Villemoes
Clearly the file was meant to contain an include guard, but it was missing the #define part. Signed-off-by: Rasmus Villemoes li...@rasmusvillemoes.dk --- drivers/target/target_core_ua.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/target/target_core_ua.h

[Bug 81861] Oops by mvsas v0.8.16: sas: ataX: end_device-Y:0:Z: dev error handler - general protection fault, RIP: mvs_task_prep_ata+0x80/0x3a0

2014-08-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=81861 --- Comment #9 from linux-...@crashplan.pro --- re: Thats not a sensible resolution, it can't be faulting on that line. Another try using a newer version of package gdb-minimal (Ubuntu 7.7-0ubuntu3.2 from trusty-proposed) gives these identical

Re: [PATCH] drivers: scsi: #define missing include guards

2014-08-22 Thread Rasmus Villemoes
Rasmus Villemoes li...@rasmusvillemoes.dk writes: The four files aha1542.h, aha1740.h, gvp11.h and mvme147.h under drivers/scsi/ contain two-thirds of an include guard, but do not elsewhere. Argh, git commit ate a line because it happened to start with #. This was supposed to be something

[Bug 81861] Oops by mvsas v0.8.16: sas: ataX: end_device-Y:0:Z: dev error handler - general protection fault, RIP: mvs_task_prep_ata+0x80/0x3a0

2014-08-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=81861 --- Comment #10 from linux-...@crashplan.pro --- Another test round to see whether there is a difference in crash whether using cold or warm boot: 5C + cold boot = mvs_task_prep+0x72e/0xd50 [mvsas] 5C + warm boot = mvs_task_prep+0x72e/0xd50

RE: [PATCH v3 08/13] be2iscsi: Use pci_enable_msix_range()

2014-08-22 Thread Jayamohan Kallickal
-Original Message- From: Tomas Henzl [mailto:the...@redhat.com] Sent: Thursday, August 21, 2014 4:10 AM To: Alexander Gordeev; linux-ker...@vger.kernel.org Cc: Jayamohan Kallickal; linux-scsi@vger.kernel.org; linux-...@vger.kernel.org Subject: Re: [PATCH v3 08/13] be2iscsi: Use

Re: [Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-22 Thread Alan Stern
On Thu, 21 Aug 2014, Christoph Hellwig wrote: On Thu, Aug 21, 2014 at 05:43:41PM -0400, Martin K. Petersen wrote: Alan Okay, here's a patch that implements the suggestion, except that I Alan put the flag in the Scsi_Host structure instead of the template. Alan This was to minimize the

Re: [Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-22 Thread Christoph Hellwig
On Fri, Aug 22, 2014 at 10:53:42AM -0400, Alan Stern wrote: Good idea. An enhanced patch is below. If I can get a Tested-By: from Tiziano and one or two Acked-By: responses, I'll submit this for the current and stable kernels. Sending the initial INQUIRY command to LUNs larger than 0

[Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=80711 --- Comment #15 from Martin K. Petersen martin.peter...@oracle.com --- Alan == Alan Stern st...@rowland.harvard.edu writes: Alan Sending the initial INQUIRY command to LUNs larger than 0 involves Alan a chicken-and-egg problem -- we don't know

Re: [Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-22 Thread Martin K. Petersen
Alan == Alan Stern st...@rowland.harvard.edu writes: Alan Sending the initial INQUIRY command to LUNs larger than 0 involves Alan a chicken-and-egg problem -- we don't know whether to fill in the Alan LUN bits in the command until we know the SCSI level, and we don't Alan know the SCSI level

[Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=80711 --- Comment #16 from Alan Stern st...@rowland.harvard.edu --- On Fri, 22 Aug 2014, Christoph Hellwig wrote: On Fri, Aug 22, 2014 at 10:53:42AM -0400, Alan Stern wrote: Good idea. An enhanced patch is below. If I can get a Tested-By: from

Re: [Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-22 Thread Alan Stern
On Fri, 22 Aug 2014, Christoph Hellwig wrote: On Fri, Aug 22, 2014 at 10:53:42AM -0400, Alan Stern wrote: Good idea. An enhanced patch is below. If I can get a Tested-By: from Tiziano and one or two Acked-By: responses, I'll submit this for the current and stable kernels. Sending

Re: [Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-22 Thread James Bottomley
On Fri, 2014-08-22 at 10:53 -0400, Alan Stern wrote: On Thu, 21 Aug 2014, Christoph Hellwig wrote: On Thu, Aug 21, 2014 at 05:43:41PM -0400, Martin K. Petersen wrote: Alan Okay, here's a patch that implements the suggestion, except that I Alan put the flag in the Scsi_Host structure

Re: [RESEND][PATCH 8/8][SCSI]mpt3sas: Bump mpt3sas driver version to 04.100.00.00

2014-08-22 Thread Sreekanth Reddy
Hi Martin, Today I was busy with the internal activity. By Monday I will repost this patch with requested changes. Thanks, Sreekanth On Fri, Aug 22, 2014 at 2:40 AM, Martin K. Petersen martin.peter...@oracle.com wrote: Sreekanth == Sreekanth Reddy sreekanth.re...@avagotech.com writes:

Re: [PATCH v3 13/17] arcmsr: fix ioctl data read/write error for adapter type C

2014-08-22 Thread Tomas Henzl
On 08/19/2014 09:17 AM, Ching Huang wrote: From: Ching Huang ching2...@areca.com.tw Rewrite ioctl entry and its relate function. This patch fix ioctl data read/write error and change data I/O access from byte to Dword. Signed-off-by: Ching Huang ching2...@areca.com.tw --- diff -uprN

Re: [PATCH/RESEND] scsi.mq: Added use_cmd_list flag in scsi_host to reduce lock contention

2014-08-22 Thread Bart Van Assche
On 08/20/14 15:54, kashyap.de...@avagotech.com wrote: Comment provided by Bart Van and Chris H is addressed in this patch. Add use_cmd_list flag in scsi_host to indicate scs.mq stack to keep track of cmd_list per sdev. Default behaviour is not to keep track of cmd_list per sdev, as this

Re: [PATCH v3 0/17] arcmsr: change note since v13 or v2

2014-08-22 Thread Tomas Henzl
On 08/19/2014 05:02 PM, Christoph Hellwig wrote: Hi Ching, I've fixed up various checkpatch errors and fixed up some descriptions and applied the patches to a branch. This includes patch 4, so please send a fix for this and any other patches relative to the branch. Please find the branch

[Bug 81861] Oops by mvsas v0.8.16: sas: ataX: end_device-Y:0:Z: dev error handler - general protection fault, RIP: mvs_task_prep_ata+0x80/0x3a0

2014-08-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=81861 --- Comment #11 from linux-...@crashplan.pro --- Created attachment 147771 -- https://bugzilla.kernel.org/attachment.cgi?id=147771action=edit sg_ses PCIe port expander card output -- You are receiving this mail because: You are watching the

Re: [Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-22 Thread Alan Stern
On Fri, 22 Aug 2014, James Bottomley wrote: On Fri, 2014-08-22 at 10:53 -0400, Alan Stern wrote: Sending the initial INQUIRY command to LUNs larger than 0 involves a chicken-and-egg problem -- we don't know whether to fill in the LUN bits in the command until we know the SCSI level, and

[Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=80711 --- Comment #17 from Alan Stern st...@rowland.harvard.edu --- On Fri, 22 Aug 2014, James Bottomley wrote: On Fri, 2014-08-22 at 10:53 -0400, Alan Stern wrote: Sending the initial INQUIRY command to LUNs larger than 0 involves a

[Bug 81861] Oops by mvsas v0.8.16: sas: ataX: end_device-Y:0:Z: dev error handler - general protection fault, RIP: mvs_task_prep_ata+0x80/0x3a0

2014-08-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=81861 --- Comment #12 from Alan a...@lxorguk.ukuu.org.uk --- 0xa01c481e +1838:mov0x254(%rbx),%ecx is loading an offset from something. It can't be line 471. It could be line 472, or could be 468. but the offset looks way too big to

Re: [PATCH] bnx2fc: fix incorrect DMA memory mapping in bnx2fc_map_sg()

2014-08-22 Thread Maurizio Lombardi
Hi Chad, On 08/22/2014 02:08 PM, Chad Dupuis wrote: Eddie, Maurizio, Since it looks like there can be a difference in the pdev would it make sense instead to convert the unmap function to use the bare DMA API so we're consistent in our use of hba-pcidev-dev? Maybe something like this: I

Re: [RFC PATCH -logging 00/10] scsi/constants: Output continuous error messages on trace

2014-08-22 Thread Douglas Gilbert
On 14-08-12 11:13 PM, Yoshihiro YUNOMAE wrote: Hi Douglas, Thank you for your comment. (2014/08/08 22:07), Douglas Gilbert wrote: On 14-08-08 01:50 PM, Yoshihiro YUNOMAE wrote: Hi All, This patch set introduces new traceevents in order to output continuous error messages. Current SCSI

[PATCH][SCSI] scsi-mq: fix requests that use a separate CDB buffer

2014-08-22 Thread Tony Battersby
This patch fixes code such as the following with scsi-mq enabled: rq = blk_get_request(...); blk_rq_set_block_pc(rq); rq-cmd = my_cmd_buffer; /* separate CDB buffer */ blk_execute_rq_nowait(...); Code like this appears in e.g. sg_start_req() in drivers/scsi/sg.c (for large CDBs

[PATCH][SCSI] fix regression in SCSI_IOCTL_SEND_COMMAND

2014-08-22 Thread Tony Battersby
blk_rq_set_block_pc() memsets rq-cmd to 0, so it should come immediately after blk_get_request() to avoid overwriting the user-supplied CDB. Also check for failure to allocate rq. Fixes: f27b087b81b7 (block: add blk_rq_set_block_pc()) Cc: sta...@vger.kernel.org # 3.16.x Signed-off-by: Tony

Re: [PATCH] target: target_core_transport.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-08-22 Thread Nicholas A. Bellinger
Hi Rickard, On Sun, 2014-08-03 at 23:50 +0200, Rickard Strandqvist wrote: Ensures that the string is null-terminate in connection with the use of strncpy. Optimized code by replacing unnecessary sprintf with strlcat and more, and simultaneously guarantees that the string does not get bigger

Re: [PATCH] tcm_fc: Replace rcu_assign_pointer() with RCU_INIT_POINTER()

2014-08-22 Thread Nicholas A. Bellinger
Hi Andreea-Cristina, On Mon, 2014-08-18 at 15:05 +0300, Andreea-Cristina Bernat wrote: The use of rcu_assign_pointer() is NULLing out the pointer. According to RCU_INIT_POINTER()'s block comment: 1. This use of RCU_INIT_POINTER() is NULLing out the pointer it is better to use it instead of

Re: [PATCH] drivers: target: target_core_ua_h: Add #define of include guard

2014-08-22 Thread Nicholas A. Bellinger
Hi Rasmus, On Fri, 2014-08-22 at 14:54 +0200, Rasmus Villemoes wrote: Clearly the file was meant to contain an include guard, but it was missing the #define part. Signed-off-by: Rasmus Villemoes li...@rasmusvillemoes.dk --- drivers/target/target_core_ua.h | 1 + 1 file changed, 1

Re: [PATCH V5 0/5] Add XEN pvSCSI support

2014-08-22 Thread Nicholas A. Bellinger
Hi Juergen Co, On Mon, 2014-08-18 at 11:31 +0200, jgr...@suse.com wrote: This series adds XEN pvSCSI support. With pvSCSI it is possible to use physical SCSI devices from a XEN domain. The support consists of a backend in the privileged Domain-0 doing the real I/O and a frontend in the

Re: [PATCHv3 0/8] target: Save memory on unused se_dev_entrys and se_luns

2014-08-22 Thread Andy Grover
On 07/29/2014 06:15 AM, Christoph Hellwig wrote: Nic, any progress on looking over these? Seems like there's actually nothing at all queued up for 3.17 in the target tree, or am І missing something? ping? -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of

Re: [PATCH] bnx2fc: fix incorrect DMA memory mapping in bnx2fc_map_sg()

2014-08-22 Thread Eddie Wai
On Fri, 2014-08-22 at 20:12 +0200, Maurizio Lombardi wrote: Hi Chad, On 08/22/2014 02:08 PM, Chad Dupuis wrote: Eddie, Maurizio, Since it looks like there can be a difference in the pdev would it make sense instead to convert the unmap function to use the bare DMA API so we're

Re: [PATCH] bnx2fc: do not add shared skbs to the fcoe_rx_list

2014-08-22 Thread Eddie Wai
On Fri, 2014-07-25 at 10:12 +0200, Maurizio Lombardi wrote: Hi Eddie, just want to add you to the CC list. Some days ago the bnx2fc's maintainer email address has been updated, this should be the new one: qlogic-storage-upstr...@qlogic.com I tried to send this patch to the new address

Re: [PATCH][SCSI] fix regression in SCSI_IOCTL_SEND_COMMAND

2014-08-22 Thread Douglas Gilbert
On 14-08-22 03:53 PM, Tony Battersby wrote: blk_rq_set_block_pc() memsets rq-cmd to 0, so it should come immediately after blk_get_request() to avoid overwriting the user-supplied CDB. Also check for failure to allocate rq. Fixes: f27b087b81b7 (block: add blk_rq_set_block_pc()) Cc:

Re: [PATCH][SCSI] fix regression in SCSI_IOCTL_SEND_COMMAND

2014-08-22 Thread Christoph Hellwig
On Fri, Aug 22, 2014 at 08:28:27PM -0400, Douglas Gilbert wrote: To test this ioctl one option is to get the sg3_utils package and build scsi_ioctl.c in the examples directory with 'make scsi_ioctl'. In lk 3.17-rc1, scsi_ioctl indicates that SCSI_IOCTL_SEND_COMMAND is not working. In my test

Re: [Xen-devel] [PATCH V5 3/5] Introduce xen-scsifront module

2014-08-22 Thread Konrad Rzeszutek Wilk
--- /dev/null +++ b/drivers/scsi/xen-scsifront.c @@ -0,0 +1,1017 @@ +/* + * Xen SCSI frontend driver + * + * Copyright (c) 2008, FUJITSU Limited + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License version 2

Re: [Xen-devel] [PATCH V5 0/5] Add XEN pvSCSI support

2014-08-22 Thread Konrad Rzeszutek Wilk
On Fri, Aug 22, 2014 at 02:21:55PM -0700, Nicholas A. Bellinger wrote: Hi Juergen Co, On Mon, 2014-08-18 at 11:31 +0200, jgr...@suse.com wrote: This series adds XEN pvSCSI support. With pvSCSI it is possible to use physical SCSI devices from a XEN domain. The support consists of a

Re: [PATCH][SCSI] scsi-mq: fix requests that use a separate CDB buffer

2014-08-22 Thread Douglas Gilbert
On 14-08-22 03:53 PM, Tony Battersby wrote: This patch fixes code such as the following with scsi-mq enabled: rq = blk_get_request(...); blk_rq_set_block_pc(rq); rq-cmd = my_cmd_buffer; /* separate CDB buffer */ blk_execute_rq_nowait(...); Code like this appears in e.g.

Re: [PATCH][SCSI] scsi-mq: fix requests that use a separate CDB buffer

2014-08-22 Thread Douglas Gilbert
On 14-08-22 08:52 PM, Douglas Gilbert wrote: On 14-08-22 03:53 PM, Tony Battersby wrote: This patch fixes code such as the following with scsi-mq enabled: rq = blk_get_request(...); blk_rq_set_block_pc(rq); rq-cmd = my_cmd_buffer; /* separate CDB buffer */