Looks good to me. Can I get a quick second review?
On Fri, Sep 19, 2014 at 12:17:27PM +0530, Sreekanth Reddy wrote:
This patch will fix the below compilation errors on i386 ARCH
drivers/built-in.o: In function `_scsih_qcmd':
mpt2sas_scsih.c:(.text+0x1e7b56): undefined reference to
This patch fixes the error print invalid resource for the APM X-Gene
SoC AHCI SATA Host Controller driver. This print was due to the fact
that the controller 3 don't have a mux resource. This didn't result
in any errors but the print seems like meaningless.
Signed-off-by: Loc Ho l...@apm.com
Sreekanth == Sreekanth Reddy sreekanth.re...@avagotech.com writes:
Sreekanth This patch will fix the below compilation errors on i386 ARCH
Sreekanth drivers/built-in.o: In function `_scsih_qcmd':
Sreekanth mpt2sas_scsih.c:(.text+0x1e7b56): undefined reference to
Sreekanth `__udivdi3'
Fix two regressions with the timer/blk_mq_start_request changes found
when using scsi-mq on an ATA device.
Note that given how late we are in the cycle I wonder if we really should
push the changes in block/for-linus to Linus in this cycle. The race
part of the timer fixes is extremly narrow,
Signed-off-by: Christoph Hellwig h...@lst.de
---
block/blk-mq.c | 2 +-
block/blk-timeout.c | 5 -
block/blk.h | 2 ++
3 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index 966c920..aeac4b7 100644
--- a/block/blk-mq.c
+++
On 2014-09-22 07:59, Christoph Hellwig wrote:
Fix two regressions with the timer/blk_mq_start_request changes found
when using scsi-mq on an ATA device.
Note that given how late we are in the cycle I wonder if we really should
push the changes in block/for-linus to Linus in this cycle. The
On 2014-09-22 07:59, Christoph Hellwig wrote:
Signed-off-by: Christoph Hellwig h...@lst.de
---
block/blk-mq.c | 2 +-
block/blk-timeout.c | 5 -
block/blk.h | 2 ++
3 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/block/blk.h b/block/blk.h
index
On Thu, Sep 18, 2014 at 12:12:22PM -0700, Subhash Jadavani wrote:
Hi Chris,
While testing with another vendor's UFS devices, I realized that SELECT
REPORT need not to be set to 0x02 for making the device report the W-LUs.
Even when SELECT REPORT is set 0x00, this particular UFS device
Hi Bart,
I like these changes modulo the minor comments we had.
One thing that is missing is generation multiqueue-aware tags at the
blk-mq level, which should be as simple as always adding a queue
prefix in the tag allocation code. Did you consider switching srp
to use the block layer provided
On Fri, Sep 19, 2014 at 04:50:59PM -0700, Randy Dunlap wrote:
--- linux-next-20140918.orig/drivers/scsi/qla2xxx/Kconfig
+++ linux-next-20140918/drivers/scsi/qla2xxx/Kconfig
@@ -30,7 +30,7 @@ config SCSI_QLA_FC
config TCM_QLA2XXX
tristate TCM_QLA2XXX fabric module for Qlogic 2xxx
Thanks,
applied.
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Christoph Hellwig h...@infradead.org
Date: Mon, 22 Sep 2014 07:42:13 -0700
On Fri, Sep 19, 2014 at 04:50:59PM -0700, Randy Dunlap wrote:
--- linux-next-20140918.orig/drivers/scsi/qla2xxx/Kconfig
+++ linux-next-20140918/drivers/scsi/qla2xxx/Kconfig
@@ -30,7 +30,7 @@ config SCSI_QLA_FC
From: Christoph Hellwig h...@infradead.org
Date: Mon, 22 Sep 2014 07:42:13 -0700
On Fri, Sep 19, 2014 at 04:50:59PM -0700, Randy Dunlap wrote:
--- linux-next-20140918.orig/drivers/scsi/qla2xxx/Kconfig
+++ linux-next-20140918/drivers/scsi/qla2xxx/Kconfig
@@ -30,7 +30,7 @@ config SCSI_QLA_FC
In case of multiple FCFs, the newly allocated lnode by csio_lnode_alloc()
is completely ignored during link up event. Fix it.
Signed-off-by: P Karthik Jayanth kart...@chelsio.com
---
drivers/scsi/csiostor/csio_lnode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
From: Randy Dunlap rdun...@infradead.org
Date: Fri, 19 Sep 2014 16:50:59 -0700
From: Randy Dunlap rdun...@infradead.org
Fix kconfig dependency warnings which can lead to build errors:
warning: (SCSI_BNX2X_FCOE LIBFCOE TCM_QLA2XXX) selects LIBFC which has
unmet direct dependencies
On 2014-09-22 10:25, Bart Van Assche wrote:
On 22/09/2014 8:37, Christoph Hellwig wrote:
One thing that is missing is generation multiqueue-aware tags at the
blk-mq level, which should be as simple as always adding a queue
prefix in the tag allocation code.
Hello Christoph,
Adding a queue
On 21/09/2014 9:58, ronnie sahlberg wrote:
For now I populated it with a bunch of tests I copied fro the SCSI family.
Some, not all, tests.
Missing are a whole bunch of tests that require that you have multiple
I_T nexuses,
such as all the persistent reservation tests, which would be difficult
On Mon, Sep 8, 2014 at 7:57 PM, Luis R. Rodriguez
mcg...@do-not-panic.com wrote:
Why do we care about the priority of probing tasks? Does that
actually make any meaningful difference? If so, how?
As I noted before -- I have yet to provide clear metrics but at least
changing both init paths
On 2014-09-22 10:31, Jens Axboe wrote:
On 2014-09-22 10:25, Bart Van Assche wrote:
On 22/09/2014 8:37, Christoph Hellwig wrote:
One thing that is missing is generation multiqueue-aware tags at the
blk-mq level, which should be as simple as always adding a queue
prefix in the tag allocation
On Mon, Sep 22, 2014 at 9:34 AM, Bart Van Assche bvanass...@acm.org wrote:
On 21/09/2014 9:58, ronnie sahlberg wrote:
For now I populated it with a bunch of tests I copied fro the SCSI family.
Some, not all, tests.
Missing are a whole bunch of tests that require that you have multiple
I_T
On Mon, Sep 22, 2014 at 11:56:58AM -0400, David Miller wrote:
CONFIG_SCSI_QLA_FC currently selects SCSI_FC_ATTRS, so we shouldn't
need this here. Also any reason not to switch that one over to a
depends as well?
Christoph, I understand your confusion now, in the networking tree
On 22/09/2014 8:37, Christoph Hellwig wrote:
One thing that is missing is generation multiqueue-aware tags at the
blk-mq level, which should be as simple as always adding a queue
prefix in the tag allocation code.
Hello Christoph,
Adding a queue prefix in the tag allocation code is an
The return value is not used by callers of this function
so change the function to return void.
Signed-off-by: Joe Perches j...@perches.com
---
This change is associated to a desire to eventually
change printk to return void.
drivers/scsi/libsas/sas_ata.c | 11 ---
1 file changed, 4
When using a virtual SCSI disk in a VMWare VM if blkdev_issue_zeroout is used
data can be improperly zeroed out using the mptfusion driver. This patch
disables write_same for this driver which ensures that manual zeroing out
is used instead.
BugLink: http://bugs.launchpad.net/bugs/1371591
On 09/22/2014 01:02 PM, Christoph Hellwig wrote:
On Mon, Sep 22, 2014 at 12:56:59PM -0500, Chris J Arges wrote:
When using a virtual SCSI disk in a VMWare VM if blkdev_issue_zeroout is used
data can be improperly zeroed out using the mptfusion driver. This patch
disables write_same for this
On Mon, Sep 22, 2014 at 01:17:01PM -0500, Chris J Arges wrote:
I've only been able to reproduce this on VMWare. There is a pretty
straightforward reproducer in the BugLink if there is any interest in
verifying on hardware.
How would you recommending blacklisting only VMWare guests in this
On 14-09-22 10:06 AM, Jens Axboe wrote:
On 2014-09-22 07:59, Christoph Hellwig wrote:
Fix two regressions with the timer/blk_mq_start_request changes found
when using scsi-mq on an ATA device.
Note that given how late we are in the cycle I wonder if we really should
push the changes in
On 09/22/2014 01:19 PM, Christoph Hellwig wrote:
On Mon, Sep 22, 2014 at 01:17:01PM -0500, Chris J Arges wrote:
I've only been able to reproduce this on VMWare. There is a pretty
straightforward reproducer in the BugLink if there is any interest in
verifying on hardware.
How would you
drivers/built-in.o: In function `_scsih_qcmd':
mpt2sas_scsih.c:(.text+0xf43d7b): undefined reference to `__udivdi3'
mpt2sas_scsih.c:(.text+0xf43db4): undefined reference to `__umoddi3'
make: *** [vmlinux] Error 1
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of
On Thu 2014-09-11 13:23:54, Dmitry Torokhov wrote:
On Thu, Sep 11, 2014 at 12:59:25PM -0700, James Bottomley wrote:
On Tue, 2014-09-09 at 16:01 -0700, Dmitry Torokhov wrote:
On Tuesday, September 09, 2014 03:46:23 PM James Bottomley wrote:
On Wed, 2014-09-10 at 07:41 +0900, Tejun Heo
On Monday, September 22, 2014 09:49:06 PM Pavel Machek wrote:
On Thu 2014-09-11 13:23:54, Dmitry Torokhov wrote:
On Thu, Sep 11, 2014 at 12:59:25PM -0700, James Bottomley wrote:
On Tue, 2014-09-09 at 16:01 -0700, Dmitry Torokhov wrote:
On Tuesday, September 09, 2014 03:46:23 PM James
On Fri, 2014-09-19 at 16:51 -0700, Alex Elsayed wrote:
Nicholas A. Bellinger wrote:
On Fri, 2014-09-19 at 14:43 -0700, Alex Elsayed wrote:
Nicholas A. Bellinger wrote:
snip
So the idea of allowing the in-kernel CDB emulation to run after
user-space has returned unsupported opcode
When using a virtual SCSI disk in a VMWare VM if blkdev_issue_zeroout is used
data can be improperly zeroed out using the mptfusion driver. This patch
disables write_same for this driver and the vmware subsystem_vendor which
ensures that manual zeroing out is used instead.
BugLink:
On Fri, 2014-09-19 at 17:35 -0700, Andy Grover wrote:
On 09/19/2014 04:51 PM, Alex Elsayed wrote:
Not sure I follow.. How does the proposed passthrough mode prevent
someone from emulating OSDs, media changers, optical disks or anything
else in userspace with TCMU..?
The main thing
On 09/22/2014 01:58 PM, Nicholas A. Bellinger wrote:
So I'd still like to start for an initial merge with the two different
modes mentioned earlier. The pure-passthrough mode where everything is
handled by user-space, and an I/O passthrough mode where only
SCF_SCSI_DATA_CDB is passed along to
On Mon, 2014-09-22 at 14:00 -0700, Andy Grover wrote:
On 09/22/2014 01:58 PM, Nicholas A. Bellinger wrote:
So I'd still like to start for an initial merge with the two different
modes mentioned earlier. The pure-passthrough mode where everything is
handled by user-space, and an I/O
Jens,
can we simply get these commits reverted from now if there's no better
fix? I'd hate to have this boot stall in the first kernel with blk-mq
support for scsi.
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More
On Mon, Sep 22, 2014 at 02:40:15PM -0400, Douglas Gilbert wrote:
With these patches applied (actually a resync an hour
ago with the for-linus tree which includes them), the
freeze-during-boot-up problem that I have been seeing
with an old SATA boot disk (perhaps 1.5 Gbps) for
the last two
On Tue, Sep 23, 2014 at 07:55:54AM +0200, Christoph Hellwig wrote:
Jens,
can we simply get these commits reverted from now if there's no better
fix? I'd hate to have this boot stall in the first kernel with blk-mq
support for scsi.
Patches going out right now.
Thanks.
--
tejun
--
To
On Tue, Sep 23, 2014 at 01:56:48AM -0400, Tejun Heo wrote:
On Tue, Sep 23, 2014 at 07:55:54AM +0200, Christoph Hellwig wrote:
Jens,
can we simply get these commits reverted from now if there's no better
fix? I'd hate to have this boot stall in the first kernel with blk-mq
support for
40 matches
Mail list logo
