Re: [PATCH v4 10/25] virtio: add API to enable VQs early

* > >+ * Note: vqs are enabled automatically after probe returns. > >+ */ > >+static inline > >+void virtio_device_ready(struct virtio_device *dev) > >+{ > >+unsigned status = dev->config->get_status(dev); > >+ > >+BUG_ON(status & VIRTIO_CONFIG_S_DR

Re: [PATCH 3/3] block: Introduce blkdev_issue_zeroout_discard() function

> "Darrick" == Darrick J Wong writes: Darrick> Can this be plumbed into a BLK* ioctl too? I'll write a patch, Darrick> if this is ok with everyone: Darrick> ...and make it zap the page cache per earlier discussion. This Darrick> seems to be a good fit with what we've been discussing for Da

Re: [PATCH v4 10/25] virtio: add API to enable VQs early

Fedora 20, guest Fedora 20. my config is at: https://fedorapeople.org/~grover/config-20141110 [0.828494] [ cut here ] [0.829039] kernel BUG at /home/agrover/git/kernel/include/linux/virtio_config.h:125! [0.831266] invalid opcode: [#1] SMP DEBUG_PAGEALL

Re: [PATCH 3/3] block: Introduce blkdev_issue_zeroout_discard() function

On Fri, Nov 07, 2014 at 12:08:14AM -0500, Martin K. Petersen wrote: > blkdev_issue_discard() will zero a given block range on disk. This is > done by way of either WRITE SAME or regular WRITE. I.e. the blocks on > disk will be written and thus provisioned. > > There are use cases where the desired

Re: [PATCH 2/3] sd: Disable discard_zeroes_data for UNMAP

On 07/11/2014 06:08, Martin K. Petersen wrote: > The T10 SBC UNMAP command does not provide any hard guarantees that > blocks will return zeroes on a subsequent READ. This is due to the fact > that the device server is free to silently ignore all or parts of the > request. > > The only way to ensu

Re: [PATCH] scsi: Fix more error handling in SCSI_IOCTL_SEND_COMMAND

On 2014-11-10 15:40, Tony Battersby wrote: Fix an error path in SCSI_IOCTL_SEND_COMMAND that calls blk_put_request(rq) on an invalid IS_ERR(rq) pointer. Fixes: a492f075450f ("block,scsi: fixup blk_get_request dead queue scenarios") Signed-off-by: Tony Battersby Thanks, good catch. Might be an

[PATCH] scsi: Fix more error handling in SCSI_IOCTL_SEND_COMMAND

Fix an error path in SCSI_IOCTL_SEND_COMMAND that calls blk_put_request(rq) on an invalid IS_ERR(rq) pointer. Fixes: a492f075450f ("block,scsi: fixup blk_get_request dead queue scenarios") Signed-off-by: Tony Battersby --- (resending, since no one picked it up last time) For inclusion in 3.18 o

Re: tag handling refactor V2

On 2014-11-10 08:56, Christoph Hellwig wrote: The current SCSI handling suffers from large amounts of duplicate code, and a general confusion of multiple concepts of tagging. This series tries to reduce the amount of code, and introduce two separate clear concepts of tagging: a) a driver can

[PATCH 1/5] [SCSI] Fnic: Not probing all the vNICS via fnic_probe on boot

In fnic_dev_wait, Wait for finish to complete at least three times in two seconds while loop before returning -ETIMEDOUT as sometime schedule_timeout_uninterruptible takes more than two seconds to wake up. - Increment fnic version from 1.6.0.11 to 1.6.0.12 Signed-off-by: Hiral Shah Signed-off-b

[PATCH 2/5] [SCSI] Fnic: Memcopy only mimumum of data or trace buffer [SCSI] Fnic: Memcopy only mimumum of data or trace buffer

In case of receive path, we do not have eth header or fcoe header available when we take a trace so we fill the fc trace buffer with 0xff for both values. We copy only mimimum of received data or trace buffer size - fc header - eth and fcoe header - Increment fnic version from 1.6.0.12 to 1.6.0.1

[PATCH 5/5] [SCSI] Fnic: Fnic Driver crashed with NULL pointer reference

When issuing I/O request, if the I/O completes before returning from fnic_queuecommand(), we may be referencing scsi_cmnd structure that may be freed by interrupt handler. Acquring IO lock would synchronize fnic_queuecommand and interrupt handler. - Increment fnic version from 1.6.0.15 to 1.6.0.16

[PATCH 4/5] [SCSI] Fnic: For Standalone C series, "sending VLAN request" message seen even if the link is down

When physical link between standalone C series and switch is down, the fip timer is not turned off and timer expiration will keep sending vlan request. It can be fixed by stopping the fip_timer and it will be restarted automatically when Link is up. - Increment fnic version from 1.6.0.14 to 1.6.0

[PATCH 3/5] [SCSI] Fnic: Improper resue of exchange Ids

IOs belonging to an rport are aborted with Internal terminate option when rport goes offline. Any new IO issued to the rport during this time can reuse the terminated exchange which will cause inconsistent state of the exchange between local port and remote port. fc_rport_priv is set to RPORT_ST_D

Re: UNMAP command parameter list

Christoph Hellwig infradead.org> writes: > > On Mon, Nov 10, 2014 at 11:44:39AM -0500, Martin K. Petersen wrote: > > You'll have to traverse scatterlist and extract the descriptor from > > there. You can use scsi_for_each_sg() to walk the list. Thank you; I'm working on it. > > > > If you o

RE: [PATCH 1/1] be2iscsi: add block valid bit to iBFT flag

>Adding Vikas to verify if qla4xxx has the same issue. >On 11/10/2014 12:52 AM, Minh Duc Tran wrote: >> From: Minh Tran minhduc.t...@emulex.com >> >> >>We are starting to see problems with certain open-iscsi >> versions out there checking block v

Re: device handler cleanups V2

On 10/30/2014 04:19 AM, Christoph Hellwig wrote: > This series contains a couple easy cleanups for the device handler > infrastructure. I think some more work could be done in the longer run, > e.g. by using a class_device interface to attach to the scsi_device, > similar to how the /dev/sg device

Re: tag handling refactor V2

On 11/10/2014 09:56 AM, Christoph Hellwig wrote: > The current SCSI handling suffers from large amounts of duplicate code, and > a general confusion of multiple concepts of tagging. > > This series tries to reduce the amount of code, and introduce two separate > clear concepts of tagging: > > a)

Re: [PATCHv3 net-next 0/3] RDMA/cxgb4,cxgb4vf,cxgb4i,csiostor: Cleanup macros

From: Hariprasad Shenai Date: Fri, 7 Nov 2014 09:35:22 +0530 > This series moves the debugfs code to a new file debugfs.c and cleans up > macros/register defines. > > Various patches have ended up changing the style of the symbolic > macros/register > defines and some of them used the macros/r

Re: UNMAP command parameter list

> "Christoph" == Christoph Hellwig writes: Christoph> Note that if the hardware doesn't actually implement UNMAP Christoph> and you have to emulate something you're probably better off Christoph> emulating WRITE SAME (16) with the UNMAP bit, as the format Christoph> is a lot easier to handle,

Re: UNMAP command parameter list

On Mon, Nov 10, 2014 at 11:44:39AM -0500, Martin K. Petersen wrote: > You'll have to traverse scatterlist and extract the descriptor from > there. You can use scsi_for_each_sg() to walk the list. > > If you only care about in-kernel discards it's pretty easy since we only > issue a single descript

Re: [PATCH 1/1] be2iscsi: add block valid bit to iBFT flag

Adding Vikas to verify if qla4xxx has the same issue. On 11/10/2014 12:52 AM, Minh Duc Tran wrote: > From: Minh Tran minhduc.t...@emulex.com > > > >We are starting to see problems with certain open-iscsi > versions out there checking block valid

Re: UNMAP command parameter list

> "Andras" == Andras Kovacs writes: >> Thank you. Then I guess I'll find the Paramerer List in the struct >> scsi_data_buffer sdb variable (within struct scsi_cmnd). Will check >> on Monday. Andras> I've looked into it, but struct scsi_data_buffer doesn't contain Andras> a byte array (rather

[PATCH v6 1/7] vfs: Prepare for adding a new preadv/pwritev with user flags.

Plumbing the flags argument through the vfs code so they can be passed down to __generic_file_(read/write)_iter function that do the acctual work. Signed-off-by: Milosz Tanski Reviewed-by: Christoph Hellwig Reviewed-by: Jeff Moyer --- drivers/target/target_core_file.c | 6 +++--- fs/nfsd/vfs.

Re: [PATCH 2/2] virtio_scsi: support multi hw queue of blk-mq

On Mon, Nov 10, 2014 at 10:25:43PM +0800, Ming Lei wrote: > It depends on how long the transition period is, and other drivers > with multi hwq support might be in the same situation with virtio-scsi. If > the period is a bit long, it would be painful for these drivers to support > both blk-mq and

Re: UNMAP command parameter list

Andras Kovacs fixstars.com> writes: > > Elliott, Robert (Server Storage hp.com> writes: > > > That is the data transferred for the command, not in the > > command descriptor block itself. > > Thank you. Then I guess I'll find the Paramerer List in the struct > scsi_data_buffer sdb variable (w

[PATCH 07/11] scsi: remove use_blk_tcq Scsi_Host field

Signed-off-by: Christoph Hellwig Reviewed-by: Hannes Reinecke Reviewed-by: Martin K. Petersen --- include/scsi/scsi_host.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h index 5b03ba9..d6bd652 100644 --- a/include/scsi/scsi_host.h +++ b/in

[PATCH 11/11] ufs: remove spurious scsi_set_tag_type call

ufs never looks at the tag type, so there is no need to set it either. Signed-off-by: Christoph Hellwig --- drivers/scsi/ufs/ufshcd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 67e2280..362b818 100644 --- a/drivers/scsi/ufs/ufsh

[PATCH 08/11] scsi: always assign block layer tags if enabled

Allow a driver to ask for block layer tags by setting .use_blk_tags in the host template, in which case it will always see a valid value in request->tag, similar to the behavior when using blk-mq. This means even SCSI "untagged" commands will now have a tag, which is especially useful when using a

[PATCH 06/11] mptfusion: don't change queue type in ->change_queue_depth

This function shouldn't change the queue type, just the depth. Signed-off-by: Christoph Hellwig Reviewed-by: Martin K. Petersen Reviewed-by: Hannes Reinecke --- drivers/message/fusion/mptscsih.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/message/fusion/mp

[PATCH 09/11] scsi: don't set tagging state from scsi_adjust_queue_depth

Remove the tagged argument from scsi_adjust_queue_depth, and just let it handle the queue depth. For most drivers those two are fairly separate, given that most modern drivers don't care about the SCSI "tagged" status of a command at all, and many old drivers allow queuing of multiple untagged com

[PATCH 10/11] scsi: don't force tagged_supported in drivers

Now that we also get proper values in cmd->request->tag for untagged commands, there is no need to force tagged_supported to on in drivers that need host-wide tags. Signed-off-by: Christoph Hellwig --- drivers/scsi/fnic/fnic_main.c | 2 -- drivers/scsi/libsas/sas_scsi_host.c | 1 - drive

[PATCH 01/11] scsi: provide a generic change_queue_type method

Most drivers use exactly the same implementation, so provide it as a library function. Signed-off-by: Christoph Hellwig Reviewed-by: Bart Van Assche Reviewed-by: Martin K. Petersen Reviewed-by: Hannes Reinecke --- drivers/infiniband/ulp/srp/ib_srp.c | 24 +--- drivers/scs

tag handling refactor V2

The current SCSI handling suffers from large amounts of duplicate code, and a general confusion of multiple concepts of tagging. This series tries to reduce the amount of code, and introduce two separate clear concepts of tagging: a) a driver can request block-level tagging to always have a vali

[PATCH 04/11] scsi: remove ordered_tag host template field

Signed-off-by: Christoph Hellwig Reviewed-by: Bart Van Assche Reviewed-by: Martin K. Petersen Reviewed-by: Hannes Reinecke --- drivers/scsi/hosts.c | 1 - drivers/usb/storage/uas.c | 1 - include/scsi/scsi_host.h | 10 -- 3 files changed, 12 deletions(-) diff --git a/drivers/s

[PATCH 03/11] scsi: remove ordered_tags scsi_device field

Remove the ordered_tags field, we haven't been issuing ordered tags based on it since the big barrier rework in 2010. Signed-off-by: Christoph Hellwig Reviewed-by: Bart Van Assche Reviewed-by: Martin K. Petersen --- drivers/message/fusion/mptscsih.c| 5 ++--- drivers/scsi/bfa/bfad_im.c

[PATCH 02/11] scsi: add new scsi-command flag for tagged commands

Currently scsi piggy backs on the block layer to define the concept of a tagged command. But we want to be able to have block-level host-wide tags assigned even for untagged commands like the initial INQUIRY, so add a new SCSI-level flag for commands that are tagged at the scsi level, so that even

[PATCH 05/11] scsi: remove abuses of scsi_populate_tag

Unless we want to build a SPI tag message we should just check SCMD_TAGGED instead of reverse engineering a tag type through the use of scsi_populate_tag_msg. Also rename the function to spi_populate_tag_msg, make it behave like the other spi message helpers, and move it to the spi transport class

Re: [PATCH 2/2] virtio_scsi: support multi hw queue of blk-mq

On Mon, Nov 10, 2014 at 9:39 PM, Christoph Hellwig wrote: > On Mon, Nov 10, 2014 at 11:41:43AM +0100, Paolo Bonzini wrote: >> FWIW, instead of force_blk_mq, it would be fine for me to make >> virtio-scsi use a single queue if not using blk-mq. > > I agree with that. For virtio-scsi, we can do tha

Re: bisected regression: qla2xxx endianness on sparc64

> On Mon, Nov 03, 2014 at 11:32:14PM +0200, Meelis Roos wrote: > > Yes. I took the same 3.18.0-rc1-00422-g2cc9188-dirty kernel that had > > just this patch reverted, it started the controller fine, detected disk, > > mounted root, started multiple tasks and then some time after startin > > exim

Re: [RFC] Discard update for 3.19

Looks like there is no real dependency between these patches, so we might take on each through the libata, scsi and block trees. Can I get another review for the sd patch, please? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.k

Re: [PATCH] hpsa: fix potential resource leak

Don, can you help me review Tomas hpsa patches, including those from the last week of October? Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: bisected regression: qla2xxx endianness on sparc64

On Mon, Nov 03, 2014 at 11:32:14PM +0200, Meelis Roos wrote: > Yes. I took the same 3.18.0-rc1-00422-g2cc9188-dirty kernel that had > just this patch reverted, it started the controller fine, detected disk, > mounted root, started multiple tasks and then some time after startin > exim it just ha

Re: bisected regression: qla2xxx endianness on sparc64

On Mon, Nov 03, 2014 at 03:09:47PM -0500, Chad Dupuis wrote: > We should revert that change. What were some of the other failures you were > seeing? Can you please send me the revert ASAP? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord.

Re: [PATCH 2/2] virtio_scsi: support multi hw queue of blk-mq

On Mon, Nov 10, 2014 at 11:41:43AM +0100, Paolo Bonzini wrote: > FWIW, instead of force_blk_mq, it would be fine for me to make > virtio-scsi use a single queue if not using blk-mq. I agree with that. I'd rather move all of SCSI over after a fairly short period instead of special cases like this,

[PATCH 3/7] megaraid_sas : Do not process IOCTLs and SCSI commands during driver removal

Do not process any SCSI and IOCTL command further(return them with appropriate return values to callers), while driver removal is in progress/PCI shutdown is invoked. Signed-off-by: Sumit Saxena Signed-off-by: Kashyap Desai --- drivers/scsi/megaraid/megaraid_sas_base.c | 20

[PATCH 0/7] megaraid_sas : Description Patch

megaraid_sas driver changes. Please consider this patch set for next kernel release. Signed-off-by: Sumit Saxena Signed-off-by: Kashyap Desai --- [PATCH 0/7] megaraid_sas : Description Patch [PATCH 1/7] megaraid_sas : Driver version upgrade [PATCH 2/7] megaraid_sas : Update MAINTAINERS for me

[PATCH 7/7] megaraid_sas : Endinaness related bug fixes

This patch addresses few endianness related bug fixes. Cc: Signed-off-by: Sumit Saxena Signed-off-by: Kashyap Desai --- drivers/scsi/megaraid/megaraid_sas_fp.c | 17 + drivers/scsi/megaraid/megaraid_sas_fusion.c | 13 +++-- 2 files changed, 16 insertions(+), 14

[PATCH 5/7] megaraid_sas : Make HBA operational after LD_MAP_SYNC DCMD in OCR path

In OCR(Online Controller Reset) path, driver sets adapter state to MEGASAS_HBA_OPERATIONAL before getting new RAID map. There will be a small window where IO will come from OS with old RAID map. This patch will update adapter state to MEGASAS_HBA_OPERATIONAL, only after driver has new RAID map to

[PATCH 4/7] megaraid_sas : Online Firmware upgrade suppport for Extended VD feature

This patch provides driver compatibility for updating firmware online to upgrade legacy(64 VD) firmware to Extended VD firmware and viceversa. Currently, at driver load time only, driver will check whether Firmware is legacy or 240 VD. If legacy Firmware is upgraded to Extended VD firmware withou

[PATCH 2/7] megaraid_sas : Update MAINTAINERS for megaraid drivers

Update MAINTAINERS list for megaraid_sas driver Signed-off-by: Sumit Saxena --- MAINTAINERS | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index aefa948..94c393f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5830,10 +5830,14 @@ W:

[PATCH 6/7] megaraid_sas : Corrected return of wait_event from abort frame path

Corrected wait_event() call which was waiting for wrong completion status(0xFF). Cc: Signed-off-by: Sumit Saxena Signed-off-by: Kashyap Desai --- drivers/scsi/megaraid/megaraid_sas_base.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_

[PATCH 1/7] megaraid_sas : Driver version upgrade

megaraid_sas driver version upgrade Signed-off-by: Sumit Saxena --- drivers/scsi/megaraid/megaraid_sas.h | 2 +- drivers/scsi/megaraid/megaraid_sas_base.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/meg

[3.16.y-ckt extended stable] Patch "scsi: Fix error handling in SCSI_IOCTL_SEND_COMMAND" has been added to staging queue

This is a note to let you know that I have just added a patch titled scsi: Fix error handling in SCSI_IOCTL_SEND_COMMAND to the linux-3.16.y-queue branch of the 3.16.y-ckt extended stable tree which can be found at: http://kernel.ubuntu.com/git?p=ubuntu/linux.git;a=shortlog;h=refs/heads/l

Re: [PATCH 2/2] virtio_scsi: support multi hw queue of blk-mq

On 09/11/2014 17:57, Ming Lei wrote: > Since virtio_scsi has supported multi virtqueue already, > it is natural to map virtque to hw-queue of blk-mq. > > Cc: Paolo Bonzini > Signed-off-by: Ming Lei > --- > drivers/scsi/virtio_scsi.c | 154 > > 1 fi

Reminder

Your partnership is needed for a profitable business transaction involving huge amounts of fund please contact me for more details. --- Uw partnerschap is nodig voor een winstgevende business transactie waarbij enorme hoeveelheden fonds ku