[PATCH] iscsi-target: fix error path in iscsi_target_init_module()

2014-11-30 Thread Lino Sanfilippo
In iscsi_target_init_module() unwind transport protocol registration in case that iscsit_load_discovery_tpg() failed. Signed-off-by: Lino Sanfilippo linosanfili...@gmx.de --- drivers/target/iscsi/iscsi_target.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: Crash when copying from broken external hdd

2014-11-30 Thread Richard Weinberger
On Sat, Nov 29, 2014 at 11:52 AM, Simon Danner danner.si...@gmail.com wrote: Hello, i get the following crash after i try to copy files from a broken external hdd to another external hdd. It happens after a few minutes, with latest git and 3.17.4 from Arch. Attached screenshot is from latest

[PATCH v7 42/46] virtio_scsi: v1.0 support

2014-11-30 Thread Michael S. Tsirkin
Note: for consistency, and to avoid sparse errors, convert all fields, even those no longer in use for virtio v1.0. Signed-off-by: Michael S. Tsirkin m...@redhat.com Acked-by: Paolo Bonzini pbonz...@redhat.com --- include/linux/virtio_scsi.h | 32 +++-

Re: [PATCH] st: implement sysfs based tape statistics

2014-11-30 Thread Laurence Oberman
Hello Shane, So far so good on the upstream, built as a new driver. I need to run some more tests to capture stats and validate the numbers, so far just functional tests and reading sysfs numbers. I then need to backport to RHEL6 and RHEL7 kernels as we have two BZ's out there for this. WIll be

Re: Crash when copying from broken external hdd

2014-11-30 Thread Laurence Oberman
I need more of the stack if you have it, the screenshot is not attached. Thanks Laurence On Sun, Nov 30, 2014 at 6:11 AM, Richard Weinberger richard.weinber...@gmail.com wrote: On Sat, Nov 29, 2014 at 11:52 AM, Simon Danner danner.si...@gmail.com wrote: Hello, i get the following crash after i

Re: [Scst-devel] New qla2x00tgt Driver Question

2014-11-30 Thread Duane Grigsby
On 11/26/14, 10:10 AM, Dr. Greg Wettstein g...@wind.enjellic.com wrote: On Nov 19, 11:54am, Marc Smith wrote: } Subject: [Scst-devel] New qla2x00tgt Driver Question Hi, Hi, I hope the day continues to go well for everyone. It is -15C here with a -26C windchill so Izzy, my golden retriever

Re: [PATCH] iscsi-target: fix error path in iscsi_target_init_module()

2014-11-30 Thread Sagi Grimberg
On 11/30/2014 1:00 PM, Lino Sanfilippo wrote: In iscsi_target_init_module() unwind transport protocol registration in case that iscsit_load_discovery_tpg() failed. Signed-off-by: Lino Sanfilippo linosanfili...@gmx.de --- drivers/target/iscsi/iscsi_target.c | 1 + 1 file changed, 1

Re: Crash when copying from broken external hdd

2014-11-30 Thread Richard Weinberger
Am 30.11.2014 um 17:36 schrieb Simon Danner: Hi, here the two screenshots i could take, from 3.17.4 and 3.18 git. You're hitting BUG_ON(blk_queued_rq(req)); in blk_finish_request() Thanks, //richard Thanks Simon On Sun, 2014-11-30 at 10:58 -0500, Laurence Oberman wrote: I need more of

[PATCH 2/4] drivers/scsi/bfa/bfa_svc.c: remove unneeded structure

2014-11-30 Thread Julia Lawall
From: Julia Lawall julia.law...@lip6.fr Delete a local structure that is only used to be initialized by memset. A semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // smpl @@ identifier x,i; @@ { ... when any -struct i x; +... when != x - memset(x,...); ...+ }

[PATCH 0/4] remove unneeded array

2014-11-30 Thread Julia Lawall
Remove an array or structure that only serves as the first argument to memset. The complete semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // smpl @@ identifier x; type T; @@ { ... when any -T x[...]; +... when != x - memset(x,...); ...+ } @@ identifier x,i;

[PATCH 1/4] target: remove unneeded array

2014-11-30 Thread Julia Lawall
From: Julia Lawall julia.law...@lip6.fr Delete a local array that is only used to be initialized by memset. A semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // smpl @@ identifier x; type T; @@ { ... when any -T x[...]; +... when != x - memset(x,...); ...+ }

Re: Crash when copying from broken external hdd

2014-11-30 Thread Laurence Oberman
The BUG_ON is taken because blk_queued_rq(req)) returns true which means the request-queuelist is empty, i.e no more entries by the time the request is dereferenced Can I get the messages file entries (last 100 lines) just prior to the panic, not the whole file. If its large attach .gz and email