On Tue, Dec 02, 2014 at 03:07:14PM +0100, Tomas Henzl wrote:
Hi Sreekanth,
I think this should be handled as any other change with an usual
patch sent to the list, 'git revert 3520f9c779' and 'git revert 963ba22b90'
will create the patches for you.
Exactly. And now I'll need a review for
Any chance to get a review for this one and Dougs other scsi_debug
patch?
On Wed, Nov 26, 2014 at 12:45:13PM -0500, Douglas Gilbert wrote:
From: Douglas Gilbert dgilb...@interlog.com
Date: Wed, 26 Nov 2014 12:33:48 -0500
Subject: [PATCH] scsi_debug fix compare and write errors
Kernel build
Any chance to get reviews for these two patches?
On Tue, Nov 25, 2014 at 03:50:09PM +0100, Christoph Hellwig wrote:
Not need to have an if/else to either assign FCP_PTA_SIMPLE or 0
to a variable.
Btw, it seems we really should factor generating a fcp cmnd from
a scsi_cmnd into a common
Any chance to get another review for these to complete the queue depth /
type changes for this merge window?
On Mon, Nov 24, 2014 at 03:36:17PM +0100, Christoph Hellwig wrote:
These are a few patches that follow up my previous cleanups for the
queue depth and type handling.
The first patch
The issue_reset variables were never set to zero. This bug was found
with static analysis.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c
b/drivers/scsi/mpt2sas/mpt2sas_base.c
index 58e4521..98bd546 100644
---
We never set issue_reset to zero.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c
b/drivers/scsi/mpt3sas/mpt3sas_base.c
index 1560115..a6d471a 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_base.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
@@
On Wed, 3 Dec 2014, Dan Carpenter wrote:
The issue_reset variables were never set to zero. This bug was found
with static analysis.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c
b/drivers/scsi/mpt2sas/mpt2sas_base.c
index
On Wed, Dec 03, 2014 at 11:36:20AM +0100, Julia Lawall wrote:
On Wed, 3 Dec 2014, Dan Carpenter wrote:
The issue_reset variables were never set to zero. This bug was found
with static analysis.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git
Use 'bool' type instead.
Signed-off-by: Hannes Reinecke h...@suse.de
---
drivers/scsi/advansys.c | 79 -
1 file changed, 38 insertions(+), 41 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 364f3f8..42e9dc6 100644
Signed-off-by: Hannes Reinecke h...@suse.de
---
drivers/scsi/advansys.c | 102
1 file changed, 42 insertions(+), 60 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index c5395b5..0aea820 100644
---
Signed-off-by: Hannes Reinecke h...@suse.de
---
drivers/scsi/advansys.c | 32 +++-
1 file changed, 15 insertions(+), 17 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 42e9dc6..14a4571 100644
--- a/drivers/scsi/advansys.c
+++
The advansys_reset() function is actually a host reset, not a
bus reset.
Signed-off-by: Hannes Reinecke h...@suse.de
---
drivers/scsi/advansys.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 6719a33..d9b27ca
No point in defining our own.
Signed-off-by: Hannes Reinecke h...@suse.de
---
drivers/scsi/advansys.c | 176 ++--
1 file changed, 67 insertions(+), 109 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 0d29d0b..364f3f8
Signed-off-by: Hannes Reinecke h...@suse.de
---
drivers/scsi/advansys.c | 35 +--
1 file changed, 21 insertions(+), 14 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 6af2a52..4979e5a 100644
--- a/drivers/scsi/advansys.c
+++
Signed-off-by: Hannes Reinecke h...@suse.de
---
drivers/scsi/advansys.c | 34 +-
1 file changed, 13 insertions(+), 21 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 14a4571..bd44d1b 100644
--- a/drivers/scsi/advansys.c
+++
The driver has now been converted to use the DMA-API, so
update the version number and remove the compilation warning.
And check for DMA mapping errors, while we're at it.
Signed-off-by: Hannes Reinecke h...@suse.de
---
MAINTAINERS | 1 +
drivers/scsi/advansys.c | 41
Hi all,
it has been bugged me for ages that the advansys driver always
reported a compilation warning about not having been converted
to the DMA-API.
And even aggressive waiting hasn't made this warning go away.
So here's a patchset to update the advansys driver to current
standards and use the
Convert to use a shared host tag map for command lookup. This
saves us having an internal structure and avoid the command
pointer abuse.
Signed-off-by: Hannes Reinecke h...@suse.de
---
drivers/scsi/advansys.c | 218 ++--
1 file changed, 79
Signed-off-by: Hannes Reinecke h...@suse.de
---
drivers/scsi/advansys.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 0aea820..0d29d0b 100644
--- a/drivers/scsi/advansys.c
+++
Signed-off-by: Hannes Reinecke h...@suse.de
---
drivers/scsi/advansys.c | 238 +---
1 file changed, 104 insertions(+), 134 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 4979e5a..ec8f122 100644
---
Signed-off-by: Hannes Reinecke h...@suse.de
---
drivers/scsi/advansys.c | 104 +---
1 file changed, 55 insertions(+), 49 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index ec8f122..c5395b5 100644
---
On 12/02/2014 04:28 PM, Sreekanth Reddy wrote:
This reverts commit 3520f9c779bed098ca76dd3fb6377264301d57ed
(mpt2sas: Remove phys on topology change)
Reverting the previous mpt2sas drives patch changes,
since we will observe below issue
Issue:
Drives connected Enclosure/Expander will
On 12/02/2014 04:28 PM, Sreekanth Reddy wrote:
This reverts commit 963ba22b90a955363644cd397b20226928eab976
(mpt3sas: Remove phys on topology change)
Reverting the previous mpt3sas drives patch changes,
since we will observe below issue
Issue:
Drives connected Enclosure/Expander will
On 11/24/2014 03:36 PM, Christoph Hellwig wrote:
Since we got rid of ordered tag support in 2010 the prime use case of
switching on and off ordered tags has been obsolete. The other function
of enabling/dsiabling tagging entirely has only been correctly implemented
by the 53c700 driver and
On 11/24/2014 03:36 PM, Christoph Hellwig wrote:
Dropping to untagged mode when ramping down a queue due to QUEUE FULL
events has two problems:
- nothing in the midlayer or drivers ever moves back to tagged mode
during queue ramp up.
- cmd_per_lun isn't the untagged queue depth for
On 11/24/2014 03:36 PM, Christoph Hellwig wrote:
Both remaining users are better of just checking sdev-simple_tags
directly.
Signed-off-by: Christoph Hellwig h...@lst.de
Reviewed-by: Hannes Reinecke h...@suse.de
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries Storage
On 11/24/2014 03:36 PM, Christoph Hellwig wrote:
There is no benefit over just setting sdev-simple_tags directly.
Signed-off-by: Christoph Hellwig h...@lst.de
---
drivers/scsi/53c700.c | 2 +-
drivers/scsi/tmscsim.c | 2 +-
include/scsi/scsi_tcq.h | 15 ---
3 files
On 11/25/2014 03:50 PM, Christoph Hellwig wrote:
Not need to have an if/else to either assign FCP_PTA_SIMPLE or 0
to a variable.
Btw, it seems we really should factor generating a fcp cmnd from
a scsi_cmnd into a common helper.
Signed-off-by: Christoph Hellwig h...@lst.de
Reviewed-by:
On 11/25/2014 03:50 PM, Christoph Hellwig wrote:
Reported-by: Stephen Rothwell s...@canb.auug.org.au
Signed-off-by: Christoph Hellwig h...@lst.de
---
drivers/scsi/ibmvscsi/ibmvfc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c
On Wed, Dec 03, 2014 at 03:14:08PM +0100, walter harms wrote:
hi Dan,
just a minor question:
did you forget to mention that you also changed from u8 to bool or was this
unintentional ?
That's a trivial thing and I didn't think it was worth mentioning.
regards,
dan carpenter
--
To
Am 03.12.2014 11:09, schrieb Dan Carpenter:
The issue_reset variables were never set to zero. This bug was found
with static analysis.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c
b/drivers/scsi/mpt2sas/mpt2sas_base.c
index
On 12/03/2014 08:10 AM, Hannes Reinecke wrote:
On 11/25/2014 03:50 PM, Christoph Hellwig wrote:
Reported-by: Stephen Rothwell s...@canb.auug.org.au
Signed-off-by: Christoph Hellwig h...@lst.de
---
drivers/scsi/ibmvscsi/ibmvfc.c | 1 -
1 file changed, 1 deletion(-)
diff --git
Thanks for looking into this old driver.
If you've got a few spare cycles it might make sense to simply split
the wide board support out - the driver literally is two different
drivers with an if/else section in every method for the totally
different narrow vs wide boards. Having at least a
Sreekanth == Sreekanth Reddy sreekanth.re...@avagotech.com writes:
Sreekanth Anyone who aware of mpt2sas/mpt3sas driver's can please
Sreekanth review this patch set.
It's on my todo list.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line
Ok, Thanks Martin.
On Wed, Dec 3, 2014 at 8:51 PM, Martin K. Petersen
martin.peter...@oracle.com wrote:
Sreekanth == Sreekanth Reddy sreekanth.re...@avagotech.com writes:
Sreekanth Anyone who aware of mpt2sas/mpt3sas driver's can please
Sreekanth review this patch set.
It's on my todo list.
On Wednesday 03 December 2014, Christoph Hellwig wrote:
Thanks for looking into this old driver.
If you've got a few spare cycles it might make sense to simply split
the wide board support out - the driver literally is two different
drivers with an if/else section in every method for the
On Wed, 2014-12-03 at 16:34 +0100, Ondrej Zary wrote:
On Wednesday 03 December 2014, Christoph Hellwig wrote:
Thanks for looking into this old driver.
If you've got a few spare cycles it might make sense to simply split
the wide board support out - the driver literally is two different
On Tue, Dec 02, 2014 at 10:39:40PM +, Elliott, Robert (Server Storage)
wrote:
In similar code, mpt3sas and lockless hpsa just call get_cpu_mask()
inside the loop:
cpu = cpumask_first(cpu_online_mask);
for (i = 0; i h-msix_vector; i++) {
rc =
On 14-12-03 06:44 AM, Hannes Reinecke wrote:
Hi all,
it has been bugged me for ages that the advansys driver always
reported a compilation warning about not having been converted
to the DMA-API.
And even aggressive waiting hasn't made this warning go away.
So here's a patchset to update the
On 12/03/2014 01:03 AM, Jason Wilkes wrote:
Note:
There are more instances of the problem described below, but I
thought I'd explain the first one in detail, to make sure it's
worth fixing the others (and to make sure I didn't do anything
stupid, which I may have. I'm new to this :-).
On 12/03/2014 04:42 PM, James Bottomley wrote:
On Wed, 2014-12-03 at 16:34 +0100, Ondrej Zary wrote:
On Wednesday 03 December 2014, Christoph Hellwig wrote:
Thanks for looking into this old driver.
If you've got a few spare cycles it might make sense to simply split
the wide board support
On 12/2/14, 9:09 PM, Martin K. Petersen wrote:
Mike == Michael Christie micha...@cs.wisc.edu writes:
Mike,
Mike This was the issue we worked with Microsoft on wasn’t it? You guys
Mike figured out it was fixed in their target in a recent release
Mike right?
The issue we worked recently was
On Wednesday 03 December 2014 12:44:53 Hannes Reinecke wrote:
Hi all,
it has been bugged me for ages that the advansys driver always
reported a compilation warning about not having been converted
to the DMA-API.
And even aggressive waiting hasn't made this warning go away.
So here's a
On Nov 30, 4:00pm, Duane Grigsby wrote:
} Subject: Re: [Scst-devel] New qla2x00tgt Driver Question
Hi, Ihope the week is going well for everyone.
I've significantly cut information out of this in order to simplify
the mail.
Duane, I had forwarded logs from previous testing to you on Monday and
I'm pretty sure I did. I'd normally just say yes I'm sure, but the
kernel folks do extremely clever things with the compiler, linker, and
basically everything else, so I'm reluctant to assume that *anything*
I know about C in userspace or C in less-cleverly-written code holds
here. To that end,
Mike == Mike Christie micha...@cs.wisc.edu writes:
Mike Are you sure about this? The issue you are talking about and the
Mike one jazz is is the same issue right?
Oh, I see. I wasn't CC:ed on the first part of this thread so I missed
the fact that it was RSOC that was the problem. I read the
Hi Greg,
I looked at your logs and also reviewed the PLOGI handling in
Trunk-SCST.15. We found a issue with PLOGI/PRLI cleanup handling that I¹m
addressing. Whatever fixes will get pushed upstream with the qla2xxx and
scst-qla2xxx.git.
‹duane
On 12/3/14, 12:46 PM, Dr. Greg Wettstein
On 12/03/2014 05:00 PM, Martin K. Petersen wrote:
Mike j...@deti74.ru's patch would work around the same problem because
Mike in sd_read_write_same, sd would see no_write_same is set and not
Mike send REPORT SUPPORTED OPERATION.
Yeah.
I still don't have a problem quirking the MS target.
From: Rafael J. Wysocki rafael.j.wyso...@intel.com
After commit b2b49ccbdd54 (PM: Kconfig: Set PM_RUNTIME if PM_SLEEP is
selected) PM_RUNTIME is always set if PM is set, so #ifdef blocks
depending on CONFIG_PM_RUNTIME may now be changed to depend on
CONFIG_PM.
Replace CONFIG_PM_RUNTIME with
Now that we sanity check the optimal I/O size reported by the device we
no longer need to blacklist the VPD pages on certain Seagate drives.
Signed-off-by: Martin K. Petersen martin.peter...@oracle.com
Cc: sta...@vger.kernel.org
---
drivers/scsi/scsi_devinfo.c | 1 -
1 file changed, 1
We have come across a couple of devices that report crackpot values in
the optimal I/O size in the Block Limits VPD page. Since this is a
32-bit entity that gets multiplied by the logical block size we can get
disproportionately large values reported to the block layer.
Cap io_opt at 256 MB.
Commit 4089b71cc820 blacklisted WRITE SAME for all VMware disks.
However, the WRITE SAME commands are supported for passthrough
disks. Change the heuristic so we only blacklist virtual disks.
Signed-off-by: Martin K. Petersen martin.peter...@oracle.com
Reported-by: Petr Vandrovec p...@vmware.com
The Microsoft iSCSI target does not support REPORT SUPPORTED OPERATION
CODES. Blacklist these devices so we don't attempt to send the command.
Signed-off-by: Martin K. Petersen martin.peter...@oracle.com
Reported-by: j...@deti74.ru
Cc: Mike Christie micha...@cs.wisc.edu
Cc: sta...@vger.kernel.org
Mike == Mike Christie micha...@cs.wisc.edu writes:
Mike Shot, not sure what was tested in that thread now. I tried out
Mike the newer MS iscsi target, 3.3, and still hit the same issue that
Mike was reported here.
Mike What info did you need? Here is vendor/product/version info:
Just sent
Christoph == Christoph Hellwig h...@lst.de writes:
Reviewed-by: Martin K. Petersen martin.peter...@oracle.com
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More
Christoph == Christoph Hellwig h...@lst.de writes:
Christoph Not need to have an if/else to either assign FCP_PTA_SIMPLE
Christoph or 0 to a variable.
Reviewed-by: Martin K. Petersen martin.peter...@oracle.com
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this
Christoph == Christoph Hellwig h...@lst.de writes:
Christoph Since we got rid of ordered tag support in 2010 the prime use
Christoph case of switching on and off ordered tags has been obsolete.
Christoph The other function of enabling/dsiabling tagging entirely has
Christoph only been correctly
Christoph == Christoph Hellwig h...@lst.de writes:
Christoph Dropping to untagged mode when ramping down a queue due to
Christoph QUEUE FULL events has two problems:
Christoph - nothing in the midlayer or drivers ever moves back to
Christoph tagged mode during queue ramp up. - cmd_per_lun
Christoph == Christoph Hellwig h...@lst.de writes:
Christoph Both remaining users are better of just checking
Christoph sdev-simple_tags directly.
Reviewed-by: Martin K. Petersen martin.peter...@oracle.com
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list:
Christoph == Christoph Hellwig h...@lst.de writes:
Christoph There is no benefit over just setting sdev-simple_tags
Christoph directly.
Reviewed-by: Martin K. Petersen martin.peter...@oracle.com
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the
Christoph == Christoph Hellwig h...@infradead.org writes:
Christoph For SPI drivers use the message defintions from scsi.c, and
Christoph for target drivers introduce a new TCM_*_TAG namespace.
s/defintions/definitions/
Reviewed-by: Martin K. Petersen martin.peter...@oracle.com
--
Martin K.
Sreekanth == Sreekanth Reddy sreekanth.re...@avagotech.com writes:
Sreekanth Below is the changeset from the MPI specification and 2.00.34
Sreekanth header files 1) Defined additional bits in the BiosOptions
Sreekanth field of BIOS Page 1 to allow for finer control of X86 BIOS
Sreekanth and UEFI
Sreekanth == Sreekanth Reddy sreekanth.re...@avagotech.com writes:
Sreekanth This patch will log a message when driver receives
Sreekanth Temperature Threshold exceeded event from any temperature
Sreekanth sensor. The message will look similar to like mpt3sas0:
Sreekanth Temperature Threshold
Sreekanth == Sreekanth Reddy sreekanth.re...@avagotech.com writes:
Sreekanth When a flaky disk is there in a topology then during driver
Sreekanth load, discovery related I/O times out; which results in SCSI
Sreekanth error recovery initiating host reset and then the controller
Sreekanth won't
Sreekanth == Sreekanth Reddy sreekanth.re...@avagotech.com writes:
Sreekanth Bump driver version to 19.100.00.00.
Reviewed-by: Martin K. Petersen martin.peter...@oracle.com
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe
Sreekanth == Sreekanth Reddy sreekanth.re...@avagotech.com writes:
Sreekanth Change List in this MPI2 specification, 1. Added SSUTimeout
Sreekanth field to MPI2_CONFIG_PAGE_BIOS_1, and more defines for the
Sreekanth BiosOptions field.
Reviewed-by: Martin K. Petersen martin.peter...@oracle.com
Sreekanth == Sreekanth Reddy sreekanth.re...@avagotech.com writes:
Sreekanth 1. Removed the upper boundary restriction for the module
Sreekanth parameter max_sgl_entries. Earlier, the max_sgl_entries was
Sreekanth capped at the SCSI_MAX_SG_SEGMENTS kernel definition. With
Sreekanth this change,
Sreekanth == Sreekanth Reddy sreekanth.re...@avagotech.com writes:
Sreekanth For any SCSI command, if the driver receives IOC status =
Sreekanth SCSI_IOC_TERMINATED and log info = 0x32010081 then that
Sreekanth command will be completed with DID_RESET host status.
What does that log info value
Sreekanth == Sreekanth Reddy sreekanth.re...@avagotech.com writes:
Sreekanth Copyright, Trademark Confidentiality legal statements
Sreekanth throughout source code changed from LSI to Avago.
Reviewed-by: Martin K. Petersen martin.peter...@oracle.com
--
Martin K. Petersen Oracle Linux
Sreekanth == Sreekanth Reddy sreekanth.re...@avagotech.com writes:
Sreekanth Added a support to set cpu affinity mask for each MSIX vector
Sreekanth enabled by the HBA, So that by runnig the irqbalancer,
Sreekanth interrupts can be balanced among the cpus.
Wouldn't it be better to do this in
Sreekanth == Sreekanth Reddy sreekanth.re...@avagotech.com writes:
Sreekanth Bump mpt2sas driver version to 20.100.00.00.
Reviewed-by: Martin K. Petersen martin.peter...@oracle.com
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line
Dr. Greg Wettstein wrote on 12/03/2014 12:46 PM:
Secondly, Vlad, we have been running additional testing for the last
two days and we have logs from the SCST core which I am including
below which suggests that the SCST core target code excessively stalls
or mishandles an ABORT while processing
On 12/03/2014 07:29 PM, Ondrej Zary wrote:
On Wednesday 03 December 2014 12:44:53 Hannes Reinecke wrote:
Hi all,
it has been bugged me for ages that the advansys driver always
reported a compilation warning about not having been converted
to the DMA-API.
And even aggressive waiting hasn't
On Dec 3, 8:59pm, Vladislav Bolkhovitin wrote:
} Subject: Re: [Scst-devel] New qla2x00tgt Driver Question
Dr. Greg Wettstein wrote on 12/03/2014 12:46 PM:
Secondly, Vlad, we have been running additional testing for the last
two days and we have logs from the SCST core which I am including
74 matches
Mail list logo
