Re: [PATCH-v2 01/15] target: Convert DIF emulation to use cmd->prot_type

2015-03-30 Thread Sagi Grimberg
On 3/30/2015 6:28 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger This patch changes existing DIF emulation to check the command descriptor's prot_type, instead of what the backend device is exposing in pi_prot_type. Since this value is already set in sbc_check_prot(), go ahead and u

Re: [PATCH-v2 02/15] target: Add protected fabric + unprotected device support

2015-03-30 Thread Sagi Grimberg
On 3/30/2015 6:28 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger This patch adds a new target_core_fabric_ops callback for allowing fabric drivers to expose a TPG attribute for signaling when a T10-PI protected fabric wants to function with an un-protected device without T10-PI. Thi

Re: [PATCH-v2 03/15] target: Update SPC/SBC emulation for sess_prot_type

2015-03-30 Thread Sagi Grimberg
On 3/30/2015 6:28 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger This patch updates standard INQUIRY, INQUIRY EVPD=0x86, READ_CAPACITY_16 and control mode pages to use se_sess->sess_prot_type when determing which type of T10-PI related feature bits can be exposed. This is required f

Re: [PATCH-v2 04/15] target: Move cmd->prot_op check into target_check_write_prot

2015-03-30 Thread Sagi Grimberg
On 3/30/2015 6:28 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger This patch moves the existing target_execute_cmd() check for cmd->prot_op into it's own function, so it's easier to add future support for WRITE STRIP. Cc: Martin Petersen Cc: Sagi Grimberg Cc: Christoph Hellwig Sig

Re: [PATCH-v2 05/15] target: Add internal WRITE_STRIP support

2015-03-30 Thread Sagi Grimberg
On 3/30/2015 6:28 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger This patch adds WRITE_STRIP support in target_check_write_prot() that invokes sbc_dif_verify_write() for checking T10-PI metadata before submitting the I/O to a backend driver. Upon verify failure, the specific sense c

Re: [PATCH-v2 06/15] target: Move cmd->prot_op check into target_check_read_prot

2015-03-30 Thread Sagi Grimberg
On 3/30/2015 6:28 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger This patch moves the existing target_complete_ok_work() check for cmd->prot_op into it's own function, so it's easier to add future support for READ INSERT. Cc: Martin Petersen Cc: Sagi Grimberg Cc: Christoph Hellwig

Re: [PATCH-v2 08/15] target/file: Add checks for backend DIF emulation

2015-03-30 Thread Sagi Grimberg
On 3/30/2015 6:28 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger Make sure that FILEIO only attempts to use backend DIF emulation when it's actually enabled at device level. Cc: Martin Petersen Cc: Sagi Grimberg Cc: Christoph Hellwig Signed-off-by: Nicholas Bellinger --- drive

Re: [PATCH-v2 15/15] iscsi/iser-target: Add fabric_prot_type attribute support

2015-03-30 Thread Sagi Grimberg
On 3/30/2015 6:28 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger This patch updates iscsi/iser-target to add a new fabric_prot_type TPG attribute for iser-target, used for controlling LLD level protection into LIO when the backend device does not support T10-PI. This is required for

Re: [PATCH-v2 11/15] loopback: Add fabric_prot_type attribute support

2015-03-30 Thread Sagi Grimberg
On 3/30/2015 6:28 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger This patch updates loopback to add a new fabric_prot_type TPG attribute, used for controlling LLD level protection into LIO when the backend device does not support T10-PI. Also, go ahead and set DIN_PASS + DOUT_PASS s

RE: [V2 PATCH 03/11] aacraid: 4KB sector support

2015-03-30 Thread Murthy Bhat
Reviewed-by: Murthy Bhat -Original Message- From: Hannes Reinecke [mailto:h...@suse.de] Sent: Friday, March 27, 2015 4:33 PM To: Mahesh Rajashekhara; jbottom...@parallels.com; linux-scsi@vger.kernel.org Cc: Achim Leubner Subject: Re: [V2 PATCH 03/11] aacraid: 4KB sector support On 03/2

RE: [V2 PATCH 01/11] aacraid: AIF support for SES device add/remove

2015-03-30 Thread Murthy Bhat
Reviewed-by: Murthy Bhat -Original Message- From: Hannes Reinecke [mailto:h...@suse.de] Sent: Friday, March 27, 2015 3:43 PM To: Mahesh Rajashekhara; jbottom...@parallels.com; linux-scsi@vger.kernel.org Cc: Achim Leubner Subject: Re: [V2 PATCH 01/11] aacraid: AIF support for SES device a

RE: [V2 PATCH 02/11] aacraid: IOCTL pass-through command fix

2015-03-30 Thread Murthy Bhat
Reviewed-by: Murthy Bhat -Original Message- From: Hannes Reinecke [mailto:h...@suse.de] Sent: Friday, March 27, 2015 3:43 PM To: Mahesh Rajashekhara; jbottom...@parallels.com; linux-scsi@vger.kernel.org Cc: Achim Leubner Subject: Re: [V2 PATCH 02/11] aacraid: IOCTL pass-through command f

RE: [V2 PATCH 04/11] aacraid: MSI-x support

2015-03-30 Thread Murthy Bhat
Reviewed-by: Murthy Bhat -Original Message- From: Hannes Reinecke [mailto:h...@suse.de] Sent: Friday, March 27, 2015 3:47 PM To: Mahesh Rajashekhara; jbottom...@parallels.com; linux-scsi@vger.kernel.org Cc: Achim Leubner Subject: Re: [V2 PATCH 04/11] aacraid: MSI-x support On 03/26/201

RE: [V2 PATCH 05/11] aacraid: vpd page code 0x83 support

2015-03-30 Thread Murthy Bhat
Reviewed-by: Murthy Bhat -Original Message- From: Hannes Reinecke [mailto:h...@suse.de] Sent: Friday, March 27, 2015 3:49 PM To: Mahesh Rajashekhara; jbottom...@parallels.com; linux-scsi@vger.kernel.org Cc: Achim Leubner Subject: Re: [V2 PATCH 05/11] aacraid: vpd page code 0x83 support

RE: [V2 PATCH 06/11] aacraid: 240 simple volume support

2015-03-30 Thread Murthy Bhat
Reviewed-by: Murthy Bhat -Original Message- From: Hannes Reinecke [mailto:h...@suse.de] Sent: Friday, March 27, 2015 3:49 PM To: Mahesh Rajashekhara; jbottom...@parallels.com; linux-scsi@vger.kernel.org Cc: Achim Leubner Subject: Re: [V2 PATCH 06/11] aacraid: 240 simple volume support

RE: [V2 PATCH 07/11] aacraid: IOP RESET command handling changes

2015-03-30 Thread Murthy Bhat
Reviewed-by: Murthy Bhat -Original Message- From: Mahesh Rajashekhara Sent: Friday, March 27, 2015 4:45 PM To: Hannes Reinecke; jbottom...@parallels.com; linux-scsi@vger.kernel.org Cc: Achim Leubner Subject: RE: [V2 PATCH 07/11] aacraid: IOP RESET command handling changes Thanks Hannes

RE: [V2 PATCH 10/11] aacraid: AIF raw device remove support

2015-03-30 Thread Murthy Bhat
Reviewed-by: Murthy Bhat -Original Message- From: Hannes Reinecke [mailto:h...@suse.de] Sent: Friday, March 27, 2015 3:53 PM To: Mahesh Rajashekhara; jbottom...@parallels.com; linux-scsi@vger.kernel.org Cc: Achim Leubner Subject: Re: [V2 PATCH 10/11] aacraid: AIF raw device remove suppo

RE: [V2 PATCH 11/11] aacraid: driver version change

2015-03-30 Thread Murthy Bhat
Reviewed-by: Murthy Bhat -Original Message- From: Hannes Reinecke [mailto:h...@suse.de] Sent: Friday, March 27, 2015 3:53 PM To: Mahesh Rajashekhara; jbottom...@parallels.com; linux-scsi@vger.kernel.org Cc: Achim Leubner Subject: Re: [V2 PATCH 11/11] aacraid: driver version change On 0

RE: [V2 PATCH 09/11] aacraid: performance improvement changes

2015-03-30 Thread Murthy Bhat
Reviewed-by: Murthy Bhat -Original Message- From: Hannes Reinecke [mailto:h...@suse.de] Sent: Friday, March 27, 2015 3:52 PM To: Mahesh Rajashekhara; jbottom...@parallels.com; linux-scsi@vger.kernel.org Cc: Achim Leubner Subject: Re: [V2 PATCH 09/11] aacraid: performance improvement cha

RE: [V2 PATCH 08/11] aacraid: IOCTL fix

2015-03-30 Thread Murthy Bhat
Reviewed-by: Murthy Bhat -Original Message- From: Mahesh Rajashekhara Sent: Friday, March 27, 2015 5:00 PM To: Hannes Reinecke; jbottom...@parallels.com; linux-scsi@vger.kernel.org Cc: Achim Leubner Subject: RE: [V2 PATCH 08/11] aacraid: IOCTL fix Thanks Hannes, After getting the plat

RE: Scsi Error handling query

2015-03-30 Thread Kashyap Desai
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Friday, March 27, 2015 9:32 PM > To: Kashyap Desai; linux-scsi@vger.kernel.org > Subject: Re: Scsi Error handling query > > On 03/26/2015 07:43 PM, Kashyap Desai wrote: > >> -Original Message- > >> From: Hann

Re: [RFC 00/22] target: se_node_acl LUN list RCU conversion

2015-03-30 Thread Christoph Hellwig
I went through this in detail, and the odd patch split that splits one change up into muliple patches, but then also mixes up other changes makes it hard to read. So I started rebasing the tree to understand it moving your various cleanups to the front of the series. Of coure while reading throug

Re: [PATCH 11/16] scsi_dh_alua: multipath failover fails with error 15

2015-03-30 Thread Bart Van Assche
On 01/31/14 10:29, Hannes Reinecke wrote: > When a path is already optimized multipath failover will fail > with the message > Could not failover device X:Y: Handler scsi_dh_alua Error 15 > > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/device_handler/scsi_dh_alua.c | 7 +-- > 1 file

Re: [PATCH 11/16] scsi_dh_alua: multipath failover fails with error 15

2015-03-30 Thread Hannes Reinecke
On 03/30/2015 02:30 PM, Bart Van Assche wrote: > On 01/31/14 10:29, Hannes Reinecke wrote: >> When a path is already optimized multipath failover will fail >> with the message >> Could not failover device X:Y: Handler scsi_dh_alua Error 15 >> >> Signed-off-by: Hannes Reinecke >> --- >> drivers/sc

[PATCH 03/20] [SCSI] mpt3sas: Added module parameter 'unblock_io' to unblock IO's during disk addition

2015-03-30 Thread Sreekanth Reddy
During hot-plugging of a disk(having a flaky link), the disk addition stops and any further disk addition or removal doesn't happen on that controller. This is because, when driver receives DELAY_NOT_RESPONDING event for a disk while it is undergoing addition at the SCSI Transport layer, the dri

[PATCH 08/20] [SCSI] mpt3sas: Update MPI2 strings to MPI2.5

2015-03-30 Thread Sreekanth Reddy
Update MPI2 strings to MPI2.5. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.c | 3 +-- drivers/scsi/mpt3sas/mpt3sas_base.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c index

[PATCH 01/20] [SCSI] mpt3sas: Added Combined Reply Queue feature to extend up-to 96 MSIX vector support

2015-03-30 Thread Sreekanth Reddy
In this patch, increased the number of MSIX vector support for SAS3 C0 HBAs to up-to 96. Following are changes that are done in this patch 1. Support this feature only for SAS3 C0 cards and also only when reply post free queue count is greater than 8. 2. Instead of using single ReplyPostHostInde

[PATCH 00/20] mpt3sas: driver update

2015-03-30 Thread Sreekanth Reddy
This patch set contains all the features and defect fixes from Phase4 to Phase8. Please review this patch set and consider these patches for next kernel release. Next time onwards we will make sure to post individual patches as and when we develop a feature & done basic testing instead of postin

[PATCH 04/20] [SCSI] mpt3sas: Remove redundancy code while freeing the controller resources.

2015-03-30 Thread Sreekanth Reddy
Removed the redundancy code while freeing the controller resources. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.c | 57 + 1 file changed, 32 insertions(+), 25 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/sc

[PATCH 09/20] [SCSI] mpt3sas: MPI 2.5 Rev J (2.5.5) specification and 2.00.34 header files

2015-03-30 Thread Sreekanth Reddy
Following is the change set, 1. Added more defines for the BiosOptions field of MPI2_CONFIG_PAGE_BIOS_1. 2. Added MPI2_TOOLBOX_CLEAN_BIT26_PRODUCT_SPECIFIC definition. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpi/mpi2.h | 5 +++-- drivers/scsi/mpt3sas/mpi/mpi2_cnfg.h | 14 +

[PATCH 12/20] [SCSI] mpt3sas: Bump mpt3sas driver version to v6.100.00.00

2015-03-30 Thread Sreekanth Reddy
Bump mpt3sas driver version to v6.100.00.00. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h b/drivers/scsi/mpt3sas/mpt3sas_base.h index 8f99024..402c2ee 100644 ---

[PATCH 15/20] [SCSI] mpt3sas: Return host busy error status to SML when DMA mapping of scatter gather list fails for a SCSI command

2015-03-30 Thread Sreekanth Reddy
scsi_dma_map API will return a negative value (i.e. -ENOMEM) if DMA mapping of sg lists fails and zero if the sg list in the SCSI cmd is NULL. But drivers doesn't handled sg list DMA mapping failure case properly. So, Updated the code to return host busy error status to SCSI MID Layer (SML), wh

[PATCH 16/20] [SCSI] mpt3sas: Added support for customer specific branding

2015-03-30 Thread Sreekanth Reddy
Added support for below customer specific brandings "VendorID" "DeviceID" "SubsystemVendor ID" "SubsystemDevice ID" Cisco Branding String 0x1000 0x97 0x1137 0x154 Cisco 9300-8i 12Gbps SAS HBA 0x1000 0x97 0x1137 0

[PATCH 17/20] [SCSI] mpt3sas: Use alloc_ordered_workqueue() API instead of create_singlethread_workqueue() API

2015-03-30 Thread Sreekanth Reddy
Created a thread using alloc_ordered_workqueue() API in order to process the works from firmware Work-queue sequentially instead of create_singlethread_workqueue() API. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 7 ++- 1 file changed, 6 insertions(+), 1 delet

[PATCH 19/20] [SCSI] mpt3sas: When device is blocked followed by unblock fails, unfreeze the I/Os

2015-03-30 Thread Sreekanth Reddy
Issue: When the disks are getting discovered and assigned device handles by the kernel, a device block followed by an unblock (due to broadcast primitives) issued by the driver is interspersed by the kernel changing the state of the device. Therefore the unblock by the driver results in a no ope

[PATCH 20/20] [SCSI] mpt3sas : Bump mpt3sas driver version to 9.100.00.00

2015-03-30 Thread Sreekanth Reddy
Bump mpt3sas driver version to 9.100.00.00 Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h b/drivers/scsi/mpt3sas/mpt3sas_base.h index 1fd1e7f..706f0a5 100644 --- a

[PATCH 18/20] [SCSI] mpt3sas: Call dma_mapping_error() API after mapping an address with dma_map_single() API

2015-03-30 Thread Sreekanth Reddy
Added dma_mapping_error() API after mapping an address with dma_map_single() API. Otherwise when CONFIG_DMA_API_DEBUG is enabled in the kernel, then it complains about mpt3sas driver not calling dma_mapping_error after mapping an address with dma_map_single Signed-off-by: Sreekanth Reddy ---

[PATCH 10/20] [SCSI] mpt3sas: Add branding string support for OEM's HBA

2015-03-30 Thread Sreekanth Reddy
Added the following Dell branding to the mpt3sas driver. "VendorID" "DeviceID" "SubsystemVendor ID" "SubsystemDevice ID" Dell Branding String 0x10000x0097 0x1028 0x1F46DELL 12Gbps HBA Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt

[PATCH 11/20] [SCSI] mpt3sas: Add branding string support for OEM custom HBA

2015-03-30 Thread Sreekanth Reddy
Add the following OEM's branding to the mpt3sas driver. "VendorID" "DeviceID" "SubsystemVendor ID" "SubsystemDevice ID" Cisco Branding String 0x1000 0x97 SVID = 0x1137 0x014C Cisco 9300-8E 12G SAS HBA Signed-off-by: Sreekanth Reddy --- drivers/scsi/m

[PATCH 14/20] [SCSI] mpt3sas: Complete the SCSI command with DID_RESET status for log_info value 0x0x32010081

2015-03-30 Thread Sreekanth Reddy
For any SCSI command, if the driver receives IOC status = SCSI_IOC_TERMINATED and log info = 0x32010081 then that command will be completed with DID_RESET host status. The definition of this log info value is "Virtual IO has failed and has to be retried". Firmware will provide this log info va

[PATCH 13/20] [SCSI] mpt3sas: MPI 2.5 Rev K (2.5.6) specifications

2015-03-30 Thread Sreekanth Reddy
Below are the new changes to MPI 2.5 Rev K(2.5.6) specification and 2.00.35 header files 1) Added a minimum size requirement for target mode command buffers. 2) Added MinMSIxIndex and MaxMSIxIndex fields to CommandBufferPostBase Request. 3) For BIOS Page 1, added SSUTimeout field, and added Produc

[PATCH 05/20] [SCSI] mpt3sas: MPI 2.5 Rev I (2.5.4) specifications.

2015-03-30 Thread Sreekanth Reddy
Update MPI 2.5 Release: MPI 2.5 Rev I (2.5.4) specification and 2.00.33 header files Below is the change set from the MPI specification for I Rev 1) Added Base Enclosure Level bit to the Flags field of Manufacturing Page 7. 2) Updated description of the MaxTargetPortConnectTime field of SAS IO U

[PATCH 07/20] [SCSI] mpt3sas: Bump mpt3sas Driver version to v5.100.00.00

2015-03-30 Thread Sreekanth Reddy
Bump mpt3sas Driver version to v5.100.00.00 Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h b/drivers/scsi/mpt3sas/mpt3sas_base.h index a182d26..29ecfd1 100644 ---

[PATCH 06/20] [SCSI] mpt3sas: Provides the physical location of sas drives

2015-03-30 Thread Sreekanth Reddy
This Patch will provide more details of the devices such as slot number, enclosure logical id, enclosure level & connector name in the following scenarios, - When end device is added in the topology, - When the end device is removed from the setup, - When the SCSI mid layer issues TASK ABORT/ DE

[PATCH 02/20] [SCSI] mpt3sas: Get IOC_FACTS information using handshake protocol only after HBA card gets into READY or Operational state.

2015-03-30 Thread Sreekanth Reddy
Driver initialization fails if driver tries to send IOC facts request message when the IOC is in reset or in a fault state. This patch will make sure that 1.Driver to send IOC facts request message only if HBA is in operational or ready state. 2.If IOC is in fault state, a diagnostic reset wou

Resend: [PATCH ] qla2xxx Add SCSI command jammer/discard capabilty to the qla2xxx target module - revision3

2015-03-30 Thread Laurence Oberman
Hello Bart, Quinn Tran, I have been using this jammer facility since I posted the below updated patch with no memory leaks and no issues. Is there any interest to take this patch in, its certainly been critical for me in some of the error recovery testing I have been doing. Thanks Laurence Obe

Re: Scsi Error handling query

2015-03-30 Thread Hannes Reinecke
On 03/30/2015 01:45 PM, Kashyap Desai wrote: >> -Original Message- >> From: Hannes Reinecke [mailto:h...@suse.de] >> Sent: Friday, March 27, 2015 9:32 PM >> To: Kashyap Desai; linux-scsi@vger.kernel.org >> Subject: Re: Scsi Error handling query >> >> On 03/26/2015 07:43 PM, Kashyap Desai wr

Re: [RFC 00/22] target: se_node_acl LUN list RCU conversion

2015-03-30 Thread Andy Grover
On 03/30/2015 05:08 AM, Christoph Hellwig wrote: Fortunately there is the old patch from Andy to make the se_dev_entry dynamically allocated, which comes in useful here. With that we might only change the rdonly flag on a live dev entry, or assign an ACL when it previously was NULL, something th

Re: [RFC 00/22] target: se_node_acl LUN list RCU conversion

2015-03-30 Thread Christoph Hellwig
On Mon, Mar 30, 2015 at 12:16:04PM -0700, Andy Grover wrote: > I dug my patches up and rebased on top of target-pending/for-next. Pushed > here: > > git://git.kernel.org/pub/scm/linux/kernel/git/grover/linux.git > mar30-dynalloc-deve > > https://git.kernel.org/cgit/linux/kernel/git/grover/linux.g

Re: [RFC 00/22] target: se_node_acl LUN list RCU conversion

2015-03-30 Thread Andy Grover
On 03/30/2015 12:21 PM, Christoph Hellwig wrote: On Mon, Mar 30, 2015 at 12:16:04PM -0700, Andy Grover wrote: I dug my patches up and rebased on top of target-pending/for-next. Pushed here: git://git.kernel.org/pub/scm/linux/kernel/git/grover/linux.git mar30-dynalloc-deve https://git.kernel.or

[PATCH 00/25] treewide: Use bool function return values of true/false not 1/0

2015-03-30 Thread Joe Perches
Joe Perches (25): arm: Use bool function return values of true/false not 1/0 arm64: Use bool function return values of true/false not 1/0 hexagon: Use bool function return values of true/false not 1/0 ia64: Use bool function return values of true/false not 1/0 mips: Use bool function retu

[PATCH 13/25] csiostor: Use bool function return values of true/false not 1/0

2015-03-30 Thread Joe Perches
Use the normal return values for bool functions Signed-off-by: Joe Perches --- drivers/scsi/csiostor/csio_scsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/csiostor/csio_scsi.c b/drivers/scsi/csiostor/csio_scsi.c index 2c4562d..5754fb6 100644 --- a/driv

Re: [PATCH 00/25] treewide: Use bool function return values of true/false not 1/0

2015-03-30 Thread Casey Schaufler
On 3/30/2015 4:45 PM, Joe Perches wrote: > Joe Perches (25): > arm: Use bool function return values of true/false not 1/0 > arm64: Use bool function return values of true/false not 1/0 > hexagon: Use bool function return values of true/false not 1/0 > ia64: Use bool function return values o

Re: [PATCH 00/25] treewide: Use bool function return values of true/false not 1/0

2015-03-30 Thread Joe Perches
On Mon, 2015-03-30 at 17:07 -0700, Casey Schaufler wrote: > On 3/30/2015 4:45 PM, Joe Perches wrote: > > Joe Perches (25): > > arm: Use bool function return values of true/false not 1/0 [etc...] > Why, and why these in particular? bool functions are probably better returning bool values instea

Re: [PATCH RESUBMIT] Enclosure: fix WARN ON when doing dlpar removing an adapter in dual patch devices

2015-03-30 Thread wenxiong
Hi James, Thanks for your patch! I got a chance to test your patch today and it works. Thanks, Wendy Quoting James Bottomley : On Wed, 2015-03-18 at 17:18 -0500, wenxi...@linux.vnet.ibm.com wrote: From: Wen Xiong Hi James, Our test teams still see lots of these errors in error log when