Re: [GIT PULL] SCSI updates for the 4.0+ merge window

2015-04-16 Thread Hannes Reinecke
On 04/16/2015 07:34 PM, James Bottomley wrote: > This is the usual grab bag of driver updates (lpfc, qla2xxx, storvsc, > aacraid, ipr) plus an assortment of minor updates. There's also a major > update to aic1542 which moves the driver into this millenium. > > The patch is available here: > > gi

Re: mvsas panics and dies when attached to a port extender on newer kernels

2015-04-16 Thread Adam Talbot
Tested against main RAID6, 7 disk array, with sas extender and work with out error. Tested against 2X mirror of SSD's, direct attached, and worked with out error. Check was a simple RAID check. "echo check > /sys/block/md126/md/sync_action" Patched against: root@nas:~# uname -a Linux nas 4.0.0 #

RE: [PATCH v4 42/43] hpsa: add PMC to copyright

2015-04-16 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Don Brace > Sent: Thursday, April 16, 2015 8:51 AM > Subject: [PATCH v4 42/43] hpsa: add PMC to copyright > > need to add PMC to copyright notice and update the Hewlett-P

Re: [PATCH 6/7] be2iscsi: Logout of FW Boot Session

2015-04-16 Thread Mike Christie
On 04/16/2015 02:52 PM, Mike Christie wrote: > On 04/17/2015 04:34 AM, John Soni Jose wrote: >> Once be2iscsi driver is loaded and operational close Boot >> session established by FW. >> >> Signed-off-by: John Soni Jose >> Signed-off-by: Jayamohan Kallickal >> --- >> drivers/scsi/be2iscsi/be_c

Re: [PATCH 6/7] be2iscsi: Logout of FW Boot Session

2015-04-16 Thread Mike Christie
On 04/17/2015 04:34 AM, John Soni Jose wrote: > Once be2iscsi driver is loaded and operational close Boot > session established by FW. > > Signed-off-by: John Soni Jose > Signed-off-by: Jayamohan Kallickal > --- > drivers/scsi/be2iscsi/be_cmds.h | 12 ++ > drivers/scsi/be2iscsi/be_iscs

[GIT PULL] SCSI updates for the 4.0+ merge window

2015-04-16 Thread James Bottomley
This is the usual grab bag of driver updates (lpfc, qla2xxx, storvsc, aacraid, ipr) plus an assortment of minor updates. There's also a major update to aic1542 which moves the driver into this millenium. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scs

Re: mvsas panics and dies when attached to a port extender on newer kernels

2015-04-16 Thread Adam Talbot
Oh! Good idea. ;-) I will test it in 6~8 hours, once the raid check finishes. On Thu, Apr 16, 2015 at 10:28 AM, James Bottomley wrote: > On Thu, 2015-04-16 at 10:26 -0700, Adam Talbot wrote: >> Wow, I forgot how long it takes to compile a full kernel. Glad I ran >> Gentoo for a few years and kne

Re: mvsas panics and dies when attached to a port extender on newer kernels

2015-04-16 Thread James Bottomley
On Thu, 2015-04-16 at 10:26 -0700, Adam Talbot wrote: > Wow, I forgot how long it takes to compile a full kernel. Glad I ran > Gentoo for a few years and knew how to compile and apply patches. I > will admit I had to dust off some mental cobwebs. > > Pre-patched 4.0.0 kernel tree: Oops, as expect

Re: mvsas panics and dies when attached to a port extender on newer kernels

2015-04-16 Thread Adam Talbot
Wow, I forgot how long it takes to compile a full kernel. Glad I ran Gentoo for a few years and knew how to compile and apply patches. I will admit I had to dust off some mental cobwebs. Pre-patched 4.0.0 kernel tree: Oops, as expected Patched 4.0.0 kernel tree: IT WORKED! Basic mount, and c

[PATCH 5/7] be2iscsi : Update the copyright year

2015-04-16 Thread John Soni Jose
Signed-off-by: John Soni Jose Signed-off-by: Jayamohan Kallickal --- drivers/scsi/be2iscsi/be.h |2 +- drivers/scsi/be2iscsi/be_cmds.c |2 +- drivers/scsi/be2iscsi/be_cmds.h |2 +- drivers/scsi/be2iscsi/be_iscsi.c |2 +- drivers/scsi/be2iscsi/be_iscsi.h |2 +- drivers

[PATCH 7/7] be2iscsi : Bump the driver version

2015-04-16 Thread John Soni Jose
Bump the driver version Signed-off-by: John Soni Jose Signed-off-by: Jayamohan Kallickal --- drivers/scsi/be2iscsi/be_main.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/be2iscsi/be_main.h b/drivers/scsi/be2iscsi/be_main.h index 8aff7cd..f375f85 100644

[PATCH 4/7] be2iscsi : Fix memory check before unmapping.

2015-04-16 Thread John Soni Jose
Check DMA memory before it is unmapped. Signed-off-by: John Soni Jose Signed-off-by: Jayamohan Kallickal --- drivers/scsi/be2iscsi/be_main.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c index

[PATCH 2/7] be2iscsi : Fix the PCI request region reserving.

2015-04-16 Thread John Soni Jose
Reserve device PCI I/O and Memory resources. Signed-off-by: John Soni Jose Signed-off-by: Jayamohan Kallickal --- drivers/scsi/be2iscsi/be_main.c | 22 ++ 1 files changed, 18 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2isc

[PATCH 0/7] be2iscsi driver update to 10.6.0.0

2015-04-16 Thread John Soni Jose
The patchset updates be2iscsi driver to 10.6.0.0 version. These patches are generated aganist scsi for-next branch John Soni Jose (7): be2iscsi : Fix the retry count for boot targets be2iscsi : Fix the PCI request region reserving. be2iscsi : Fix memory leak in the unload path be2iscsi :

[PATCH 6/7] be2iscsi: Logout of FW Boot Session

2015-04-16 Thread John Soni Jose
Once be2iscsi driver is loaded and operational close Boot session established by FW. Signed-off-by: John Soni Jose Signed-off-by: Jayamohan Kallickal --- drivers/scsi/be2iscsi/be_cmds.h | 12 ++ drivers/scsi/be2iscsi/be_iscsi.c | 12 ++ drivers/scsi/be2iscsi/be_main.c |1 +

[PATCH 3/7] be2iscsi : Fix memory leak in the unload path

2015-04-16 Thread John Soni Jose
Driver was not freeing the DMA memory allocated for EQ/CQ in the unload path. This patch frees the DMA memory during the driver unload. Signed-off-by: John Soni Jose Signed-off-by: Jayamohan Kallickal --- drivers/scsi/be2iscsi/be_main.c | 18 -- 1 files changed, 12 insertion

[PATCH 1/7] be2iscsi : Fix the retry count for boot targets

2015-04-16 Thread John Soni Jose
Increment the retry count to get the boot target info when port async event is received by the driver. Update sysfs enteries with the boot target parameters. Signed-off-by: Minh Tran Signed-off-by: John Soni Jose Signed-off-by: Jayamohan Kallickal --- drivers/scsi/be2iscsi/be_cmds.c |4

Re: [RFC] Simlify dif_verify routines and fixup fileio protection information code.

2015-04-16 Thread Sagi Grimberg
On 4/16/2015 6:58 PM, Sagi Grimberg wrote: On 4/16/2015 4:46 PM, Akinobu Mita wrote: 2015-04-16 17:52 GMT+09:00 Sagi Grimberg : On 4/15/2015 7:10 PM, Martin K. Petersen wrote: "Sagi" == Sagi Grimberg writes: By the commit 436f4a0a ("loopback: Add fabric_prot_type attribute support"), Whe

Re: Backport of a fix for HPSA (Disabling a disabled device problem during kdump) driver

2015-04-16 Thread Luis Henriques
On Mon, Apr 13, 2015 at 03:18:44PM +0200, Tomas Henzl wrote: > On 04/11/2015 12:45 AM, Vinson Lee wrote: > > On Tue, Jan 27, 2015 at 4:18 PM, Greg KH wrote: > >> On Tue, Jan 06, 2015 at 05:15:19PM +0100, Tomas Henzl wrote: > >>> On 01/05/2015 07:41 PM, Masoud Sharbiani wrote: > Dear stable ma

Re: [RFC] Simlify dif_verify routines and fixup fileio protection information code.

2015-04-16 Thread Sagi Grimberg
On 4/16/2015 4:46 PM, Akinobu Mita wrote: 2015-04-16 17:52 GMT+09:00 Sagi Grimberg : On 4/15/2015 7:10 PM, Martin K. Petersen wrote: "Sagi" == Sagi Grimberg writes: By the commit 436f4a0a ("loopback: Add fabric_prot_type attribute support"), When WRITE_SAME command with WRPROTECT=0 is exe

Re: [RFC] Simlify dif_verify routines and fixup fileio protection information code.

2015-04-16 Thread Martin K. Petersen
> "Akinobu" == Akinobu Mita writes: >>> We don't issue WRITE SAME with PI so there is no prot SGL. >> Is there a specific reason why we don't? There really isn't much of a benefit when all you're doing is replicating zeroes. So it hasn't been very high on my list. Akinobu> It is not only f

Re: [PATCH 2/3] uas: Add US_FL_MAX_SECTORS_240 flag

2015-04-16 Thread Alan Stern
On Thu, 16 Apr 2015, Hans de Goede wrote: > The usb-storage driver sets max_sectors = 240 in its scsi-host template, for > uas we do not want to do that for all devices, but testing has shown that > some devices need it. > > This commit adds a US_FL_MAX_SECTORS_240 flag for such devices, and impl

Re: [PATCH 1/3] uas: Allow uas_use_uas_driver to return usb-storage flags

2015-04-16 Thread Steve Bangert
On Thu, 2015-04-16 at 14:17 +0200, Hans de Goede wrote: > uas_use_uas_driver may set some US_FL_foo flags during detection, currently > these are stored in a local variable and then throw away, but these may be > of interest to the caller, so add an extra parameter to (optionally) return > the dete

[PATCH v4 31/43] hpsa: call pci_release_regions after pci_disable_device

2015-04-16 Thread Don Brace
From: Robert Elliott Despite the fact that PCI devices are enabled in this order: 1. pci_enable_device 2. pci_request_regions Documentation/PCI/pci.txt specifies that they be undone in this order 1. pci_disable_device 2. pci_release_regions Tested by injecting error

[PATCH v4 39/43] hpsa: propagate the error code in hpsa_kdump_soft_reset

2015-04-16 Thread Don Brace
From: Robert Elliott If hpsa_wait_for_board_state fails, hpsa_kdump_soft_reset should propagate its return value (e.g., -ENODEV) rather than just returning -1. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |

[PATCH v4 35/43] hpsa: create workqueue after the driver is ready for use

2015-04-16 Thread Don Brace
From: Robert Elliott Don't create the resubmit workqueue in hpsa_init_one until everything else is ready to use, so everything can be freed in reverse order of when they were allocated without risking freeing things while workqueue items are still active. Destroy the workqueue in the right order

[PATCH v4 29/43] hpsa: refactor and rework support for sending TEST_UNIT_READY

2015-04-16 Thread Don Brace
From: Webb Scales Factor out the code which sends the TEST_UNIT_READY from wait_for_device_to_become_ready() into its own function. Move the code which waits for the TEST_UNIT_READY from wait_for_device_to_become_ready() into its own function. If a logical drive has failed, resetting it will en

[PATCH v4 36/43] hpsa: add interrupt number to /proc/interrupts interrupt name

2015-04-16 Thread Don Brace
From: Robert Elliott Add the interrupt number to the interrupt names that appear in /proc/interrupts, so they are unique Also, delete the IRQ and DAC prints. Other parts of the kernel already print the IRQ assignments, and dual-address-cycle support has not been interesting since the parallel P

[PATCH v4 34/43] hpsa: fix try_soft_reset error handling

2015-04-16 Thread Don Brace
From: Robert Elliott If registering the special interrupt handlers in hpsa_init_one before a soft reset fails, the error exit needs to deallocate everything that was allocated before. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Robert Elliott Signed-off-by: Don Brace --

[PATCH v4 28/43] hpsa: don't return abort request until target is complete

2015-04-16 Thread Don Brace
From: Webb Scales Don't return from the abort request until the target command is complete. Mark outstanding commands which have a pending abort, and do not send them to the host if we can avoid it. If the current command has been aborted, do not call the SCSI command completion routine from the

[PATCH v4 37/43] hpsa: use block layer tag for command allocation

2015-04-16 Thread Don Brace
From: Webb Scales Rework slave allocation: - separate the tagging support setup from the hostdata setup - make the hostdata setup act consistently when the lookup fails - make the hostdata setup act consistently when the device is not added - set up the queue depth consistently across the

[PATCH v4 42/43] hpsa: add PMC to copyright

2015-04-16 Thread Don Brace
need to add PMC to copyright notice and update the Hewlett-Packard copyright notification. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Reviewed-by: Justin Lindley Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |3 ++- drivers/scsi/hpsa.h |3 ++- drivers/scsi/hpsa_cmd.

[PATCH v4 33/43] hpsa: cleanup for init_one step 2 in kdump

2015-04-16 Thread Don Brace
From: Robert Elliott In hpsa_undo_allocations_after_kdump_soft_reset, the things allocated in hpsa_init_one step 2 - h->resubmit_wq and h->lockup_detected need to be freed, in the right order. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Robert Elliott Signed-off-by: Don

[PATCH v4 32/43] hpsa: skip free_irq calls if irqs are not allocated

2015-04-16 Thread Don Brace
From: Robert Elliott If try_soft_reset fails to re-allocate irqs, the error exit starts with free_irq calls, which generate kernel WARN messages since they were already freed a few lines earlier. Jump to the next exit label to skip the free_irq calls. Reviewed-by: Scott Teel Reviewed-by: Kevin

[PATCH v4 43/43] hpsa: add in new controller id

2015-04-16 Thread Don Brace
add in support for latest PMC controller Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 5fc4118..910d748 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -132,6 +132,7 @@ stati

[PATCH v4 41/43] hpsa: change driver version

2015-04-16 Thread Don Brace
update driver version Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index a596de5..4b4df66 100644 --- a/drivers/scsi/hpsa.c +++

[PATCH v4 30/43] hpsa: performance tweak for hpsa_scatter_gather()

2015-04-16 Thread Don Brace
From: Webb Scales Divide the loop in hpsa_scatter_gather() into two, one for the initial SG list and a second one for the chained list, if any. This allows the conditional check which resets the indicies for the chained list to be performed outside the loop instead of being done on every iterati

[PATCH v4 40/43] hpsa: cleanup reset

2015-04-16 Thread Don Brace
From: Webb Scales Synchronize completion the reset with completion of outstanding commands Extending the newly-added synchronous abort functionality, now also synchronize resets with the completion of outstanding commands. Rename the wait queue to reflect the fact that it's being used for both t

[PATCH v4 27/43] hpsa: use helper routines for finishing commands

2015-04-16 Thread Don Brace
From: Webb Scales cleanup command completions Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Webb Scales Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 78 --- 1 file changed, 31 insertions(+), 47 deletions(-) diff --

[PATCH v4 38/43] hpsa: use scsi host_no as hpsa controller number

2015-04-16 Thread Don Brace
From: Robert Elliott Rather than numbering the hpsa controllers with an incrementing 0..n value (e.g., that shows up in /proc/interrupts), use the scsi midlayer host_no (e.g. matching /sys/class/scsi_host/hostNN). Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Robert Elliott

[PATCH v4 25/43] hpsa: do not print ioaccel2 warning messages about unusual completions.

2015-04-16 Thread Don Brace
From: Robert Elliott The SCSI midlayer already prints more detail about completions, and has logging level options to filter them if not wanted. These just slow down the system if a lot of errors occur, stressing error handling even more. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Sign

[PATCH v4 26/43] hpsa: add support sending aborts to physical devices via the ioaccel2 path

2015-04-16 Thread Don Brace
From: Stephen Cameron add support for tmf when in ioaccel2 mode Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Joe Handzik Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 136 +-- drivers/scsi/hpsa.h |1 drivers

[PATCH v4 12/43] hpsa: factor out hpsa_ioaccel_submit function

2015-04-16 Thread Don Brace
From: Webb Scales clean up command submission Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Webb Scales Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 91 +-- 1 file changed, 66 insertions(+), 25 deletions(-) diff --

[PATCH v4 08/43] hpsa: make function names consistent

2015-04-16 Thread Don Brace
From: Robert Elliott make function names more consistent and meaningful Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/driv

[PATCH v4 17/43] hpsa: clean up error handling

2015-04-16 Thread Don Brace
From: Robert Elliott refactor error cleanup and shutdown disable interrupts and pci_disable_device on critical failures add hpsa_free_cfgtables function Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 92 +

[PATCH v4 07/43] hpsa: allow lockup detected to be viewed via sysfs

2015-04-16 Thread Don Brace
From: Stephen Cameron expose a detected lockup via sysfs Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 68238dd..adc0a

[PATCH v4 04/43] hpsa: clean up aborts

2015-04-16 Thread Don Brace
From: Stephen Cameron Do not send aborts to logical devices that do not support aborts Instead of relying on what the Smart Array claims for supporting logical drives, simply try an abort and see how it responds at device discovery time. This way devices that do support aborts (e.g. MSA2000) ca

[PATCH v4 19/43] hpsa: add ioaccel sg chaining for the ioaccel2 path

2015-04-16 Thread Don Brace
From: Webb Scales Increase the request size for ioaccel2 path. The error, if any, returned by hpsa_allocate_ioaccel2_sg_chain_blocks to hpsa_alloc_ioaccel2_cmd_and_bft should be returned upstream rather than assumed to be -ENOMEM. This differs slightly from hpsa_alloc_ioaccel1_cmd_and_bft, whic

[PATCH v4 20/43] hpsa: add more ioaccel2 error handling, including underrun statuses.

2015-04-16 Thread Don Brace
From: Joe Handzik improve ioaccel2 error handling, including better handling of underrun statuses Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Joe Handzik Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 33 - drivers/scsi/hpsa_cm

[PATCH v4 21/43] hpsa: do not check cmd_alloc return value - it cannnot return NULL

2015-04-16 Thread Don Brace
From: Robert Elliott cmd_alloc can no longer return NULL, so don't check for NULL any more (which is unreachable code). Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 77 ++

[PATCH v4 13/43] hpsa: print accurate SSD Smart Path Enabled status

2015-04-16 Thread Don Brace
From: Robert Elliott offload_enabled changes are deferred until after the added/updated prints occur, so the values are incorrect. defer printing SSD Smart Path Enabled status information until the information is correct Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Robert

[PATCH v4 24/43] hpsa: clean up some error reporting output in abort handler

2015-04-16 Thread Don Brace
From: Robert Elliott report more useful information on aborts Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git

[PATCH v4 02/43] hpsa: clean up host, channel, target, lun prints

2015-04-16 Thread Don Brace
From: Webb Scales We had a mix of formats used for specifying controller, bus, target, and lun address of devices. change to the format used by the scsi midlayer and upper layer (2:3:0:0) so you can easily follow the information from hpsa to scsi midlayer to sd upper layer. Also add this inform

[PATCH v4 14/43] hpsa: use ioaccel2 path to submit IOs to physical drives in HBA mode.

2015-04-16 Thread Don Brace
From: Joe Handzik use ioaccel2 path to submit I/O to physical drives in HBA mode Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Joe Handzik Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 10 +- drivers/scsi/hpsa.h |1 + 2 files changed, 10 insertions(+),

[PATCH v4 09/43] hpsa: factor out hpsa_init_cmd function

2015-04-16 Thread Don Brace
From: Stephen Cameron Factor out hpsa_cmd_init from cmd_alloc(). We also need this for resubmitting commands down the default RAID path when they have returned from the ioaccel paths with errors. In particular, reinitialize the cmd_type and busaddr fields as these will not be correct for submit

[PATCH v4 10/43] hpsa: do not ignore return value of hpsa_register_scsi

2015-04-16 Thread Don Brace
From: Stephen Cameron add error handling for failure when registering with SCSI subsystem. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drive

[PATCH v4 06/43] hpsa: hpsa decode sense data for io and tmf

2015-04-16 Thread Don Brace
From: Stephen Cameron In hba mode, we could get sense data in descriptor format so we need to handle that. It's possible for CommandStatus to have value 0x0D "TMF Function Status", which we should handle. We will get this from a P1224 when aborting a non-existent tag, for example. The "ScsiSta

[PATCH v4 01/43] hpsa: add masked physical devices into h->dev[] array

2015-04-16 Thread Don Brace
From: Stephen Cameron Cache the ioaccel handle so that when we need to abort commands sent down the ioaccel2 path, we can look up the LUN ID in h->dev[] instead of having to do I/O to the controller. Add a field to elements in h->dev[] to keep track of how the device is exposed to the SCSI mid l

[PATCH v4 18/43] hpsa: refactor freeing of resources into more logical functions

2015-04-16 Thread Don Brace
From: Robert Elliott refactor freeing of resources into more logical functions Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 104 +++ 1 file changed, 56 ins

[PATCH v4 22/43] hpsa: correct return values from driver functions.

2015-04-16 Thread Don Brace
From: Robert Elliott correct return codes for error conditions Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/hpsa

[PATCH v4 15/43] hpsa: Get queue depth from identify physical bmic for physical disks.

2015-04-16 Thread Don Brace
From: Joe Handzik get drive queue depth to help avoid task set full conditions. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Joe Handzik Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 33 + 1 file changed, 13 insertions(+), 20 delet

[PATCH v4 23/43] hpsa: clean up driver init

2015-04-16 Thread Don Brace
From: Robert Elliott Improve initialization error handling in hpsa_init_one Clean up style and indent issues Rename functions for consistency Improve error messaging on allocations Fix return status from hpsa_put_ctlr_into_performant_mode Correct free order in hpsa_init_one using new function

[PATCH v4 03/43] hpsa: rework controller command submission

2015-04-16 Thread Don Brace
From: Webb Scales Allow driver initiated commands to have a timeout. It does not yet try to do anything with timeouts on such commands. We are sending a reset in order to get rid of a command we want to abort. If we make it return on the same reply queue as the command we want to abort, the com

[PATCH v4 05/43] hpsa: decrement h->commands_outstanding in fail_all_outstanding_cmds

2015-04-16 Thread Don Brace
From: Stephen Cameron make tracking of outstanding commands more robust Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 2ac700b..6ee92af

[PATCH v4 16/43] hpsa: break hpsa_free_irqs_and_disable_msix into two functions

2015-04-16 Thread Don Brace
From: Robert Elliott replace calls to hpsa_free_irqs_and_disable_msix with hpsa_free_irqs and hpsa_disable_interrupt_mode Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 35 ++--

[PATCH v4 11/43] hpsa: try resubmitting down raid path on task set full

2015-04-16 Thread Don Brace
From: Stephen Cameron allow the controller firmware to queue up commands when the ioaccel device queue is full. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers

[PATCH v4 00/43] hpsa update

2015-04-16 Thread Don Brace
These patches are based on Linus's tree The changes are: - make function names consistent - refactor functions - cleanup driver messages - cleanup error handling - clean up abort management - enhance sense data reporting - enhance ioaccel command support - add in block layer tag support -

Re: [RFC] Simlify dif_verify routines and fixup fileio protection information code.

2015-04-16 Thread Akinobu Mita
2015-04-16 17:52 GMT+09:00 Sagi Grimberg : > On 4/15/2015 7:10 PM, Martin K. Petersen wrote: >>> >>> "Sagi" == Sagi Grimberg writes: >> >> > By the commit 436f4a0a ("loopback: Add fabric_prot_type attribute > support"), When WRITE_SAME command with WRPROTECT=0 is executed, > sb

Re: [patch] sd: fix an error return in probe()

2015-04-16 Thread Tomas Henzl
On 01/19/2015 03:41 PM, Dan Carpenter wrote: > If device_add() fails then it should return the error code but instead > the current code returns success. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c > index ebf35cb6..75a0b55 100644 > --- a/drivers/scsi/sd

Re: [patch] csiostor: fix an error code in csio_hw_init()

2015-04-16 Thread Tomas Henzl
On 04/14/2015 04:32 PM, Dan Carpenter wrote: > We should return -ENOMEM if kzalloc() fails here instead of returning > success. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/scsi/csiostor/csio_hw.c b/drivers/scsi/csiostor/csio_hw.c > index 2e66f34..622bdab 100644 > --- a/drivers/scsi/c

[PATCH 3/3] uas: Set max_sectors_240 quirk for ASM1053 devices

2015-04-16 Thread Hans de Goede
Testing has shown that ASM1053 devices do not work properly with transfers larger than 240 sectors, so set max_sectors to 240 on these. Reported-by: Steve Bangert Signed-off-by: Hans de Goede --- drivers/usb/storage/uas-detect.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --

[PATCH 2/3] uas: Add US_FL_MAX_SECTORS_240 flag

2015-04-16 Thread Hans de Goede
The usb-storage driver sets max_sectors = 240 in its scsi-host template, for uas we do not want to do that for all devices, but testing has shown that some devices need it. This commit adds a US_FL_MAX_SECTORS_240 flag for such devices, and implements support for it in uas.c, while at it it also a

[PATCH 1/3] uas: Allow uas_use_uas_driver to return usb-storage flags

2015-04-16 Thread Hans de Goede
uas_use_uas_driver may set some US_FL_foo flags during detection, currently these are stored in a local variable and then throw away, but these may be of interest to the caller, so add an extra parameter to (optionally) return the detected flags, and use this in the uas driver. Signed-off-by: Hans

[Bug 90601] panic on write to 3ware raid array

2015-04-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=90601 mer...@liao.homelinux.org changed: What|Removed |Added Attachment #162291|0 |1 is obsolete|

[Bug 90601] panic on write to 3ware raid array

2015-04-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=90601 --- Comment #19 from mer...@liao.homelinux.org --- Created attachment 174181 --> https://bugzilla.kernel.org/attachment.cgi?id=174181&action=edit crash-backtrace -- You are receiving this mail because: You are the assignee for the bug. -- To un

[Bug 90601] panic on write to 3ware raid array

2015-04-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=90601 --- Comment #18 from mer...@liao.homelinux.org --- Created attachment 174171 --> https://bugzilla.kernel.org/attachment.cgi?id=174171&action=edit dmesg I finally managed to get a dmesg output with the crashing kernel. Especially this part might

Re: [RFC] Simlify dif_verify routines and fixup fileio protection information code.

2015-04-16 Thread Sagi Grimberg
On 4/15/2015 7:10 PM, Martin K. Petersen wrote: "Sagi" == Sagi Grimberg writes: By the commit 436f4a0a ("loopback: Add fabric_prot_type attribute support"), When WRITE_SAME command with WRPROTECT=0 is executed, sbc_dif_generate() is called but cmd->t_prot_sg is NULL as block layer didn't allo