On Mon, Jun 08, 2015 at 08:50:51PM -0700, Calvin Owens wrote:
These objects can be referenced concurrently throughout the driver, we
need a way to make sure threads can't delete them out from under each
other.
Signed-off-by: Calvin Owens calvinow...@fb.com
Thsi doesn't make sense without
Please use a descriptive one line Subject line and put the rest of
your changelog into the message body.
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jun 08, 2015 at 08:50:56PM -0700, Calvin Owens wrote:
Since the fw_event deletes itself from the list, cleanup_queue() can
walk onto garbage pointers or walk off into freed memory.
This refactors the code in _scsih_fw_event_cleanup_queue() to not
iterate over the fw_event_list
-Original Message-
From: Christoph Hellwig [mailto:h...@infradead.org]
Sent: Friday, July 3, 2015 9:19 AM
To: Vitaly Kuznetsov
Cc: linux-scsi@vger.kernel.org; Long Li; KY Srinivasan; Haiyang Zhang; James
E.J. Bottomley; de...@linuxdriverproject.org; linux-ker...@vger.kernel.org
On 07/03/15 09:11, Dave Jones wrote:
After a fuzzing run recently, I noticed that the machine had oom'd, and
killed everything, but there was still 3GB of memory still in use, that
I couldn't even reclaim with /proc/sys/vm/drop_caches
So I enabled kmemleak. After applying this..
diff --git
On Thu, Jun 25, 2015 at 04:24:22PM +0530, Nagarajkumar Narayanan wrote:
This patch contains the fix for kernel oops on issuing setpci reset
along with sysfs, cli access
spinlock initialization modified to DEFINE_SPINLOCK as per the
comments for previous version of the patch
Why is the
-Original Message-
From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
Sent: Wednesday, July 1, 2015 2:31 AM
To: linux-scsi@vger.kernel.org
Cc: Long Li; KY Srinivasan; Haiyang Zhang; James E.J. Bottomley;
de...@linuxdriverproject.org; linux-ker...@vger.kernel.org
Subject: [PATCH]
On Wed, Jul 01, 2015 at 11:04:08AM +0200, Vitaly Kuznetsov wrote:
SPC-2/3/4 specs state that The standard INQUIRY data (see table ...)
shall contain at least 36 bytes. Hyper-V host doesn't always honor this
requirement, e.g. when there is no physical device present at a particular
LUN host
On Mon, Jun 08, 2015 at 08:50:54PM -0700, Calvin Owens wrote:
The fw_event_work struct is concurrently referenced at shutdown, so
add a refcount to protect it.
Same comment here - a refcount that isn't used isn't useful, please fold
into the next patch.
--
To unsubscribe from this list: send
On Mon, Jun 08, 2015 at 08:50:55PM -0700, Calvin Owens wrote:
This refactors the fw_event code to use the new refcount.
I spent some time looking over this code because it's so convoluted.
In general I think code should either embeed one work_struct (and it
really doesn't seem to need a delayed
After a fuzzing run recently, I noticed that the machine had oom'd, and
killed everything, but there was still 3GB of memory still in use, that
I couldn't even reclaim with /proc/sys/vm/drop_caches
So I enabled kmemleak. After applying this..
diff --git a/mm/kmemleak.c b/mm/kmemleak.c
index
On Mon, Jun 29, 2015 at 06:05:25PM +0300, Sagi Grimberg wrote:
Instead of open coding the sense buffer construction, use
scsi scsi_build_sense_buffer() and scsi_set_sense_information()
helpers.
This patch also fixes wrong setting of descriptor format sense data
for t10-pi integrity errors.
On Mon, Jun 08, 2015 at 08:50:53PM -0700, Calvin Owens wrote:
We cannot iterate over the list without holding a lock for the entire
duration, or we risk corrupting random memory if items are added or
deleted as we iterate.
This refactors code such that it always holds the lock when iterating
On Tue, Jun 30, 2015 at 10:59:04AM +1000, Stephen Rothwell wrote:
Fixes:
drivers/scsi/virtio_scsi.c: In function 'virtscsi_probe':
drivers/scsi/virtio_scsi.c:952:11: warning: unused variable 'host_prot'
[-Wunused-variable]
int err, host_prot;
^
Signed-off-by: Stephen
Why is this a binary attribute? Needs an interface specific in
Documentation/ABI/ to start with, and a Ccto stable seems very
aggressive.
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On Fri, Jul 03, 2015 at 10:04:00AM -0700, Bart Van Assche wrote:
On 07/03/15 09:11, Dave Jones wrote:
After a fuzzing run recently, I noticed that the machine had oom'd, and
killed everything, but there was still 3GB of memory still in use, that
I couldn't even reclaim with
Use module_pcmcia_driver for drivers whose init and exit functions
only register and unregister, respectively.
A simplified version of the Coccinelle semantic patch that performs
this transformation is as follows:
@a@
identifier f, x;
@@
-static f(...) { return pcmcia_register_driver(x); }
@b
+struct _sas_device *
+mpt2sas_scsih_sas_device_get_by_sas_address_nolock(struct MPT2SAS_ADAPTER
*ioc,
+u64 sas_address)
Any chance to use a shorter name for this function? E.g.
__mpt2sas_get_sdev_by_addr ?
+{
+ struct _sas_device *sas_device;
+
+
https://bugzilla.kernel.org/show_bug.cgi?id=71021
Dāvis davis...@gmail.com changed:
What|Removed |Added
CC||davis...@gmail.com
--- Comment
-Original Message-
From: KY Srinivasan
Sent: Friday, July 03, 2015 11:35 AM
To: Vitaly Kuznetsov; linux-scsi@vger.kernel.org
Cc: Long Li; Haiyang Zhang; James E.J. Bottomley;
de...@linuxdriverproject.org;
linux-ker...@vger.kernel.org
Subject: RE: [PATCH] scsi: storvsc: use
These are signed values the come from the user, we put a cap on the
upper bounds but not on the lower bounds.
We use karg.dataSgeOffset to calculate sz. We verify sz and
proceed as if that means that karg.dataSgeOffset is correct but this
fails to consider that the sz calculations can have
Hiral Shah his...@cisco.com writes:
Signed-off-by: Hiral Shah his...@cisco.com
Signed-off-by: Sesidhar Baddela sebad...@cisco.com
Signed-off-by: Anil Chintalapati achin...@cisco.com
---
drivers/scsi/fnic/fnic.h | 2 +-
drivers/scsi/fnic/fnic_scsi.c | 4 +++-
2 files changed, 4
Removing static analysis error:-
(error) Possible null pointer dereference: hba
hba-cid_que.conn_cid_tbl[iscsi_cid] = bnx2i_conn;
Validation of hba is not required in if check,
because validation is done before entrying to this function
and error comes because after this
We would like to get the following updates in:
Revert ownership to Emulex from Avago Technologies
Signed-off-by: Ketan Mukadam ketan.muka...@avagotech.com
---
drivers/scsi/be2iscsi/Kconfig| 4 ++--
drivers/scsi/be2iscsi/Makefile | 2 +-
drivers/scsi/be2iscsi/be.h | 4 ++--
We would like to update the MAINTAINER list for be2iscsi driver
Signed-off-by: Ketan Mukadam ketan.muka...@avagotech.com
---
MAINTAINERS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 4336263..897e777 100644
--- a/MAINTAINERS
+++
Revert the ownership to Emulex and update the MAINTAINER for be2iscsi
Ketan Mukadam (2):
MAINTAINERS: Update MAINTAINER list
be2iscsi: Revert ownership to Emulex
MAINTAINERS | 4 ++--
drivers/scsi/be2iscsi/Kconfig| 4 ++--
drivers/scsi/be2iscsi/Makefile | 2 +-
Dan Carpenter dan.carpen...@oracle.com writes:
These are signed values the come from the user, we put a cap on the
upper bounds but not on the lower bounds.
We use karg.dataSgeOffset to calculate sz. We verify sz and
proceed as if that means that karg.dataSgeOffset is correct but this
27 matches
Mail list logo
