Re: [PATCH] target: add support for START_STOP_UNIT SCSI opcode

2015-07-30 Thread Nicholas A. Bellinger
On Thu, 2015-07-23 at 15:27 -0700, Spencer Baugh wrote: > From: Brian Bunker > > AIX servers using VIOS servers that virtualize FC cards will have a > problem booting without support for START_STOP_UNIT. > > v2: Cite sb3r36 exactly, clean up if conditions > > Signed-off-by: Brian Bunker > Sign

Re: [PATCH] target: improve unsupported opcode message

2015-07-30 Thread Nicholas A. Bellinger
On Wed, 2015-07-22 at 15:01 -0700, Spencer Baugh wrote: > From: Joern Engel > > Make the warning about unsupported SCSI opcode more useful: > > - Add in the initiator name so we know who's sending it. > - Print the warning even for opcodes that spc_parse_cdb() knows about >but that we don'

Re: [PATCH] target: allow underflow/overflow for PR OUT etc. commands

2015-07-30 Thread Nicholas A. Bellinger
On Wed, 2015-07-22 at 15:08 -0700, Spencer Baugh wrote: > From: Roland Dreier > > It's not necessarily a fatal error if a command with a data-out phase > has a data length that differs from the transport data length (e.g. > PERSISTENT RESERVE OUT might have a parameter list length in the CDB > th

Re: [PATCH] target/iscsi: fix digest computation for chained SGs

2015-07-30 Thread Nicholas A. Bellinger
On Tue, 2015-07-21 at 18:38 -0700, Roland Dreier wrote: > On Tue, Jul 21, 2015 at 1:57 AM, Sagi Grimberg > wrote: > > How were you able to get a chained SG list in the target code? > > Local hack. So this bug can't be hit in current mainline code, but > patch improves the code and removes a hid

Re: [PATCH] target/iscsi: Fix double free of a TUR followed by a solicited NOPOUT

2015-07-30 Thread Nicholas A. Bellinger
Hi Spencer & Alexei, On Tue, 2015-07-21 at 15:07 -0700, Spencer Baugh wrote: > From: Alexei Potashnik > > Make sure all non-READ SCSI commands get targ_xfer_tag initialized > to 0x, not just WRITEs. > > Double-free of a TUR cmd object occurs under the following scenario: > > 1. TUR rec

[PATCH 1/1] be2iscsi : Add warning message for unsupported adapter

2015-07-30 Thread Ketan Mukadam
Add a warning message to indicate obsolete/unsupported BE2 Adapter Family devics Signed-off-by: Ketan Mukadam --- drivers/scsi/be2iscsi/be_main.c | 2 ++ drivers/scsi/be2iscsi/be_mgmt.c | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/be2iscsi/be_main.c b/drive

[PATCH 0/1] be2iscsi : Add warning message for unsupported devices

2015-07-30 Thread Ketan Mukadam
Add a warning message to indicate obsolete/unsupported BE2 Adapter Family devices Ketan Mukadam (1): be2iscsi : Add warning message for unsupported adapter drivers/scsi/be2iscsi/be_main.c | 2 ++ drivers/scsi/be2iscsi/be_mgmt.c | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) -- 1.8.

Re: [PATCH] target: Wait RCU grace-period before backend/fabric unload

2015-07-30 Thread Paul E. McKenney
On Thu, Jul 30, 2015 at 05:23:43PM -0700, Nicholas A. Bellinger wrote: > On Thu, 2015-07-30 at 06:07 -0700, Paul E. McKenney wrote: > > On Thu, Jul 30, 2015 at 06:15:23AM +, Nicholas A. Bellinger wrote: > > > From: Nicholas Bellinger > > > > > > This patch addresses a v4.2-rc1 regression wher

[PATCH 1/1] scsi: cxgbi: delete useless DIV_ROUND_UP definition

2015-07-30 Thread Peter Chen
The common kernel.h has already supplied it. Signed-off-by: Peter Chen --- drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c index de6feb8..908399a 100644 --- a/drivers/scsi/cxgbi/cxgb4i/

Re: [dm-devel] kernel BUG at drivers/scsi/scsi_lib.c:1101! observed during md5sum for one file on (RAID4->RAID0) device

2015-07-30 Thread NeilBrown
On Thu, 30 Jul 2015 06:28:06 -0700 James Bottomley wrote: > On Thu, 2015-07-30 at 05:03 -0400, Yi Zhang wrote: > > Hi SCSI/RAID maintainer > > > > During raid test with 4.2.0-rc3, I observed below kernel BUG, pls check > > below info for the test log/environment/test steps. > > > > Log: > > [

Re: [PATCH] target: Wait RCU grace-period before backend/fabric unload

2015-07-30 Thread Nicholas A. Bellinger
On Thu, 2015-07-30 at 06:07 -0700, Paul E. McKenney wrote: > On Thu, Jul 30, 2015 at 06:15:23AM +, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > This patch addresses a v4.2-rc1 regression where backend driver > > struct module unload immediately after ->free_device() has d

Re: [PATCH v2 1/3] cxlflash: Base error recovery support

2015-07-30 Thread Manoj Kumar
Wendy: Thanks for your review. Comment inline below. - Manoj Kumar On 7/29/2015 5:12 PM, wenxi...@linux.vnet.ibm.com wrote: + +cfg->eeh_active = EEH_STATE_NONE; +wake_up_all(&cfg->eeh_waitq); +} + Do you need host->lock in these EEH callback functions? These are synchronous callba

Re: [PATCH v2 3/3] cxlflash: Virtual LUN support

2015-07-30 Thread Manoj Kumar
Wendy: Thanks for taking the time to review this patch. Comments inline below. - Manoj Kumar On 7/29/2015 5:13 PM, wenxi...@linux.vnet.ibm.com wrote: +/* Update the free_curr_idx */ +if (bit_pos == 63) +lun_info->free_curr_idx = bit_word + 1; Predefined Macros for 63 and 64?

Re: [PATCH][SCSI] hptiop: Support HighPoint RR36xx HBAs and Support SAS tape and SAS media changer

2015-07-30 Thread James Bottomley
On Wed, 2015-06-24 at 11:41 +0800, linux wrote: > Support HighPoint RR36xx HBAs which are based on Marvell Frey. > Support SAS tape and SAS media changer. > > Signed-off-by: HighPoint Linux Team > > drivers/scsi/hptiop.c | 104 > +++ >

Re: [scsi 7/7] scsi_debug: resp_request: remove unused variable

2015-07-30 Thread Martin K. Petersen
> "Tomas" == Tomas Winkler writes: Tomas> Fixes the following warning In function ‘resp_requests’: Tomas> drivers/scsi//scsi_debug.c:1432:15: warning: variable Tomas> ‘want_dsense’ set but not used [-Wunused-but-set-variable] bool Tomas> dsense, want_dsense; Reviewed-by: Martin K. Petersen

Re: [scsi 6/7 RESEND] scsi_debug: fix REPORT LUNS Well Known LU

2015-07-30 Thread Martin K. Petersen
> "Tomas" == Tomas Winkler writes: Tomas> The use case to report 'REPORT LUNS WLUN' described in scsi_debug Tomas> documentation didn't work because: scsi_scan_host_selected() Tomas> checks for: lun < shost->max_lun Tomas> To fix this we set: max_lun = SCSI_W_LUN_REPORT_LUNS + 1; Reviewed-b

Re: [scsi 5/7 RESEND] scsi_debug: schedule_resp fix input variable check

2015-07-30 Thread Martin K. Petersen
> "Tomas" == Tomas Winkler writes: Tomas> The function should never be called with cmnd NULL so put a fat Tomas> WARN there. Fix also smatch wraning: schedule_resp() warn: Tomas> variable dereferenced before check 'cmnd' Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle L

Re: [scsi 4/7 RESEND] scsi_debug: make dump_sector static

2015-07-30 Thread Martin K. Petersen
> "Tomas" == Tomas Winkler writes: Tomas> fixes warning: warning: no previous prototype for ‘dump_sector’ Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message t

Re: [scsi 3/7 RESEND] scsi_debug: vfree is null safe so drop the check

2015-07-30 Thread Martin K. Petersen
> "Tomas" == Tomas Winkler writes: Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.o

Re: [scsi 2/7 RESEND] scsi_debug: use SCSI_W_LUN_REPORT_LUNS instead of SAM2_WLUN_REPORT_LUNS;

2015-07-30 Thread Martin K. Petersen
> "Tomas" == Tomas Winkler writes: Tomas> use SCSI_W_LUN_REPORT_LUNS from scsi.h instead of localy defined Tomas> SAM2_WLUN_REPORT_LUNS Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-sc

Re: [scsi 1/7 RESEND] scsi_debug: define pr_fmt() for consistent logging

2015-07-30 Thread Martin K. Petersen
> "Tomas" == Tomas Winkler writes: Tomas> Use pr_fmt with both module name and __func__ Also drop few bare Tomas> printk leftovers Tomas> The log format should stay pretty much intact Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe fr

Re: [patch] Revert "block: remove artifical max_hw_sectors cap"

2015-07-30 Thread Jeff Moyer
"Elliott, Robert (Server Storage)" writes: >> Christoph, did you have some hardware where a higher max_sectors_kb >> improved performance? > > I don't still have performance numbers, but the old default of > 512 KiB was interfering with building large writes that RAID > controllers can treat as

Re: kernel BUG at drivers/scsi/scsi_lib.c:1101! observed during md5sum for one file on (RAID4->RAID0) device

2015-07-30 Thread James Bottomley
On Thu, 2015-07-30 at 05:03 -0400, Yi Zhang wrote: > Hi SCSI/RAID maintainer > > During raid test with 4.2.0-rc3, I observed below kernel BUG, pls check below > info for the test log/environment/test steps. > > Log: > [ 306.741662] md: bind > [ 306.750865] md: bind > [ 306.753993] md: bind >

Re: [PATCH] target: Wait RCU grace-period before backend/fabric unload

2015-07-30 Thread Paul E. McKenney
On Thu, Jul 30, 2015 at 06:15:23AM +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > This patch addresses a v4.2-rc1 regression where backend driver > struct module unload immediately after ->free_device() has done > an internal call_rcu(), results in IRQ rcu_process_callbacks()

Re: [PATCH 8/8] pm80xx: Bump pm80xx driver version to 0.1.38

2015-07-30 Thread Tomas Henzl
On 29.7.2015 08:27, viswa...@pmcs.com wrote: > From: Viswas G > > Bump pm80xx driver version to 0.1.38. > > Signed-off-by: Viswas G > Signed-off-by: Suresh Thiagarajan Reviewed-by: Tomas Henzl Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a m

Re: [PATCH 7/8] pm80xx: Handling Invalid SSP Response frame

2015-07-30 Thread Tomas Henzl
On 29.7.2015 08:27, viswa...@pmcs.com wrote: > From: Viswas G > > The request has to be retried incase if the length of the SSP > Response IU is invalid. > > Signed-off-by: Viswas G > Signed-off-by: Suresh Thiagarajan Reviewed-by: Tomas Henzl Tomas -- To unsubscribe from this list: send t

Re: [PATCH 7/8] pm80xx: Handling Invalid SSP Response frame

2015-07-30 Thread Tomas Henzl
On 29.7.2015 08:27, viswa...@pmcs.com wrote: > From: Viswas G > > The request has to be retried incase if the length of the SSP > Response IU is invalid. > > Signed-off-by: Viswas G > Signed-off-by: Suresh Thiagarajan Reviewed-by: Tomas Henzl Tomas -- To unsubscribe from this list: send th

Re: [PATCH 6/8] pm80xx: Add PORT RECOVERY TIMEOUT support

2015-07-30 Thread Tomas Henzl
On 29.7.2015 08:27, viswa...@pmcs.com wrote: > From: Viswas G > > PORT RECOVERY TIMEOUT is the maximum time between the controller's > detection of the PHY down until the receipt of the ID_Frame (from the > same remote SAS port). If the time expires before the ID_FRAME is > received, the port is

Re: [PATCH 5/8] pm80xx: Remove unnecessary phy disconnect while link error

2015-07-30 Thread Tomas Henzl
On 29.7.2015 08:27, viswa...@pmcs.com wrote: > From: Viswas G > > If the link error happens, we don't need to disconnect the phy, > which will remove the drive. Instead acknowledging the controller > and logging the error will be enough. > > Signed-off-by: Viswas G > Signed-off-by: Suresh Thiag

kernel BUG at drivers/scsi/scsi_lib.c:1101! observed during md5sum for one file on (RAID4->RAID0) device

2015-07-30 Thread Yi Zhang
Hi SCSI/RAID maintainer During raid test with 4.2.0-rc3, I observed below kernel BUG, pls check below info for the test log/environment/test steps. Log: [ 306.741662] md: bind [ 306.750865] md: bind [ 306.753993] md: bind [ 306.764475] md: bind [ 306.786156] md: bind [ 306.789362] md: bind