Re: [PATCH 02/10] dm-mpath, scsi_dh: request scsi_dh modules in scsi_dh, not dm-mpath

2015-08-31 Thread Hannes Reinecke
On 08/28/2015 09:53 PM, James Bottomley wrote: > On Thu, 2015-08-27 at 14:16 +0200, Hannes Reinecke wrote: >> @@ -158,7 +171,7 @@ store_dh_state(struct device *dev, struct >> device_attribute *attr, >> /* >> * Attach to a device handler >> */ >> -

Re: [PATCH 0/2] be2iscsi driver update to 10.6.0.1

2015-08-31 Thread Sony John
Hi Mike Any review updates for this patchset. Thanks On Thu, Aug 20, 2015 at 4:44 AM, John Soni Jose wrote: > This patch is generated against the for-next branch. > > John Soni Jose (1): > be2iscsi: Bump the driver version > > John Soni Jose (1): > be2iscsi: Fix

[PATCH] scsi_scan: don't dump trace when scsi_prep_async_scan() is called twice

2015-08-31 Thread Vitaly Kuznetsov
The only user of scsi_prep_async_scan() is scsi_scan_host() and it handles the situation correctly. Move 'called twice' reporting to debug level as well. The issue is observed on Hyper-V: on any device add/remove event storvsc driver calls scsi_scan_host() and in case previous scan is still

Re: [PATCH] hfcldd: Add Hitachi FC driver.

2015-08-31 Thread Johannes Thumshirn
"豊原吉宏 / TOYOHARA,YOSHIHIRO" writes: > I am an engineer in Hitachi. , > We committed the following files newly > and mailed the patch by one mail. Maybe you could split it up into a logical patch series. All in all 131907 LOC in one patch are quite some work to

Re: [PATCH] Remove check for SAS expander when querying bay/enclosure IDs.

2015-08-31 Thread Jordan Hargrave
On Tue, Jul 14, 2015 at 6:23 AM, Hannes Reinecke wrote: > On 07/13/2015 04:27 PM, Jordan Hargrave wrote: >> Dell Server backplanes can report bay/enclosure IDs without an >> expander present. This patch allows the bay/enclosure IDs to be >> propagaged to sysfs.we >> >>

[PATCH 00/14] lpfc: Update to revision 11.0.0.0

2015-08-31 Thread James Smart
This patch set updates the lpfc driver to revision 11.0.0.0 The patches were cut against scsi-misc -- james s James Smart (14): Pull in patches posted to linux-scsi prior: lpfc: fix model description lpfc: Remove unnessary cast lpfc: in sli3 use configured sg_seg_cnt for

[PATCH 02/14] lpfc: Remove unnessary cast

2015-08-31 Thread James Smart
From: Firo Yang kzalloc() returns a void pointer - no need to cast it in drivers/scsi/lpfc/lpfc_init.c::lpfc_sli_driver_resource_setup() Signed-off-by: Firo Yang Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_init.c | 3

[PATCH 03/14] lpfc: in sli3 use configured sg_seg_cnt for sg_tablesize

2015-08-31 Thread James Smart
From: Bodo Stroesser Hi James, We had some performance problems with RAID systems connected to LPe12k. AFAICS, the reason is a small bug in lpfc.ko, causing the IO-size to be smaller than expected. The patch below fixes it for us. Please CC me, I'm not on the list.

[PATCH 01/14] lpfc: fix model description

2015-08-31 Thread James Smart
From: Sebastian Herbszt Remove trailing space from model description. Signed-off-by: Sebastian Herbszt Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 10/14] lpfc: Add support for Lancer G6 and 32G FC links

2015-08-31 Thread James Smart
Add support for Lancer G6 and 32G FC links Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 8 +--- drivers/scsi/lpfc/lpfc_attr.c| 17 + drivers/scsi/lpfc/lpfc_ct.c

[PATCH 11/14] lpfc: Fix for discovery failure in PT2PT when FLOGI's ELS ACC response gets aborted

2015-08-31 Thread James Smart
Fix for discovery failure in PT2PT when FLOGI's ELS ACC response gets aborted Change login state machine to: - Restart FLOGI if prior is ABTS'd - Reject incoming FLOGIs if we have one pending The above ensures that we always finish FLOGI processing, regardless of who initated FLOGI, before

[PATCH 05/14] Fix kmalloc overflow in LPFC driver at large core count

2015-08-31 Thread James Smart
Note: original patch modified by me to resolve unused variable warning From: ian mitchell This patch allows the LPFC to start up without a fatal kernel bug based on an exceeded KMALLOC_MAX_SIZE and a too large NR_CPU-based maskbits field. The bug was based on the number of

[PATCH 07/14] lpfc: remove set but not used variables

2015-08-31 Thread James Smart
From: Sebastian Herbszt Remove set but not used variables. Signed-off-by: Sebastian Herbszt Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_attr.c | 6 drivers/scsi/lpfc/lpfc_bsg.c | 20 --

[PATCH 14/14] lpfc: Update version to 11.0.0.0 for upstream patch set

2015-08-31 Thread James Smart
Update version to 11.0.0.0 for upstream patch set Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 13/14] lpfc: Fix default RA_TOV and ED_TOV in the FC/FCoE driver for all topologies

2015-08-31 Thread James Smart
Fix default RA_TOV and ED_TOV in the FC/FCoE driver for all topologies Initial link up defaults were not properly being tracked relative to initial FLOGI or pt2pt PLOGI. Add code to initialize them. Signed-off-by: Dick Kennedy Signed-off-by: James Smart

[PATCH 08/14] lpfc: Fix possible use-after-free and double free in lpfc_mbx_cmpl_rdp_page_a2()

2015-08-31 Thread James Smart
From: Johannes Thumshirn If the bf_get() call in lpfc_mbx_cmpl_rdp_page_a2() does succeeds, execution continues normally and mp gets kfree()d. If the subsequent call to lpfc_sli_issue_mbox() fails execution jumps to the error label where lpfc_mbuf_free() is called with

[PATCH 04/14] lpfc: Destroy lpfc_hba_index IDR on module exit

2015-08-31 Thread James Smart
From: Johannes Thumshirn Destroy lpfc_hba_index IDR on module exit, reclaiming the allocated memory. This was detected by the following semantic patch (written by Luis Rodriguez ) @ defines_module_init @ declarer name module_init, module_exit; declarer

[PATCH 09/14] fix: lpfc_send_rscn_event sends bigger buffer size

2015-08-31 Thread James Smart
From: Ales Novak lpfc_send_rscn_event() allocates data for sizeof(struct lpfc_rscn_event_header) + payload_len, but claims that the data has size of sizeof(struct lpfc_els_event_header) + payload_len. That leads to buffer overruns. Signed-off-by: Ales Novak

[PATCH 12/14] lpfc: The linux driver does not reinitiate discovery after a failed FLOGI

2015-08-31 Thread James Smart
The linux driver does not reinitiate discovery after a failed FLOGI Forgot to clear FCF Discovery in-progress flag upon FLOGI failures. Thus we didn't restart FLOGI. Signed-off-by: Dick Kennedy Signed-off-by: James Smart ---

[PATCH 06/14] lpfc:Make the function lpfc_sli4_mbox_completions_pending static in order to comply with function prototype

2015-08-31 Thread James Smart
From: Nicholas Krause This makes the function lpfc_sli4_mbox_completion's definition static now in order to comply with its prototype being also declared as static too. Signed-off-by: Nicholas Krause Signed-off-by: James Smart

Re: [PATCH] lpfc: Fix possible use-after-free and double free in lpfc_mbx_cmpl_rdp_page_a2()

2015-08-31 Thread James Smart
On 8/18/2015 6:27 PM, Sebastian Herbszt wrote: Johannes Thumshirn wrote: Sebastian Herbszt writes: Johannes Thumshirn wrote: If the bf_get() call in lpfc_mbx_cmpl_rdp_page_a2() does succeeds, execution continues normally and mp gets kfree()d. If the subsequent call to

RE: [PATCH v2 0/10] megaraid_sas : Updates for scsi for-next

2015-08-31 Thread Sumit Saxena
> -Original Message- > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] > Sent: Saturday, August 29, 2015 1:03 AM > To: sumit.sax...@avagotech.com > Cc: linux-scsi@vger.kernel.org; the...@redhat.com; > martin.peter...@oracle.com; h...@infradead.org;

RE: [scsi 5/7 RESEND] scsi_debug: schedule_resp fix input variable check

2015-08-31 Thread Winkler, Tomas
> > On Sun, 2015-08-30 at 10:36 +, Winkler, Tomas wrote: > > > > > > > > > > > > > > > I'm just not sure why the patches are not merged or even rejected. > > > > > > > > Because ideally I want a Maintainer ack. That's Doug Gilbert. > > > > James > > The patches were discussed and the ACked

[PATCH v3 3/10] megaraid_sas : Jbod sequence number support

2015-08-31 Thread sumit . saxena
Implemented JBOD map which will provide quick access for JBOD path and also provide sequence number. This will help hardware to fail command to the FW in case of any sequence mismatch. Fast Path IO for JBOD will refer JBOD map (which has sequence number per JBOD devices) instead of Raid map.

[PATCH] hfcldd: Add Hitachi FC driver.

2015-08-31 Thread 豊原吉宏 / TOYOHARA,YOSHIHIRO
I am an engineer in Hitachi. , We committed the following files newly and mailed the patch by one mail. But the mail has about 4,600,000 characters, and is blocked beyond 100,000 character of the mail permission. There are also source file beyond 20,000 lines. Could you advise how to do and

[PATCH 1/1] storvsc: Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag

2015-08-31 Thread K. Y. Srinivasan
Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag since we are not specifying tags. Signed-off-by: K. Y. Srinivasan Cc: sta...@vger.kernel.org --- drivers/scsi/storvsc_drv.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/storvsc_drv.c

RE: [PATCH] scsi_scan: move 'INQUIRY result too short' message to debug level

2015-08-31 Thread KY Srinivasan
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Monday, August 31, 2015 5:50 AM > To: James E.J. Bottomley > Cc: linux-scsi@vger.kernel.org; linux-ker...@vger.kernel.org; KY Srinivasan > ; Long Li

[PATCH v3 10/10] megaraid_sas : Version upgrade

2015-08-31 Thread sumit . saxena
Signed-off-by: Sumit Saxena Signed-off-by: Kashyap Desai --- drivers/scsi/megaraid/megaraid_sas.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas.h

RE: [PATCH 1/1] storvsc: Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag

2015-08-31 Thread KY Srinivasan
> -Original Message- > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] > Sent: Monday, August 31, 2015 7:02 AM > To: KY Srinivasan > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; oher...@suse.com; >

[PATCH v3 7/10] megaraid_sas : Print critical fw event message

2015-08-31 Thread sumit . saxena
Print firmware event in readable format. This will help user to track any critical firmware event without any application support. sample syslogd output - megaraid_sas :02:00.0: 8619 (491648347s/0x0020/WARN) - Controller temperature threshold exceeded. This may indicate inadequate system

[PATCH v3 6/10] megaraid_sas : Chip reset if driver fail to bring ioc ready

2015-08-31 Thread sumit . saxena
Patch which fix the issue reported as below. http://marc.info/?l=linux-scsi=143694494104544=2 This patch will try to do chip reset from driver load time. Driver load time, if firmware is not comming to ready state, driver try chip reset calling adp_reset() callback. For fusion adapter, that

[PATCH v3 8/10] megaraid_sas : Fix validHandles check in io path

2015-08-31 Thread sumit . saxena
Syncro firmware supports round robin IO switch on dual path. For this driver use validHandles as a check for dual path. This check suppose to be > 1 (not > 2) Without this patch, earlier driver code does not use dual path functionality. Signed-off-by: Sumit Saxena

[PATCH v3 01/10] megaraid_sas : Synchronize driver headers with firmware APIs

2015-08-31 Thread sumit . saxena
Signed-off-by: Sumit Saxena Signed-off-by: Kashyap Desai Reviewed-by: Martin Petersen --- drivers/scsi/megaraid/megaraid_sas.h| 18 ++ drivers/scsi/megaraid/megaraid_sas_fusion.h |

[PATCH v3 02/10] megaraid_sas : Increase timeout to 60 secs for abort frames during shutdown

2015-08-31 Thread sumit . saxena
Signed-off-by: Sumit Saxena Signed-off-by: Kashyap Desai Reviewed-by: Martin Petersen --- drivers/scsi/megaraid/megaraid_sas_base.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v3 5/10] megaraid_sas : Support for max_io_size 1MB

2015-08-31 Thread sumit . saxena
Driver will expose max sge = 256 (earlier it was 64), if firmware support extended IO size upto 1M. Signed-off-by: Sumit Saxena Signed-off-by: Kashyap Desai Reviewed-by: Martin Petersen ---

[PATCH v3 0/10] megaraid_sas : Updates for scsi for-next

2015-08-31 Thread sumit . saxena
MegaRaid driver changes. This patch set is rebased on top of below commit- commit da0dc9fb4e6b0ad5a947c27a3c48985f6a2377eb Author: Bjorn Helgaas Date: Tue Jul 7 15:52:45 2015 -0500 megaraid_sas: fix whitespace errors Please consider this patch set for next kernel

[PATCH v3 9/10] megaraid_sas : Code refactor for use of requestorId

2015-08-31 Thread sumit . saxena
Some of the code changes was proposed by David Binderman Removed redudant check of requestorId. Redundant condition: instance.requestorId. Check for plasma firmware 1.11 or new restructured to support only for specific device id Signed-off-by: Sumit Saxena

[PATCH] scsi_scan: move 'INQUIRY result too short' message to debug level

2015-08-31 Thread Vitaly Kuznetsov
Some Hyper-V hosts are known for ignoring SPC-2/3/4 requirement for 'INQUIRY data (see table ...) shall contain at least 36 bytes'. As a result we get tons on 'scsi 0:7:1:1: scsi scan: INQUIRY result too short (5), using 36' messages on console. As Hyper-V is also known for its serial port being

Re: [PATCH 1/1] storvsc: Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag

2015-08-31 Thread James Bottomley
On Mon, 2015-08-31 at 08:21 -0700, K. Y. Srinivasan wrote: > Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag since we are not specifying > tags. What's the actual problem description this causes? James > Signed-off-by: K. Y. Srinivasan > Cc: sta...@vger.kernel.org > --- >