Re: [PATCH v2] scsi: kconfig: When possible, compile drivers with COMPILE_TEST

2015-10-15 Thread kbuild test robot
Hi Luis, [auto build test ERROR on scsi/for-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Luis-de-Bethencourt/scsi-kconfig-When-possible-compile-drivers-with-COMPILE_TEST/20151015-073819 c

NULL pointer dereference: IP: [] sr_runtime_suspend+0xc/0x20 [sr_mod]

2015-10-15 Thread Paul Menzel
Dear Linux SCSI folks, using Debian Sid/unstable with Linux 4.2.3-1 upgrading from systemd 227-1 to 227-2 [1] and other packages, the system doesn’t start up anymore and the /dev/md1 device doesn’t seem to be found and I am dropped into shell from initramfs (BusyBox). Only having wireless LAN an

[PATCH 3/9] aic7xxx: Avoid name collision with

2015-10-15 Thread Michal Marek
Rename the local definition of LIST_HEAD to BSD_LIST_HEAD. This fixes a ctags error if we apply the C rules to header files as well: ctags: Warning: drivers/scsi/aic7xxx/aic79xx.h:1072: null expansion of name pattern "\3" ctags: Warning: drivers/scsi/aic7xxx/aic7xxx.h:919: null expansion of name

Re: [dm-devel] [PATCH 3/6] sd: implement the Persistent Reservation API

2015-10-15 Thread Christoph Hellwig
On Thu, Oct 15, 2015 at 08:30:50AM -0700, Bart Van Assche wrote: > Can you explain why this functionality has been added to the sd driver > instead of the SCSI core ? Aren't persistent reservations a concept that > applies to all SCSI device types ? In theory it does. In practice it's only used

Re: [dm-devel] [PATCH 3/6] sd: implement the Persistent Reservation API

2015-10-15 Thread Bart Van Assche
On 10/15/2015 05:10 AM, Christoph Hellwig wrote: This is a mostly trivial mapping to the PERSISTENT RESERVE IN/OUT commands. Hello Christoph, Can you explain why this functionality has been added to the sd driver instead of the SCSI core ? Aren't persistent reservations a concept that applie

Re: [PATCH] scsi: advansys needs ISA dma api for ISA support

2015-10-15 Thread Arnd Bergmann
On Thursday 15 October 2015 14:09:31 Hannes Reinecke wrote: > On 10/15/2015 02:06 PM, Hannes Reinecke wrote: > > On 10/12/2015 05:10 PM, Arnd Bergmann wrote: > >> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig > >> index d2f480b04a52..d4aa6a1a806c 100644 > >> --- a/drivers/scsi/Kconfig >

[PATCH] bnx2fc: Modify supported product numbers in MODULE_DESCRIPTION

2015-10-15 Thread Masanari Iida
Currently bnx2fc driver support not only BMC57710, but also BCM57711, BCM57712, BCM57800, BCM57810 and BCM57840. It is better to modify from "BCM57710" to "BCM5771x/BCM578xx" Signed-off-by: Masanari Iida --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Persistent Reservation API V4

2015-10-15 Thread Christoph Hellwig
This series adds support for a simplified Persistent Reservation API to the block layer. The intent is that both in-kernel and userspace consumers can use the API instead of having to hand craft SCSI or NVMe command through the various pass through interfaces. It also adds DM support as getting r

[PATCH 2/6] block: add an API for Persistent Reservations

2015-10-15 Thread Christoph Hellwig
This commits adds a driver API and ioctls for controlling Persistent Reservations s/genericly/generically/ at the block layer. Persistent Reservations are supported by SCSI and NVMe and allow controlling who gets access to a device in a shared storage setup. Note that we add a pr_ops structure to

[PATCH 1/6] block: cleanup blkdev_ioctl

2015-10-15 Thread Christoph Hellwig
Split out helpers for all non-trivial ioctls to make this function simpler, and also start passing around a pointer version of the argument, as that's what most ioctl handlers actually need. Signed-off-by: Christoph Hellwig --- block/ioctl.c | 227

[PATCH 3/6] sd: implement the Persistent Reservation API

2015-10-15 Thread Christoph Hellwig
This is a mostly trivial mapping to the PERSISTENT RESERVE IN/OUT commands. Signed-off-by: Christoph Hellwig --- drivers/scsi/sd.c | 96 +++ 1 file changed, 96 insertions(+) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 3f37022..a1e

[PATCH 4/6] dm: refactor ioctl handling

2015-10-15 Thread Christoph Hellwig
This moves the call to blkdev_ioctl and the argument checking to core code, and only leaves a callout to find the block device to operate on it the targets. This will simplifies the code and will allow us to pass through ioctl-like command using other methods in the next patch. Also split out a h

[PATCH 5/6] dm: add support for passing through persistent reservations

2015-10-15 Thread Christoph Hellwig
This adds support to pass through persistent reservation requests similar to the existing ioctl handling, and with the same limitations, e.g. devices may only have a single target attached. This is mostly intended for multipathing. Signed-off-by: Christoph Hellwig --- drivers/md/dm.c | 123

[PATCH 6/6] NVMe: Add persistent reservation ops

2015-10-15 Thread Christoph Hellwig
From: Keith Busch Signed-off-by: Keith Busch [hch: rebased, set PTPL=1] Signed-off-by: Christoph Hellwig --- drivers/nvme/host/pci.c | 95 + 1 file changed, 95 insertions(+) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index ad

Re: [PATCH] scsi: advansys needs ISA dma api for ISA support

2015-10-15 Thread Hannes Reinecke
On 10/15/2015 02:06 PM, Hannes Reinecke wrote: > On 10/12/2015 05:10 PM, Arnd Bergmann wrote: >> The advansys drvier uses the request_dma function that is used on ISA >> machines for the internal DMA controller, which causes build errors >> on platforms that have ISA slots but do not provide the IS

Re: [PATCH 03/25] scsi: hisi_sas: add initial bare driver

2015-10-15 Thread Xinwei Kong
On 2015/10/15 17:23, John Garry wrote: On 15/10/2015 09:49, Xinwei Kong wrote: On 2015/10/12 23:20, John Garry wrote: This patch adds the initial bare driver for the HiSilicon SAS HBA. The driver includes no HW interaction, but only the changes to build and load the driver module. The HBA is

Re: [PATCH] scsi: advansys needs ISA dma api for ISA support

2015-10-15 Thread Hannes Reinecke
On 10/12/2015 05:10 PM, Arnd Bergmann wrote: > The advansys drvier uses the request_dma function that is used on ISA > machines for the internal DMA controller, which causes build errors > on platforms that have ISA slots but do not provide the ISA DMA API: > > drivers/scsi/advansys.c: In function

RE: [PATCH] megaraid_sas: init tasklet earlier

2015-10-15 Thread Sumit Saxena
> -Original Message- > From: Sumit Saxena [mailto:sumit.sax...@avagotech.com] > Sent: Friday, August 28, 2015 3:52 PM > To: 'Tomas Henzl'; 'linux-scsi@vger.kernel.org' > Cc: Kashyap Desai; Kiran Kumar Kasturi > Subject: RE: [PATCH] megaraid_sas: init tasklet earlier > > > > > -Original

Re: [PATCH 03/25] scsi: hisi_sas: add initial bare driver

2015-10-15 Thread zhangfei
On 10/15/2015 05:23 PM, John Garry wrote: On 15/10/2015 09:49, Xinwei Kong wrote: +++ b/drivers/scsi/hisi_sas/hisi_sas.h @@ -0,0 +1,24 @@ +/* + * Copyright (c) 2015 Linaro Ltd. + * Copyright (c) 2015 Hisilicon Limited. + * + * This program is free software; you can redistribute it and/or

Re: [PATCH 03/25] scsi: hisi_sas: add initial bare driver

2015-10-15 Thread John Garry
On 15/10/2015 09:49, Xinwei Kong wrote: On 2015/10/12 23:20, John Garry wrote: This patch adds the initial bare driver for the HiSilicon SAS HBA. The driver includes no HW interaction, but only the changes to build and load the driver module. The HBA is a platform device. Signed-off-by: John

Re: [PATCH 03/25] scsi: hisi_sas: add initial bare driver

2015-10-15 Thread Xinwei Kong
On 2015/10/12 23:20, John Garry wrote: > This patch adds the initial bare driver for the HiSilicon > SAS HBA. The driver includes no HW interaction, but only > the changes to build and load the driver module. > > The HBA is a platform device. > > Signed-off-by: John Garry > --- > drivers/scsi

Re: [PATCH 09/25] scsi: hisi_sas: add phy SAS ADDR initialization

2015-10-15 Thread Arnd Bergmann
On Thursday 15 October 2015 11:36:53 zhangfei wrote: > On 10/14/2015 11:18 PM, Arnd Bergmann wrote: > > On Wednesday 14 October 2015 16:05:21 John Garry wrote: > >> > >> OK, we can look at adding the ability to read the SAS HBA address from a > >> FW image or EFI variables. > >> > > > > The easiest

[PATCH 04/12] megaraid_sas : Support for Cutlass(12 Gbps) controller

2015-10-15 Thread sumit . saxena
Signed-off-by: Sumit Saxena Signed-off-by: Kashyap Desai --- drivers/scsi/megaraid/megaraid_sas.h|5 + drivers/scsi/megaraid/megaraid_sas_base.c |6 ++ drivers/scsi/megaraid/megaraid_sas_fusion.c | 12 3 files changed, 23 insertions(+), 0 deletions(-) di

[PATCH 09/12] megaraid_sas : Make PI enabled VD 8 byte DMA aligned

2015-10-15 Thread sumit . saxena
Signed-off-by: Sumit Saxena Signed-off-by: Kashyap Desai --- drivers/scsi/megaraid/megaraid_sas_base.c | 34 + 1 files changed, 34 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c inde

[PATCH 10/12] megaraid_sas : SMAP restriction-do not access user memory from IOCTL code

2015-10-15 Thread sumit . saxena
This is an issue on SMAP enabled CPUs and 32 bit apps running on 64 bit OS. Donot access user memory from kernel code. SMAP bit restricts to access user memory from kernel code. Corresponding Redhat Bugzilla id for this is:[Bug 1267911]. Cc: Signed-off-by: Sumit Saxena Signed-off-by: Kashyap D

PATCH 03/12] megaraid_sas : Support for Intruder(12 Gbps) controller

2015-10-15 Thread sumit . saxena
Signed-off-by: Sumit Saxena Signed-off-by: Kashyap Desai --- drivers/scsi/megaraid/megaraid_sas.h |9 + drivers/scsi/megaraid/megaraid_sas_base.c |8 2 files changed, 17 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi

[PATCH 11/12] megaraid_sas : Driver version upgrade

2015-10-15 Thread sumit . saxena
Signed-off-by: Sumit Saxena --- drivers/scsi/megaraid/megaraid_sas.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h index 7c14a20..9b918ab 100644 --- a/drivers/scsi/megaraid/megaraid_sas.h +

Re: [PATCH 1/1] scsi subsystem : fix function __scsi_device_lookup

2015-10-15 Thread Zhengping Zhou
Yes But it's interesting ,when you continue to add this device (with the same LUN, target, bus, and host number!) to the list,scsi_add_device will call scsi_probe_and_add_lun,and it will call scsi_device_lookup_by_target(starget, lun) to recheck its existence finally.but scsi_device_lookup_by_targ

[PATCH 08/12] megaraid_sas : Initialize tasklet before setting up IRQs

2015-10-15 Thread sumit . saxena
It may happen (kdump), that an interrupt is invoked just after the setup_irqs function was called but before the tasklet was initialised. At this phase the hw ints should have been disabled, but for unknown reason this mechanism seems to not work properly. From: Tomas Henzl Signed-off-by: Tomas

[PATCH 05/12] megaraid_sas : Donot use PAGE_SIZE macro for calculation of max_sectors per IO request

2015-10-15 Thread sumit . saxena
Do not use PAGE_SIZE marco to calculate max_sectors per IO request. Driver code assumes PAGE_SIZE will be always 4096 which can do lead to wrongly calculated value if PAGE_SIZE is not 4096. This issue was reported in Ubuntu Bugzilla Bug #1475166. Cc: Signed-off-by: Sumit Saxena Signed-off-by:

[PATCH 07/12] megaraid_sas : Online firmware Upgrade support for Secure JBOD feature

2015-10-15 Thread sumit . saxena
Signed-off-by: Sumit Saxena Signed-off-by: Kashyap Desai --- drivers/scsi/megaraid/megaraid_sas_base.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c index 6777504..3214c7e 100

[PATCH 02/12] megaraid_sas : Code optimization- remove PCI Ids based checks

2015-10-15 Thread sumit . saxena
Code optimization: remove PCI id based checks and instead of those use instance->ctrl_context to make call whether controller is MFI based OR fusion adapter. fusion adapters further are also divided in two categories- 1)THUNDERBOLT SERIES and 2)INVADER SERIES. Signed-off-by: Sumit Saxena Signe

[PATCH 12/12] megaraid_sas : Remove debug print from function megasas_update_span_set

2015-10-15 Thread sumit . saxena
Signed-off-by: Sumit Saxena --- drivers/scsi/megaraid/megaraid_sas_fp.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_fp.c b/drivers/scsi/megaraid/megaraid_sas_fp.c index ce5b832..741509b 100644 --- a/drivers/scsi/megaraid/megarai

[PATCH 06/12] megaraid_sas : Update OCR capability on controller properties change

2015-10-15 Thread sumit . saxena
Signed-off-by: Sumit Saxena Signed-off-by: Kashyap Desai --- drivers/scsi/megaraid/megaraid_sas.h |1 + drivers/scsi/megaraid/megaraid_sas_base.c | 11 +++ 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megar

[PATCH 01/12] megaraid_sas : Expose TAPE drives unconditionally

2015-10-15 Thread sumit . saxena
Expose non-disk(TAPE drive, CD-ROM) unconditionally. This issue is reported in Redhat Bugzilla [Bug 1254762]. Cc: Signed-off-by: Sumit Saxena Signed-off-by: Kashyap Desai --- drivers/scsi/megaraid/megaraid_sas_base.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a

[PATCH 0/12] megaraid_sas : Updates for scsi for-next

2015-10-15 Thread sumit . saxena
This patch set is rebased on top of last patch set sent by me- http://marc.info/?l=linux-scsi&m=144102204225400&w=2 Please consider this patch set for next kernel release. Signed-off-by: Sumit Saxena Signed-off-by: Kashyap Desai --- [PATCH 00/12] megaraid_sas : Updates for scsi for-next. [PATCH

Re: [PATCH 1/1] scsi subsystem : fix function __scsi_device_lookup

2015-10-15 Thread Hannes Reinecke
On 10/15/2015 09:38 AM, Zhengping Zhou wrote: > when a scsi_device is unpluged from scsi controller, if the > scsi_device is still be used by application layer,it won't be > released until users release it. In this case, scsi_device_remove just set > the scsi_device's state to be SDEV_DEL. But if y

Re: [PATCH 2/2] qla2xxx: fix rwlock recursion

2015-10-15 Thread Hannes Reinecke
On 10/14/2015 05:57 PM, Himanshu Madhani wrote: > This patch fixes rwlock recursion introduced for ISP82XX by > commit 8dfa4b5a ("qla2xxx: Fix sparse annotations") > > Original patch fixes other sparse warnings which did not cause > any regression. So instead of reverting complete patch, this patc

Re: [PATCH 1/2] qla2xxx: Remove unavailable firmware files

2015-10-15 Thread Hannes Reinecke
On 10/14/2015 05:57 PM, Himanshu Madhani wrote: > Remove firmware binary names for the ISPs, which > are not submitted to linux-firmware > > Signed-off-by: Himanshu Madhani > Signed-off-by: Giridhar Malavali > --- > drivers/scsi/qla2xxx/qla_os.c | 29 - > 1 files c

[PATCH 1/1] scsi subsystem : fix function __scsi_device_lookup

2015-10-15 Thread Zhengping Zhou
when a scsi_device is unpluged from scsi controller, if the scsi_device is still be used by application layer,it won't be released until users release it. In this case, scsi_device_remove just set the scsi_device's state to be SDEV_DEL. But if you plug the disk just before the old scsi_device is re

Re: [PATCH 0/3] SCSI: Fix hard lockup in scsi_remove_target()

2015-10-15 Thread Johannes Thumshirn
On Wed, 2015-10-14 at 16:22 -0400, Ewan Milne wrote: > On Wed, 2015-10-14 at 07:30 -0700, James Bottomley wrote: > > On Wed, 2015-10-14 at 15:50 +0200, Johannes Thumshirn wrote: > > > Removing a SCSI target via scsi_remove_target() suspected to be > > > racy. When a > > > sibling get's removed from