Re: [PATCH 3/4] scsi: fix compiler warning for sg

2015-11-04 Thread kbuild test robot
Hi Sinan, [auto build test ERROR on: scsi/for-next] [also build test ERROR on: v4.3 next-20151105] url: https://github.com/0day-ci/linux/commits/Sinan-Kaya/scsi-mpt2sas-try-64-bit-DMA-when-32-bit-DMA-fails/20151105-125248 base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git f

Re: [PATCH 3/4] scsi: fix compiler warning for sg

2015-11-04 Thread kbuild test robot
Hi Sinan, [auto build test ERROR on: scsi/for-next] [also build test ERROR on: v4.3 next-20151105] url: https://github.com/0day-ci/linux/commits/Sinan-Kaya/scsi-mpt2sas-try-64-bit-DMA-when-32-bit-DMA-fails/20151105-125248 base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git f

Re: [PATCH 3/4] scsi: fix compiler warning for sg

2015-11-04 Thread kbuild test robot
Hi Sinan, [auto build test ERROR on: scsi/for-next] [also build test ERROR on: v4.3 next-20151104] url: https://github.com/0day-ci/linux/commits/Sinan-Kaya/scsi-mpt2sas-try-64-bit-DMA-when-32-bit-DMA-fails/20151105-125248 base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git

[scsi:for-next 22/23] ERROR: "__udivdi3" [drivers/scsi/sg.ko] undefined!

2015-11-04 Thread kbuild test robot
Hi Alan, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next head: a34a7cb8a7905606206559cd8d6605e5a72028e9 commit: b704f70ce2003c8046d5c0128303aeeb0d93d890 [22/23] SCSI: fix bug in scsi_dev_info_list matching config: i386-rand

[PATCH 2/4] scsi: mpt3sas: try 64 bit DMA when 32 bit DMA fails

2015-11-04 Thread Sinan Kaya
Current code gives up when 32 bit DMA is not supported. This patch tests 64 bit support before bailing out in such conditions. Signed-off-by: Sinan Kaya --- drivers/scsi/mpt3sas/mpt3sas_base.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/drivers/scsi

[PATCH 3/4] scsi: fix compiler warning for sg

2015-11-04 Thread Sinan Kaya
The MULDIV macro has been designed for small numbers. It emits an overflow warning on 64 bit systems. This patch places type casts in the parameters to fix the compiler warning. Signed-off-by: Sinan Kaya --- drivers/scsi/sg.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH 4/4] scsi: mptxsas: offload IRQ execution

2015-11-04 Thread Sinan Kaya
The mpt2sas and mpt3sas drivers are spinning forever in their IRQ handlers if there is a lot of job queued up by the PCIe card. This handler is causing spikes for the rest of the system and sluggish behavior. Marking all MSI interrupts as non-shared and moving the MSI interrupts to thread context.

[PATCH 1/4] scsi: mpt2sas: try 64 bit DMA when 32 bit DMA fails

2015-11-04 Thread Sinan Kaya
Current code gives up when 32 bit DMA is not supported. This patch tests 64 bit support before bailing out in such conditions. Signed-off-by: Sinan Kaya --- drivers/scsi/mpt2sas/mpt2sas_base.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/

[Bug 107221] New: file not opened

2015-11-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=107221 Bug ID: 107221 Summary: file not opened Product: SCSI Drivers Version: 2.5 Kernel Version: 4.1.2 Hardware: Sparc32 OS: Linux Tree: Fedora Status:

Re:linux-scsi在干吗:(AD)

2015-11-04 Thread 57702
linux-scsi 【天猫】尊敬的淘宝会员,您获得了进群资格,邀请您进QQ群号24662898进群验证码89群内每天抢免单秒杀活动,天天免费红包 退订回T

Re: [PATCH 0/4] Fix performance burning or extracting audio etc. from multiple optical drives.

2015-11-04 Thread Wakko Warner
Tim Small wrote: > Fix performance burning or extracting audio etc. from multiple optical > drives. I know this is a bit late and is still not in 4.3. I applied 2 of the patches. I did not apply the ide-cd, the paride nor the gdrom since I don't have any of those. > Patches are against 3.18.0-r

Re: [PATCH 2/2] Restart list search after unlock in scsi_remove_target

2015-11-04 Thread Bart Van Assche
On 11/04/2015 02:44 PM, James Bottomley wrote: On Wed, 2015-11-04 at 14:35 -0800, Bart Van Assche wrote: (replying to my own e-mail) Hello Christoph, Is it OK for you if I mention you as author of this e-mail ? Could you just both co-operate, especially since there's not much difference betw

Re: [PATCH v2 3/3] ibmvscsi: Allow to configure maximum LUN

2015-11-04 Thread Brian King
On 11/04/2015 07:02 AM, Hannes Reinecke wrote: > On 11/04/2015 12:46 PM, Laurent Vivier wrote: >> >> >> On 04/11/2015 12:16, Hannes Reinecke wrote: >>> On 11/04/2015 11:20 AM, Laurent Vivier wrote: QEMU allows until 32 LUNs. Signed-off-by: Laurent Vivier --- drivers/scsi/

Re: [dm-devel] [PATCH 19/32] block: add helper to get data dir from op

2015-11-04 Thread Bart Van Assche
On 11/04/2015 02:08 PM, mchri...@redhat.com wrote: From: Mike Christie In later patches the op will no longer be a bitmap, so we will not have REQ_WRITE set for all non reads like discard, flush, and write same. Drivers will still want to treat them as writes for accounting reasons, so this pat

Re: [PATCH 2/2] Restart list search after unlock in scsi_remove_target

2015-11-04 Thread James Bottomley
On Wed, 2015-11-04 at 14:35 -0800, Bart Van Assche wrote: > On 10/30/2015 03:09 PM, Bart Van Assche wrote: > > When dropping a lock while iterating a list we must restart the search > > as other threads could have manipulated the list under us. Without this > > we can get stuck in an endless loop.

Re: [PATCH 2/2] Restart list search after unlock in scsi_remove_target

2015-11-04 Thread Bart Van Assche
On 10/30/2015 03:09 PM, Bart Van Assche wrote: When dropping a lock while iterating a list we must restart the search as other threads could have manipulated the list under us. Without this we can get stuck in an endless loop. This is a slightly modified version of a patch from Christoph Hellwig

[PATCH 01/32] block/fs: add REQ_OP definitions.

2015-11-04 Thread mchristi
From: Mike Christie This patch adds definitions for request/bio operations which will be used in the next patches. In the initial patches the REQ_OPs match the REQ ones for compat reasons while all the code is converted in this set. In the last patches that will be removed. Signed-off-by: Mike

[RESEND RFC PATCH 00/32] separate operations from flags in the bio/request structs

2015-11-04 Thread mchristi
This is just a resend of the patchset from earlier today. There was a error in the middle of sending the set, so it looks like 10 - 32 got dropped. There are a couple new block layer commands we are trying to add support for in the near term: compare and write http://www.spinics.net/lists/target-

[PATCH 05/32] drbd: prepare drbd for bi_rw split

2015-11-04 Thread mchristi
From: Mike Christie This patch prepares drbd's submit_bio use for the next patches that split bi_rw into a operation and flags field. Instead of passing in a bitmap with both the operation and flags mixed in, the callers will now pass them in seperately. This patch modifies the code related to t

[PATCH 03/32] dio/btrfs: prep dio->submit_bio users for bi_rw split.

2015-11-04 Thread mchristi
From: Mike Christie Instead of passing around a bitmap of ops and flags, the next patches separate it into a op field and a flags field. This patch prepares the dio code and dio->submit_bio users for the split. Note that the next patches will fix up the submit_bio() call with along other users o

[PATCH 02/32] block/fs/mm: prepare submit_bio_wait users for bi_rw split

2015-11-04 Thread mchristi
From: Mike Christie This patch prepares submit_bio_wait callers for the next patches that split bi_rw into a operation and flags field. Instead of passing in a bitmap with both the operation and flags mixed in, the callers now pass them in seperately. Temp issue: When the fs.h read/write types,

[PATCH 06/32] xen blkback: prepare for bi_rw split

2015-11-04 Thread mchristi
From: Mike Christie This patch prepares xen blkback submit_bio use for the next patches that split bi_rw into a operation and flags field. Instead of passing in a bitmap with both the operation and flags mixed in, the callers will now pass them in seperately. This patch modifies the code related

[PATCH 04/32] block: prepare blkdev_issue_discard for bi_rw split

2015-11-04 Thread mchristi
From: Mike Christie The next patches will prepare the submit_bio users for the split. There were a lot more users than there were for submit_bio_wait, so if the conversion was not a one liner, I broke it out into its own patch. This patch prepares blkdev_issue_discard. There is some compat code

[PATCH 07/32] dm: prepare for bi_rw split

2015-11-04 Thread mchristi
From: Mike Christie This patch prepares dm's submit_bio use for the next patches that split bi_rw into a operation and flags field. Instead of passing in a bitmap with both the operation and flags mixed in, the callers will now pass them in seperately. This patch modifies the code related to the

[PATCH 10/32] f2fs: prepare for bi_rw split

2015-11-04 Thread mchristi
From: Mike Christie This patch prepares f2fs's submit_bio use for the next patches that split bi_rw into a operation and flags field. Instead of passing in a bitmap with both the operation and flags mixed in, the callers will now pass them in seperately. This patch modifies the code related to t

[PATCH 09/32] btrfs: prepare for bi_rw split

2015-11-04 Thread mchristi
From: Mike Christie This patch prepares btrfs's submit_bio use for the next patches that split bi_rw into a operation and flags field. Instead of passing in a bitmap with both the operation and flags mixed in, the callers will now pass them in seperately. This patch modifies the code related to

[PATCH 08/32] target: prepare for bi_rw split

2015-11-04 Thread mchristi
From: Mike Christie This patch prepares lio's submit_bio use for the next patches that split bi_rw into a operation and flags field. Instead of passing in a bitmap with both the operation and flags mixed in, the callers will now pass them in seperately. This patch modifies the code related to th

[PATCH 14/32] block/fs/mm: pass in op and flags to submit_bio

2015-11-04 Thread mchristi
From: Mike Christie This patch prepares submit_bio callers for the next patches that split bi_rw into a operation and flags field. Instead of passing in a bitmap with both the operation and flags mixed in, the callers now pass them in seperately. Signed-off-by: Mike Christie --- block/bio.c

[PATCH 16/32] block/fs/md: pass in op and flags to submit_bh

2015-11-04 Thread mchristi
From: Mike Christie This patch prepares submit_bh callers for the next patches that split bi_rw into a operation and flags field. Instead of passing in a bitmap with both the operation and flags mixed in, the callers now pass them in seperately. Signed-off-by: Mike Christie --- drivers/md/bitm

[PATCH 15/32] btrfs: prepare for bi_rw split

2015-11-04 Thread mchristi
From: Mike Christie This patch prepares btrfs's submit_bh use for the next patches that split bi_rw into a operation and flags field. Instead of passing in a bitmap with both the operation and flags mixed in, the callers will now pass them in seperately. This patch modifies the code related to t

[PATCH 13/32] mm: prepare for bi_rw split

2015-11-04 Thread mchristi
From: Mike Christie This patch prepares mm's submit_bio use for the next patches that split bi_rw into a operation and flags field. Instead of passing in a bitmap with both the operation and flags mixed in, the callers will now pass them in seperately. This patch modifies the code related to the

[PATCH 12/32] xfs: prepare for bi_rw split

2015-11-04 Thread mchristi
From: Mike Christie This patch prepares xfs's submit_bio use for the next patches that split bi_rw into a operation and flags field. Instead of passing in a bitmap with both the operation and flags mixed in, the callers will now pass them in seperately. This patch modifies the code related to th

[PATCH 17/32] block: add operation field to bio struct

2015-11-04 Thread mchristi
From: Mike Christie This patch adds field to the bio to store the REQ_OP, and it has the block layer code set it. The next patches will modify the other drivers and filesystems to also set the bi_op. We are still ORing the op into the bi_rw. When I am done with the conversion, that will be dropp

[PATCH 18/32] drbd: set bio bi_op to REQ_OP

2015-11-04 Thread mchristi
From: Mike Christie This patch has drbd set the bi_op. For compat reasons, we are still ORing the op into bi_rw. This will be dropped in later patches in this series when everyone is updated. Signed-off-by: Mike Christie --- drivers/block/drbd/drbd_actlog.c | 1 + drivers/block/drbd/drbd_b

[PATCH 11/32] gfs2: prepare for bi_rw split

2015-11-04 Thread mchristi
From: Mike Christie This patch prepares gfs2's submit_bio use for the next patches that split bi_rw into a operation and flags field. Instead of passing in a bitmap with both the operation and flags mixed in, the callers will now pass them in seperately. This patch modifies the code related to t

[PATCH 19/32] block: add helper to get data dir from op

2015-11-04 Thread mchristi
From: Mike Christie In later patches the op will no longer be a bitmap, so we will not have REQ_WRITE set for all non reads like discard, flush, and write same. Drivers will still want to treat them as writes for accounting reasons, so this patch adds a helper to translate a op to a data directio

[PATCH 25/32] block: add operation field to request struct

2015-11-04 Thread mchristi
From: Mike Christie This patch adds field to the request to store the REQ_OP, and has the block layer code set it up. The next patches will modify the other drivers to get/test the request->op field. We are still ORing the op into the cmd_flags. When I am done with the conversion, that will be d

[PATCH 21/32] bcache: set bi_op to REQ_OP

2015-11-04 Thread mchristi
From: Mike Christie This patch has bcache set the bi_op. For compat reasons, we are still ORing the op into bi_rw. This will be dropped in later patches in this series when everyone is updated. Signed-off-by: Mike Christie --- drivers/md/bcache/btree.c | 2 ++ drivers/md/bcache/journal.c

[PATCH 20/32] md: set bi_op to REQ_OP

2015-11-04 Thread mchristi
From: Mike Christie This patch has md set the bi_op. For compat reasons, we are still ORing the op into bi_rw. This will be dropped in later patches in this series when everyone is updated. For discards, I am also still passing in REQ_WRITE in with the flags, so code that has not yet been conve

[PATCH 24/32] dm: pass dm stats data dir instead of bi_rw

2015-11-04 Thread mchristi
From: Mike Christie It looks like dm stats primarily cares about the data direction (READ vs WRITE) and does not need the bio/request flags and in the future operation value. REQ_DISCARD is always set with REQ_WRITE, so the check for either one in dm_stats_account_io is not needed. This patch ha

[PATCH 26/32] ide cd: do not set REQ_WRITE on requests.

2015-11-04 Thread mchristi
From: Mike Christie The block layer will set the correct READ/WRITE operation flags/fields when creating a request, so there is not need for drivers to set the REQ_WRITE flag. Signed-off-by: Mike Christie --- drivers/ide/ide-cd_ioctl.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/driv

[PATCH 22/32] block/fs/drivers: set bi_op to REQ_OP

2015-11-04 Thread mchristi
From: Mike Christie This patch sets the bi_op to a REQ_OP for users where it was a simple one line change. For compat reasons, we are still ORing the op into bi_rw. This will be dropped in later patches in this series when everyone is updated. Signed-off-by: Mike Christie --- drivers/block/pk

[PATCH 27/32] cfq/cgroup: pass operation and flags seperately

2015-11-04 Thread mchristi
From: Mike Christie The operation is about to be separated from the flags, so this patch has users pass them in separately to the cgroup stats. Signed-off-by: Mike Christie --- block/cfq-iosched.c| 49 +++--- include/linux/blk-cgroup.h | 13 +

[PATCH 23/32] block/fs: pass in op and flags to ll_rw_block

2015-11-04 Thread mchristi
From: Mike Christie This has ll_rw_block users pass in the request op and flags seperately instead of as a bitmap. Signed-off-by: Mike Christie --- fs/buffer.c | 19 ++- fs/ext4/inode.c | 6 +++--- fs/ext4/namei.c | 3 ++- fs/ext4/super

[PATCH 28/32] block/fs/drivers: use bio/rq_data_dir helpers

2015-11-04 Thread mchristi
From: Mike Christie This has the the block layer, drivers and fs code use the bio and rq data_dir helpers instead of accessing the bi_rw/cmd_flags and checking for REQ_WRITE. Signed-off-by: Mike Christie --- block/blk-merge.c| 2 +- drivers/ata/libata-scsi.c| 2 +- driv

[PATCH 29/32] block/drivers: rm request cmd_flags REQ_OP use

2015-11-04 Thread mchristi
From: Mike Christie With this patch the request struct code no longer uses the cmd_flags field for REQ_OP operations. --- block/blk-core.c | 17 + block/blk-merge.c | 10 ++ block/blk-mq.c| 10 +- block/cfq-ios

[PATCH 30/32] drbd: don't use bi_rw for operations

2015-11-04 Thread mchristi
From: Mike Christie This removes drbd's bi_rw use for operations read, write, discard, write same, etc (REQ_OPs). Signed-off-by: Mike Christie --- drivers/block/drbd/drbd_actlog.c | 2 +- drivers/block/drbd/drbd_bitmap.c | 1 - drivers/block/drbd/drbd_main.c | 15 --- dri

[PATCH 32/32] block: remove __REQ op defs and reduce bi_op/bi_rw sizes

2015-11-04 Thread mchristi
From: Mike Christie This patches removes the __REQ/REQ definitions for operations now defined by REQ_OPs. There is now no need for bi_rw to be a long, so this makes it a int. I also moved the priority to its own field, but I guess I could have just kept this in the bi_rw since there is only 16 b

[PATCH 31/32] block/fs/driver: rm bio bi_rw REQ_OP use

2015-11-04 Thread mchristi
From: Mike Christie With this patch we no longer use the bio->bi_rw field for REQ_WRITE, REQ_DISCARD, REQ_WRITE_SAME, (REQ_OPs). bi_rw should only set REQ_XYZ values and bi_op is for REQ_OPs. Signed-off-by: Mike Christie --- block/bio.c | 15 +++-- block/blk

[PATCH v2 27/27] hpsa: bump the driver version

2015-11-04 Thread Don Brace
Reviewed-by: Justin Lindley Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Reviewed-by: Gerry Morong Reviewed-by: Hannes Reinecke Reviewed-by: Matthew R. Ochs Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/d

[PATCH v2 26/27] hpsa: add in sas transport class

2015-11-04 Thread Don Brace
From: Kevin Barnett Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl Reviewed-by: Matthew R. Ochs Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 550 +--

[PATCH v2 25/27] hpsa: fix multiple issues in path_info_show

2015-11-04 Thread Don Brace
From: Rasmus Villemoes path_info_show() seems to be broken in multiple ways. First, there's 817 return snprintf(buf, output_len+1, "%s%s%s%s%s%s%s%s", 818 path[0], path[1], path[2], path[3], 819 path[4], path[5], path[6], path[7]); so hopefully output_len contains the combine

[PATCH v2 23/27] hpsa: disable report lun data caching

2015-11-04 Thread Don Brace
From: Scott Teel When external target arrays are present, disable the firmware's normal behavior of returning a cached copy of the report lun data, and force it to collect new data each time we request a report luns. This is necessary for external arrays, since there may be no reliable signal fr

[PATCH v2 24/27] hpsa: enhance device messages

2015-11-04 Thread Don Brace
Reviewed-by: Justin Lindley Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Reviewed-by: Tomas Henzl Reviewed-by: Hannes Reinecke Reviewed-by: Matthew R. Ochs Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 45 - 1 file changed, 40 inserti

[PATCH v2 22/27] hpsa: add discovery polling for PT RAID devices.

2015-11-04 Thread Don Brace
From: Scott Teel There are problems with getting configuration change notification in pass-through RAID environments. So, activate flag h->discovery_polling when one of these devices is detected in update_scsi_devices. After discovery_polling is set, execute a report luns from rescan_controller

[PATCH v2 21/27] hpsa: eliminate fake lun0 enclosures

2015-11-04 Thread Don Brace
From: Scott Teel We don't need to create fake enclosure devices at Lun0 in external target array configurations anymore. This was done to support Pre-SCSI rev 5 controllers that didn't suppoprt report luns commands, so the SCSI layer had to scan targets. If there was no LUN at LUN 0, then the tar

[PATCH v2 12/27] hpsa: correct check for non-disk devices

2015-11-04 Thread Don Brace
The driver is using two MACROs which seemingly are looking in the wrong location for the device_flags returned from CISS_REPORT_PHYS. Both MACROs, NON_DISK_PHYS_DEV and PHYS_IOACCEL, are using the pointer returned from figure_lunaddrbytes which is the address of the LUN.lunid element in the extende

[PATCH v2 16/27] hpsa: add function is_logical_device

2015-11-04 Thread Don Brace
From: Kevin Barnett simplify checking for logical/physical devices Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Reviewed-by: Tomas Henzl Reviewed-by: Matthew R. Ochs Reviewed-by: Hannes Reinecke Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 19 +++

[PATCH v2 15/27] hpsa: simplify update scsi devices

2015-11-04 Thread Don Brace
From: Kevin Barnett remove repeated calculation that checks for physical or logical devices. Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Reviewed-by: Tomas Henzl Reviewed-by: Matthew R. Ochs Reviewed-by: Hannes Reinecke Signed-off-by: Don Brace --- driv

[PATCH v2 13/27] hpsa: correct ioaccel2 sg chain len

2015-11-04 Thread Don Brace
Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Reviewed-by: Tomas Henzl Reviewed-by: Hannes Reinecke Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi

[PATCH v2 14/27] hpsa: simplify check for device exposure

2015-11-04 Thread Don Brace
From: Kevin Barnett remove macros and cleanup device exposure checking Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Reviewed-by: Tomas Henzl Reviewed-by: Hannes Reinecke Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 25 +++-- dr

[PATCH v2 17/27] hpsa: enhance hpsa_get_device_id

2015-11-04 Thread Don Brace
use an index into vpd data for SAS/SATA drives Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Reviewed-by: Tomas Henzl Reviewed-by: Matthew R. Ochs Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 23 --- 1 file changed, 20 insertions(

[PATCH v2 20/27] hpsa: generalize external arrays

2015-11-04 Thread Don Brace
From: Scott Teel External array LUNs must use target and lun numbers assigned by the external array. So the driver must treat these differently from local LUNs when assigning lun/target. LUN's 'model' field has been used to detect Lun types that need special treatment, but the desire is to elimi

[PATCH v2 19/27] hpsa: move scsi_add_device and scsi_remove_device calls to new function

2015-11-04 Thread Don Brace
From: Kevin Barnett preparation for adding the sas transport class Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Reviewed-by: Tomas Henzl Reviewed-by: Hannes Reinecke Reviewed-by: Matthew R. Ochs Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 71 +++

[PATCH v2 18/27] hpsa: refactor hpsa_figure_bus_target_lun

2015-11-04 Thread Don Brace
From: Kevin Barnett setup for sas transport. Need to set the bus and target accordingly. Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Reviewed-by: Hannes Reinecke Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 25 - drivers/sc

Re: [PATCH] st: trivial: remove form feed characters

2015-11-04 Thread James Bottomley
On Wed, 2015-11-04 at 23:04 +0200, "Kai Mäkisara (Kolumbus)" wrote: > > On 4.11.2015, at 11.52, Maurizio Lombardi wrote: > > > > Signed-off-by: Maurizio Lombardi > > --- > > drivers/scsi/st.c | 24 > > 1 file changed, 8 insertions(+), 16 deletions(-) > > > > diff --git a

[PATCH v2 10/27] hpsa: fix hpsa_adjust_hpsa_scsi_table

2015-11-04 Thread Don Brace
Fix a NULL pointer issue in the driver when devices are removed during a reset. Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 16 drivers/scsi/hpsa.h |1 + 2 files changed, 17 insertions(+) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index ae9968b..382cb5d

[PATCH v2 11/27] hpsa: fix physical target reset

2015-11-04 Thread Don Brace
From: Scott Teel Set reset type in device_reset_handler to do either logical unit reset for logical devices, or physical target reset, for physical devices. Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Reviewed-by: Tomas Henzl Reviewed-by: Hannes Reinecke S

[PATCH v2 09/27] hpsa: correct transfer length for 6 byte read/write commands

2015-11-04 Thread Don Brace
handle block counts of 0. Cleanup block and block count calculations. Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Reviewed-by: Tomas Henzl Reviewed-by: Hannes Reinecke Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 19 ++- 1 file chan

[PATCH v2 07/27] hpsa: allow driver requested rescans

2015-11-04 Thread Don Brace
Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Reviewed-by: Tomas Henzl Reviewed-by; Hannes Reinecke Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 17 +++-- drivers/scsi/hpsa.h |1 + 2 files changed, 16 insertions(+), 2 deletions(-) dif

[PATCH v2 05/27] hpsa: check for null arguments to dev_printk

2015-11-04 Thread Don Brace
Check for NULLs. Reviewed-by: Tomas Henzl Reviewed-by: Manoj Kumar Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 5a996273..b64913f 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hp

[PATCH v2 02/27] hpsa: stop zeroing reset_cmds_out and ioaccel_cmds_out during rescan

2015-11-04 Thread Don Brace
pulling the rug out from under the reset handler likewise for ioaccel_cmds_out Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 815dc7f.

[PATCH v2 08/27] hpsa: abandon rescans on memory alloaction failures.

2015-11-04 Thread Don Brace
Abandon and reschedule rescan process only if device inquiries fail due to mem alloc failures, which are likely to occur for all devices. Otherwise, skip device if inquiry fails for other reasons, and continue rescanning process for other devices. Reviewed-by: Scott Teel Reviewed-by: Justin Lind

[PATCH v2 03/27] hpsa: remove unused hpsa_tag_discard_error_bits

2015-11-04 Thread Don Brace
This function is no longer used. Reviewed-by: Tomas Henzl Reviewed-by: Hannes Reinecke Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 4085401..5a996273 100644 ---

[PATCH v2 06/27] hpsa: fix null device issues

2015-11-04 Thread Don Brace
Reviewed-by: Tomas Henzl Reviewed-by: Manoj Kumar Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index b64913f..4468166 100644 --- a/drivers/scsi/hpsa.c +++

[PATCH v2 04/27] hpsa: change devtype to unsigned

2015-11-04 Thread Don Brace
This member is used in calls to scsi_device_type. It should be unsigned since the kernel checks for upper bounds and it should never be negative. Suggested-by: Tomas Henzl Suggested-by: Hannes Reinecke Suggested-by: Matthew R. Ochs Signed-off-by: Don Brace --- drivers/scsi/hpsa.h |2 +- 1

[PATCH v2 01/27] hpsa: remove unused parameter hostno

2015-11-04 Thread Don Brace
This parameter was once used before scan_start was defined but now it is no longer used. Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 30 ++ 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 40669f8

[PATCH v2 00/27] hpsa updates

2015-11-04 Thread Don Brace
These patches are based on Linus's tree The changes are: - removed unused parameter hostno - corrected zeroing out reset_cmds_out during a rescan - removed unused function - corrected issue with dev_printk - add driver requested rescans - stop rescans on memory allocation failures and ski

Re: [PATCH] st: trivial: remove form feed characters

2015-11-04 Thread Kai Mäkisara (Kolumbus)
> On 4.11.2015, at 11.52, Maurizio Lombardi wrote: > > Signed-off-by: Maurizio Lombardi > --- > drivers/scsi/st.c | 24 > 1 file changed, 8 insertions(+), 16 deletions(-) > > diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c > index b37b9b0..7c4e518 100644 > --- a/driv

Re: [PATCH] st: trivial: remove form feed characters

2015-11-04 Thread Laurence Oberman
Reviewed-by: Laurence Oberman On Wed, Nov 4, 2015 at 4:52 AM, Maurizio Lombardi wrote: > Signed-off-by: Maurizio Lombardi > --- > drivers/scsi/st.c | 24 > 1 file changed, 8 insertions(+), 16 deletions(-) > > diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c > index b

Re: [PATCH] st: trivial: remove form feed characters

2015-11-04 Thread Matthew R. Ochs
Reviewed-by: Matthew R. Ochs -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 4/5] ipr: Issue Configure Cache Parameters command.

2015-11-04 Thread wenxiong
Reviewed-by: Wen Xiong Thanks, Wendy Quoting Gabriel Krisman Bertazi : Some new adapters require a special Configure Cache Parameters command to enable the adapter write cache, so send this during the adapter initialization if the adapter requires it. Changes since v1: - Fix checkpat

Re: [PATCH v2 1/5] ipr: Add delay to ensure coherent dumps.

2015-11-04 Thread wenxiong
Reviewed-by: Wen Xiong Thanks, Wendy Quoting Gabriel Krisman Bertazi : Add a holding pattern prior to collecting dump data, to wait for the IOA indication that the Mailbox register is stable and won't change without an explicit reset. This ensures we'll be collecting meaningful dump data, e

Re: [PATCH v2 2/5] ipr: Don't set NO_ULEN_CHK bit when resource is a vset.

2015-11-04 Thread wenxiong
Reviewed-by: Wen Xiong Thanks, Wendy Quoting Gabriel Krisman Bertazi : According to the IPR specification, Inhibit Underlength Checking bit must be disabled when issuing commands to vsets. Enabling it in this case might cause SCSI commands to fail with an Illegal Request, so make sure we kee

Re: [PATCH v2 5/5] ipr: Driver version 2.6.3.

2015-11-04 Thread wenxiong
Reviewed-by: Wen Xiong Thanks, Wendy Quoting Gabriel Krisman Bertazi : Signed-off-by: Gabriel Krisman Bertazi --- drivers/scsi/ipr.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/ipr.h b/drivers/scsi/ipr.h index b16bcd1..a34c7a5 100644 --- a/drivers/sc

Re: [PATCH v2 3/5] ipr: Inquiry IOA page 0xC4 during initialization.

2015-11-04 Thread wenxiong
Reviewed-by: Wen Xiong Thanks, Wendy Quoting Gabriel Krisman Bertazi : Add an IOA Inquiry command for Page 0xC4 during IOA initialization to collect cache capabilities, particularly to check if Sync IOA Write Cache is supported. Inquiry will happen right after Cap Inquiry on page 0xD0; and w

Re: [dm-devel] [RFC PATCH 00/32] separate operations from flags in the bio/request structs

2015-11-04 Thread Mike Christie
On 11/04/2015 10:49 AM, Bart Van Assche wrote: > Hello Mike, > > If you have to touch submit_bio() and submit_bio_wait(), how about > requiring the callers of these functions to set the cmd and flags > arguments in the bio structure and to leave out the cmd and flags > arguments from the submit_bi

[PATCH 3/3] mvsas: remove SCSI host before detaching from SAS transport

2015-11-04 Thread Jinpu Wang
>From 6c3cb7d4df1e164008338c922cd99149a6a8191b Mon Sep 17 00:00:00 2001 From: Jack Wang Date: Wed, 4 Nov 2015 10:05:01 +0100 Subject: [PATCH 3/3] mvsas: remove SCSI host before detaching from SAS transport commit cff549e4860f ("scsi: proper state checking and module refcount handling in scsi_dev

[PATCH 2/3] aic94xx: remove SCSI host before detaching from SAS transport

2015-11-04 Thread Jinpu Wang
>From 3aae177e7aa89fa84ae5c60ed5f10056610d Mon Sep 17 00:00:00 2001 From: Jack Wang Date: Wed, 4 Nov 2015 10:01:41 +0100 Subject: [PATCH 2/3] aic94xx: remove SCSI host before detaching from SAS transport commit cff549e4860f ("scsi: proper state checking and module refcount handling in scsi_d

Re: [dm-devel] [RFC PATCH 00/32] separate operations from flags in the bio/request structs

2015-11-04 Thread Bart Van Assche
On 11/04/2015 08:32 AM, mchri...@redhat.com wrote: There are a couple new block layer commands we are trying to add support for in the near term: compare and write http://www.spinics.net/lists/target-devel/msg07826.html copy offload/extended copy/xcopy https://www.redhat.com/archives/dm-devel/2

[PATCH 1/3] isci: isci: remove SCSI host before detaching from SAS transport

2015-11-04 Thread Jinpu Wang
>From b1fb56b6d98610251253dc4b858df509df08e813 Mon Sep 17 00:00:00 2001 From: Jack Wang Date: Wed, 4 Nov 2015 09:46:05 +0100 Subject: [PATCH 1/3] isci: remove SCSI host before detaching from SAS transport commit cff549e4860f ("scsi: proper state checking and module refcount handling in scsi_devi

[PATCH 03/32] dio/btrfs: prep dio->submit_bio users for bi_rw split.

2015-11-04 Thread mchristi
From: Mike Christie Instead of passing around a bitmap of ops and flags, the next patches separate it into a op field and a flags field. This patch prepares the dio code and dio->submit_bio users for the split. Note that the next patches will fix up the submit_bio() call with along other users o

[PATCH 02/32] block/fs/mm: prepare submit_bio_wait users for bi_rw split

2015-11-04 Thread mchristi
From: Mike Christie This patch prepares submit_bio_wait callers for the next patches that split bi_rw into a operation and flags field. Instead of passing in a bitmap with both the operation and flags mixed in, the callers now pass them in seperately. Temp issue: When the fs.h read/write types,

[PATCH 01/32] block/fs: add REQ_OP definitions.

2015-11-04 Thread mchristi
From: Mike Christie This patch adds definitions for request/bio operations which will be used in the next patches. In the initial patches the REQ_OPs match the REQ ones for compat reasons while all the code is converted in this set. In the last patches that will be removed. Signed-off-by: Mike

[RFC PATCH 00/32] separate operations from flags in the bio/request structs

2015-11-04 Thread mchristi
There are a couple new block layer commands we are trying to add support for in the near term: compare and write http://www.spinics.net/lists/target-devel/msg07826.html copy offload/extended copy/xcopy https://www.redhat.com/archives/dm-devel/2014-July/msg00070.html The problem is if we contine

[PATCH 07/32] dm: prepare for bi_rw split

2015-11-04 Thread mchristi
From: Mike Christie This patch prepares dm's submit_bio use for the next patches that split bi_rw into a operation and flags field. Instead of passing in a bitmap with both the operation and flags mixed in, the callers will now pass them in seperately. This patch modifies the code related to the

[PATCH 08/32] target: prepare for bi_rw split

2015-11-04 Thread mchristi
From: Mike Christie This patch prepares lio's submit_bio use for the next patches that split bi_rw into a operation and flags field. Instead of passing in a bitmap with both the operation and flags mixed in, the callers will now pass them in seperately. This patch modifies the code related to th

[PATCH 05/32] drbd: prepare drbd for bi_rw split

2015-11-04 Thread mchristi
From: Mike Christie This patch prepares drbd's submit_bio use for the next patches that split bi_rw into a operation and flags field. Instead of passing in a bitmap with both the operation and flags mixed in, the callers will now pass them in seperately. This patch modifies the code related to t

[PATCH 04/32] block: prepare blkdev_issue_discard for bi_rw split

2015-11-04 Thread mchristi
From: Mike Christie The next patches will prepare the submit_bio users for the split. There were a lot more users than there were for submit_bio_wait, so if the conversion was not a one liner, I broke it out into its own patch. This patch prepares blkdev_issue_discard. There is some compat code

[PATCH 09/32] btrfs: prepare for bi_rw split

2015-11-04 Thread mchristi
From: Mike Christie This patch prepares btrfs's submit_bio use for the next patches that split bi_rw into a operation and flags field. Instead of passing in a bitmap with both the operation and flags mixed in, the callers will now pass them in seperately. This patch modifies the code related to

  1   2   >