[patch 2/2] megaraid_sas: missing curly braces in megasas_detach_one()

The indenting indicates that there are supposed to be some curly braces here. Presumably it means we free something unintentionally leading to a use after free. Fixes: 3761cb4cf65e ('megaraid_sas: JBOD sequence number support') Signed-off-by: Dan Carpenter --- Not tested. diff --git a/drivers/s

[patch 1/2] megaraid_sas: remove a stray tab

One line was indented more than the others. Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c index cc95372..829e9e9 100644 --- a/drivers/scsi/megaraid/megaraid_sas_base.c +++ b/drivers/scsi/megaraid/megaraid_sas_base

aacraid and rotational 1 even for ssd disks

Hi. I wonder if aacraid shouldn't properly inform kernel about sdd disk via /sys/devices/../queue/rotational flag? Using 3.18.22 kernel and aacraid driver tells linux that all drives are rotational: raid: # cat /sys/devices/pci:80/:80:03.0/:81:00.0/host10/target10:0:0/10:0:0:0/bl

scsi-sd fails with error "Invalid field in cdb" for SATA-to-USB adapter JMicron

Hello, In continuation to the issue described in [1] and [2]: Unfortunately, I still suffer from the same problem on Linux kernel v4.2.3. The problem is in detailed described in [3], in particular I see the following in dmesg: sd 6:0:0:0: [sdd] 234441648 512-byte logical blocks: (120 GB/111 GiB)

Re: [dm-devel] [RFC PATCH 00/32] separate operations from flags in the bio/request structs

On Wed, Nov 04, 2015 at 10:53:39AM -0600, Mike Christie wrote: > > If you have to touch submit_bio() and submit_bio_wait(), how about > > requiring the callers of these functions to set the cmd and flags > > arguments in the bio structure and to leave out the cmd and flags > > arguments from the su

Re: [PATCH 32/32] block: remove __REQ op defs and reduce bi_op/bi_rw sizes

I love this series! Also I think it's very good that we finally split the ioprio out to it's own field. Thanks a lot for doing this work. > I was not sure if or how much or where people wanted to stick things. > There also appears to be room in the bi_flags field. If bi_flags is > only using 13

Re: [dm-devel] [PATCH 19/32] block: add helper to get data dir from op

On Thu, Nov 05, 2015 at 11:34:07AM -0600, Mike Christie wrote: > I can do that. You are right in how they are used. I just did the above, > to follow the other *_data_dir calls. I think the *_data_dir calls are horrible interfaces. But your series already is huge, so if it makes your life easier

Re: [RESEND RFC PATCH 00/32] separate operations from flags in the bio/request structs

On Wed, Nov 04, 2015 at 04:07:57PM -0600, mchri...@redhat.com wrote: > Known issues: > - REQ_FLUSH is still a flag, but should probably be a operation. > For lower level drivers like SCSI where we only get a flush, it makes > more sense to be a operation. However, upper layers like filesystems > c