Re: [dm-devel] [RFC PATCH 00/32] separate operations from flags in the bio/request structs

On Wed, Nov 11, 2015 at 01:53:24AM -0600, Mike Christie wrote: > We no longer have the bvec merge functions so the original reason given > in the thread/patch Bart referenced is no longer valid. > > Offlist it was suggested that dropping the argument from submit_bio > might still improve

[PATCH 2/2] scsi_transport_fc: Implement 'async_user_scan' module parameter

When invoking a scan via the sysfs 'scan' attribute the process will be blocked until the scan is completed, which can take a very long time on large installations. Enabling the 'async_user_scan' parameter moves the actual LUN scanning to a workqueue, thereby unblocking the process.

[PATCH 0/2] scsi_transport_fc: LUN masking

Hi all, having been subjected to the pain of trying to bootstrap a really large machine with systemd I decided to implement LUN masking in scsi_transport_fc. The principle is simple: disallow the automated LUN scanning when discovering a rport, and create udev rules which selectively enable

[PATCH 1/2] scsi_transport_fc: implement 'disable_target_scan' module parameter

On larger installations it makes sense to disable the target scan per default on boot, and scan the required LUNs directly via udev rules. Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi_transport_fc.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-)

Re: [RFC PATCH 00/32] separate operations from flags in the bio/request structs

On Wed, Nov 11 2015 at 6:28am -0500, Christoph Hellwig wrote: > On Wed, Nov 11, 2015 at 01:53:24AM -0600, Mike Christie wrote: > > We no longer have the bvec merge functions so the original reason given > > in the thread/patch Bart referenced is no longer valid. > > > >

Re: [PATCH RESEND] scsi: Set sg_tablesize to 1, for LLDDs that set SG_NONE

Hannes: A very valid point. Thanks for your suggestion. Will look at resolving the issue in blk-mq. Regards, - Manoj On 11/11/2015 1:28 AM, Hannes Reinecke wrote: Shouldn't we rather fixup blk-mq to properly support SG_NONE? Silently converting SG_NONE (=0) to 1 has a fair chance of breaking

[PATCH RESEND 03/25] mpt3sas: Move Gen3 HBA's device registration with PCI, SML and IOCTL related API's to a separate file

From: Sreekanth Reddy 1. Created a mpt3sas_module.c files for mpt3sas driver module, where it can register SAS3 HBA devices with PCI, SML, IOCTL subsystems. Also removed the correspanding API's from mpt3sas_scsih.c file. Signed-off-by: Sreekanth Reddy

[PATCH RESEND 04/25] mpt2sas: Created mpt2sas_module.c file in which Gen2 HBA's are registers with PCI, SML and IOCTLs

From: Sreekanth Reddy 1. Create a mpt2sas_module.c file for mpt2sas driver module where GEN2 HBA devices registers with PCI, SML, IOCTL subsytems. 2. Updated the Makefile to use the object files from mpt3sas folder 3. Defined a compilation defination flag

[PATCH 00/25] mpt3sas: Mergering mpt2sas & mpt3sas driver code

Last time we have posted a set of patches which combine the mpt2sas and mpt3sas driver code. and we are generating two driver modules (i.e. two separate .ko's) from this Combined driver source. Now we have modified above Combined driver source (i.e. single driver source with two .ko's) to a

[PATCH RESEND 09/25] mpt3sas: Don't send PHYDISK_HIDDEN Raid Action request on SAS2 HBA's

From: Sreekanth Reddy Don't send PHYDISK_HIDDEN Raid Action request for SAS2 HBA's. Since these HBA's doesn't support this Raid Action. Also enable fast_path only for SAS3 HBA's. Signed-off-by: Sreekanth Reddy ---

[PATCH 4.1 v2] target-core: fix return without a value

Fix the warning drivers/target/target_core_pr.c:332:3: warning: 'return' with no value, in function returning non-void [-Wreturn-type] The patch 35afa65642a9a88c81913377b93a3a66220f8b9d committed to 4.1.11 adds a check if device_list is NULL. The patch adds a return statement without a value to

Re: [PATCH 00/25] mpt3sas: Mergering mpt2sas & mpt3sas driver code

On 11/11/2015 01:00 PM, Sreekanth Reddy wrote: > Last time we have posted a set of patches which combine the mpt2sas > and mpt3sas driver code. and we are generating two driver modules > (i.e. two separate .ko's) from this Combined driver source. > > Now we have modified above Combined driver

RE: [PATCH RESEND 09/25] mpt3sas: Don't send PHYDISK_HIDDEN Raid Action request on SAS2 HBA's

> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Wednesday, November 11, 2015 6:27 PM > To: Sreekanth Reddy; j...@kernel.org > Cc: martin.peter...@oracle.com; linux-scsi@vger.kernel.org; > jbottom...@parallels.com; sathya.prak...@avagotech.com; >

[PATCH RESEND 02/25] mpt3sas: Added mpt2sas driver definitions

From: Sreekanth Reddy 1. Added mpt2sas driver related macro's in mpt3sas header files 2. Made scsi host's, raid class's, pci's, ioctl's call back functions as a gobal API's, so that both the drivers can use these call back functions. Signed-off-by: Sreekanth Reddy

Re: [PATCH RESEND 09/25] mpt3sas: Don't send PHYDISK_HIDDEN Raid Action request on SAS2 HBA's

On 11/11/2015 01:00 PM, Sreekanth Reddy wrote: > From: Sreekanth Reddy > > Don't send PHYDISK_HIDDEN Raid Action request for SAS2 HBA's. > Since these HBA's doesn't support this Raid Action. > > Also enable fast_path only for SAS3 HBA's. > > Signed-off-by:

[PATCH RESEND 12/25] mpt3sas: Ported WarpDrive product SSS6200 support

From: Sreekanth Reddy Ported below list of Warp drive specific patches 1. 'commit 0bdccdb0a090ad8dc5f851cad5e843244c410ee8 ("mpt2sas: WarpDrive New product SSS6200 support added")', 2. 'commit 82a452581230b3ffc9d6475dffdb2568497b5fec ("mpt2sas: WarpDrive

[PATCH RESEND 06/25] mpt3sas: Define 'hba_mpi_version_belonged' IOC variable

From: Sreekanth Reddy 1. Use 'hba_mpi_version_belonged' IOC varable to uniquely identify each individual generation driver functionality at runtime. 2. Declared global variable 'driver_name' and used this variable while reserving PCI regions and while allocating

[PATCH RESEND 13/25] mpt3sas: Ported the providing sysfs attribute to report Backup Rail Monitor Status

From: Sreekanth Reddy A new sysfs shost attribute called "BMR_status" is implemented to report Backup Rail Monitor status. This attribute is located in the path /sys/class/scsi_host/host#/BMR_status when reading this adapter attribute, then driver will

[PATCH RESEND 08/25] mpt3sas: For an IO, build MPI SGL LIST on GEN2 HBA's and build IEEE SGL LIST on GEN3 HBA's

From: Sreekanth Reddy Gen2 HBA's uses MPI Scatter Gather Lists where as Gen3 HBA's uses IEEE Scatter Gather Lists. So modify the common code part in such a way that it will build IEEE SGL table for Gen3 HBA's and it will build MPI SGL table for Gen2 HBA's.

Re: [PATCH 4.1] target-core: fix return without a value

On Tue, 10 Nov 2015, Greg Kroah-Hartman wrote: > On Tue, Nov 10, 2015 at 06:31:47PM -0500, Mikulas Patocka wrote: > > > > > > On Tue, 10 Nov 2015, Greg Kroah-Hartman wrote: > > > > > On Tue, Nov 10, 2015 at 01:32:10PM -0500, Mikulas Patocka wrote: > > > > Fix the warning

[PATCH RESEND 15/25] mpt3sas: Refcount fw_events and fix unsafe list usage

From: Sreekanth Reddy The fw_event_work struct is concurrently referenced at shutdown, so add a refcount to protect it, and refactor the code to use it. Additionally, refactor _scsih_fw_event_cleanup_queue() such that it no longer iterates over the list without

[PATCH RESEND 11/25] mpt3sas: fix for driver fails EEH, recovery from injected pci bus error

From: Sreekanth Reddy This patch stops the driver to invoke kthread (which remove the dead ioc) for some time while EEH recovery has started. This changes are ported from below mpt2sas driver patch 'commit b4730fb6e54a634a145c9c71c5cf856f00beb5cd ("mpt2sas: fix

[PATCH RESEND 14/25] mpt3sas: Refcount sas_device objects and fix unsafe list usage

From: Sreekanth Reddy These objects can be referenced concurrently throughout the driver, we need a way to make sure threads can't delete them out from under each other. This patch adds the refcount, and refactors the code to use it. Additionally, we cannot

[PATCH RESEND 07/25] mpt2sas, mpt3sas : Removed SCSI_MPTXSAS_LOGGING entry from Kconfig

From: Sreekanth Reddy Currently there is a logging level option provided for user for each of our drivers in the kernel configuration utility. They can enable this option to get more verbose information. By default this is enabled. When this option is enabled then

[PATCH RESEND 10/25] mpt3sas: Manage MSIX vectors according to HBA device type

From: Sreekanth Reddy 1. Don't enable MSI-X vector for SAS2008 B0 controller, 2. Enable only single MSI-X vectors for below HBA's a. SAS2004 b. SAS2008 c. SAS2008_1 d. SAS2008_2 e. SAS2008_3 f. SAS2116_1 g. SAS2116_2 3. Enable Combined Reply

[PATCH RESEND 17/25] mpt3sas: setpci reset kernel oops fix

From: Sreekanth Reddy setpci reset on nytro warpdrive card along with sysfs access and cli ioctl access resulted in kernel oops 1. pci_access_mutex lock added to provide synchronization between IOCTL, sysfs, PCI resource handling path 2. gioc_lock spinlock to

[PATCH 25/25] mpt3sas: Bump mpt3sas driver version to 09.102.00.00

Bump mpt3sas driver version to 09.102.00.00 Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h b/drivers/scsi/mpt3sas/mpt3sas_base.h

[PATCH 19/25] mpt3sas: Single driver module which supports both SAS 2.0 & SAS 3.0 HBA's

Modified the mpt3sas driver to have a single driver module which support both SAS 2.0 & SAS 3.0 HBA devices, Change List: * Added SAS 2.0 HBA device IDs to the mpt3sas_pci_table pci table. * Created two separate SCSI host templates for SAS2 and SAS3 HBAs. so that, during the driver load time

[PATCH RESEND 18/25] mpt2sas, mpt3sas: Update the driver versions

From: Sreekanth Reddy Bump the mpt2sas driver version to 20.102.00.00 and Bump the mpt3sas driver version to 9.101.00.00. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.h | 15 ++- 1 file changed,

[PATCH 24/25] mpt3sas: Added SCSI_MPT3SAS_MERGED config option

This Kconfig option is only used for legacy mpt2sas/mpt3sas interoperability. Once this config is set, out of box driver mpt2sas and mpt3sas can reconginize difference between merged and legacy inbox driver. Used only to interface gracefully between old mpt2sas/mpt3sas and merged mpt3sas driver.

[PATCH 21/25] mpt2sas: Removed mpt2sas folder

Removed mpt2sas files, mpt2sas directory & mpt3sas_module.c file. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt2sas/Kconfig | 61 drivers/scsi/mpt2sas/Makefile | 15 -- drivers/scsi/mpt2sas/mpt2sas_module.c | 281

[PATCH 20/25] mpt3sas: Moved Warpdriver specific functions to mpt3sas_warpdrive.c

Change List: * Moved mpt2sas_warpdrive.c file from mpt2sas to mpt3sas folder and renamed it as mpt3sas_warpdrive.c. * Also renamed the functions in mpt3sas_warpdrive.c file to follow current driver function name convention. * Updated the Makefile to build mpt3sas_warpdrive.o file for these

[PATCH 22/25] mpt3sas: Added a module parameter hbas_to_enumerate

Added module parameter 'hbas_to_enumerate', which user can use this merged driver as legacy mpt2sas driver or as a legacy mpt3sas driver if needed. Here are the available options for this module parameter 0 - Merged driver which enumerates both SAS 2.0 & SAS 3.0 HBAs 1 - Acts as legacy

[PATCH RESEND 16/25] mpt3sas: Added OEMs Gen2 PnP ID Branding names

From: Sreekanth Reddy Added OEMs Gen2 PnP ID Branding names from mpt2sas driver. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.c | 326 drivers/scsi/mpt3sas/mpt3sas_base.h

Re: [PATCH RESEND 06/25] mpt3sas: Define 'hba_mpi_version_belonged' IOC variable

On 11/11/2015 01:00 PM, Sreekanth Reddy wrote: > From: Sreekanth Reddy > > 1. Use 'hba_mpi_version_belonged' IOC varable to uniquely > identify each individual generation driver functionality at > runtime. > > 2. Declared global variable 'driver_name' and used >

Re: [patch] mptfusion: don't allow negative bytes in kbuf_alloc_2_sgl()

> "Dan" == Dan Carpenter writes: Dan> There is a static checker warning here because "bytes" is Dan> controlled by the user and we cap the upper bound with min() but Dan> allow negatives. Negative bytes will result in some nasty warning Dan> messages but are not

Re: [RESEND PATCH] mpt2sas: Remove usage of 'struct timeval'

> "Tina" == Tina Ruchandani writes: Tina, Tina> 'struct timeval' will have its tv_sec value overflow on 32-bit Tina> systems in year 2038 and beyond. This patch replaces the use of Tina> struct timeval for computing mpi_request.TimeStamp, and instead Tina> uses

Re: [PATCH v5 1/2] ibmvscsi: display default value for max_id, max_lun and max_channel.

> "Laurent" == Laurent Vivier writes: Laurent> As devices with values greater than that are silently ignored, Laurent> this gives some hints to the sys admin to know why he doesn't Laurent> see his devices... Applied both patches. -- Martin K. Petersen Oracle

4.4 SCSI queue status

As some of you may have noticed, I have been volunteered to help with the SCSI tree going forward. Much like Christoph did for while. My current tree is here: http://git.kernel.org/cgit/linux/kernel/git/mkp/linux.git/log/?h=4.4/scsi-queue At this point I am done merging SCSI patches for 4.4.

Re: [RESEND PATCH] [SCSI] mvumi: 64bit value for seconds_since1970

> "Tina" == Tina Ruchandani writes: Tina> struct mvumi_hs_page2 stores a "seconds_since1970" field which is Tina> of type u64. It is however, written to, using 'struct timeval' Tina> which has a 32-bit seconds field and whose value will overflow in Tina> year 2038.

Re: [PATCH] sd: Clear PS bit before Mode Select.

> "Gabriel" == Gabriel Krisman Bertazi writes: Gabriel> This patch clears the PS bit in the buffer returned by Mode Gabriel> Select, right before it is used in the Mode Select command. Applied. -- Martin K. Petersen Oracle Linux Engineering -- To

Re: [PATCH v3] scsi: pmcraid: replace struct timeval with ktime_get_real_seconds()

> "Alison" == Alison Schofield writes: Alison> Replace the use of struct timeval and do_gettimeofday() with 64 Alison> bit ktime_get_real_seconds. Prevents 32-bit type overflow in Alison> year 2038 on 32-bit systems. Applied. -- Martin K. Petersen Oracle Linux

[PATCH 1/1] iscsi: fix regression caused by session lock patch

From: Mike Christie This patch fixes this oops report by Guilherme Piccol: list_del corruption. prev->next should be c00f3da2b080, but was c00f3da2c080 [ cut here ] WARNING: at lib/list_debug.c:59 CPU: 48 PID: 12033 Comm: fio-2.2.7 Not

Re: [PATCH 00/25] mpt3sas: Mergering mpt2sas & mpt3sas driver code

> "Sreekanth" == Sreekanth Reddy writes: Sreekanth, Sreekanth> Last time we have posted a set of patches which combine the Sreekanth> mpt2sas and mpt3sas driver code. and we are generating two Sreekanth> driver modules (i.e. two separate .ko's) from this

Re: [PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check

Applied. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html