On Friday 20 November 2015, Finn Thain wrote:
>
> On Thu, 19 Nov 2015, Ondrej Zary wrote:
>
> > On Thursday 19 November 2015 03:24:56 Finn Thain wrote:
> >
> > > On Wed, 18 Nov 2015, Ondrej Zary wrote:
> > >
> > > >
> > > > I have some NCR5380 ISA cards and can test them.
> > >
> > > Thanks Ondre
On Fri, Nov 20, 2015 at 06:21:06PM +1100, Finn Thain wrote:
> > Not sure what module was being probed here. I presume it was g_NCR5380
> > or g_NCR5380_mmio. Neither of these calls 'scsi_scan_host'. I'm not sure
> > what the implications are (?)
>
> Nevermind. The call is in scsi_module.c.
Whic
On Fri, 20 Nov 2015, I wrote:
> On Thu, 19 Nov 2015, Ondrej Zary wrote:
>
> > [ 240.108501] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables
> > this message.
> > [ 240.108597] modprobeD 001a 0 1957 1950 0x
> > [ 240.108790] ce0fad00 0086 53881781 0
Ahoj,
napiste mi na e-mailovou adresu pro podrobnosti o vzájemne spoluprace.
chn.j...@gmail.com
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11/19/2015 12:08 PM, James Bottomley wrote:
> On Thu, 2015-11-19 at 11:54 -0800, Bart Van Assche wrote:
>> On 11/19/2015 11:22 AM, Aaro Koskinen wrote:
>>> I get the below crash when cold booting OCTEON router with USB disk as
>>> rootfs. Bisected to:
>>>
>>> commit bf2cf3baa20b0a6cd2d08707e
On Thu, 19 Nov 2015, Ondrej Zary wrote:
> On Thursday 19 November 2015 03:24:56 Finn Thain wrote:
>
> > On Wed, 18 Nov 2015, Ondrej Zary wrote:
> >
> > >
> > > I have some NCR5380 ISA cards and can test them.
> >
> > Thanks Ondrej. I've no idea which ISA drivers are presently working in
> > main
On Thursday 19 November 2015 03:24:56 Finn Thain wrote:
> On Wed, 18 Nov 2015, Ondrej Zary wrote:
> > On Wednesday 18 November 2015, Finn Thain wrote:
> > > Like my previous work on the NCR5380 drivers, this patch series has
> > > bug fixes, code cleanup and modernization. These drivers suffer fr
The hpsa driver recently started using the sas transport class, but it
does not ensure that the corresponding code is actually built, which
may lead to a link error:
drivers/built-in.o: In function `hpsa_free_sas_phy':
(.text+0x1ce874): undefined reference to `sas_port_delete_phy'
(.text+0x1ce87c)
Hi,
On Thu, Nov 19, 2015 at 01:04:10PM -0800, Bart Van Assche wrote:
> On 11/19/2015 12:30 PM, Aaro Koskinen wrote:
> >FYI, this sequence is 100% reproducible on my setup. The disk is in
> >Macally USB enclosure. On cold-boot it will stay on "Spinning up disk"
> >phase until I manually press the O
This patch copies the badblock management code from md-raid to use it
for tracking bad/'poison' sectors on a per-block device level.
NVDIMM devices, which behave more like DRAM, may develop bad cache
lines, or 'poison'. A block device exposed by the pmem driver can
then consume poison via a read (
On 11/19/2015 12:30 PM, Aaro Koskinen wrote:
FYI, this sequence is 100% reproducible on my setup. The disk is in
Macally USB enclosure. On cold-boot it will stay on "Spinning up disk"
phase until I manually press the ON button. And that's when the disconnect
message appears, don't know why...
H
Hi,
On Thu, Nov 19, 2015 at 12:08:32PM -0800, James Bottomley wrote:
> On Thu, 2015-11-19 at 11:54 -0800, Bart Van Assche wrote:
> > On 11/19/2015 11:22 AM, Aaro Koskinen wrote:
> > > [2.702105] scsi 0:0:0:0: Direct-Access Ext Hard Disk
> > > PQ: 0 ANSI: 5
> > > [2.71
On Thu, 2015-11-19 at 11:54 -0800, Bart Van Assche wrote:
> On 11/19/2015 11:22 AM, Aaro Koskinen wrote:
> > I get the below crash when cold booting OCTEON router with USB disk as
> > rootfs. Bisected to:
> >
> > commit bf2cf3baa20b0a6cd2d08707ef05dc0e992a8aa0
> > Author: Bart Van Assche
>
On 11/19/2015 11:22 AM, Aaro Koskinen wrote:
I get the below crash when cold booting OCTEON router with USB disk as
rootfs. Bisected to:
commit bf2cf3baa20b0a6cd2d08707ef05dc0e992a8aa0
Author: Bart Van Assche
Date: Fri Sep 18 17:23:42 2015 -0700
scsi: Fix
Hi,
I get the below crash when cold booting OCTEON router with USB disk as
rootfs. Bisected to:
commit bf2cf3baa20b0a6cd2d08707ef05dc0e992a8aa0
Author: Bart Van Assche
Date: Fri Sep 18 17:23:42 2015 -0700
scsi: Fix a bdi reregistration race
Reverting the p
On Mon, 2015-11-16 at 09:45 +0100, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Mon, 16 Nov 2015 09:39:12 +0100
>
> The kmem_cache_destroy() function tests whether its argument is NULL
> and then returns immediately. Thus the test around the call is not needed.
>
> This issue was dete
> "Vitaly" == Vitaly Kuznetsov writes:
Vitaly> On some host errors storvsc module tries to remove sdev by
Vitaly> scheduling a job which does the following:
Applied to 4.4.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linu
> "Ondrej" == Ondrej Zary writes:
Ondrej> This patch series removes the first level of crap from atp870u -
Ondrej> the worst (in-tree) SCSI driver [1] and then cleans up the code
Ondrej> a bit.
Ondrej> First the driver is converted to C from something that looks
Ondrej> like a (bad) assemble
On 11/19/2015 09:23 AM, Christoph Hellwig wrote:
> It's pretty much guaranteed a block layer bug, most likely in the
> merge bios to request infrastucture where we don't obey the merging
> limits properly.
>
> Does either of you have a known good and first known bad kernel?
Well, I have been figh
On Wed, 2015-11-18 at 15:32 +0100, Maurizio Lombardi wrote:
> If cdev_add() returns an error, the code calls
> cdev_del() passing the STm->cdevs[rew] pointer as parameter;
> the problem is that the pointer has not been initialized yet.
>
> This patch fixes the problem by moving the STm->cdevs[rew]
On 18.11.2015 15:32, Maurizio Lombardi wrote:
> If cdev_add() returns an error, the code calls
> cdev_del() passing the STm->cdevs[rew] pointer as parameter;
> the problem is that the pointer has not been initialized yet.
>
> This patch fixes the problem by moving the STm->cdevs[rew] pointer
> init
The initio driver has for many years had two copies of the
same module device table. One of them is also used for registering
the other driver, the other one is entirely useless after the
large scale cleanup that Alan Cox did back in 2007.
The compiler warns about this whenever the driver is built
The advansys drvier uses the request_dma function that is used on ISA
machines for the internal DMA controller, which causes build errors
on platforms that have ISA slots but do not provide the ISA DMA API:
drivers/scsi/advansys.c: In function 'advansys_board_found':
drivers/scsi/advansys.c:11300:
On 11/19/2015 02:17 PM, Vitaly Kuznetsov wrote:
> Some host adapters (e.g. Hyper-V storvsc) are known for not respecting the
> SPC-2/3/4 requirement for 'INQUIRY data (see table ...) shall contain at
> least 36 bytes'. As a result we get tons on 'scsi 0:7:1:1: scsi scan:
> INQUIRY result too short
On 11/18/2015 09:35 AM, Finn Thain wrote:
> If a target disappears from the SCSI bus, NCR5380_select() may
> subsequently fail with a time-out. In this situation, scsi_done is
> called and NCR5380_select() returns 0. Both hostdata->connected and
> hostdata->selecting are NULL and the main loop shou
On 11/18/2015 09:35 AM, Finn Thain wrote:
> Remove the restart_select and targets_present variables introduced in
> Linux v1.1.38. The former was used only for a questionable debug printk
> and the latter "so we can call a select failure a retryable condition".
> Well, retrying select failure in ge
On 11/18/2015 09:35 AM, Finn Thain wrote:
> The "failed" label in NCR5380_select() is not helpful. Some failures
> return 0, others -1. Use return instead of goto to improve clarity and
> brevity, like atari_NCR5380.c does. Fix the relevant comments.
>
> Signed-off-by: Finn Thain
>
> ---
> driv
On 11/18/2015 09:35 AM, Finn Thain wrote:
> The aborted flag was introduced in v1.1.38 but never used. Remove it.
>
> Signed-off-by: Finn Thain
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & Storage
h...@suse.de
On 11/18/2015 09:35 AM, Finn Thain wrote:
> Remove the duplicate write to the Select Enable Register that appeared
> in v1.1.38.
>
> Also remove the redundant write to Initiator Command Register prior to
> calling do_abort().
>
> Signed-off-by: Finn Thain
>
> ---
Reviewed-by: Hannes Reinecke
On 11/18/2015 09:35 AM, Finn Thain wrote:
> Make use of do_reset() in the bus reset handler in atari_NCR5380.c. The
> version in NCR5380.c already does so. Keep them in sync.
>
> Signed-off-by: Finn Thain
>
> ---
>
> Bus reset handlers in both core drivers still have serious problems for
> EH p
> "Vitaly" == Vitaly Kuznetsov writes:
Vitaly> Some host adapters (e.g. Hyper-V storvsc) are known for not
Vitaly> respecting the SPC-2/3/4 requirement for 'INQUIRY data (see
Vitaly> table ...) shall contain at least 36 bytes'. As a result we get
Vitaly> tons on 'scsi 0:7:1:1: scsi scan: INQU
On 11/18/2015 09:35 AM, Finn Thain wrote:
> The atari_NCR5380.c core driver now takes care of bus reset upon driver
> initialization if required (same as NCR5380.c). Move the Toshiba CD-ROM
> support into the core driver, enabled with a host flag, so that all
> NCR5380 drivers can make use of it.
>
This looks fine to me. I wonder why we even bother returning
deleted devices for a normal scsi_device_lookup, but let's get
this isolated fix in for now and sort out the big picture later.
Reviewed-by: Christoph Hellwig
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
Hi,
On Tuesday 17 November 2015 01:41 PM, Alim Akhtar wrote:
> Hi
> Thanks again for looking into this.
>
> On 11/17/2015 11:46 AM, Kishon Vijay Abraham I wrote:
>> Hi,
>>
>> On Monday 09 November 2015 10:56 AM, Alim Akhtar wrote:
>>> From: Seungwon Jeon
>>>
>>> This patch introduces Exynos UFS
On 11/18/2015 09:35 AM, Finn Thain wrote:
> Merge the bus reset code from NCR5380.c into atari_NCR5380.c. This allows
> for removal of a lot of duplicated code conditional on the RESET_BOOT
> macro (in the next patch).
>
> The atari_NCR5380.c fork lacks the do_reset() and NCR5380_poll_politely()
>
This looks like a good compromise:
Reviewed-by: Christoph Hellwig
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11/18/2015 09:35 AM, Finn Thain wrote:
> Move board-specific code like this,
> NCR5380_write(C400_CONTROL_STATUS_REG, CSR_BASE);
> from the core driver to the board driver. Eliminate the NCR53C400 macro
> from the core driver. Removal of all macros like this one will be
> necessary in orde
On 11/18/2015 09:35 AM, Finn Thain wrote:
> This patch splits the NCR5380_init() function into two parts, similar
> to the scheme used with atari_NCR5380.c. This avoids two problems.
>
> Firstly, NCR5380_init() may perform a bus reset, which would cause the
> chip to assert IRQ. The chip is unable
Some host adapters (e.g. Hyper-V storvsc) are known for not respecting the
SPC-2/3/4 requirement for 'INQUIRY data (see table ...) shall contain at
least 36 bytes'. As a result we get tons on 'scsi 0:7:1:1: scsi scan:
INQUIRY result too short (5), using 36' messages on console. This can be
problema
On some host errors storvsc module tries to remove sdev by scheduling a job
which does the following:
sdev = scsi_device_lookup(wrk->host, 0, 0, wrk->lun);
if (sdev) {
scsi_remove_device(sdev);
scsi_device_put(sdev);
}
While this code seems correct the following crash is ob
Originally the driver would use of_irq_count to
calculate how much memory is required for storing the
interrupt names, since the number of interrupt sources
for the controller is variable.
Since of_irq_count cannot be used by the driver, use
fixed names.
Signed-off-by: John Garry
Signed-off-by: Z
On 19/11/2015 03:15, Martin K. Petersen wrote:
"John" == John Garry writes:
John> thanks, please note that we still have the dependency on
John> http://www.spinics.net/lists/arm-kernel/msg452833.html
John> Without it the driver can only be built into the kernel, and not
John> as a module.
I
On 11/19/2015 09:35 AM, Christoph Hellwig wrote:
> Can you push out a git branch with this code for easier review as well?
>
Pushed to kernel.org:hare/scsi-devel.git branch alua.v6
Branch is based upon mkp/scsi.git branch 4.5/scsi-queue
Thanks for reviewing.
Cheers,
Hannes
--
Dr. Hannes Reinec
On 19/11/2015 09:20, Or Gerlitz wrote:
On 11/16/2015 6:37 PM, Sagi Grimberg wrote:
+/**
+ * struct iser_hello - iSER Hello header
+ *
+ * @opcode: opcode (must be set to ISER_HELLO)
+ * @max_min_ver: maximum and minimum iser versions
+ * @iser_ird: iSER IRD
+ * @rsvd: reserv
Can you push out a git branch with this code for easier review as well?
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Looks fine,
Reviewed-by: Christoph Hellwig
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
> - blk_limits_max_hw_sectors() is no longer used and can be removed.
Killing that first in a separate patch would have been a tad cleaner.
Otherwise looks fine,
Reviewed-by: Christoph Hellwig
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to
Looks good,
Reviewed-by: Christoph Hellwig
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
It's pretty much guaranteed a block layer bug, most likely in the
merge bios to request infrastucture where we don't obey the merging
limits properly.
Does either of you have a known good and first known bad kernel?
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the bo
49 matches
Mail list logo
