Re: [PATCH-v2 2/2] target/iblock: Use -EAGAIN/-ENOMEM to propigate SAM BUSY/TASK_SET_FULL

2016-03-07 Thread Nicholas A. Bellinger
On Mon, 2016-03-07 at 08:55 +0100, Christoph Hellwig wrote: > On Sun, Mar 06, 2016 at 01:55:15PM -0800, Nicholas A. Bellinger wrote: > > The intended use is for any make_request_fn() based driver that invokes > > bio_endio() completion directly, and sets bi_error != 0 to signal > > non GOOD status

Re: [PATCH v6 16/17] scsi: ufs-qcom: enable/disable the device ref clock

2016-03-07 Thread Gilad Broner
Reviewed-by: Gilad Broner > This change enables the device ref clock before changing to HS mode > and disables it if entered to PWM mode. > > Signed-off-by: Yaniv Gardi > > --- > drivers/scsi/ufs/ufs-qcom.c | 12 > drivers/scsi/ufs/ufshcd.h | 9 + > 2 files changed, 21 i

Re: [PATCH v6 17/17] scsi: ufs-qcom: add printouts of testbus debug registers

2016-03-07 Thread Gilad Broner
Reviewed-by: Gilad Broner > This change adds printouts of testbus and debug registers. > > Signed-off-by: Yaniv Gardi > > --- > drivers/scsi/ufs/ufs-qcom.c | 77 > + > drivers/scsi/ufs/ufs-qcom.h | 9 ++ > 2 files changed, 86 insertions(+) > > di

Re: [PATCH v6 15/17] scsi: ufs-qcom: set PA_Local_TX_LCC_Enable before link startup

2016-03-07 Thread Gilad Broner
Reviewed-by: Gilad Broner > Some UFS devices (and may be host) have issues if LCC is > enabled. So we are setting PA_Local_TX_LCC_Enable to 0 > before link startup which will make sure that both host > and device TX LCC are disabled once link startup is > completed. > > Signed-off-by: Yaniv Gardi

Re: [PATCH v10 5/6] add TC G210 platform driver

2016-03-07 Thread Joao Pinto
Hi, On 3/4/2016 9:12 PM, Arnd Bergmann wrote: > On Friday 04 March 2016 17:22:18 Joao Pinto wrote: >> This patch adds a glue platform driver for the Synopsys G210 Test Chip. >> >> Signed-off-by: Joao Pinto > > Looks basically ok, but I think it can be simplified a little: > >> +/** >> + * struc

[PATCH] scsi: storvsc: fix SRB_STATUS_ABORTED handling

2016-03-07 Thread Vitaly Kuznetsov
Commit 3209f9d780d1 ("scsi: storvsc: Fix a bug in the handling of SRB status flags") filtered SRB_STATUS_AUTOSENSE_VALID out effectively making the (SRB_STATUS_ABORTED | SRB_STATUS_AUTOSENSE_VALID) case a dead code. The logic from this branch (e.g. storvsc_device_scan() call) is still required, fix

Re: [PATCH v10 6/6] add TC G210 pci driver

2016-03-07 Thread Joao Pinto
Hi, On 3/4/2016 9:17 PM, Arnd Bergmann wrote: > On Friday 04 March 2016 17:22:19 Joao Pinto wrote: >> This patch adds a glue pci driver for the Synopsys G210 Test Chip. >> >> Signed-off-by: Joao Pinto > > Mostly ok, just a few suggestions: > >> + >> +/* Test Chip type expected values */ >> +#de

[PATCH v11 5/6] add TC G210 platform driver

2016-03-07 Thread Joao Pinto
This patch adds a glue platform driver for the Synopsys G210 Test Chip. Signed-off-by: Joao Pinto --- Changes v10->v11 (Arnd Bergmann): - vops structs are now passed in .data Changes v0->v10: - This patch only appeared in v10 .../devicetree/bindings/ufs/tc-dwc-g210-pltfrm.txt | 26 + drive

[PATCH v11 6/6] add-TC-G210-pci-driver

2016-03-07 Thread Joao Pinto
This patch adds a glue pci driver for the Synopsys G210 Test Chip. Signed-off-by: Joao Pinto --- Changes v10->v11 (Arnd Bergmann): - tc_type is now initialized to TC_G210_INV - probe function checks if the test chip version is specified Changes v0->v10: - This patch only appeared in v10 drivers

Re: [PATCH] cxgbit: fix dma_addr_t printk format

2016-03-07 Thread Varun Prakash
On Sat, Mar 05, 2016 at 01:04:41AM +0100, Arnd Bergmann wrote: > The newly added driver prints a dma_addr_t using the %llx format string, > but that is wrong on most 32-bit architectures: > > drivers/target/iscsi/cxgbit/cxgbit_ddp.c: In function 'cxgbit_dump_sgl': > drivers/target/iscsi/cxgbit/cxg

Re: [RFC 13/34] iscsi-target: add new transport type

2016-03-07 Thread Varun Prakash
On Sat, Mar 05, 2016 at 01:28:58PM -0800, Nicholas A. Bellinger wrote: > On Tue, 2016-03-01 at 06:48 -0800, Christoph Hellwig wrote: > > This really looks like an odd interface. I think everyone will > > be much happpier in the long run if you do a generic offload interface > > instead of special

Re: [PATCH] sd: Fix discard granularity when LBPRZ=1

2016-03-07 Thread Ewan Milne
On Sat, 2016-03-05 at 18:10 -0500, Martin K. Petersen wrote: > Commit 397737223c59 ("sd: Make discard granularity match logical block > size when LBPRZ=1") accidentally set the granularity to one byte instead > of one logical block on devices that provide determistic zeroes after > UNMAP. > > Sign

-EAGAIN and -ENOMEM from ->bi_end_io, was Re: [PATCH-v2 2/2] target/iblock: Use -EAGAIN/-ENOMEM to propigate SAM BUSY/TASK_SET_FULL

2016-03-07 Thread Christoph Hellwig
On Mon, Mar 07, 2016 at 12:03:56AM -0800, Nicholas A. Bellinger wrote: > > On Sun, Mar 06, 2016 at 01:55:15PM -0800, Nicholas A. Bellinger wrote: > > > The intended use is for any make_request_fn() based driver that invokes > > > bio_endio() completion directly, and sets bi_error != 0 to signal > >

Re: [PATCH-v2 2/2] target/iblock: Use -EAGAIN/-ENOMEM to propigate SAM BUSY/TASK_SET_FULL

2016-03-07 Thread James Bottomley
On Mon, 2016-03-07 at 00:03 -0800, Nicholas A. Bellinger wrote: > On Mon, 2016-03-07 at 08:55 +0100, Christoph Hellwig wrote: > > On Sun, Mar 06, 2016 at 01:55:15PM -0800, Nicholas A. Bellinger > > So as-is this might be well intended but either useless or broken. > > -- > > No, it useful for ho

Re: [PATCH 1/7] cxlflash: Simplify PCI registration

2016-03-07 Thread Matthew R. Ochs
> On Mar 4, 2016, at 3:55 PM, Uma Krishnan wrote: > > From: "Manoj N. Kumar" > > The calls to pci_request_regions(), pci_resource_start(), > pci_set_dma_mask(), pci_set_master() and pci_save_state() are all > unnecessary for the IBM CXL flash adapter since data buffers > are not required to be

Re: [PATCH 2/7] cxlflash: Unmap problem state area before detaching master context

2016-03-07 Thread Matthew R. Ochs
> On Mar 4, 2016, at 3:55 PM, Uma Krishnan wrote: > > When operating in the PowerVM environment, the cxlflash module can > receive an error from the hypervisor indicating that there are > existing mappings in the page table for the process MMIO space. > > This issue exists because term_afu() cur

Re: [PATCH 5/7] cxlflash: Reorder user context initialization

2016-03-07 Thread Matthew R. Ochs
> On Mar 4, 2016, at 3:55 PM, Uma Krishnan wrote: > > In order to support cxlflash in the PowerVM environment, underlying > hypervisor APIs have imposed a kernel API ordering change. > > For the superpipe access to LUN, user applications need a context. > The cxlflash module creates this context

Re: [PATCH 6/7] cxlflash: Fix to avoid unnecessary scan with internal LUNs

2016-03-07 Thread Matthew R. Ochs
> On Mar 4, 2016, at 3:55 PM, Uma Krishnan wrote: > > From: "Manoj N. Kumar" > > When switching to the internal LUN defined on the > IBM CXL flash adapter, there is an unnecessary > scan occurring on the second port. This scan leads > to the following extra lines in the log: > > Dec 17 10:09:0

Re: [PATCH 7/7] cxlflash: Increase cmd_per_lun for better throughput

2016-03-07 Thread Matthew R. Ochs
> On Mar 4, 2016, at 3:55 PM, Uma Krishnan wrote: > > From: "Manoj N. Kumar" > > With the current value of cmd_per_lun at 16, the throughput > over a single adapter is limited to around 150kIOPS. > > Increase the value of cmd_per_lun to 256 to improve > throughput. With this change a single ad

[PATCH] uas: Reduce can_queue to MAX_CMNDS

2016-03-07 Thread Hans de Goede
The uas driver can never queue more then MAX_CMNDS (- 1) tags and tags are shared between luns, so there is no need to claim that we can_queue some random large number. Not claiming that we can_queue 65536 commands, fixes the uas driver failing to initialize while allocating the tag map with a "Pa

Re: [RFC 13/34] iscsi-target: add new transport type

2016-03-07 Thread Nicholas A. Bellinger
On Mon, 2016-03-07 at 20:25 +0530, Varun Prakash wrote: > On Sat, Mar 05, 2016 at 01:28:58PM -0800, Nicholas A. Bellinger wrote: > > On Tue, 2016-03-01 at 06:48 -0800, Christoph Hellwig wrote: > > > This really looks like an odd interface. I think everyone will > > > be much happpier in the long r

Re: -EAGAIN and -ENOMEM from ->bi_end_io, was Re: [PATCH-v2 2/2] target/iblock: Use -EAGAIN/-ENOMEM to propigate SAM BUSY/TASK_SET_FULL

2016-03-07 Thread Nicholas A. Bellinger
On Mon, 2016-03-07 at 17:18 +0100, Christoph Hellwig wrote: > On Mon, Mar 07, 2016 at 12:03:56AM -0800, Nicholas A. Bellinger wrote: > > > On Sun, Mar 06, 2016 at 01:55:15PM -0800, Nicholas A. Bellinger wrote: > > > > The intended use is for any make_request_fn() based driver that invokes > > > > b

Re: [PATCH-v2 2/2] target/iblock: Use -EAGAIN/-ENOMEM to propigate SAM BUSY/TASK_SET_FULL

2016-03-07 Thread Nicholas A. Bellinger
On Mon, 2016-03-07 at 11:40 -0500, James Bottomley wrote: > On Mon, 2016-03-07 at 00:03 -0800, Nicholas A. Bellinger wrote: > > On Mon, 2016-03-07 at 08:55 +0100, Christoph Hellwig wrote: > > > On Sun, Mar 06, 2016 at 01:55:15PM -0800, Nicholas A. Bellinger > > > > So as-is this might be well int

Re: [RFC 14/34] iscsi-target: export symbols

2016-03-07 Thread Nicholas A. Bellinger
On Sat, 2016-03-05 at 13:54 -0800, Nicholas A. Bellinger wrote: > Hi Varun & Co, > > On Wed, 2016-03-02 at 17:30 +0530, Varun Prakash wrote: > > On Tue, Mar 01, 2016 at 08:19:21PM +0530, Christoph Hellwig wrote: > > > This looks like pretty random exports and not something like a well > > > define

Re: [PATCH] Use ida_simple for SCSI iSCSI transport session id

2016-03-07 Thread Lee Duncan
On 02/12/2016 09:54 AM, James Bottomley wrote: > On Fri, 2016-02-12 at 09:38 -0800, Lee Duncan wrote: >> The scsi_transport_iscsi module already uses the ida_simple >> routines for managing the target ID, if requested to do >> so. This change replaces an ever-increasing atomic integer >> that track

RE: [PATCH] scsi: storvsc: fix SRB_STATUS_ABORTED handling

2016-03-07 Thread KY Srinivasan
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Monday, March 7, 2016 3:00 AM > To: linux-scsi@vger.kernel.org > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; KY > Srinivasan ; Haiyang Zhang > ; Cathy Avery ; James E.J. > Bottomley ; Ma

Re: [PATCH] be2iscsi: set the boot_kset pointer to NULL in case of failure

2016-03-07 Thread Martin K. Petersen
> "Maurizio" == Maurizio Lombardi writes: Maurizio, Maurizio> In beiscsi_setup_boot_info(), the boot_kset pointer should be Maurizio> set to NULL in case of failure otherwise an invalid pointer Maurizio> dereference may occur later. iscsi_boot_destroy_kset() checks before deref and the othe

Re: [PATCH resend 2/2] mpt3sas: Remove unnecessary synchronize_irq() before free_irq()

2016-03-07 Thread Martin K. Petersen
> "Lars-Peter" == Lars-Peter Clausen writes: Lars-Peter> Calling synchronize_irq() right before free_irq() is quite Lars-Peter> useless. On one hand the IRQ can easily fire again before Lars-Peter> free_irq() is entered, on the other hand free_irq() itself Lars-Peter> calls synchronize_irq()

Re: [PATCH resend 1/2] be2iscsi: Remove unnecessary synchronize_irq() before free_irq()

2016-03-07 Thread Martin K. Petersen
> "Lars-Peter" == Lars-Peter Clausen writes: Lars-Peter> Calling synchronize_irq() right before free_irq() is quite Lars-Peter> useless. On one hand the IRQ can easily fire again before Lars-Peter> free_irq() is entered, on the other hand free_irq() itself Lars-Peter> calls synchronize_irq()

Re: [PATCH] Use ida_simple for SCSI iSCSI transport session id

2016-03-07 Thread Martin K. Petersen
> "Lee" == Lee Duncan writes: Lee> It looks like Mike and Chris are good with it. However, it received no formal reviews or acked-bys... -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to

Re: [PATCH] sg: fix dxferp in from_to case

2016-03-07 Thread Martin K. Petersen
> "Doug" == Douglas Gilbert writes: Doug> This patch is in response to this report: Doug> http://www.spinics.net/lists/linux-scsi/msg93456.html Doug> One of the strange things that the original sg driver did was let Doug> the user provide both a data-out buffer (it followed the Doug> sg_head

Re: [PATCH] sd: Fix discard granularity when LBPRZ=1

2016-03-07 Thread Martin K. Petersen
> "Ewan" == Ewan Milne writes: >> Commit 397737223c59 ("sd: Make discard granularity match logical >> block size when LBPRZ=1") accidentally set the granularity to one >> byte instead of one logical block on devices that provide determistic >> zeroes after UNMAP. Ewan> Reviewed-by: Ewan D. Mi

Re: -EAGAIN and -ENOMEM from ->bi_end_io, was Re: [PATCH-v2 2/2] target/iblock: Use -EAGAIN/-ENOMEM to propigate SAM BUSY/TASK_SET_FULL

2016-03-07 Thread Christoph Hellwig
On Mon, Mar 07, 2016 at 02:39:29PM -0800, Nicholas A. Bellinger wrote: > > I explicitly wrote "as-is". We need a way to opt into this behavior, > > and we also somehow need to communicate the timeout. > > What did you have in mind..? You need an interface to tell the driver that it can return a