On Mon, 14 Mar 2016, Hannes Reinecke wrote:
> On 03/14/2016 05:27 AM, Finn Thain wrote:
> > This setting does not need to be conditional on Atari ST or TT.
> >
> > Without TCQ support, cmd_per_lun == 2 is probably reasonable...
> >
> > Signed-off-by: Finn Thain
> >
On Mon, 14 Mar 2016, Hannes Reinecke wrote:
> Well ... using individual printk() like here might end up in each
> call to be broken up into individual lines.
> You might want to consider using a line buffer here or, better
> still, move to seq_file or debugfs output.
This routine is meant to be
On Mon, 14 Mar 2016, Christoph Hellwig wrote:
> On Mon, Mar 14, 2016 at 03:27:14PM +1100, Finn Thain wrote:
> > The driver has a limit of eight LUs because of the byte-sized bitfield
> > that is used for busy flags. Reject commands with LUN > 7.
>
> Please just set the max_lun parameter in the
On Mon, 14 Mar 2016, Hannes Reinecke wrote:
> > @@ -1555,8 +1555,7 @@ static int NCR5380_transfer_dma(struct S
> > NCR5380_read(RESET_PARITY_INTERRUPT_REG);
> > *data = d + c;
> > *count = 0;
> > - *phase = NCR5380_read(STATUS_REG) & PHASE_MASK;
> > - return foo;
> > + return
On Mon, 14 Mar 2016, Hannes Reinecke wrote:
> I still would keep the 'DMA_MIN_LEN' definition around for sun3_scsi.c;
> makes it a bit more obvious what the magic number '129' is supposed to
> mean.
OK.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body
I see the following error when booting a 4.4.1 kernel from the
bnx2x/bnx2fc drivers:
bnx2x: [bnx2x_get_fc_npiv:14843(eth2)]FC-NPIV table with bad length 0x0840
This is using a QLogic/Broadcom CNA card in FCoE mode. The relavent code
in drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c has:
> "Hannes" == Hannes Reinecke writes:
> diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
> index 97074c9..929204b 100644
> --- a/drivers/scsi/scsi_scan.c
> +++ b/drivers/scsi/scsi_scan.c
> @@ -96,10 +96,11 @@ MODULE_PARM_DESC(max_luns,
> #define
> "Hannes" == Hannes Reinecke writes:
Hannes,
Hannes> VPD pages 0x0 and 0x83 are mandatory even for SPC-2, so we
Hannes> should be lowering the restriction to avoid having to whitelist
Hannes> every SPC-2 compliant device.
I wonder how many non-compliant devices we would have
Arnd Bergmann wrote:
> gcc-6 complains about the indentation of the lpfc_destroy_vport_work_array()
> call in lpfc_online(), which clearly doesn't look right:
>
> drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_online':
> drivers/scsi/lpfc/lpfc_init.c:2880:3: warning: statement is indented as if
Reviewed-by: Manoj Kumar
---
Manoj Kumar
On 3/14/2016 2:42 PM, James Bottomley wrote:
The @odin.com one has been bouncing for a while now, so replace with
new Employer email.
Signed-off-by: James Bottomley
---
diff --git a/MAINTAINERS
On Mon, 2016-03-14 at 11:14 -0700, Satish Kharat wrote:
> The the scsi_cmnd error code is expected to be in the left 16 bits
> of the result field. Change is to correct this.
>
> Signed-off-by: Satish Kharat
> ---
> drivers/scsi/fnic/fnic.h | 2 +-
>
On Mon, 2016-03-14 at 11:14 -0700, Satish Kharat wrote:
> Fnic does not support mutiqueue. Setting the scsi_host_template in
> fnic_host_template to indicate that.
>
> Changing fnic_version from 1.6.0.21 to 1.6.0.22
>
> Signed-off-by: Satish Kharat
> ---
>
> "Hannes" == Hannes Reinecke writes:
Hannes> There is no way to detect the scsi_target_id for any given SAS
Hannes> remote port, so add a new sysfs attribute 'scsi_target_id'.
Applied to 4.6/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe
On Mon, 2016-03-14 at 11:14 -0700, Satish Kharat wrote:
> In case of LUN reset, the device reset command is issued with one of
> the I/Os that has timed out on that LUN. The change is to also return
> this I/O with error status set to DID_RESET.
> Fnic driver version changed from 1.6.0.19 to
> "Tom" == Tom Yan writes:
Tom,
Tom> But yeah if it has unmap granularity reported to be, for example,
Tom> 16, then it will not be correctly set with min_not_zero().
Tom> Wait, shouldn't it be:
Tom> max(sdkp->logical_block_size, sdkp->unmap_granularity *
> "Dan" == Dan Carpenter writes:
Dan> The pg_updated variable is support to be set to false at the start
Dan> but it is uninitialized.
Applied to 4.6/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line
> "Yaniv" == Yaniv Gardi writes:
Yaniv> V8: fixed cyclic dependency by removing ufs_quirk.c that was
Yaniv> previously added in V7 06/17, and moving its code into ufshcd.c
Applied to 4.6/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
--
To
On Mon, 2016-03-14 at 11:14 -0700, Satish Kharat wrote:
> If an I/O times out and an abort issued by host, if the abort is
> successful we need to set scsi status as DID_ABORT. Or else the
> mid-layer error handler which looks for this error code, will
> offline the device. Also if the original
The @odin.com one has been bouncing for a while now, so replace with
new Employer email.
Signed-off-by: James Bottomley
---
diff --git a/MAINTAINERS b/MAINTAINERS
index a7c4466..59f12c8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9644,7 +9644,7 @@ F:
Fnic does not support mutiqueue. Setting the scsi_host_template in
fnic_host_template to indicate that.
Changing fnic_version from 1.6.0.21 to 1.6.0.22
Signed-off-by: Satish Kharat
---
drivers/scsi/fnic/fnic.h | 2 +-
drivers/scsi/fnic/fnic_main.c | 1 +
2 files
The the scsi_cmnd error code is expected to be in the left 16 bits
of the result field. Change is to correct this.
Signed-off-by: Satish Kharat
---
drivers/scsi/fnic/fnic.h | 2 +-
drivers/scsi/fnic/fnic_scsi.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
In case of LUN reset, the device reset command is issued with one of
the I/Os that has timed out on that LUN. The change is to also return
this I/O with error status set to DID_RESET.
Fnic driver version changed from 1.6.0.19 to 1.6.0.20
Signed-off-by: Satish Kharat
---
When issuing I/O we check if rport is online through libfc
rport_lookup() function which needs to be protected by mutex lock
that cannot acquired in I/O context. The change is to use midlayer
remote port’s dd_data which is preserved until its devloss timeout
and no protection is required.
Fnic
On Mon, 2016-03-14 at 16:26 +0100, Hannes Reinecke wrote:
> On 03/14/2016 04:25 PM, Arnd Bergmann wrote:
> > On Monday 14 March 2016 16:19:58 Hannes Reinecke wrote:
> >>> vports = lpfc_create_vport_work_array(phba);
> >>> - if (vports != NULL)
> >>> + if (vports != NULL) {
> >>>
On 03/14/2016 04:25 PM, Arnd Bergmann wrote:
> On Monday 14 March 2016 16:19:58 Hannes Reinecke wrote:
>>> vports = lpfc_create_vport_work_array(phba);
>>> - if (vports != NULL)
>>> + if (vports != NULL) {
>>> for (i = 0; i <= phba->max_vports && vports[i] != NULL; i++)
On Monday 14 March 2016 16:19:58 Hannes Reinecke wrote:
> > vports = lpfc_create_vport_work_array(phba);
> > - if (vports != NULL)
> > + if (vports != NULL) {
> > for (i = 0; i <= phba->max_vports && vports[i] != NULL; i++) {
> > struct Scsi_Host
On 03/14/2016 03:29 PM, Arnd Bergmann wrote:
> gcc-6 found a dubious indentation in the megasas_mgmt_fw_ioctl
> function:
>
> drivers/scsi/megaraid/megaraid_sas_base.c: In function
> 'megasas_mgmt_fw_ioctl':
> drivers/scsi/megaraid/megaraid_sas_base.c:6658:4: warning: statement is
> indented as
On 03/14/2016 03:29 PM, Arnd Bergmann wrote:
> gcc-6 complains about the indentation of the lpfc_destroy_vport_work_array()
> call in lpfc_online(), which clearly doesn't look right:
>
> drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_online':
> drivers/scsi/lpfc/lpfc_init.c:2880:3: warning:
On 03/14/2016 03:38 PM, Ewan Milne wrote:
> On Mon, 2016-03-14 at 07:19 -0700, Bart Van Assche wrote:
>> While testing the latest version of the SRP initiator and target
>> drivers I encountered the following message in the kernel log:
>>
>> sd 16:0:0:0: Warning! Received an indication that the
On Mon, 2016-03-14 at 07:19 -0700, Bart Van Assche wrote:
> While testing the latest version of the SRP initiator and target
> drivers I encountered the following message in the kernel log:
>
> sd 16:0:0:0: Warning! Received an indication that the LUN assignments on this
> target have changed.
On 03/14/2016 03:19 PM, Bart Van Assche wrote:
> While testing the latest version of the SRP initiator and target
> drivers I encountered the following message in the kernel log:
>
> sd 16:0:0:0: Warning! Received an indication that the LUN assignments on this
> target have changed. The Linux
On Mon, Mar 14, 2016 at 07:19:55AM -0700, Bart Van Assche wrote:
> While testing the latest version of the SRP initiator and target
> drivers I encountered the following message in the kernel log:
>
> sd 16:0:0:0: Warning! Received an indication that the LUN assignments on this
> target have
gcc-6 warns about obviously wrong indentation for newly added
code in aac_slave_configure():
drivers/scsi/aacraid/linit.c: In function 'aac_slave_configure':
drivers/scsi/aacraid/linit.c:458:3: warning: statement is indented as if it
were guarded by... [-Wmisleading-indentation]
gcc-6 found a dubious indentation in the megasas_mgmt_fw_ioctl
function:
drivers/scsi/megaraid/megaraid_sas_base.c: In function 'megasas_mgmt_fw_ioctl':
drivers/scsi/megaraid/megaraid_sas_base.c:6658:4: warning: statement is
indented as if it were guarded by... [-Wmisleading-indentation]
gcc-6 complains about the indentation of the lpfc_destroy_vport_work_array()
call in lpfc_online(), which clearly doesn't look right:
drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_online':
drivers/scsi/lpfc/lpfc_init.c:2880:3: warning: statement is indented as if it
were guarded by...
gcc-6 found a couple of bugs in scsi drivers that are not
yet fixed in linux-next.
In all three cases, the code is indented in a rather misleading
way, but actually correct. I think it would be good to have
this fixed in 4.6, but no backports are needed even though
the problems have all been
While testing the latest version of the SRP initiator and target
drivers I encountered the following message in the kernel log:
sd 16:0:0:0: Warning! Received an indication that the LUN assignments on this
target have changed. The Linux SCSI layer does not automatical
This is a truncated
Hannes:
Thanks for correcting the last argument.
Reviewed-by: Manoj Kumar
---
Manoj Kumar
On 3/14/2016 4:43 AM, Hannes Reinecke wrote:
There is no way to detect the scsi_target_id for any given SAS
remote port, so add a new sysfs attribute 'scsi_target_id'.
On Mon, Mar 14, 2016 at 10:43:08AM +0100, Hannes Reinecke wrote:
> There is no way to detect the scsi_target_id for any given SAS
> remote port, so add a new sysfs attribute 'scsi_target_id'.
>
> Signed-off-by: Hannes Reinecke
Reviewed-by: Johannes Thumshirn
There is no way to detect the scsi_target_id for any given SAS
remote port, so add a new sysfs attribute 'scsi_target_id'.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/scsi_sas_internal.h | 2 +-
drivers/scsi/scsi_transport_sas.c | 2 ++
2 files changed, 3 insertions(+), 1
On Fri, Mar 11, 2016 at 04:33:40PM +0100, Hannes Reinecke wrote:
> On larger installations it is useful to disable automatic LUN
> scanning, and only add the required LUNs via udev rules.
> This can speed up bootup dramatically.
>
> This patch introduces a scan_type 'disabled', which work like
>
On Fri, Mar 11, 2016 at 07:22:19PM +0100, Sebastian Andrzej Siewior wrote:
> after sending a few patches to the odin.com email address I noticed that
> it is no longer valid.
>
> Signed-off-by: Sebastian Andrzej Siewior
Reviewed-by: Johannes Thumshirn
On 03/14/2016 05:27 AM, Finn Thain wrote:
> Fix various issues: Comments about bus errors are incorrect. The
> PDMA asm must return the size of the memory access that faulted so the
> transfer count can be adjusted accordingly. A phase change may cause a
> bus error but should not be treated as
On 03/14/2016 05:27 AM, Finn Thain wrote:
> The benefit of limiting can_queue to 1 is that atari_scsi shares the
> ST DMA chip more fairly with other drivers (e.g. falcon-ide).
>
> Unfortunately, this can limit SCSI bus utilization. On systems without
> IDE, atari_scsi should issue SCSI commands
On Mon, Mar 14, 2016 at 03:27:14PM +1100, Finn Thain wrote:
> The driver has a limit of eight LUs because of the byte-sized bitfield
> that is used for busy flags. Reject commands with LUN > 7.
Please just set the max_lun parameter in the host template, which will
take care of this.
--
To
On 03/14/2016 05:27 AM, Finn Thain wrote:
> This setting does not need to be conditional on Atari ST or TT.
>
> Without TCQ support, cmd_per_lun == 2 is probably reasonable...
>
> Signed-off-by: Finn Thain
>
> ---
> drivers/scsi/atari_scsi.c |3 +--
> 1 file
On 03/14/2016 05:27 AM, Finn Thain wrote:
> Update kernel parameter documentation for atari_scsi, mac_scsi and
> g_NCR5380 drivers. Remove duplication.
>
> Signed-off-by: Finn Thain
>
> ---
> Documentation/scsi/g_NCR5380.txt | 17 ++-
>
On 03/14/2016 05:27 AM, Finn Thain wrote:
> Signed-off-by: Finn Thain
>
> ---
> drivers/scsi/NCR5380.c | 12 +---
> drivers/scsi/NCR5380.h |4
> drivers/scsi/arm/oak.c |2 --
> drivers/scsi/dmx3191d.c |2 --
> drivers/scsi/dtc.c
On 03/14/2016 05:27 AM, Finn Thain wrote:
> Signed-off-by: Finn Thain
>
> ---
> drivers/scsi/NCR5380.c |6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> Index: linux/drivers/scsi/NCR5380.c
>
On 03/14/2016 05:27 AM, Finn Thain wrote:
> Decode all bits in the chip registers. They are all useful at times.
> Fix printk severity so that this output can be suppressed along with
> the other debugging output.
>
> Signed-off-by: Finn Thain
>
> ---
>
On 03/14/2016 05:27 AM, Finn Thain wrote:
> The dmx3191d driver is not capable of DMA or PDMA so all transfers
> use PIO. Now that large slow PIO transfers periodically stop and call
> cond_resched(), the max_sectors limit can go away.
>
> Signed-off-by: Finn Thain
>
On 03/14/2016 05:27 AM, Finn Thain wrote:
> The driver has a limit of eight LUs because of the byte-sized bitfield
> that is used for busy flags. Reject commands with LUN > 7.
>
> Signed-off-by: Finn Thain
>
> ---
> drivers/scsi/NCR5380.c |6 ++
>
On 03/14/2016 05:27 AM, Finn Thain wrote:
> Now that atari_scsi and sun3_scsi have been converted to use the NCR5380.c
> core driver, remove atari_NCR5380.c. Also remove the last vestiges of its
> Tagged Command Queueing implementation from the wrapper drivers.
>
> The TCQ support in
On 03/14/2016 05:27 AM, Finn Thain wrote:
> Add support for the custom Sun 3 DMA logic to the NCR5380.c core driver.
> This code is copied from atari_NCR5380.c.
>
> Signed-off-by: Finn Thain
>
> ---
>
> The Sun 3 DMA code is still configured by macros. I have
On 03/14/2016 05:27 AM, Finn Thain wrote:
> Add support for the Atari ST DMA chip to the NCR5380.c core driver.
> This code is copied from atari_NCR5380.c.
>
> Signed-off-by: Finn Thain
>
> ---
> drivers/scsi/NCR5380.c| 32
>
On 03/14/2016 05:27 AM, Finn Thain wrote:
> Adopt the DMA implementation from atari_NCR5380.c. This means that
> atari_scsi and sun3_scsi can make use of the NCR5380.c core driver
> and the atari_NCR5380.c driver fork can be made redundant.
>
> Signed-off-by: Finn Thain
On 03/14/2016 05:27 AM, Finn Thain wrote:
> Standardize the DMA setup hooks so that the DMA implementation in
> atari_NCR5380.c can be reconciled with pseudo DMA implementation in
> NCR5380.c.
>
> Calls to NCR5380_dma_recv_setup() and NCR5380_dma_send_setup() return
> a negative value on failure,
On 03/14/2016 05:27 AM, Finn Thain wrote:
> Those wrapper drivers which use DMA define the REAL_DMA macro and
> those which use pseudo DMA define PSEUDO_DMA. These macros need to be
> removed for a number of reasons, not least of which is to have drivers
> share more code.
>
> Redefine the PDMA
On 03/14/2016 05:27 AM, Finn Thain wrote:
> The io_recovery_delay macro is intended to insert a microsecond delay
> between the chip register accesses that begin a DMA operation. This
> is reportedly needed for some ISA boards.
>
> Reverse the sense of the macro test so that in the common case,
>
On 03/14/2016 05:27 AM, Finn Thain wrote:
> For those wrapper drivers which only implement Programmed IO, have
> NCR5380_dma_xfer_len() evaluate to zero. That allows PDMA to be easily
> disabled at run-time and so the PSEUDO_DMA macro is no longer needed.
>
> Also remove the spin counters used
On 03/14/2016 05:27 AM, Finn Thain wrote:
> The only chip that needs the workarounds enabled is an early NMOS
> device. That means that the common case is to disable them.
>
> Unfortunately the sense of the flag is such that it has to be set
> for the common case.
>
> Rename the flag so that
On 03/14/2016 05:27 AM, Finn Thain wrote:
> Only the atari_scsi and sun3_scsi drivers define DMA_MIN_SIZE.
> Both drivers also define NCR5380_dma_xfer_len, which means
> DMA_MIN_SIZE is redundant.
>
> This removes another discrepancy between the two core drivers.
>
> Signed-off-by: Finn Thain
On 03/14/2016 05:27 AM, Finn Thain wrote:
> For the NCR5380.c core driver, these macros are never used.
> If REAL_DMA were to be defined, compilation would fail.
>
> For the atari_NCR5380.c core driver, REAL_DMA is always defined.
>
> Hence these macros are pointless.
>
> Signed-off-by: Finn
On 03/14/2016 05:27 AM, Finn Thain wrote:
> Drivers that define PSEUDO_DMA also define NCR5380_dma_xfer_len.
> The core driver must call NCR5380_dma_xfer_len which means
> FLAG_NO_PSEUDO_DMA can be eradicated from the core driver.
>
> dmx3191d doesn't define PSEUDO_DMA and has no use for
On 03/14/2016 05:27 AM, Finn Thain wrote:
> This change brings a number of improvements: fewer macros, better test
> coverage, simpler code and sane Kconfig options. The downside is a small
> chance of incompatibility (which seems unavoidable).
>
> CONFIG_SCSI_GENERIC_NCR53C400 exists to enable
On 03/11/2016 07:53 PM, Manoj Kumar wrote:
> On 3/11/2016 9:33 AM, Hannes Reinecke wrote:
>> There is no way to detect the scsi_target_id for any given SAS
>> remote port, so add a new sysfs attribute 'scsi_target_id'.
>>
>> Signed-off-by: Hannes Reinecke
>> ---
>>
66 matches
Mail list logo