Re: [PATCH] bnx2fc: Fix locking requirements in bnx2fc_init_tgt

2016-04-05 Thread James Bottomley
On Tue, 2016-04-05 at 13:50 -0400, Bastien Bastien Philbert wrote: > On Tue, Apr 5, 2016 at 1:43 PM, Chad Dupuis > wrote: > > > > > > On Tue, 5 Apr 2016, Bastien Philbert wrote: > > > > > This fixes the locking around the call to bnx2fc_alloc_id to > > > comply > > >

[PATCH] mpt3sas:Make sure mpt3sas adapter has been reset in scsih_resume

2016-04-05 Thread Bastien Philbert
This fixes the issue in the function scih_resume that we assume that the mpt3sas adapter has been reset properly with a call to mpt3sas_base_hard_reset_handler by checking if this function call returns a error code and exit adpater resume prematurely Signed-off-by: Bastien Philbert

[PATCH] csiostor: Fix backwards locking in the function __csio_unreg_rnode

2016-04-05 Thread Bastien Philbert
This fixes backwards locking in the function __csio_unreg_rnode to properly lock before the call to the function csio_unreg_rnode and not unlock with spin_unlock_irq as this would not allow the proper protection for concurrent access on the shared csio_hw structure pointer hw. In addition switch

[PATCH v2 1/3] Add ZBC <-> ZAC xlat support for report, open, close, reset, finish

2016-04-05 Thread Shaun Tancheff
Add SCSI <-> ATA translation layer for ZBC commands: - Open, Close, and Finish zones Signed-off-by: Shaun Tancheff --- drivers/ata/libata-scsi.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/ata/libata-scsi.c

[PATCH v2 2/3] Add bio/request flags for using ZBC/ZAC commands

2016-04-05 Thread Shaun Tancheff
T10 ZBC and T13 ZAC specify operations for Zoned devices. To be able to access the zone information and open and close zones adding flags for the report zones command (REQ_REPORT_ZONES) and for Open and Close zone (REQ_OPEN_ZONE and REQ_CLOSE_ZONE) can be added for use by struct bio's bi_rw and

[PATCH v2 3/3] Add ioctl to issue ZBC/ZAC commands via block layer

2016-04-05 Thread Shaun Tancheff
Add New ioctl types BLKREPORT- Issue Report Zones to device. BLKOPENZONE - Issue an Zone Action: Open Zone command. BLKCLOSEZONE - Issue an Zone Action: Close Zone command. BLKRESETZONE - Issue an Zone Action: Reset Zone command. Signed-off-by: Shaun Tancheff

Re: [PATCH] bnx2fc: Fix locking requirements in bnx2fc_init_tgt

2016-04-05 Thread Bastien Bastien Philbert
On Tue, Apr 5, 2016 at 1:43 PM, Chad Dupuis wrote: > > > On Tue, 5 Apr 2016, Bastien Philbert wrote: > >> This fixes the locking around the call to bnx2fc_alloc_id to comply >> with the comments about this particular function's definition about >> requiring the need to

Re: [PATCH] bnx2fc: Fix locking requirements in bnx2fc_init_tgt

2016-04-05 Thread Chad Dupuis
On Tue, 5 Apr 2016, Bastien Philbert wrote: This fixes the locking around the call to bnx2fc_alloc_id to comply with the comments about this particular function's definition about requiring the need to hold the hba mutex before and after calling it. Signed-off-by: Bastien Philbert

Re: [PATCH v3 4/5] scsi: rename SCSI_MAX_{SG, SG_CHAIN}_SEGMENTS

2016-04-05 Thread Tejun Heo
On Mon, Apr 04, 2016 at 02:48:10PM -0700, Ming Lin wrote: > From: Ming Lin > > Rename SCSI_MAX_SG_SEGMENTS to SG_CHUNK_SIZE, which means the amount > we fit into a single scatterlist chunk. > > Rename SCSI_MAX_SG_CHAIN_SEGMENTS to SG_MAX_SEGMENTS. > > Will move these 2

[PATCH] bnx2fc: Fix locking requirements in bnx2fc_init_tgt

2016-04-05 Thread Bastien Philbert
This fixes the locking around the call to bnx2fc_alloc_id to comply with the comments about this particular function's definition about requiring the need to hold the hba mutex before and after calling it. Signed-off-by: Bastien Philbert ---

Re: QoS for iSCSI target?

2016-04-05 Thread Chris Friesen
On 04/04/2016 06:25 PM, Nicholas A. Bellinger wrote: On Mon, 2016-04-04 at 17:01 -0600, Chris Friesen wrote: I'm not trying to globally throttle IO on a particular block device. I'm trying to control how much IO the iSCSI target in the kernel is allowed to drive on a particular block device.

Re: [PATCH 09/27] target: use bio_is_full()

2016-04-05 Thread Christoph Hellwig
On Tue, Apr 05, 2016 at 07:56:54PM +0800, Ming Lei wrote: > +++ b/drivers/target/target_core_pscsi.c > @@ -951,7 +951,7 @@ pscsi_map_sg(struct se_cmd *cmd, struct scatterlist *sgl, > u32 sgl_nents, > pr_debug("PSCSI: bio->bi_vcnt: %d nr_vecs: %d\n", >

Re: [PATCH v2 6/8] tools rpmb: add RPBM access tool

2016-04-05 Thread kbuild test robot
Hi Tomas, [auto build test ERROR on char-misc/char-misc-testing] [also build test ERROR on v4.6-rc2 next-20160405] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Tomas-Winkler/Replay

Re: [PATCH v2 6/8] tools rpmb: add RPBM access tool

2016-04-05 Thread kbuild test robot
Hi Tomas, [auto build test ERROR on char-misc/char-misc-testing] [also build test ERROR on v4.6-rc2 next-20160405] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Tomas-Winkler/Replay

Re: [PATCHv3] scsi: disable automatic target scan

2016-04-05 Thread Benjamin Block
On 09:29 Fri 01 Apr , Hannes Reinecke wrote: > On 03/30/2016 09:41 PM, Benjamin Block wrote: > > Hello Hannes, > > > > I am a bit late here, but as this got pulled and Steffen didn't have > > time to give it a review, I did today. > > > > On 08:39 Thu 17 Mar , Hannes Reinecke wrote: > >>

[PATCH 09/27] target: use bio_is_full()

2016-04-05 Thread Ming Lei
Signed-off-by: Ming Lei --- drivers/target/target_core_pscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/target/target_core_pscsi.c b/drivers/target/target_core_pscsi.c index de18790..24906c3 100644 ---

[PATCH 00/27] block: cleanup direct access on .bi_vcnt & .bi_io_vec

2016-04-05 Thread Ming Lei
Hi Guys, It is always not a good practice to access bio->bi_vcnt and bio->bi_io_vec from drivers directly. Also this kind of direct access will cause trouble when converting to multipage bvecs. The 1st patch introduces the following 4 bio helpers which can be used inside drivers for avoiding

Re: [PATCH v4 0/2] Update SCSI target removal path

2016-04-05 Thread Martin K. Petersen
> "Johannes" == Johannes Thumshirn writes: Johannes> This is a follow up to "scsi: Add intermediate STARGET_REMOVE Johannes> state to scsi_target_state". James suggested we should let this incubate before hitting stable. Dropped v3 from 4.6/scsi-fixes and applied v4 to

Re: [PATCH 03/12] BUG: Losing bits on request.cmd_flags

2016-04-05 Thread Shaun Tancheff
On Tue, Apr 5, 2016 at 9:08 AM, Martin K. Petersen wrote: >> "Shaun" == Shaun Tancheff writes: > > Shaun> Oh, okay. It became an issue in the next patch where some > Shaun> internal cmd_flags temporaries where stored in 32 bit values. >

Re: [PATCH v13 0/9] add support for DWC UFS Controller

2016-04-05 Thread Joao Pinto
On 4/5/2016 11:15 AM, Winkler, Tomas wrote: > > Hi, > > On 4/5/2016 12:34 AM, Martin K. Petersen wrote: >>> "Joao" == Joao Pinto writes: >> >> Joao, >> >> Joao> The work consisted of: - Fixed typo in ufshcd-pltfrm.c - Tweak >> Joao> ufshcd.c for UFS 2.0 support -

RE: [PATCH v13 0/9] add support for DWC UFS Controller

2016-04-05 Thread Winkler, Tomas
Hi, On 4/5/2016 12:34 AM, Martin K. Petersen wrote: >> "Joao" == Joao Pinto writes: > > Joao, > > Joao> The work consisted of: - Fixed typo in ufshcd-pltfrm.c - Tweak > Joao> ufshcd.c for UFS 2.0 support - Implement ufshcd-dwc which > Joao> contains all DWC HW

[PATCH v4 1/2] scsi: Add intermediate STARGET_REMOVE state to scsi_target_state

2016-04-05 Thread Johannes Thumshirn
Add intermediate STARGET_REMOVE state to scsi_target_state to avoid running into the BUG_ON() in scsi_target_reap(). The STARGET_REMOVE state is only valid in the path from scsi_remove_target() to scsi_target_destroy() indicating this target is going to be removed. This re-fixes the problem

[PATCH v4 0/2] Update SCSI target removal path

2016-04-05 Thread Johannes Thumshirn
This is a follow up to "scsi: Add intermediate STARGET_REMOVE state to scsi_target_state". Changes to v3: * Incorporate James' suggestions for the commit messages. * Re-add accidently dropped Reviewed-by tags. Changes to v2: * Reverse the order of patches as pointed out by James. Changes to v1:

[PATCH v4 2/2] Revert "scsi: fix soft lockup in scsi_remove_target() on module removal"

2016-04-05 Thread Johannes Thumshirn
Now that we've done a more comprehensive fix with the intermediate target state we can remove the previous hack introduced with commit 90a88d6ef88edcfc4f644dddc7eef4ea41bccf8b. Signed-off-by: Johannes Thumshirn Cc: sta...@vger.kernel.org Reviewed-by: Ewan D. Milne

Re: [PATCH v13 0/9] add support for DWC UFS Controller

2016-04-05 Thread Joao Pinto
Hi, On 4/5/2016 12:34 AM, Martin K. Petersen wrote: >> "Joao" == Joao Pinto writes: > > Joao, > > Joao> The work consisted of: - Fixed typo in ufshcd-pltfrm.c - Tweak > Joao> ufshcd.c for UFS 2.0 support - Implement ufshcd-dwc which contains > Joao> all DWC HW