Re: [Lsf] Notes from the four separate IO track sessions at LSF/MM

2016-04-28 Thread James Bottomley
On Thu, 2016-04-28 at 16:19 +, Knight, Frederick wrote: > There are multiple possible situations being intermixed in this > discussion. First, I assume you're talking only about random access > devices (if you try transport level error recover on a sequential > access device - tape or SMR disk

Re: [dm-devel] [Lsf] Notes from the four separate IO track sessions at LSF/MM

2016-04-28 Thread Laurence Oberman
Hello Bart, This is when we have a subset of the paths fails. As you know the remaining path wont be used until the eh_handler is either done or is short circuited. What I will do is set this up via my jammer and capture a test using latest upstream. Of course my customer pain points are all in

Re: [dm-devel] [Lsf] Notes from the four separate IO track sessions at LSF/MM

2016-04-28 Thread Bart Van Assche
On 04/28/2016 09:23 AM, Laurence Oberman wrote: We still suffer from periodic complaints in our large customer base > regarding the long recovery times for dm-multipath. Most of the time this is when we have something like a switch > back-plane issue or an issue where RSCN'S are blocked coming

Re: [Lsf] Notes from the four separate IO track sessions at LSF/MM

2016-04-28 Thread Bart Van Assche
Hello Fred, Your feedback is very useful, but please note that in my e-mail I used the phrase "transport layer" to refer to the code in the Linux kernel in which the fast_io_fail_tmo functionality has been implemented. The following commit message from 10 years ago explains why the fast_io_fail_tm

[PATCH] [SCSI] csiostor: Do not use sizeof on pointer type

2016-04-28 Thread Vaishali Thakkar
When sizeof is applied to a pointer typed expression, it gives the size of the pointer. So, here do not use sizeof on pointer type. Problem found using Coccinelle. Fixes: a3667aaed569 ('[SCSI] csiostor: Chelsio FCoE offload driver') Signed-off-by: Vaishali Thakkar --- drivers/scsi/csiostor/csi

Re: [PATCH, RFT] byteswap: try to avoid __builtin_constant_p gcc bug

2016-04-28 Thread Quinn Tran
-Original Message- From: on behalf of Josh Poimboeuf Date: Wednesday, April 27, 2016 at 3:11 PM To: Arnd Bergmann Cc: Martin Jambor , "Martin K. Petersen" , James Bottomley , linux-scsi , linux-kernel , Denys Vlasenko , Thomas Graf , Peter Zijlstra , David Rientjes , Andrew Mort

Re: [Lsf] Notes from the four separate IO track sessions at LSF/MM

2016-04-28 Thread Laurence Oberman
Hello Folks, We still suffer from periodic complaints in our large customer base regarding the long recovery times for dm-multipath. Most of the time this is when we have something like a switch back-plane issue or an issue where RSCN'S are blocked coming back up the fabric. Corner cases still b

RE: [Lsf] Notes from the four separate IO track sessions at LSF/MM

2016-04-28 Thread Knight, Frederick
There are multiple possible situations being intermixed in this discussion. First, I assume you're talking only about random access devices (if you try transport level error recover on a sequential access device - tape or SMR disk - there are lots of additional complexities). Failures can occu

Re: [Lsf] Notes from the four separate IO track sessions at LSF/MM

2016-04-28 Thread Bart Van Assche
On 04/28/2016 08:40 AM, James Bottomley wrote: Well, the entire room, that's vendors, users and implementors complained that path failover takes far too long. I think in their minds this is enough substance to go on. The only complaints I heard about path failover taking too long came from pe

Re: [PATCH] scsi: fc: force inlining of wwn conversion functions

2016-04-28 Thread Chris Metcalf
On 4/28/2016 11:23 AM, Arnd Bergmann wrote: On Thursday 28 April 2016 10:58:43 Chris Metcalf wrote: (Resending as text/plain) On 4/27/2016 5:34 PM, Arnd Bergmann wrote: This won't help on TILE, which is the one architecture that sets ARCH_SUPPORTS_OPTIMIZED_INLINING but does not set ARCH_USE_B

Re: Notes from the four separate IO track sessions at LSF/MM

2016-04-28 Thread James Bottomley
On Thu, 2016-04-28 at 08:11 -0400, Mike Snitzer wrote: > On Wed, Apr 27 2016 at 7:39pm -0400, > James Bottomley wrote: > > > Multipath - Mike Snitzer > > > > > > Mike began with a request for feedback, which quickly lead to the > > complaint that recovery time (and how

Re: [PATCH] scsi: fc: force inlining of wwn conversion functions

2016-04-28 Thread Arnd Bergmann
On Thursday 28 April 2016 10:58:43 Chris Metcalf wrote: > (Resending as text/plain) > > On 4/27/2016 5:34 PM, Arnd Bergmann wrote: > > This won't help on TILE, which is the one architecture that sets > > ARCH_SUPPORTS_OPTIMIZED_INLINING but does not set ARCH_USE_BUILTIN_BSWAP. > > Chris Metcalf sh

Re: [PATCH] scsi: fc: force inlining of wwn conversion functions

2016-04-28 Thread Chris Metcalf
(Resending as text/plain) On 4/27/2016 5:34 PM, Arnd Bergmann wrote: This won't help on TILE, which is the one architecture that sets ARCH_SUPPORTS_OPTIMIZED_INLINING but does not set ARCH_USE_BUILTIN_BSWAP. Chris Metcalf should be able to figure out whether we can just set ARCH_USE_BUILTIN_BSWA

RE: [PATCH 2/7] hpsa: add sas_address to sysfs device attibute

2016-04-28 Thread Elliott, Robert (Persistent Memory)
> -Original Message- > From: Don Brace [mailto:don.br...@microsemi.com] > Sent: Wednesday, April 27, 2016 5:14 PM > Subject: [PATCH 2/7] hpsa: add sas_address to sysfs device attibute > > From: Joseph T Handzik ... > +static ssize_t sas_address_show(struct device *dev, > + stru

Re: Notes from the four separate IO track sessions at LSF/MM

2016-04-28 Thread Mike Snitzer
On Wed, Apr 27 2016 at 7:39pm -0400, James Bottomley wrote: > Multipath - Mike Snitzer > > > Mike began with a request for feedback, which quickly lead to the > complaint that recovery time (and how you recover) was one of the > biggest issues in device mapper multipat

Re: [PATCH 7/7] hpsa: update driver version

2016-04-28 Thread Johannes Thumshirn
On Wed, Apr 27, 2016 at 05:14:26PM -0500, Don Brace wrote: > Reviewed-by: Gerry Morong > Signed-off-by: Don Brace Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LIN

Re: [PATCH 6/7] hpsa: correct handling of HBA device removal

2016-04-28 Thread Johannes Thumshirn
On Wed, Apr 27, 2016 at 05:14:17PM -0500, Don Brace wrote: > Need to report HBA device removal faster than the > event handler polling interval. > > Stop I/O to the removed disk and wait for all > I/O operations to flush before removing the device. > > Reviewed-by: Scott Teel > Reviewed-by: Kevi

Re: [PATCH 5/7] hpsa: correct ioaccel2 error procecssing.

2016-04-28 Thread Johannes Thumshirn
On Wed, Apr 27, 2016 at 05:14:07PM -0500, Don Brace wrote: > set offload_to_be_enabled to 0 when an ioaccel2 error is processed. > > Before, an ioaccel completion error would turn of ioaccel but a rescan > would turn it back on again. > > Reviewed-by: Scott Teel > Reviewed-by: Kevin Barnett > S

Re: [PATCH 4/7] hpsa: correct ioaccel state change operation

2016-04-28 Thread Johannes Thumshirn
On Wed, Apr 27, 2016 at 05:13:59PM -0500, Don Brace wrote: > offload_to_be_enabled also needs to be set to 0 during a state > change. > > Reviewed-by: Scott Teel > Reviewed-by: Kevin Barnett > Signed-off-by: Don Brace Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn

Re: [PATCH 3/7] hpsa: add timeouts for driver initiated commands

2016-04-28 Thread Johannes Thumshirn
On Wed, Apr 27, 2016 at 05:13:51PM -0500, Don Brace wrote: > faulty drives can cause the driver to hang during a > scan operation. > > Reviewed-by: Scott Teel > Reviewed-by: Kevin Barnett > Signed-off-by: Don Brace Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn

Re: [PATCH 2/7] hpsa: add sas_address to sysfs device attibute

2016-04-28 Thread Johannes Thumshirn
On Wed, Apr 27, 2016 at 05:13:33PM -0500, Don Brace wrote: > From: Joseph T Handzik > > There have been companies requesting a sysfs entry > to obtain the sas address of device. > > Reviewed-by: Scott Teel > Reviewed-by: Kevin Barnett > Signed-off-by: Don Brace Reviewed-by: Johannes Thumshir

Re: [PATCH 1/7] hpsa: correct initialization order issue

2016-04-28 Thread Johannes Thumshirn
On Wed, Apr 27, 2016 at 05:13:26PM -0500, Don Brace wrote: > The driver was calling scsi_scan_host before enabling interrupts. > > This has gone unnoticed except for customers running in intx mode. > Calling scsi_scan_host before interrupts are enabled causes > "irq XX: nobody cared" messages and

Re: [PATCH 09/10] aacraid: Fix for KDUMP driver hang

2016-04-28 Thread Johannes Thumshirn
On Wed, Apr 27, 2016 at 04:49:50PM +, Raghava Aditya Renukunta wrote: > Hello Johannes, > > > -Original Message- > > From: Johannes Thumshirn [mailto:jthmsh...@suse.de] > > Sent: Wednesday, April 27, 2016 2:30 AM > > To: Raghava Aditya Renukunta > > Cc: jbottom...@odin.com; linux-scsi@

Re: [PATCH 08/10] aacraid: Remove code to needlessly complete fib

2016-04-28 Thread Johannes Thumshirn
On Wed, Apr 27, 2016 at 04:34:35PM +, Raghava Aditya Renukunta wrote: > > Hello Johannes, > > > > + dev_info(&dev->pdev->dev, > > > + "Invalid callback_fib[%d] (*%p)(%p)\n", > > > + index, fib->callback, fib->

Re: [PATCH 2/2] IB/iser: set max_segment_size

2016-04-28 Thread Or Gerlitz
On Tue, Apr 12, 2016 at 5:13 PM, Christoph Hellwig wrote: > So that we don't overflow the number of MR segments allocated because > we have to split on SGL segment into multiple MR segments. > > Signed-off-by: Christoph Hellwig nit, but please fix IB/iser: set [...] --> IB/iser: Set max segmen