Re: [PATCH v2.5 2/6] scsi_debug: rework resp_report_luns

2016-05-02 Thread Hannes Reinecke
On 05/01/2016 04:44 AM, Douglas Gilbert wrote: > Based on "[PATH V2] scsi_debug: rework resp_report_luns" patch > sent by Tomas Winkler on Thursday, 26 Feb 2015. His notes: > 1. Remove duplicated boundary checks which simplify the fill-in > loop > 2. Use more of scsi generic API > Replace

Re: [PATCH v2.5 1/6] scsi_debug: use pdt constants

2016-05-02 Thread Hannes Reinecke
On 05/01/2016 04:44 AM, Douglas Gilbert wrote: > Use TYPE_* constants for SCSI peripheral device types instead > of numbers. Further cleanups requested by checkpatch.pl . > > Signed-off-by: Douglas Gilbert > --- > drivers/scsi/scsi_debug.c | 86 > +--

RE: [PATCH v2.5 2/6] scsi_debug: rework resp_report_luns

2016-05-02 Thread Winkler, Tomas
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Monday, May 02, 2016 11:25 > To: Douglas Gilbert ; linux-scsi@vger.kernel.org > Cc: martin.peter...@oracle.com; Winkler, Tomas > ; emi...@redhat.com; > bart.vanass...@sandisk.com > Subject: Re: [PATCH v2.5 2/6] scs

[patch] [SCSI] aic94xx: silence a static checker warning

2016-05-02 Thread Dan Carpenter
"ddb" is a number between 0-64. It can't ever be >= 0x. But the static checker complains that since we're capping the upper bound, we may as well cap the lower bound and disallow negatives as well. Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/aic94xx/aic94xx_dev.c b/drivers/scsi

Re: [PATCH v2.5 3/6] scsi_debug: add multiple queue support

2016-05-02 Thread Hannes Reinecke
On 05/01/2016 04:44 AM, Douglas Gilbert wrote: > Add submit_queue parameter (minimum and default: 1; maximum: > nr_cpu_ids) that controls how many queues are built, each with > their own lock and in_use bit vector. Add statistics parameter > which is default on. > > Signed-off-by: Douglas Gilbert

Re: [PATCH v2.5 4/6] scsi_debug: vpd and mode page work

2016-05-02 Thread Hannes Reinecke
On 05/01/2016 04:44 AM, Douglas Gilbert wrote: > Cleanup some mode and vpd pages. Stop reporting SBC (disk) pages > when peripheral type is something else (e.g. tape). Update > version descriptors. Expand LBPRZ flag handling. > > Signed-off-by: Douglas Gilbert > --- > drivers/scsi/scsi_debug.c |

Re: [PATCH v2.5 5/6] scsi_debug: uuid for lu name

2016-05-02 Thread Hannes Reinecke
On 05/01/2016 04:44 AM, Douglas Gilbert wrote: > Permit changing of a LU name from a (fake) IEEE registered NAA (5) > to a locally assigned UUID. Using a UUID (RFC 4122) for a SCSI > designation descriptor (e.g. a LU name) was added in spc5r08.pdf > (a draft INCITS standard) on 25 January 2016. Add

Re: [PATCH v2.5 6/6] scsi_debug: use locally assigned naa

2016-05-02 Thread Hannes Reinecke
On 05/01/2016 04:44 AM, Douglas Gilbert wrote: > For reported SAS addresses replace fake IEEE registered NAAs (5) > with locally assigned NAAs (3). > > Signed-off-by: Douglas Gilbert > --- > drivers/scsi/scsi_debug.c | 35 ++- > 1 file changed, 18 insertions(+), 1

Re: UFS patchset

2016-05-02 Thread Joao Pinto
Hi Martin! On 4/30/2016 1:24 AM, Martin K. Petersen wrote: >> "Martin" == Martin K Petersen writes: > > Joao, > > Martin> In a previous email you said you had sent v14 to > Martin> linux-scsi. However, I don't see neither v14, nor v13 in > Martin> patchworks. The latest I have is v12 and it

Re: [PATCHv2]sd: Don't treat succeeded SYNC as error

2016-05-02 Thread Hannes Reinecke
On 04/29/2016 02:49 PM, Jinpu Wang wrote: > Hi, all > > We hit IO error on fsync, it turns out was because sd treat succeeded > SYNC as error. From what I checked in SBC spec there is no indication > we should fail IO in this case, so we create this patch. > > > Best Regards, > > Jack Wang > >

Re: [PATCHv2]sd: Don't treat succeeded SYNC as error

2016-05-02 Thread James Bottomley
On Mon, 2016-05-02 at 12:05 +0200, Hannes Reinecke wrote: > On 04/29/2016 02:49 PM, Jinpu Wang wrote: > > Hi, all > > > > We hit IO error on fsync, it turns out was because sd treat > > succeeded > > SYNC as error. From what I checked in SBC spec there is no > > indication > > we should fail IO in

[PATCH v15 4/9] ufs: added unipro attributes

2016-05-02 Thread Joao Pinto
Added unipro attributes. Signed-off-by: Joao Pinto Acked-by: Tomas Winkler --- Changes v12->v15: - Nothing changed (just to keep up with patch set version). Changes v0->v12 (Tomas Winkler): - This patch only appeared in v12 drivers/scsi/ufs/unipro.h | 39 +++

[PATCH v15 7/9] ufs: added support for Synopsys G210 Test Chip

2016-05-02 Thread Joao Pinto
This patch adds support for Synopsys G210 Test Chip. Signed-off-by: Joao Pinto Acked-by: Arnd Bergmann --- Changes v10->v15: - Nothing changed (just to keep up with patch set version). Changes v0->v10: - This patch only appeared in v10 drivers/scsi/ufs/Kconfig | 4 + drivers/scsi/ufs/M

[PATCH v15 5/9] ufs: added link status to ufshci

2016-05-02 Thread Joao Pinto
Added link status to ufshci. Signed-off-by: Joao Pinto Acked-by: Tomas Winkler --- Changes v12->v15: - Nothing changed (just to keep up with patch set version). Changes v0->v12 (Tomas Winkler): - This patch only appeared in v12 drivers/scsi/ufs/ufshci.h | 6 ++ 1 file changed, 6 insertions

[PATCH v15 8/9] ufs: add TC G210 platform driver

2016-05-02 Thread Joao Pinto
This patch adds a glue platform driver for the Synopsys G210 Test Chip. Signed-off-by: Joao Pinto --- Changes v13->v15: - Nothing changed (just to keep up with patch set version). Changes v12->v13 (Rob Herring): - Removed spaces from the compatibility string (pltfm driver and DT bindings) - Remov

[PATCH v15 9/9] ufs: add TC G210 pci driver

2016-05-02 Thread Joao Pinto
This patch adds a glue pci driver for the Synopsys G210 Test Chip. Signed-off-by: Joao Pinto --- Changes v13->v15: - Nothing changed (just to keep up with patch set version). Changes v12->v13: - Nothing changed (just to keep up with patch set version). Changes v10->v12 (Tomas Winkler): - custom_p

[PATCH v15 6/9] ufs: added support for DesignWare Controller

2016-05-02 Thread Joao Pinto
This patch has the goal to add support for DesignWare UFS Controller specific operations. Signed-off-by: Joao Pinto Acked-by: Arnd Bergmann --- Changes v12->v15: - Nothing changed (just to keep up with patch set version). Changes v11->v12 (Tomas Winkler): - custom_phy_initialization is now phy_i

[PATCH v15 1/9] ufs:fixed typo in ufshcd-pltfrm

2016-05-02 Thread Joao Pinto
Fixed typo in ufshcd-pltfrm. Signed-off-by: Joao Pinto Acked-by: Arnd Bergmann Acked-by: Tomas Winkler --- Changes v0->v15: - Nothing changed (just to keep up with patch set version). drivers/scsi/ufs/ufshcd-pltfrm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/

[PATCH v15 2/9] ufs: add UFS 2.0 to ufshcd-pltfrm bindings

2016-05-02 Thread Joao Pinto
Add UFS 2.0 to the ufshcd-pltfrm devicetree binding. Signed-off-by: Joao Pinto Acked-by: Rob Herring Acked-by: Tomas Winkler --- Changes v12->v15: - Nothing changed (just to keep up with patch set version). Changes v0->v12 (Tomas Winkler): - This patch only appeared in v12 Documentation/devic

[PATCH v15 3/9] ufs: added UFS 2.0 capabilities

2016-05-02 Thread Joao Pinto
Adding UFS 2.0 support to the UFS core driver. Signed-off-by: Joao Pinto Acked-by: Arnd Bergmann Acked-by: Tomas Winkler --- Changes v12->v15: - Nothing changed (just to keep up with patch set version). Changes v11->v12 (Tomas Winkler): - devicetree binding tweak was moved to a separated patch

Re: [PATCHv2]sd: Don't treat succeeded SYNC as error

2016-05-02 Thread James Bottomley
On Mon, 2016-05-02 at 06:44 -0700, James Bottomley wrote: > On Mon, 2016-05-02 at 12:05 +0200, Hannes Reinecke wrote: > > On 04/29/2016 02:49 PM, Jinpu Wang wrote: > > > Hi, all > > > > > > We hit IO error on fsync, it turns out was because sd treat > > > succeeded > > > SYNC as error. From what I

Re: UFS patchset

2016-05-02 Thread Joao Pinto
Hi Martin, On 4/30/2016 1:24 AM, Martin K. Petersen wrote: >> "Martin" == Martin K Petersen writes: > > Joao, > > Martin> In a previous email you said you had sent v14 to > Martin> linux-scsi. However, I don't see neither v14, nor v13 in > Martin> patchworks. The latest I have is v12 and it

Re: [PATCH v2.5 3/6] scsi_debug: add multiple queue support

2016-05-02 Thread Douglas Gilbert
On 2016-05-02 04:35 AM, Hannes Reinecke wrote: On 05/01/2016 04:44 AM, Douglas Gilbert wrote: Add submit_queue parameter (minimum and default: 1; maximum: nr_cpu_ids) that controls how many queues are built, each with their own lock and in_use bit vector. Add statistics parameter which is defaul

Re: [PATCH v2.5 4/6] scsi_debug: vpd and mode page work

2016-05-02 Thread Douglas Gilbert
On 2016-05-02 04:38 AM, Hannes Reinecke wrote: On 05/01/2016 04:44 AM, Douglas Gilbert wrote: Cleanup some mode and vpd pages. Stop reporting SBC (disk) pages when peripheral type is something else (e.g. tape). Update version descriptors. Expand LBPRZ flag handling. Signed-off-by: Douglas Gilbe

hpsa: Fix type ZBC conditional checks

2016-05-02 Thread Petros Koutoupis
The device ID obtained from the inquiry can only be of a single type. The original code places a check for TYPE_ZBC right after the check for TYPE_DISK. Logically, if the first if statement sees a device of a TYPE_DISK and moves on to the second statement checking if not TYPE_ZBC, it will always

Re: [dm-devel] [Lsf] Notes from the four separate IO track sessions at LSF/MM

2016-05-02 Thread Bart Van Assche
On 04/29/2016 05:47 PM, Laurence Oberman wrote: From: "Bart Van Assche" To: "Laurence Oberman" Cc: "James Bottomley" , "linux-scsi" , "Mike Snitzer" , linux-bl...@vger.kernel.org, "device-mapper development" , l...@lists.linux-foundation.org Sent: Friday, April 29, 2016 8:36:22 PM Subject: Re

Re: [dm-devel] [Lsf] Notes from the four separate IO track sessions at LSF/MM

2016-05-02 Thread Laurence Oberman
Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services - Original Message - From: "Bart Van Assche" To: "Laurence Oberman" Cc: linux-bl...@vger.kernel.org, "linux-scsi" , "Mike Snitzer" , "James Bottomley" , "device-mapper development" , l...@lists.

[PATCH 3/3] libata-scsi: Do not partially report ATA read look-ahead

2016-05-02 Thread tom . ty89
From: Tom Yan Nothing in the kernel actually makes use of the DRA bit in SCSI MODE SENSE. Neither is there a sysfs file (like 'cache_type' for WCE) that allows users to change the bit nor SCSI-ATA Translation that can toggle the ATA feature. Hence removing the MODE SENSE SCSI-ATA Translation tha

[PATCH 2/3] libata-scsi: Fix SCSI INQUIRY version descriptor

2016-05-02 Thread tom . ty89
From: Tom Yan https://bugzilla.kernel.org/show_bug.cgi?id=106931 Signed-off-by: Tom Yan diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index cd30f11..0295c38 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -1985,8 +1985,8 @@ static unsigned int ata_

[PATCH 1/3] libata-scsi: Set CmdQue=1 when NCQ is enabled

2016-05-02 Thread tom . ty89
From: Tom Yan https://bugzilla.kernel.org/show_bug.cgi?id=105931 This might look trivial at first sight. However, it can be important to have the bit set accordingly when the device/SATL is SCSI-passthrough'd to a virtual machine with scsi-block in qemu: https://github.com/YanVugenfirer/kvm-gue

[PATCH v2] byteswap: try to avoid __builtin_constant_p gcc bug

2016-05-02 Thread Arnd Bergmann
This is another attempt to avoid a regression in wwn_to_u64() after that started using get_unaligned_be64(), which in turn ran into a bug on gcc-4.9 through 6.1. The regression got introduced due to the combination of two separate workarounds (e3bde9568d99 and ef3fb2422ffe) that each try to sidest

Re: [dm-devel] [Lsf] Notes from the four separate IO track sessions at LSF/MM

2016-05-02 Thread Bart Van Assche
On 05/02/2016 12:28 PM, Laurence Oberman wrote: Even in the case of the ib_srp, don't we also have to still run the eh_timeout for each of the devices that has inflight requiring error handling serially. This means we will still have to wait to get a path failover until all are through the timeou

Re: [PATCH v2] byteswap: try to avoid __builtin_constant_p gcc bug

2016-05-02 Thread Andrew Morton
On Mon, 02 May 2016 23:48:19 +0200 Arnd Bergmann wrote: > This is another attempt to avoid a regression in wwn_to_u64() after > that started using get_unaligned_be64(), which in turn ran into a > bug on gcc-4.9 through 6.1. I'm still getting a couple screenfuls of things like net/tipc/name_dist

Re: [PATCH v2] byteswap: try to avoid __builtin_constant_p gcc bug

2016-05-02 Thread Arnd Bergmann
On Monday 02 May 2016 16:02:18 Andrew Morton wrote: > On Mon, 02 May 2016 23:48:19 +0200 Arnd Bergmann wrote: > > > This is another attempt to avoid a regression in wwn_to_u64() after > > that started using get_unaligned_be64(), which in turn ran into a > > bug on gcc-4.9 through 6.1. > > I'm st

Re: [PATCH v2] byteswap: try to avoid __builtin_constant_p gcc bug

2016-05-02 Thread Andrew Morton
On Tue, 03 May 2016 01:10:16 +0200 Arnd Bergmann wrote: > On Monday 02 May 2016 16:02:18 Andrew Morton wrote: > > On Mon, 02 May 2016 23:48:19 +0200 Arnd Bergmann wrote: > > > > > This is another attempt to avoid a regression in wwn_to_u64() after > > > that started using get_unaligned_be64(),

Re: [PATCH v2] byteswap: try to avoid __builtin_constant_p gcc bug

2016-05-02 Thread Arnd Bergmann
On Monday 02 May 2016 16:32:25 Andrew Morton wrote: > On Tue, 03 May 2016 01:10:16 +0200 Arnd Bergmann wrote: > > > On Monday 02 May 2016 16:02:18 Andrew Morton wrote: > > > On Mon, 02 May 2016 23:48:19 +0200 Arnd Bergmann wrote: > > > > > > > This is another attempt to avoid a regression in ww