> -Original Message-
> From: Jitendra Bhivare [mailto:jitendra.bhiv...@broadcom.com]
> Sent: Wednesday, August 10, 2016 6:16 PM
> To: 'Mike Christie'; 'Martin K. Petersen'
> Cc: 'linux-scsi@vger.kernel.org'
> Subject: RE: [PATCH 02/28] be2iscsi: Replace _bh with _irqsave/irqrestore
>
> > --
val is an unsigned int which makes the comparison >=0
unnecessary. This patch removes it.
Signed-off-by: Pranith Kumar
---
drivers/scsi/sd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index d3e852a..7a919b2 100644
--- a/drivers/scsi/
> "Tom" == Tom Yan writes:
Tom,
Tom> Now let's just come back to libata. I've thought of reporting dev->
Tom> max_sectors as Optimal Transfer Length in the SATL. However, I am
Tom> not sure if it is a safe thing to do, because we set it as high as
Tom> 65535 for devices with LBA48 devices. D
> "Michael" == Michael Ellerman writes:
>> Sorry about that. I fixed up async scan and managed to break sync
>> scan...
>>
>> This patch fixes it on my box. Does it fix the issue for you as well?
Michael> Yes, thanks!
Michael> If you like here's a:
Michael> Tested-by: Michael Ellerman
M
> "Oliver" == Oliver Neukum writes:
Oliver> Some SATA to USB bridges fail to cooperate with some drives
Oliver> resulting in no cache being present being reported to the
Oliver> host. That causes the host to skip sending a command to
Oliver> synchronize caches. That causes data loss when the
> "Yinghai" == Yinghai Lu writes:
Yinghai> Found one megaraid_sas HBA probe fails, [ 187.235190] scsi
Yinghai> host2: Avago SAS based MegaRAID driver [ 191.112365]
Yinghai> megaraid_sas :89:00.0: BAR 0: can't reserve [io
Yinghai> 0x-0x00ff] [ 191.120548] megaraid_sas :89:00.0: IO
> "Don" == Don Brace writes:
Don,
>> OK. I was just wondering whether it would make sense to have a libpqi
>> with all the spec-compliant pieces and put the "smart" in a dedicated
>> Microsemi driver.
Don> We would prefer not to do this at this time. We do not know of any
Don> other PQI dri
On 08/10/2016 03:49 PM, Arkadiusz Miskiewicz wrote:
Is runtime enabling/disabling of blk-mq supported?
Doesn't seem to work here:
4.1.30 (but the same thing on 4.6.3):
# zcat /proc/config.gz |grep _MQ_DEF
# CONFIG_SCSI_MQ_DEFAULT is not set
# CONFIG_DM_MQ_DEFAULT is not set
# cat /sys/module
Hi.
Is runtime enabling/disabling of blk-mq supported?
Doesn't seem to work here:
4.1.30 (but the same thing on 4.6.3):
# zcat /proc/config.gz |grep _MQ_DEF
# CONFIG_SCSI_MQ_DEFAULT is not set
# CONFIG_DM_MQ_DEFAULT is not set
# cat /sys/module/scsi_mod/parameters/use_blk_mq
N
# grep "" /sys
- Original Message -
> From: "Laurence Oberman"
> To: "Bart Van Assche"
> Cc: dm-de...@redhat.com, linux-scsi@vger.kernel.org, "Mike Snitzer"
> , "Johannes Thumshirn"
>
> Sent: Tuesday, August 9, 2016 1:21:15 PM
> Subject: Re: [dm-devel] dm-mq and end_clone_request()
>
>
>
> -
Hi,
Thanks for the patches. Changes look fine to me, other than a minor change
in patch-1 and the build issue due to the removal of
bfa_isr_disable()declaration.
Thanks,
Sudarsana
-Original Message-
From: Arnd Bergmann [mailto:a...@arndb.de]
Sent: 02 August 2016 20:53
To: Anil Guru
Hi,
On 08/10/2016 10:14 AM, Tejun Heo wrote:
Hello, Tom.
On Wed, Aug 10, 2016 at 06:04:10PM +0800, Tom Yan wrote:
On 10 August 2016 at 11:26, Tejun Heo wrote:
Hmmm.. why not? The hardware limit is 64k and the driver is using a
Is that referring to the maximum number of entries allowed in
Add core code for internal abort functionality.
The internal abort features allows the host controller
to abort commands which are still active in the
controller but have not yet been sent to the slave
device.
Typically a command only spends a relatively
short time in the controller when compared
This was lost with commit 2c55b750a884b86dea8b4cc5f15e1484cc47a25c
("[SCSI] zfcp: Redesign of the debug tracing for SAN records.")
but is necessary for problem determination, e.g. to see the
currently active zone set during automatic port scan.
For the large GPN_FT response (4 pages), save space b
After introducing generic strtolower(), iscsi_initiatorname_tolower() is
no longer needed.
Signed-off-by: Markus Mayer
Acked-by: Nicholas Bellinger
---
drivers/target/iscsi/iscsi_target_nego.c | 17 +
1 file changed, 1 insertion(+), 16 deletions(-)
diff --git a/drivers/target/i
This series introduces a family of generic string case conversion
functions. This kind of functionality is needed in several places in
the kernel. Right now, everybody seems to be implementing their own
copy of this functionality.
Based on the discussion of the previous version of this series[1] a
Add code in slot_complete_v2_hw() to deal with the
slots which have completed due to internal abort.
The status codes have the following meaning:
- STAT_IO_ABORTED: the IO has been aborted due to
internal abort, whether by device or individual
abort command
- STAT_IO_COMPLETE: internal abort comma
I have to admit that libata may not be the right place to deal with my
concern over the current BLK_DEF_MAX_SECTORS, which seems non-sensical
to me. In the original commit message:
(d2be537c3ba3, "block: bump BLK_DEF_MAX_SECTORS to 2560")
"A value of 2560 (1280k) will accommodate a 10-data-disk st
Add a collection of generic functions to convert strings to lowercase
or uppercase.
Changing the case of a string (with or without copying it first) seems
to be a recurring requirement in the kernel that is currently being
solved by several duplicated implementations doing the same thing. This
cha
Hi all,
here is a series of zfcp fixes all marked for stable.
They apply to the fixes branch of James' scsi.git or to v4.8-rc1.
Patches 1-3 are important functional bugfixes.
Patches 4-10 are serviceability regression fixes.
Steffen Maier (10):
zfcp: fix fc_host port_type with NPIV
zfcp: fix
When a tmf is issued, various response codes can be
returned from the target. For a query tmf the
response may be TMF_RESP_FUNC_COMPLETE or
TMF_RESP_FUNC_SUCC.
Add a condition for TMF_RESP_FUNC_SUCC to
hisi_sas_exec_internal_tmf_task().
This affects query tmf, as the result is success
the returned
Execute an internal abort for executing an internal
task abort. This is for case of command still being
present in host when abort is executed.
For a SATA internal abort, we set abort for all tasks
associated with the device.
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas_main.c |
When the port is detached we cannot execute a TMF,
as there can be no device attached to the port.
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c
b/drivers/scsi/hisi_sa
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/hisi_sas/hisi_sas.h b/drivers/scsi/hisi_sas/hisi_sas.h
index 4ae864d..fc51e87 100644
--- a/drivers/scsi/hisi_sas/hisi_sas.h
+++ b/drivers/scsi/hisi_sas/h
On 10 August 2016 at 15:41, David Milburn wrote:
> Hi,
>
> The 168 makes AHCI_CMD_TBL_SZ equal to 2816
>
> AHCI_CMD_TBL_SZ = AHCI_CMD_TBL_HDR_SZ + (AHCI_MAX_SG * 16)
> AHCI_CMD_TBL_SZ = 128 + (168 * 16)
>
> I think if you add in AHCI_CMD_SLOT_SZ (1024) and AHCI_RX_FIS_SZ (256)
> the DMA is 4K alig
Hi,
Thanks for the change. Following declarations also look to be referenced in
a single file and can be removed. Please check.
drivers/scsi/bfa/bfad_im.h:
extern struct scsi_host_template bfad_im_scsi_host_template;
extern struct scsi_transport_template *bfad_im_scsi_transport_
This information was lost with
commit a54ca0f62f953898b05549391ac2a8a4dad6482b
("[SCSI] zfcp: Redesign of the debug tracing for HBA records.")
but is required to debug e.g. invalid handle situations.
Signed-off-by: Steffen Maier
Fixes: a54ca0f62f95 ("[SCSI] zfcp: Redesign of the debug tracing for
bring back
commit d21e9daa63e009ce5b87bbcaa6d11ce48e07bbbe
("[SCSI] zfcp: Dont use 0 to indicate invalid LUN in rec trace")
which was lost with
commit ae0904f60fab7cb20c48d32eefdd735e478b91fb
("[SCSI] zfcp: Redesign of the debug tracing for recovery actions.")
Signed-off-by: Steffen Maier
Fixes:
On 08/10/2016 12:19 PM, Tom Yan wrote:
On 10 August 2016 at 15:41, David Milburn wrote:
Hi,
The 168 makes AHCI_CMD_TBL_SZ equal to 2816
AHCI_CMD_TBL_SZ = AHCI_CMD_TBL_HDR_SZ + (AHCI_MAX_SG * 16)
AHCI_CMD_TBL_SZ = 128 + (168 * 16)
I think if you add in AHCI_CMD_SLOT_SZ (1024) and AHCI_RX_FIS_
Add function to prepare the an internal abort
for v2 hw.
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 33 +
1 file changed, 33 insertions(+)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
in
Execute an internal abort for that device when it is removed,
so that commands for that device are not processed.
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas_main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c
b/drivers/scsi/hisi_s
In the hardware data router case, introduced with kernel 3.2
commit 86a9668a8d29 ("[SCSI] zfcp: support for hardware data router")
the ELS/GS request&response length needs to be initialized
as in the chained SBAL case.
Otherwise, the FCP channel rejects ELS requests with
FSF_REQUEST_SIZE_TOO_LARGE
On a successful end of reopen port forced,
zfcp_erp_strategy_followup_success() re-uses the port erp_action
and the subsequent zfcp_erp_action_cleanup() now
sees ZFCP_ERP_SUCCEEDED with
erp_action->action==ZFCP_ERP_ACTION_REOPEN_PORT
instead of ZFCP_ERP_ACTION_REOPEN_PORT_FORCED
but must not perfor
On 10 August 2016 at 11:26, Tejun Heo wrote:
> Hmmm.. why not? The hardware limit is 64k and the driver is using a
Is that referring to the maximum number of entries allowed in the
PRDT, Physical Region Descriptor Table (which is, more precisely,
65535)?
> lower limit of 168 most likely because
For an NPIV-enabled FCP device, zfcp can erroneously show
"NPort (fabric via point-to-point)" instead of "NPIV VPORT"
for the port_type sysfs attribute of the corresponding
fc_host.
s390-tools that can be affected are dbginfo.sh and ziomon.
zfcp_fsf_exchange_config_evaluate() ignores
fsf_qtcb_bott
Hello, Tom.
On Wed, Aug 10, 2016 at 04:32:39PM +0800, Tom Yan wrote:
> I have to admit that libata may not be the right place to deal with my
> concern over the current BLK_DEF_MAX_SECTORS, which seems non-sensical
> to me. In the original commit message:
>
> (d2be537c3ba3, "block: bump BLK_DEF_M
Hello, Tom.
On Wed, Aug 10, 2016 at 06:04:10PM +0800, Tom Yan wrote:
> On 10 August 2016 at 11:26, Tejun Heo wrote:
> > Hmmm.. why not? The hardware limit is 64k and the driver is using a
>
> Is that referring to the maximum number of entries allowed in the
> PRDT, Physical Region Descriptor Ta
Since commit a54ca0f62f953898b05549391ac2a8a4dad6482b
("[SCSI] zfcp: Redesign of the debug tracing for HBA records.")
HBA records no longer contain WWPN, D_ID, or LUN
to reduce duplicate information which is already in REC records.
In contrast to "regular" target ports, we don't use recovery to ope
On Mon, 2016-06-27 at 16:41 -0500, Don Brace wrote:
> From: Kevin Barnett
>
> This initial commit contains WIP of Microsemi's smartpqi module.
>
> Reviewed-by: Scott Benesh
> Reviewed-by: Kevin Barnett
> Signed-off-by: Kevin Barnett
> Signed-off-by: Don Brace
> ---
> MAINTAINERS
On Mon, 2016-06-27 at 16:41 -0500, Don Brace wrote:
> Depends on smartpqi driver adoption
>
> Reviewed-by: Kevin Barnett
> Reviewed-by: Scott Teel
> Signed-off-by: Kevin Barnett
> Signed-off-by: Don Brace
> ---
> drivers/scsi/aacraid/linit.c |2 --
> 1 file changed, 2 deletions(-)
>
> di
While retaining the actual filtering according to trace level,
the following commits started to write such filtered records
with a hardcoded record level of 1 instead of the actual record level:
commit 250a1352b95e1db3216e5c5d4f4365bea5122f4a
("[SCSI] zfcp: Redesign of the debug tracing for SCSI re
> -Original Message-
> From: Mike Christie [mailto:mchri...@redhat.com]
> Sent: Tuesday, August 09, 2016 11:19 PM
> To: Jitendra Bhivare; Martin K. Petersen
> Cc: linux-scsi@vger.kernel.org
> Subject: Re: [PATCH 02/28] be2iscsi: Replace _bh with _irqsave/irqrestore
>
> On 08/09/2016 03:29 A
With commit 2c55b750a884b86dea8b4cc5f15e1484cc47a25c
("[SCSI] zfcp: Redesign of the debug tracing for SAN records.")
we lost the N_Port-ID where an ELS response comes from.
With commit 7c7dc196814b9e1d5cc254dc579a5fa78ae524f7
("[SCSI] zfcp: Simplify handling of ct and els requests")
we lost the N_P
This patchset introduces support for the internal abort
feature for the HiSilicon SAS controller.
The internal abort feature allows commands which are active
in the controller to be aborted before being sent to the
slave device.
Only support will be added for v2 HW since v1 HW has issues
in suppo
commit 2c55b750a884b86dea8b4cc5f15e1484cc47a25c
("[SCSI] zfcp: Redesign of the debug tracing for SAN records.")
started to add FC_CT_HDR_LEN which made zfcp dump random data
out of bounds for RSPN GS responses because u.rspn.rsp
is the largest and last field in the union of struct zfcp_fc_req.
Othe
45 matches
Mail list logo
