Re: [PATCH 1/3] documentation/scsi: Remove nodisconnect parameter

2016-09-06 Thread Jonathan Corbet
On Sat, 27 Aug 2016 12:29:59 +1000 Finn Thain wrote: > The driver that used the 'nodisconnect' parameter was removed in > commit 565bae6a4a8f ("[SCSI] 53c7xx: kill driver"). Related documentation > was cleaned up in commit f37a7238d379 ("[SCSI] 53c7xx: fix removal > fallout"), except for the rema

[GIT PULL] SCSI fixes for 4.8-rc5

2016-09-06 Thread James Bottomley
This is really three fixes, but the SES one comes in a bundle of three (making the replacement API available properly, using it and removing the non-working one). The SES problem causes an oops on hpsa devices because they attach virtual disks to the host which aren't SAS attached (the replacement

Re: Observing Softlockup's while running heavy IOs

2016-09-06 Thread Neil Horman
On Tue, Sep 06, 2016 at 04:52:37PM +0530, Sreekanth Reddy wrote: > On Fri, Sep 2, 2016 at 4:34 AM, Bart Van Assche > wrote: > > On 09/01/2016 03:31 AM, Sreekanth Reddy wrote: > >> > >> I reduced the ISR workload by one third in-order to reduce the time > >> that is spent per CPU in interrupt conte

[PATCH 03/15] hisi_sas: keep CHL_INT2 masked for v2 HW

2016-09-06 Thread John Garry
None of the CHL_INT2 interrupts are serviced in the channel irq ISR, so leave the interrupt source masked. The interrupt mask is initially set in init_reg_v2_hw(). Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/driver

[PATCH 12/15] hisi_sas: remove init_id_frame_v2_hw()

2016-09-06 Thread John Garry
Function config_id_frame_v2_hw() is called twice for each PHY during initialisation, which is unneeded. So remove init_id_frame_v2_hw(), which only calls config_id_frame_v2_hw(). We will keep the call to config_id_frame_v2_hw() in start_phy_v2_hw() since it will be used for PHY reset functions.

[PATCH 11/15] hisi_sas: fix HBA SAS addr endianness for v1 hw

2016-09-06 Thread John Garry
The endianness for the SAS address in the TX_ID_DWORD registers is set incorrectly. We see errors like this in the boot log for v2 hw (which would have the same issue as v1 hw): [7.583284] sas: target proto 0x0 at 5d1108e7923f:0x1f not handled This is due to the host SAS addr not matching

[PATCH 13/15] hisi_sas: remove init_id_frame_v1_hw()

2016-09-06 Thread John Garry
Function config_id_frame_v1_hw() is called twice for each PHY during initialisation, which is unneeded. So remove init_id_frame_v1_hw(), which only calls config_id_frame_v1_hw(). We will keep the call to config_id_frame_v1_hw() in start_phy_v1_hw() since it will be used for PHY reset functions.

[PATCH 05/15] hisi_sas: use safe BITS_PER_BYTE for slot tag size calculation

2016-09-06 Thread John Garry
The memory calculation for the tags bitmap should use BITS_PER_BYTE macro instead of coincidental same value of sizeof(unsigned long). Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/hisi_sas/his

[PATCH 14/15] hisi_sas: add missing SATA pending device type to v2 hw

2016-09-06 Thread John Garry
In setup_itct_v2_hw(), SATA device type SAS_SATA_PENDING is missing, so add it. Note: The HiSi SAS controller does not support SATA PM, so do not handle SAS_SATA_PM_PORT or SAS_SATA_PM. Signed-off-by: John Garry Signed-off-by: Xiang Chen --- drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 1 +

[PATCH 06/15] hisi_sas: disable dlvry queues once at reset for v2 hw

2016-09-06 Thread John Garry
The Delivery queue enable register should only be written to once at reset for v2 hw. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c b/drivers/scsi/hisi_sas/hisi_s

[PATCH 15/15] hisi_sas: send three identify before phy up

2016-09-06 Thread John Garry
When the v2 hw is attached with many disks through an expander, there may be OOB reset resulting in a PHY going down after the speed is negotiated (very low probability). This issue is resolved by modifying the link control registers to send three identify frames before the PHY is ready (according

[PATCH 08/15] hisi_sas: fix a potential warning for sata disk ejection

2016-09-06 Thread John Garry
If hisi_sas_task_prep() fails for a SATA device due to PHY down, we return a failure to libata and also call task_done(), which will cause ata_qc_complete() to be called twice: - first call from hisi_sas_task_prep(), which will clear flag ATA_QCFLAG_ACTIVE - ata_qc_complete() called from libata T

[PATCH 10/15] hisi_sas: fix HBA SAS addr endianness for v2 hw

2016-09-06 Thread John Garry
The endianness for the SAS address in the TX_ID_DWORD registers is set incorrectly. We see errors like this in the boot log: [7.583284] sas: target proto 0x0 at 5d1108e7923f:0x1f not handled This is due to the host SAS addr not matching the PHY SAS addr in the expander host-attached phy di

[PATCH 07/15] hisi_sas: fix phy8 linkrate calculation in phy_up_v2_hw()

2016-09-06 Thread John Garry
In function phy_up_v2_hw(), we needlessly recalculate the phy linkrate for all phys, and the calculation is incorrect for phy8, so remove this code. Signed-off-by: John Garry Signed-off-by: Xiang Chen --- drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 3 --- 1 file changed, 3 deletions(-) diff --git

[PATCH 00/15] hisi_sas misc fixes and minor optimisations

2016-09-06 Thread John Garry
This patchset introdcues some minor bug fixes and optimisations for v1+v2 hw. No new functional features are introduced in this patchset. John Garry (15): hisi_sas: save completion queue read pointer hisi_sas: save delivery queue write pointer hisi_sas: keep CHL_INT2 masked for v2 HW hisi

[PATCH 04/15] hisi_sas: only zero slot memory when reused

2016-09-06 Thread John Garry
Currently the slot memory is zeroed when it is freed and also when it is reused, like in hisi_sas_task_prep(). Optimise by avoiding the redundant zeroing in the free. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[PATCH 02/15] hisi_sas: save delivery queue write pointer

2016-09-06 Thread John Garry
Optimise by saving an avoidable read in the get_free_slot function. The delivery queue write pointer will only be updated by software, so don't bother re-reading what was already written in the previous call to start_delivery function. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas

[PATCH 01/15] hisi_sas: save completion queue read pointer

2016-09-06 Thread John Garry
Optimise by saving an avoidable read in the cq interrupt. The queue read pointer will only be updated by software, so don't bother re-reading what was already written in the previous interrupt. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 1 + drivers/scsi/hisi_sas/hisi

[PATCH 09/15] hisi_sas: set dma mask before allocate DMA memory

2016-09-06 Thread John Garry
The device DMA mask was being set after the bulk of the DMA allocations in the driver init, so potentially DMA allocates fail. To resolve, relocate before allocating the DMA memory when initialising the driver. Signed-off-by: Xiang Chen Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_s

[PATCH 10/21] virtio scsi: Convert to hotplug state machine

2016-09-06 Thread Sebastian Andrzej Siewior
Install the callbacks via the state machine. It uses the multi instance infrastructure of the hotplug code to handle each interface. virtscsi_set_affinity() is removed from virtscsi_init() because virtscsi_cpu_notif_add() (the function which registers the instance) is invoked right after it and th

[PATCH 1/3] storvsc: use tagged SRB requests if supported by the device

2016-09-06 Thread Long Li
From: Long Li Properly set SRB flags when hosting device supports tagged queuing. This patch improves the performance on Fiber Channel disks. --- drivers/scsi/storvsc_drv.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c index

[PATCH 0/3] storvsc: fixes issues on Fiber Channel

2016-09-06 Thread Long Li
From: Long Li This patch set fixes connectivity issues and improves performance for Fiber Channel disks. Long Li (3): Use tagged SRB requests if supported by the device Properly handle SRB_ERROR when sense message is present Use block layer default segment size drivers/scsi/storvsc_drv.

[PATCH 2/3] storvsc: properly handle SRB_ERROR when sense message is present

2016-09-06 Thread Long Li
From: Long Li When sense message is present on error, we should pass along to the upper layer to decide how to deal with the error. This patch fixes connectivity issues with Fiber Channel devices. --- drivers/scsi/storvsc_drv.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/sc

[PATCH 3/3] storvsc: use block layer default segment size

2016-09-06 Thread Long Li
From: Long Li We no long have the restriction of page size limit in the SG list. Remove it. The driver can properly handle default block segment size. --- drivers/scsi/storvsc_drv.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c in

Re: [PATCH 2/6] cxlflash: Remove the device cleanly in the system shutdown path

2016-09-06 Thread Uma Krishnan
On 9/5/2016 2:12 AM, Andrew Donnellan wrote: On 03/09/16 06:39, Uma Krishnan wrote: Commit 704c4b0ddc03 ("cxlflash: Shutdown notify support for CXL Flash cards") was recently introduced to notify the AFU when a system is going down. Due to the position of the cxlflash driver in the device stac

Re: [PATCH] [SCSI] bfa: mark symbols static where possible

2016-09-06 Thread kbuild test robot
Hi Baoyou, [auto build test WARNING on scsi/for-next] [also build test WARNING on v4.8-rc5 next-20160906] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for convenience)

Re: [PATCH] [SCSI] bfa: mark symbols static where possible

2016-09-06 Thread Arnd Bergmann
On Wednesday, September 7, 2016 6:15:34 AM CEST kbuild test robot wrote: >drivers/scsi/bfa/bfad_bsg.c: In function 'bfad_iocmd_handler': > >> drivers/scsi/bfa/bfad_bsg.c:3130: warning: the frame size of 2896 bytes is > >> larger than 2048 bytes This needs to be investigated, 2896 bytes is cle

[PATCH] scsi: squash lines for simple wrapper functions

2016-09-06 Thread Masahiro Yamada
Remove unneeded variables and assignments. Signed-off-by: Masahiro Yamada --- drivers/scsi/aic7xxx/aic79xx_osm.c | 6 +- drivers/scsi/arcmsr/arcmsr_hba.c| 4 +--- drivers/scsi/esas2r/esas2r_ioctl.c | 20 drivers/scsi/lpfc/lpfc_attr.c | 8 ++-- drivers