[PATCH] hpsa: fix boolreturn.cocci warnings

2016-09-09 Thread kbuild test robot
drivers/scsi/hpsa.c:3473:9-10: WARNING: return of 0/1 in function 'hpsa_vpd_page_supported' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci CC: Scott Teel Signed-off-by: Fengguang

Re: [PATCH 3/5] hpsa: check for vpd support before sending

2016-09-09 Thread kbuild test robot
Hi Scott, [auto build test WARNING on scsi/for-next] [also build test WARNING on v4.8-rc5 next-20160909] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for convenience)

Re: [PATCH] scsi: replace broken specification URL

2016-09-09 Thread Tyrel Datwyler
On 09/09/2016 01:16 AM, Michael Opdenacker wrote: > Hi James, > > Thank you very much for your help... > > On 02/07/2016 16:49, James Bottomley wrote: >> On Sat, 2016-07-02 at 08:56 +0200, Michael Opdenacker wrote: >>> The t10.org website containing SCSI-2 draft specifications now >>> requires to

Re: [PATCH 6/6] cxlflash: Fix context reference tracking on detach

2016-09-09 Thread Uma Krishnan
On 9/2/2016 3:40 PM, Uma Krishnan wrote: From: "Matthew R. Ochs" Commit 888baf069f49 ("scsi: cxlflash: Add kref to context") introduced a kref to the context. In particular, the detach routine was updated to use the kref services for managing the removal and destruction of a context. As part o

Re: [PATCH 5/6] cxlflash: Refactor WWPN setup

2016-09-09 Thread Uma Krishnan
On 9/2/2016 3:40 PM, Uma Krishnan wrote: From: "Matthew R. Ochs" Commit 964497b3bf3f ("cxlflash: Remove dual port online dependency") logically removed the ability for the WWPN setup routine afu_set_wwpn() to return a non-success value. This routine can safely be made a void to simplify the cod

Re: [PATCH 4/6] cxlflash: Improve EEH recovery time

2016-09-09 Thread Uma Krishnan
On 9/2/2016 3:40 PM, Uma Krishnan wrote: From: "Matthew R. Ochs" When an EEH occurs during device initialization, the port timeout logic can cause excessive delays as MMIO reads will fail. Depending on where they are experienced, these delays can lead to a prolonged reset, causing an unnecessar

Re: [PATCH 3/6] cxlflash: Fix to avoid EEH and host reset collisions

2016-09-09 Thread Uma Krishnan
On 9/2/2016 3:39 PM, Uma Krishnan wrote: From: "Matthew R. Ochs" The EEH reset handler is ignorant to the current state of the driver when processing a frozen event and initiating a device reset. This can be an issue if an EEH event occurs while a user or stack initiated reset is executing. M

[PATCH 0/5] hpsa updates

2016-09-09 Thread Don Brace
The following changes are based on Linus's tree: - correct minor bug created when adding hpsa_skip_device - add check for null devices do to configuration changes - add check for null devices in ioaccel path - add check for vpd support - stop sending bmic commands to externals --- Don Brace

[PATCH 3/5] hpsa: check for vpd support before sending

2016-09-09 Thread Don Brace
From: Scott Teel Before using vendor-specific VPD pages for getting raid_level and device_id, check for page support. If page isn't supported, don't try to use it. Also, pay attention to return status on hpsa_get_device_id. Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Reviewed-by: Kevin B

[PATCH 4/5] hpsa: prevent sending bmic commands to externals

2016-09-09 Thread Don Brace
From: Scott Teel Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 6a5b7df..06f5e1c 1

[PATCH 5/5] hpsa: check for null devices in ioaccel submission patch

2016-09-09 Thread Don Brace
Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 06f5e1c..e4b3241 100644 --- a/dri

[PATCH 1/5] hpsa: determine device external status earlier

2016-09-09 Thread Don Brace
currently we are checking for external status before we are determining if a device is an external device. Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 10 +- 1 file changed, 5 insertions(+), 5 deleti

[PATCH 2/5] hpsa: check for null device pointers

2016-09-09 Thread Don Brace
A device can be deleted causing NULL pointer issues. Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/hpsa.c b/

Re: [PATCH] Some drives failing on SCT Write Same

2016-09-09 Thread Tejun Heo
On Fri, Sep 09, 2016 at 11:44:19AM -0500, Shaun Tancheff wrote: > Restrict support SCT Write Same to devices which also support ZAC where > support is required. > > Reported-by: Mike Krinkin > Signed-off-by: Shaun Tancheff Applied to libata/for-4.9. Thanks. -- tejun -- To unsubscribe from t

STRICTLY CONFIDENTIAL

2016-09-09 Thread Acct. Dept.
I have important transaction for you as next of kin to claim US$18.37m Mail me on my private email: chimwia...@gmail.com so i can send you more details Thanks Mr.Chim Wai Kim === DISCLAIMER: This email and any

Re: [PATCH] Some drives failing on SCT Write Same

2016-09-09 Thread Mike Krinkin
On Fri, Sep 09, 2016 at 11:48:51AM -0500, Shaun Tancheff wrote: > Mike, > > Can you confirm if this fix works for you? > > I tested the patch is tested on top of next-20160909. Works for me too, thank you. > > Thanks! > --Shaun > > On Fri, Sep 9, 2016 at 1

Re: patch "libata: Add support for SCT Write Same" breaks system

2016-09-09 Thread Shaun Tancheff
On Fri, Sep 9, 2016 at 10:36 AM, Tejun Heo wrote: > Hello, Shaun. > > On Fri, Sep 09, 2016 at 10:26:44AM -0500, Shaun Tancheff wrote: >> I'm looking into it now. Let me see if I can reproduce this on any of my >> hardware. >> >> If not there are a couple of options ... one is to only enable for ZB

RE: [PATCH V4 2/2] aacraid: remove wildcard for series 9 controllers

2016-09-09 Thread David Carroll
> > > > > > > "Don" == Don Brace writes: > > > > Don, > > > > Don> Depends on smartpqi driver adoption > > > > -{ 0x9005, 0x028f, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 65 }, /* Adaptec PMC > > Series 9 */ > > > > How are people that load aacraid in their initrd going to boot after > > this? > > >

[PATCH] Some drives failing on SCT Write Same

2016-09-09 Thread Shaun Tancheff
Restrict support SCT Write Same to devices which also support ZAC where support is required. Reported-by: Mike Krinkin Signed-off-by: Shaun Tancheff --- drivers/ata/libata-scsi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/l

RE: [PATCH V4 2/2] aacraid: remove wildcard for series 9 controllers

2016-09-09 Thread Scott Benesh
> > On September 8, 2016 2:33:52 PM EDT, Scott Benesh > wrote: > >> > >> On Thu, 2016-09-08 at 18:15 +, Don Brace wrote: > >> > > > -{ 0x9005, 0x028f, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 65 }, /* > >> > > > Adaptec PMC > >> > > > Series 9 */ > >> > > > > >> > > > How are people that load aacrai

Re: patch "libata: Add support for SCT Write Same" breaks system

2016-09-09 Thread Shaun Tancheff
On Fri, Sep 9, 2016 at 10:36 AM, Tejun Heo wrote: > Hello, Shaun. > > On Fri, Sep 09, 2016 at 10:26:44AM -0500, Shaun Tancheff wrote: >> I'm looking into it now. Let me see if I can reproduce this on any of my >> hardware. >> >> If not there are a couple of options ... one is to only enable for ZB

Re: patch "libata: Add support for SCT Write Same" breaks system

2016-09-09 Thread Tejun Heo
Hello, Shaun. On Fri, Sep 09, 2016 at 10:26:44AM -0500, Shaun Tancheff wrote: > I'm looking into it now. Let me see if I can reproduce this on any of my > hardware. > > If not there are a couple of options ... one is to only enable for ZBC > devices > where this explicitly required by the spec. >

Re: patch "libata: Add support for SCT Write Same" breaks system

2016-09-09 Thread Tejun Heo
Hello, On Thu, Sep 08, 2016 at 10:27:37PM +0300, Mike Krinkin wrote: > Hi, > > i tried recent linux-next on my laptop, and after boot system is > almost unusable because most of apps just crash with segfaults and > in dmesg output there are a lot of errors like this: ... > git bisect points at co

Re: [PATCH v2 3/3] scsi/ncr5380: Improve interrupt latency during PIO tranfers

2016-09-09 Thread Geert Uytterhoeven
On Fri, Sep 9, 2016 at 1:28 PM, Martin K. Petersen wrote: >> "Finn" == Finn Thain writes: > > Finn> Large PIO transfers are broken up into chunks to try to avoid > Finn> disabling local IRQs for long periods. But IRQs are still disabled > Finn> for too long and this causes SCC FIFO overruns d

Re: [PATCH] scsi: introduce a quirk for false cache reporting

2016-09-09 Thread Greg KH
On Fri, Sep 09, 2016 at 07:26:17AM -0400, Martin K. Petersen wrote: > > "Oliver" == Oliver Neukum writes: > > Oliver> On Thu, 2016-08-18 at 22:19 -0400, Martin K. Petersen wrote: > >> > "Oliver" == Oliver Neukum writes: > >> > Oliver> Some SATA to USB bridges fail to cooperate with some

Re: [PATCH 0/6] cxlflash: Miscellaneous fixes

2016-09-09 Thread Martin K. Petersen
> "Uma" == Uma Krishnan writes: Uma> This patch set contains miscellaneous fixes in the device cleanup Uma> and EEH recovery paths. One of the patches simplifies the WWPN Uma> assignment routine. Uma> There are a couple of fixes that resolve regressions introduced by Uma> Commit 704c4b0ddc03

Re: [PATCH -next] scsi: ibmvfc: fix typo in parameter description

2016-09-09 Thread Martin K. Petersen
> "Wei" == Wei Yongjun writes: Wei> From: Wei Yongjun Fix typo in parameter Wei> description. Applied to 4.9/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.

Re: [PATCH v2 3/3] scsi/ncr5380: Improve interrupt latency during PIO tranfers

2016-09-09 Thread Martin K. Petersen
> "Finn" == Finn Thain writes: Finn> Large PIO transfers are broken up into chunks to try to avoid Finn> disabling local IRQs for long periods. But IRQs are still disabled Finn> for too long and this causes SCC FIFO overruns during serial port Finn> transfers. Finn> This patch reduces the PI

Re: [REPOST PATCH 1/5] scsi: bnx2i: convert to kworker

2016-09-09 Thread Martin K. Petersen
> "Johannes" == Johannes Thumshirn writes: >> On Wed, Aug 17, 2016 at 12:09:59PM +0200, Sebastian Andrzej Siewior wrote: >> The driver creates its own per-CPU threads which are updated based on >> CPU hotplug events. It is also possible to use kworkers and remove >> some of the infrastructure

Re: [PATCH] scsi: introduce a quirk for false cache reporting

2016-09-09 Thread Martin K. Petersen
> "Oliver" == Oliver Neukum writes: Oliver> On Thu, 2016-08-18 at 22:19 -0400, Martin K. Petersen wrote: >> > "Oliver" == Oliver Neukum writes: >> Oliver> Some SATA to USB bridges fail to cooperate with some drives Oliver> resulting in no cache being present being reported to the Oliver

From:Mr Joe Ike

2016-09-09 Thread Mr Joe Ike
From:Mr Joe Ike Block 10 Flat 5 Victoria Island Lagos-Nigeria This is to inform you that your funds of US$15 Million has been approved for immediate delivery to you. For the purpose of clarification,you are advised to reconfirm your Full Names,Direct Telephone Numbers,Physical Address with Zip Cod

Re: [PATCH][SCSI] ufs: fix a wrong string in power mode change

2016-09-09 Thread Martin K. Petersen
> "Kiwoong" == Kiwoong Kim writes: Kiwoong> From: Kiwoong Kim I modified a string Kiwoong> as described in UFS spec as follow: umpcrs -> upmcrs Applied to 4.9/scsi-queue by hand. Please make sure patches are against the current scsi-queue tree. -- Martin K. Petersen Oracle Linux Engi

Re: [PATCH] [SCSI] bnx2fc: mark symbols static where possible

2016-09-09 Thread Martin K. Petersen
> "Baoyou" == Baoyou Xie writes: Baoyou> We get a few warnings when building kernel with W=1: Baoyou> drivers/scsi/bnx2fc/bnx2fc_els.c:257:6: warning: no previous Baoyou> prototype for 'bnx2fc_srr_compl' [-Wmissing-prototypes] Baoyou> drivers/scsi/bnx2fc/bnx2fc_els.c:367:6: warning: no previo

Re: [PATCH] [SCSI] aacraid: mark aac_src_select_comm() static

2016-09-09 Thread Martin K. Petersen
> "Baoyou" == Baoyou Xie writes: Baoyou> We get 1 warning when building kernel with W=1: Baoyou> drivers/scsi/aacraid/src.c:616:5: warning: no previous prototype Baoyou> for 'aac_src_select_comm' [-Wmissing-prototypes] Applied to 4.9/scsi-queue. -- Martin K. Petersen Oracle Linux Engi

Re: [PATCH] bnx2fc: Simplify code

2016-09-09 Thread Martin K. Petersen
> "Christophe" == Christophe JAILLET writes: Christophe> Calling 'list_splice' followed by 'INIT_LIST_HEAD' is Christophe> equivalent to 'list_splice_init'. Applied to 4.9/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsub

Re: [PATCH] scsi: replace broken specification URL

2016-09-09 Thread Michael Opdenacker
Hi James, Thank you very much for your help... On 02/07/2016 16:49, James Bottomley wrote: On Sat, 2016-07-02 at 08:56 +0200, Michael Opdenacker wrote: The t10.org website containing SCSI-2 draft specifications now requires to be from a member company to access the documents. This replaces th