Hi, Martin.
I think that the patch is correct.
UFS spec says "The Data Segment area is empty" for Read Descriptor.
I have been using similar code with it and it works.
That have been already applied in Android kernel.
Reviewed-by: Kiwoong Kim
Regards.
> -Original
> "Varun" == Varun Prakash writes:
Varun> If SKCBF_TX_FLAG_COMPL flag is set and unacknowledged credits are
Varun> >= max credits / 2, set completion bit in work request to reclaim
Varun> credits.
Applied to 4.9/scsi-queue.
--
Martin K. Petersen Oracle Linux
> "Subhash" == subhashj writes:
Subhash> Looks good to me.
> - /* Data segment length */
> - ucd_req_ptr->header.dword_2 = UPIU_HEADER_DWORD(
> - 0, 0, len >> 8, (u8)len);
> + /* Data segment length only need for WRITE_DESC */
> +
> "Lee" == Lee Duncan writes:
Lee> Yes, that would be great. Thank you.
Applied to 4.9/scsi-queue.
>> Is it your plan to go through the SCSI tree?
Lee> Yes, the iscsi initiator kernel code updates have been going
Lee> through the Linux SCSI mailing list and repository
> "Kyuho" == Kyuho Choi writes:
Kyuho> This patch enable no vccq quirk for SKHynix devices. SKHynix ufs
Kyuho> device don't need vccq vrail for device operation.
Applied to 4.9/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this
> "Baoyou" == Baoyou Xie writes:
Baoyou> We get 6 warnings when building kernel with W=1:
Baoyou> drivers/scsi/be2iscsi/be_main.c:65:1: warning: no previous
Baoyou> prototype for 'beiscsi_log_enable_disp' [-Wmissing-prototypes]
Baoyou>
> "Damien" == Damien Le Moal writes:
Damien> Thanks for all the comments. Should I send a fixed-up series or
Damien> just send correction patches later ?
Please repost with the requested changes in place.
Thanks!
--
Martin K. Petersen Oracle Linux Engineering
> "Damien" == Damien Le Moal writes:
Damien> Adds the new BLKREPORTZONE and BLKRESETZONE ioctls for
Damien> respectively obtaining the zone configuration of a zoned block
Damien> device and resetting the write pointer of sequential zones of a
Damien> zoned block
> "Damien" == Damien Le Moal writes:
Damien,
The new stuff looks much cleaner. Thanks for doing that!
This hunk has an unintended side effect:
@@ -2836,14 +2896,14 @@ static int sd_revalidate_disk(struct gendisk *disk)
* react badly if we do.
*/
Martin,
On 9/28/16 12:54, Martin K. Petersen wrote:
>> "Damien" == Damien Le Moal writes:
>
> Purely cosmetic: Looks like whitespace is a bit funky (spaces instead of
> tabs several places). Also a few typos.
>
> + * blkdev_report_zones - Get zones information
> +
> "Damien" == Damien Le Moal writes:
Purely cosmetic: Looks like whitespace is a bit funky (spaces instead of
tabs several places). Also a few typos.
+ * blkdev_report_zones - Get zones information
+ * @bdev: Target block device
+ * @sector:Sector from which
> "Damien" == Damien Le Moal writes:
Damien> From: Hannes Reinecke Signed-off-by: Hannes
Damien> Reinecke Signed-off-by: Damien Le Moal
Damien> ---
Reviewed-by: Martin K. Petersen
> "Damien" == Damien Le Moal writes:
Damien> Define REQ_OP_ZONE_REPORT and REQ_OP_ZONE_RESET for handling
Damien> zones of host-managed and host-aware zoned block devices. With
Damien> with these two new operations, the total number of operations
Damien> defined
> "Damien" == Damien Le Moal writes:
...same is true for the chunk_sectors attribute. Aside from that:
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line
> "Damien" == Damien Le Moal writes:
Damien> The zoned attribute is also exported as a string to applications
Damien> via sysfs. BLK_ZONED_NONE shows as "none", BLK_ZONED_HA as
Damien> "host-aware" and BLK_ZONED_HM as "host-managed".
Looks good. However, you should
On 09/26/2016 05:25 PM, Lee Duncan wrote:
> Chris Leech and I are taking over as open-iscsi maintainers.
>
> Changes since v1:
> * Updated URL to open-iscsi.com
> * Removed git repository, since code in tree
> ---
> MAINTAINERS | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>
The updated series looks fine to me:
Reviewed-by: Christoph Hellwig
Thanks a lot shaun and Demian for your hard work in the last weeks!
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info
From: Shaun Tancheff
Adds the new BLKREPORTZONE and BLKRESETZONE ioctls for respectively
obtaining the zone configuration of a zoned block device and resetting
the write pointer of sequential zones of a zoned block device.
The BLKREPORTZONE ioctl maps directly to a single
From: Hannes Reinecke
Implement ZBC support functions to setup zoned disks, both
host-managed and host-aware models. Only zoned disks that satisfy
the following conditions are supported:
1) All zones are the same size, with the exception of an eventual
last smaller runt zone.
2)
From: Shaun Tancheff
Define REQ_OP_ZONE_REPORT and REQ_OP_ZONE_RESET for handling zones of
host-managed and host-aware zoned block devices. With with these two
new operations, the total number of operations defined reaches 8 and
still fits with the 3 bits definition
This series introduces support for zoned block devices. It integrates
earlier submissions by Hannes Reinecke and Shaun Tancheff. Compared to the
previous series version, the code was significantly simplified by limiting
support to zoned devices satisfying the following conditions:
1) All zones of
Add the zoned queue limit to indicate the zoning model of a block device.
Defined values are 0 (BLK_ZONED_NONE) for regular block devices,
1 (BLK_ZONED_HA) for host-aware zone block devices and 2 (BLK_ZONED_HM)
for host-managed zone block devices. The standards defined drive managed
model is not
From: Hannes Reinecke
Implement zoned block device zone information reporting and reset.
Zone information are reported as struct blk_zone. This implementation
does not differentiate between host-aware and host-managed device
models and is valid for both. Two functions are provided:
From: Hannes Reinecke
The queue limits already have a 'chunk_sectors' setting, so
we should be presenting it via sysfs.
Signed-off-by: Hannes Reinecke
Signed-off-by: Damien Le Moal
---
block/blk-sysfs.c | 11 +++
1 file changed, 11
From: Hannes Reinecke
Signed-off-by: Hannes Reinecke
Signed-off-by: Damien Le Moal
---
block/blk-settings.c | 4
1 file changed, 4 insertions(+)
diff --git a/block/blk-settings.c b/block/blk-settings.c
index b1d5b7f..55369a6 100644
On Sun, 25 Sep 2016, Ondrej Zary wrote:
> Merge the PIO and MMIO code (with the help of ioport_map) in g_NCR5380 and
> delete g_NCR5380_mmio.
>
> Signed-off-by: Ondrej Zary
> ---
> drivers/scsi/Kconfig | 32 ++---
> drivers/scsi/g_NCR5380.c | 257
On Tue, 27 Sep 2016, Ondrej Zary wrote:
> On Monday 26 September 2016, Finn Thain wrote:
>
> [...]
>
> > > @@ -364,7 +304,7 @@ static int generic_NCR5380_release_resources(struct
> > > Scsi_Host *instance) release_mem_region(instance->base,
> > > hostdata->iomem_size);
> > > }
> > > #endif
Hi Joao,
On 2016-09-26 18:10, Kiwoong Kim wrote:
Hi.
If you want to declare some things for user interface,
is it be better to put those thing include/uapi/linux/ than
include/linux?
Agreed with Mr. Pinto's opinion with respect to implementing additional
ioctls.
Yes,
Hi Kiwoong Kim,
This is a good catch, Looks good to me.
Reviewed-by: Subhash Jadavani
Thanks,
Subhash
On 2016-09-08 16:22, Kiwoong Kim wrote:
From: Kiwoong Kim
When any UFS host controller receives a TM(Task Management)
response from a UFS
Looks good to me.
Reviewed-by: Subhash Jadavani
On 2016-08-25 02:39, Zang Leigang wrote:
Some device may cause a compatibility issue while receiving a Query
UPIU
with Data Segment which does not expected.
Signed-off-by: Zang Leigang
---
Damien, can you do a repost of the whole series with the
header reshuffled included? Except for that and the trivial
kcalloc bit the series looks fine to me:
Reviewed-by: Christoph Hellwig
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a
On Mon, Sep 26, 2016 at 6:14 AM, Damien Le Moal wrote:
> From: Hannes Reinecke
>
> Signed-off-by: Hannes Reinecke
> Signed-off-by: Damien Le Moal
> ---
> block/blk-settings.c | 4
> 1 file changed, 4
On Mon, Sep 26, 2016 at 6:14 AM, Damien Le Moal wrote:
> From: Hannes Reinecke
>
> The queue limits already have a 'chunk_sectors' setting, so
> we should be presenting it via sysfs.
>
> Signed-off-by: Hannes Reinecke
> Signed-off-by: Damien
On Mon, Sep 26, 2016 at 6:14 AM, Damien Le Moal wrote:
> Add the zoned queue limit to indicate the zoning model of a block device.
> Defined values are 0 (BLK_ZONED_NONE) for regular block devices,
> 1 (BLK_ZONED_HA) for host-aware zone block devices and 2 (BLK_ZONED_HM)
>
On Mon, Sep 26, 2016 at 6:14 AM, Damien Le Moal wrote:
> From: Hannes Reinecke
>
> Implement ZBC support functions to setup zoned disks, both
> host-managed and host-aware models. Only zoned disks that satisfy
> the following conditions are supported:
> 1)
Hi Pawel,
Please find some comments inline.
On 2016-07-26 04:56, Pawel Wodkowski wrote:
Add BLKSECDISCAD feature support if LU is provisioned for TPRZ
(bProvisioningType = 3).
Did you mean sending purge when bProvisioningType is set to 02h (TPRZ =
0)? why do we want to send the purge if
Looks good to me.
Reviewed-by: Subhash Jadavani
On 2016-09-26 07:58, Kyuho Choi wrote:
This patch enable no vccq quirk for SKHynix devices.
SKHynix ufs device don't need vccq vrail for device operation.
Signed-off-by: Kyuho Choi
---
This small patch series removes deprecated code from g_NCR5380 driver
and converts it from scsi_module.c to scsi_add_host().
Tested with:
HP C2502 (53C400A chip)
Canon FG2-5202 (53C400 chip, memory-mapped)
DTC-3181L (DTCT-436P chip, PnP)
---
Changes in v2:
- updated
Convert g_NCR5380 to use scsi_add_host instead of scsi_module.c
Use pnp_driver and isa_driver to manage cards.
In order to support multiple cards, new module parameter format is
introduced. The old parameters are kept for compatibility.
Signed-off-by: Ondrej Zary
---
Remove deprecated __setup for parsing command line parameters.
g_NCR5380.* parameters could be used instead.
This might break existing setups with g_NCR5380 built-in (if there are
any). But it has to go in order to remove the overrides[] array.
Signed-off-by: Ondrej Zary
Remove compile-time card type definition GENERIC_NCR5380_OVERRIDE.
Then remove all code iterating the overrides[] array and reduce it to
struct card.
Signed-off-by: Ondrej Zary
---
drivers/scsi/g_NCR5380.c | 351 ++
1 file
Adds the new BLKREPORTZONE and BLKRESETZONE ioctls for respectively
obtaining the zone configuration of a zoned block device and resetting
the write pointer of sequential zones of a zoned block device.
The BLKREPORTZONE ioctl maps directly to a single call of the function
blkdev_report_zones. The
From: Hannes Reinecke
Implement zoned block device zone information reporting and reset.
Zone information are reported as struct blk_zone. This implementation
does not differentiate between host-aware and host-managed device
models and is valid for both. Two functions are provided:
On Tue, 2016-09-27 at 08:34 +0200, Hannes Reinecke wrote:
> On 09/26/2016 09:06 PM, James Bottomley wrote:
> > On Mon, 2016-09-26 at 09:52 -0700, Christoph Hellwig wrote:
> > > Getting back to this after Hannes recovered from his vacation
> > > and I had a chat with him..
> > >
> > > On Mon, Aug
On Mon, Sep 26, 2016 at 06:12:24PM -0500, Shaun Tancheff wrote:
> Except our source locations are disjoint (stack and kcalloc'd).
Indeed.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On 09/27/2016 09:56 AM, James Bottomley wrote:
On Tue, 2016-09-27 at 09:43 -0700, Bart Van Assche wrote:
On 09/27/2016 09:31 AM, Steve Wise wrote:
@@ -2079,11 +2075,15 @@ EXPORT_SYMBOL_GPL(nvme_kill_queues);
void nvme_stop_queues(struct nvme_ctrl *ctrl)
{
struct nvme_ns *ns;
+
https://bugzilla.kernel.org/show_bug.cgi?id=172831
Dave Carroll changed:
What|Removed |Added
CC|
> On 09/27/2016 09:31 AM, Steve Wise wrote:
> >> @@ -2079,11 +2075,15 @@ EXPORT_SYMBOL_GPL(nvme_kill_queues);
> >> void nvme_stop_queues(struct nvme_ctrl *ctrl)
> >> {
> >>struct nvme_ns *ns;
> >> + struct request_queue *q;
> >>
> >>mutex_lock(>namespaces_mutex);
> >>
https://bugzilla.kernel.org/show_bug.cgi?id=172841
Dave Carroll changed:
What|Removed |Added
CC|
On Tue, 2016-09-27 at 09:43 -0700, Bart Van Assche wrote:
> On 09/27/2016 09:31 AM, Steve Wise wrote:
> > > @@ -2079,11 +2075,15 @@ EXPORT_SYMBOL_GPL(nvme_kill_queues);
> > > void nvme_stop_queues(struct nvme_ctrl *ctrl)
> > > {
> > > struct nvme_ns *ns;
> > > + struct request_queue *q;
> > >
On 09/27/2016 09:31 AM, Steve Wise wrote:
@@ -2079,11 +2075,15 @@ EXPORT_SYMBOL_GPL(nvme_kill_queues);
void nvme_stop_queues(struct nvme_ctrl *ctrl)
{
struct nvme_ns *ns;
+ struct request_queue *q;
mutex_lock(>namespaces_mutex);
list_for_each_entry(ns,
> @@ -2079,11 +2075,15 @@ EXPORT_SYMBOL_GPL(nvme_kill_queues);
> void nvme_stop_queues(struct nvme_ctrl *ctrl)
> {
> struct nvme_ns *ns;
> + struct request_queue *q;
>
> mutex_lock(>namespaces_mutex);
> list_for_each_entry(ns, >namespaces, list) {
> -
Hello Martin:
On 09/26/2016 06:26 PM, Martin K. Petersen wrote:
>> "Lee" == Lee Duncan writes:
>
> Lee,
>
> Lee> Chris Leech and I are taking over as open-iscsi maintainers.
>
> Do you want me to queue the MAINTAINER update?
Yes, that would be great. Thank you.
>
>
On 09/27/2016 07:42 AM, Bart Van Assche wrote:
Jens, regarding non-blk-mq mode and q_usage_counter: do you prefer that
I rework patch 8/9 such that blk_quiesce_queue() and blk_resume_queue()
are only used in blk-mq mode or are you OK with adding a
blk_queue_enter() call in get_request() and a
On 09/27/2016 01:26 PM, Vaishali Thakkar wrote:
>
>
> On Tuesday 13 September 2016 02:48 PM, Vaishali Thakkar wrote:
>> Hi,
>>
>> In the file drivers/scsi/advansys.c we are calling function AdvISR at 2
>> instances
>> [in the function advansys_reset and advansys_interrupt] while holding
>>
On 09/27/16 06:22, Ming Lei wrote:
On Tue, Sep 27, 2016 at 2:27 AM, Bart Van Assche
wrote:
Signed-off-by: Bart Van Assche
---
block/blk-core.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git
On Tue, Sep 27, 2016 at 2:27 AM, Bart Van Assche
wrote:
> Signed-off-by: Bart Van Assche
> ---
> block/blk-core.c | 15 ++-
> 1 file changed, 6 insertions(+), 9 deletions(-)
>
> diff --git a/block/blk-core.c b/block/blk-core.c
On Monday 26 September 2016, Finn Thain wrote:
[...]
> Instead of this:
> > + if (scsi_add_host(instance, pdev)) {
> > + free_irq(irq, instance);
> > + goto out_unregister;
> > + }
> > + scsi_scan_host(instance);
> > + return instance;
>
> please use the following
On Tuesday 13 September 2016 02:48 PM, Vaishali Thakkar wrote:
> Hi,
>
> In the file drivers/scsi/advansys.c we are calling function AdvISR at 2
> instances
> [in the function advansys_reset and advansys_interrupt] while holding
> spinlock.
> Function AdvISR eventually calls request_firmware
> -Original Message-
> From: Jitendra Bhivare [mailto:jitendra.bhiv...@broadcom.com]
> Sent: Friday, September 23, 2016 8:38 PM
> To: 'Mike Christie'; 'Martin K. Petersen'
> Cc: 'linux-scsi@vger.kernel.org'
> Subject: RE: [PATCH 02/28] be2iscsi: Replace _bh with _irqsave/irqrestore
>
> Hi
On Tue, Sep 27, 2016 at 08:26:19AM +0200, Hannes Reinecke wrote:
> On 09/26/2016 08:27 PM, Bart Van Assche wrote:
> > Move the blk_freeze_queue() and blk_unfreeze_queue() implementations
> > from block/blk-mq.c to block/blk-core.c. Drop "_mq" from the name of
> > the functions that have been
On Mon, Sep 26, 2016 at 11:27:49AM -0700, Bart Van Assche wrote:
> Signed-off-by: Bart Van Assche
> ---
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de
On Mon, Sep 26, 2016 at 11:28:08AM -0700, Bart Van Assche wrote:
> Since these two structure members are now used in blk-mq and !blk-mq
> paths, remove the mq_prefix. This patch does not change any
> functionality.
>
> Signed-off-by: Bart Van Assche
> ---
Looks good,
On Mon, Sep 26, 2016 at 11:26:50AM -0700, Bart Van Assche wrote:
> Ensure that all ongoing dm_mq_queue_rq() and dm_mq_requeue_request()
> calls have stopped before setting the "queue stopped" flag. This
> allows to remove the "queue stopped" test from dm_mq_queue_rq() and
>
On Mon, Sep 26, 2016 at 11:26:26AM -0700, Bart Van Assche wrote:
> The function blk_queue_stopped() allows to test whether or not a
> traditional request queue has been stopped. Introduce a helper
> function that allows block drivers to query easily whether or not
> one or more hardware contexts
On 09/26/2016 09:06 PM, James Bottomley wrote:
> On Mon, 2016-09-26 at 09:52 -0700, Christoph Hellwig wrote:
>> Getting back to this after Hannes recovered from his vacation
>> and I had a chat with him..
>>
>> On Mon, Aug 15, 2016 at 09:40:39AM -0400, Mike Snitzer wrote:
>>> Seems we still need a
On 09/26/2016 08:27 PM, Bart Van Assche wrote:
> Move the blk_freeze_queue() and blk_unfreeze_queue() implementations
> from block/blk-mq.c to block/blk-core.c. Drop "_mq" from the name of
> the functions that have been moved.
>
> Signed-off-by: Bart Van Assche
> ---
On 09/26/2016 08:26 PM, Bart Van Assche wrote:
> Ensure that all ongoing dm_mq_queue_rq() and dm_mq_requeue_request()
> calls have stopped before setting the "queue stopped" flag. This
> allows to remove the "queue stopped" test from dm_mq_queue_rq() and
> dm_mq_requeue_request(). This patch fixes
On 09/26/2016 08:26 PM, Bart Van Assche wrote:
> The function blk_queue_stopped() allows to test whether or not a
> traditional request queue has been stopped. Introduce a helper
> function that allows block drivers to query easily whether or not
> one or more hardware contexts of a blk-mq queue
69 matches
Mail list logo