On Wed, Nov 2, 2016 at 12:02 AM, Sagi Grimberg wrote:
> Reviewed-by: Sagi Grimberg
Reviewed-by: Ming Lei
--
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/ma
On 11/02/2016 01:09 AM, Andrey Grodzovsky wrote:
Problem:
This is a work around for a bug with LSI Fusion MPT SAS2 when
pefroming secure erase. Due to the very long time the operation
takes commands issued during the erase will time out and will trigger
execution of abort hook. Even though the ab
Problem:
This is a work around for a bug with LSI Fusion MPT SAS2 when
pefroming secure erase. Due to the very long time the operation
takes commands issued during the erase will time out and will trigger
execution of abort hook. Even though the abort hook is called for
the specifc command which ti
https://bugzilla.kernel.org/show_bug.cgi?id=121531
--- Comment #23 from Chloé Desoutter ---
I can trigger crashes after a long while in a heavy workload, quite randomly,
with 256.
Out of curiosity I checked the pmspcv driver from FreeBSD and they use a lower
value still :
#define MPI_MAX_INBOU
Switch to scsi_execute_req_flags() instead of
using the block interface directly. This will set
REQ_QUIET and REQ_PREEMPT, but this is okay as
we're evaluating the errors anyway and should be
able to send the command even if the device is
quiesced.
Signed-off-by: Hannes Reinecke
---
drivers/scsi
Switch to scsi_execute_req_flags() instead of
using the block interface directly. This will set
REQ_QUIET and REQ_PREEMPT, but this is okay as
we're evaluating the errors anyway and should be
able to send the command even if the device is
quiesced.
Signed-off-by: Hannes Reinecke
---
drivers/scsi
Switch to scsi_execute_req_flags() instead of
using the block interface directly. This will set
REQ_QUIET and REQ_PREEMPT, but this is okay as
we're evaluating the errors anyway and should be
able to send the command even if the device is
quiesced.
Switch to scsi_execute_req_flags() instead of
usin
Hi all,
here's a patchset to switch to scsi_execute_req_flags() for
all SCSI device handlers. Originally we would be using
blk_execute_rq_nowait to allow the 'activate' function
to run asynchronously.
However, as we're now calling the 'activate' function
synchronously there's no point in using the
> "Bill" == Bill Kuzeja writes:
Bill> A system can get hung task timeouts if a qlogic board fails during
Bill> initialization (if the board breaks again or fails the init). The
Bill> hang involves the scsi scan.
Bill> In a nutshell, since commit beb9e315e6e0 ("qla2xxx: Prevent
Bill> removal
On 11/01/2016 03:47 PM, Christoph Hellwig wrote:
On Mon, Oct 31, 2016 at 06:59:28PM +0100, Hannes Reinecke wrote:
Switch to using scsi_execute_req_flags() instead of using the
block primitives.
__scsi_execute adds RQF_QUIET and RQF_PREEMPT to the request flags, which
would be a change in behav
On 2016-10-29 13:22, Vivek Gautam wrote:
Add phy clock enable code to phy_power_on/off callbacks, and
remove explicit calls to enable these phy clocks from the
ufs-qcom hcd driver.
Signed-off-by: Vivek Gautam
---
Changes since v2:
- Added phy_power_on() and phy_power_off() calls to
power-c
On 2016-10-29 13:22, Vivek Gautam wrote:
The tx_iface_clk and rx_iface_clk no longer exist with UFS Phy
present on msm8996. So skip obtaining these clocks using
compatible match.
Signed-off-by: Vivek Gautam
---
New patch in v3 of this cleanup series.
Comes in place of the following patch in v2
On 10/24/2016 01:54 PM, Sreekanth Reddy wrote:
Observing below kernel panic while creating second raid disk
on LSI SAS3008 HBA card.
[ +0.55] [ cut here ]
[ +0.07] WARNING: CPU: 2 PID: 281 at fs/sysfs/dir.c:31
sysfs_warn_dup+0x62/0x80
[ +0.02] sysfs: canno
> "Christoph" == Christoph Hellwig writes:
Christoph> In 4.9 I've added support in the interrupt layer to
Christoph> automatically assign the interrupt affinity at interrupt
Christoph> allocation time, and expose that information to blk-mq.
Christoph> This series extents that so that SCSI dr
On Mon, Oct 31, 2016 at 10:29:26AM -0600, Tejun Heo wrote:
> On Mon, Oct 31, 2016 at 03:04:10PM +, Wei Yongjun wrote:
> > From: Wei Yongjun
> >
> > Fix to return error code -ENOMEM from the error handling
> > case instead of 0, as done elsewhere in this function.
> >
> > Signed-off-by: Wei Y
> "Bart" == Bart Van Assche writes:
Bart> The code at the end of alua_rtpg_work() is as follows:
Bart> scsi_device_put(sdev);
Bart> kref_put(&pg->kref, release_port_group);
Bart> In other words, alua_rtpg_queue() must hold an sdev reference and
Bart> a pg reference before queueing rtpg w
On 11/01/2016 03:41 PM, Christoph Hellwig wrote:
A little warning: scsi_execute_req_flags grew a new argument in the block
tree to be able to specify the request-only flags. So any of these
patches would create a (mostly harmless) conflict in linux-next.
I don't mind creating the patches again
On 11/01/2016 03:19 PM, Bart Van Assche wrote:
The code at the end of alua_rtpg_work() is as follows:
scsi_device_put(sdev);
kref_put(&pg->kref, release_port_group);
In other words, alua_rtpg_queue() must hold an sdev reference and
a pg reference before queueing rtpg work. If no
rport can't be null here, it would have failed already in
fc_remote_port_chkready
Signed-off-by: Tomas Henzl
---
drivers/scsi/fnic/fnic_scsi.c | 20 +---
1 file changed, 9 insertions(+), 11 deletions(-)
diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c
i
It is not good when an irq arrives before
driver structures are allocated.
Signed-off-by: Tomas Henzl
---
drivers/scsi/megaraid/megaraid_sas_base.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
b/drivers/scsi/megaraid/
> "Bart" == Bart Van Assche writes:
Bart> Ensure that if scsi-mq is enabled that
Bart> scsi_internal_device_block() waits until ongoing
Bart> shost->hostt->queuecommand() calls have finished.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubsc
> "Bart" == Bart Van Assche writes:
Bart> Additionally, rename srp_wait_for_queuecommand() into
Bart> scsi_wait_for_queuecommand() and add a comment about the
Bart> queuecommand() call from scsi_send_eh_cmnd().
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engine
and again,
Reviewed-by: Sagi Grimberg
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Sagi Grimberg
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Nov 01 2016, Martin K. Petersen wrote:
> > "Christoph" == Christoph Hellwig writes:
>
> Christoph> This will allow SCSI to have a single blk_mq_ops structure
> Christoph> that either lets the LLDD map the queues to PCIe MSIx vectors
> Christoph> or use the default.
>
> Jens, any obje
Again,
Reviewed-by: Sagi Grimberg
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Looks useful,
Reviewed-by: Sagi Grimberg
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Sagi Grimberg
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Sagi Grimberg
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Sagi Grimberg
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Sagi Grimberg
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Sagi Grimberg
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
> "Christoph" == Christoph Hellwig writes:
Christoph> This will allow SCSI to have a single blk_mq_ops structure
Christoph> that either lets the LLDD map the queues to PCIe MSIx vectors
Christoph> or use the default.
Jens, any objection to me funneling this change through the SCSI tree?
--
On Mon, Oct 31, 2016 at 06:59:28PM +0100, Hannes Reinecke wrote:
> Switch to using scsi_execute_req_flags() instead of using the
> block primitives.
__scsi_execute adds RQF_QUIET and RQF_PREEMPT to the request flags, which
would be a change in behavior. A little analysis on why that's safe or
eve
A little warning: scsi_execute_req_flags grew a new argument in the block
tree to be able to specify the request-only flags. So any of these
patches would create a (mostly harmless) conflict in linux-next.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a me
The code at the end of alua_rtpg_work() is as follows:
scsi_device_put(sdev);
kref_put(&pg->kref, release_port_group);
In other words, alua_rtpg_queue() must hold an sdev reference and
a pg reference before queueing rtpg work. If no rtpg work is queued
no additional references sho
This will allow SCSI to have a single blk_mq_ops structure that either
lets the LLDD map the queues to PCIe MSIx vectors or use the default.
Signed-off-by: Christoph Hellwig
Reviewed-by: Hannes Reinecke
Reviewed-by: Johannes Thumshirn
---
block/blk-mq-cpumap.c | 1 +
block/blk-mq.h |
Just hand through the blk-mq map_queues method in the host template.
Signed-off-by: Christoph Hellwig
Reviewed-by: Hannes Reinecke
Reviewed-by: Johannes Thumshirn
---
drivers/scsi/scsi_lib.c | 10 ++
include/scsi/scsi_host.h | 8
2 files changed, 18 insertions(+)
diff --git
Which cleans up a lot of the MSI-X handling, and allows us to use the
PCI IRQ layer provided vector mapping, which we can then expose to blk-mq.
Signed-off-by: Christoph Hellwig
Reviewed-by: Hannes Reinecke
Reviewed-by: Johannes Thumshirn
Acked-by: Don Brace
Tested-by: Don Brace
---
drivers/
In 4.9 I've added support in the interrupt layer to automatically
assign the interrupt affinity at interrupt allocation time, and
expose that information to blk-mq.
This series extents that so that SCSI driver can pass on the information
as well. The SCSI part is fairly trivial, although we need
> "Subhash" == Subhash Jadavani writes:
Subhash> This patch series contains not reviewed changes from patch
Subhash> series #1 ([PATCH v1 00/11] scsi: ufs: bug fixes patch series
Subhash> #1). These bug fixes patch series are intended to bring in
Subhash> important bug fixes required for UFS
> "Jim" == Jim Gill writes:
Jim> VMware prefers to update the module's version number as the driver
Jim> is updated. Would you please update the
Jim> PVSCSI_DRIVER_VERSION_STRING in vmx_pvscsi.h from 1.0.6.0-k to
Jim> 1.0.7.0-k? Otherwise the patch looks fine to us.
Applied to 4.9/scsi-fixe
> "Vivek" == Vivek Gautam writes:
Vivek> These patches cleanup the ufs phy driver to an extent.
Vivek> Subsequent patches will target to clean the phy_init() of these
Vivek> qcom-ufs phy drivers in order to get rid of a number of exported
Vivek> APIs that phy drivers expose for ufs-qcom hcd d
> "Sreekanth" == Sreekanth Reddy writes:
Sreekanth> While merging mpt3sas & mpt2sas code, we posted below patch
Sreekanth> for WarpDrive support,
[...]
Sreekanth> Due to above hunk, we are not initializing raid_device's
Sreekanth> starget for raid volumes, and so during raid disk deletion
S
> "Bart" == Bart Van Assche writes:
Bart,
Bart> Personally I prefer the patch below because that patch does not
Bart> introduce a new variable. This is a patch I started testing four
Bart> weeks ago and it has survived all my ALUA tests so far. Please
Bart> note that I do not know whether my
> "tang" == tang junhui writes:
tang> Reference count of pg leaks in alua_rtpg_work() since kref_put()
tang> is not called to decrease the reference count of pg when the
tang> condition
tang> pg->rtpg_sdev==NULL satisfied (actually it is easy to satisfy), it
tang> would cause memory of pg lea
On Tue, 1 Nov 2016, Michael Schmitz wrote:
> Hi Finn,
>
> Am 01.11.2016 um 12:47 schrieb Finn Thain:
> >
> > On Tue, 1 Nov 2016, Michael Schmitz wrote:
> >
> >>> I had tried to set that bit in zorro_esp_slave_configure but had not
> >>> done a proper job of it - I'd only set esp->config3 and
Hi Finn,
Am 01.11.2016 um 12:47 schrieb Finn Thain:
>
> On Tue, 1 Nov 2016, Michael Schmitz wrote:
>
>>> I had tried to set that bit in zorro_esp_slave_configure but had not
>>> done a proper job of it - I'd only set esp->config3 and forgot to set
>>> tp->esp_config3. Time to retest this ...
>
48 matches
Mail list logo
