Re: [PATCH] block: Fix kernel panic occurs while creating second raid disk

2016-11-02 Thread Sreekanth Reddy
On Tue, Nov 1, 2016 at 11:52 PM, Douglas Miller wrote: > On 10/24/2016 01:54 PM, Sreekanth Reddy wrote: >> >> Observing below kernel panic while creating second raid disk >> on LSI SAS3008 HBA card. >> >> [ +0.55] [ cut here ] >> [

Xmas Offer

2016-11-02 Thread Mrs Julie Leach
You are a recipient to Mrs Julie Leach Donation of $3 million USD. Contact ( julieleac...@gmail.com) for claims. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 1/6] NCR5380: Use probe_irq_*() for IRQ probing

2016-11-02 Thread Finn Thain
On Wed, 2 Nov 2016, Ondrej Zary wrote: > On Wednesday 02 November 2016, Finn Thain wrote: > > On Mon, 31 Oct 2016, Ondrej Zary wrote: > > > > > + NCR5380_write(SELECT_ENABLE_REG, hostdata->id_mask); > > > + NCR5380_write(OUTPUT_DATA_REG, hostdata->id_mask); > > > +

Re: [PATCH 4/6] g_NCR5380: Add IRQ auto-configuration for HP C2502

2016-11-02 Thread Finn Thain
On Wed, 2 Nov 2016, Ondrej Zary wrote: > > Also, you've ignored the irq module parameters. From the user's point > > of view, surely the least surprising thing is to attempt to configure > > the card for whatever irq the user asked for. > > I haven't. NCR5380_find_irq is only called when irq

Re: [PATCH 2/6] g_NCR5380: Test the IRQ before accepting it

2016-11-02 Thread Finn Thain
On Wed, 2 Nov 2016, Ondrej Zary wrote: > On Wednesday 02 November 2016 08:45:26 Finn Thain wrote: > > On Mon, 31 Oct 2016, Ondrej Zary wrote: > > > Trigger an IRQ first with a test IRQ handler to find out if it > > > really works. Disable the IRQ if not. > > > > > > This prevents hang when

Question about latest PM80xx driver

2016-11-02 Thread Duc Dang
Hi Jack, Lindar and All, I was testing Adaptec PMC-Sierra PM8018 SAS HBA [Series 7H] card [9005:8088] with our ARM64 server SoC and occasionally saw a hang in pm8001_pci_probe. It looks like the driver was trying to read nvmd information (using get_nvmd_req) and wait for completion but the

Re: [PATCH 1/3] scsi_dh_rdac: switch to scsi_execute_req_flags()

2016-11-02 Thread Hannes Reinecke
On 11/02/2016 04:44 PM, Ewan D. Milne wrote: On Tue, 2016-11-01 at 22:49 +0100, Hannes Reinecke wrote: ... static int get_lun_info(struct scsi_device *sdev, struct rdac_dh_data *h, char *array_name, u8 *array_id) { - int err, i; - struct c8_inquiry *inqp; +

Re: [PATCH v5 0/14] Fix race conditions related to stopping block layer queues

2016-11-02 Thread Bart Van Assche
On 11/02/2016 01:08 PM, Jens Axboe wrote: Bart, I have applied the series, except patches 11+12. I don't mind taking them through the block tree, but they can go through the SCSI tree as well. Let me know what folks think. Hello Jens, Thanks for having applied this patch series. I will resend

Re: [PATCH 2/6] g_NCR5380: Test the IRQ before accepting it

2016-11-02 Thread Ondrej Zary
On Wednesday 02 November 2016 08:45:26 Finn Thain wrote: > On Mon, 31 Oct 2016, Ondrej Zary wrote: > > Trigger an IRQ first with a test IRQ handler to find out if it really > > works. Disable the IRQ if not. > > > > This prevents hang when incorrect IRQ was specified by user. > > Once again, how

Re: [PATCH v5 0/14] Fix race conditions related to stopping block layer queues

2016-11-02 Thread Jens Axboe
On 10/28/2016 06:18 PM, Bart Van Assche wrote: Hello Jens, Multiple block drivers need the functionality to stop a request queue and to wait until all ongoing request_fn() / queue_rq() calls have finished without waiting until all outstanding requests have finished. Hence this patch series that

Re: [PATCH 1/3] scsi_dh_rdac: switch to scsi_execute_req_flags()

2016-11-02 Thread Ewan D. Milne
On Tue, 2016-11-01 at 22:49 +0100, Hannes Reinecke wrote: ... > static int get_lun_info(struct scsi_device *sdev, struct rdac_dh_data *h, > char *array_name, u8 *array_id) > { > - int err, i; > - struct c8_inquiry *inqp; > + int err = SCSI_DH_IO, i; > +

Re: [PATCH v5 0/14] Fix race conditions related to stopping block layer queues

2016-11-02 Thread Christoph Hellwig
Hi Bart, this whole series looks great to me: Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3] scsi_dh_hp_sw: switch to scsi_execute_req_flags()

2016-11-02 Thread Christoph Hellwig
> + switch (sshdr.sense_key) { > + case NOT_READY: > + if ((sshdr.asc == 0x04) && (sshdr.ascq == 3)) { No need for the inner braces. Otherwise looks fine: Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line

Re: [PATCH 2/3] scsi_dh_emc: switch to scsi_execute_req_flags()

2016-11-02 Thread Christoph Hellwig
On Tue, Nov 01, 2016 at 10:49:37PM +0100, Hannes Reinecke wrote: > Switch to scsi_execute_req_flags() instead of > using the block interface directly. This will set ... and scsi_get_vpd_page() > + if ((sshdr->sense_key == 0x05) && (sshdr->asc == 0x04) && > + (sshdr->ascq == 0x00)) {

Re: [PATCH 1/3] scsi_dh_rdac: switch to scsi_execute_req_flags()

2016-11-02 Thread Christoph Hellwig
On Tue, Nov 01, 2016 at 10:49:36PM +0100, Hannes Reinecke wrote: > Switch to scsi_execute_req_flags() instead of > using the block interface directly. This will set > REQ_QUIET and REQ_PREEMPT, but this is okay as > we're evaluating the errors anyway and should be > able to send the command even

Re: [PATCH] scsi: mpt3sas: fix some spelling mistakes in message and comments

2016-11-02 Thread Laurence Oberman
- Original Message - > From: "Alexander Alemayhu" > To: "Colin King" > Cc: "Sathya Prakash" , "Chaitra P B" > , "Suganath Prabu > Subramani"

Re: [PATCH] scsi: mpt3sas: fix some spelling mistakes in message and comments

2016-11-02 Thread Alexander Alemayhu
On Mon, Oct 31, 2016 at 09:34:46AM -0600, Colin King wrote: > From: Colin Ian King > > Trival fixes, minor spelling mistakes in comments and in a KERN_INFO > message. It's hard to see which words changed. A summary would have been nice, something like: o

RE: [PATCH] megaraid-sas: request irqs later

2016-11-02 Thread Sumit Saxena
>-Original Message- >From: Tomas Henzl [mailto:the...@redhat.com] >Sent: Tuesday, November 01, 2016 10:02 PM >To: linux-scsi@vger.kernel.org >Cc: sumit.sax...@broadcom.com; kashyap.de...@broadcom.com >Subject: [PATCH] megaraid-sas: request irqs later > >It is not good when an irq arrives

Re: [PATCH] [SCSI] mpt3sas: Fix secure erase premature termination (v2)

2016-11-02 Thread Sreekanth Reddy
On Wed, Nov 2, 2016 at 7:37 AM, Hannes Reinecke wrote: > On 11/02/2016 01:09 AM, Andrey Grodzovsky wrote: >> >> Problem: >> This is a work around for a bug with LSI Fusion MPT SAS2 when >> pefroming secure erase. Due to the very long time the operation >> takes commands issued

Re: [PATCH 4/6] g_NCR5380: Add IRQ auto-configuration for HP C2502

2016-11-02 Thread Ondrej Zary
On Wednesday 02 November 2016, Finn Thain wrote: > On Mon, 31 Oct 2016, Ondrej Zary wrote: > > Find free and working IRQ automatically on HP C2502 cards. > > Also allow IRQ 9 to work (aliases to IRQ 2 on the card). > > > > Signed-off-by: Ondrej Zary > > --- > >

Re: [PATCH 1/6] NCR5380: Use probe_irq_*() for IRQ probing

2016-11-02 Thread Ondrej Zary
On Wednesday 02 November 2016, Finn Thain wrote: > On Mon, 31 Oct 2016, Ondrej Zary wrote: > > Use standard probe_irq_on() and probe_irq_off() functions instead of own > > implementation. This prevents warning messages like this in the kernel > > log: genirq: Flags mismatch irq 1.

Re: [PATCH 6/6] g_NCR5380: Fix release region in error handling

2016-11-02 Thread Finn Thain
On Mon, 31 Oct 2016, Ondrej Zary wrote: > When a SW-configurable card is specified but not found, the driver > releases wrong region, causing the following message in kernel log: > Trying to free nonexistent resource <-000f> > > Fix it by assigning base earlier. > >

Re: [PATCH 5/6] g_NCR5380: Autoprobe IRQ by default

2016-11-02 Thread Finn Thain
On Mon, 31 Oct 2016, Ondrej Zary wrote: > IRQ probing seems to work fine now. Default to autoprobe for IRQ instead > of disabling it. > > Signed-off-by: Ondrej Zary > --- > drivers/scsi/g_NCR5380.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >

Re: [PATCH 4/6] g_NCR5380: Add IRQ auto-configuration for HP C2502

2016-11-02 Thread Finn Thain
On Mon, 31 Oct 2016, Ondrej Zary wrote: > Find free and working IRQ automatically on HP C2502 cards. > Also allow IRQ 9 to work (aliases to IRQ 2 on the card). > > Signed-off-by: Ondrej Zary > --- > drivers/scsi/g_NCR5380.c | 29 +++-- > 1

Re: [PATCH 2/6] g_NCR5380: Test the IRQ before accepting it

2016-11-02 Thread Finn Thain
On Mon, 31 Oct 2016, Ondrej Zary wrote: > Trigger an IRQ first with a test IRQ handler to find out if it really > works. Disable the IRQ if not. > > This prevents hang when incorrect IRQ was specified by user. > Once again, how does it cause a hang? If the user specifies an IRQ, we should

Re: [PATCH 3/6] g_NCR5380: Check for chip presence before calling NCR5380_init()

2016-11-02 Thread Finn Thain
On Mon, 31 Oct 2016, Ondrej Zary wrote: > Write and read back MODE_REG to check if the chip is really there > before doing more initialization. > > This prevents hang when incorrect I/O address was specified by user (in > the most common case where no device is present there so all reads >

Re: [PATCH 1/6] NCR5380: Use probe_irq_*() for IRQ probing

2016-11-02 Thread Finn Thain
On Mon, 31 Oct 2016, Ondrej Zary wrote: > Use standard probe_irq_on() and probe_irq_off() functions instead of own > implementation. This prevents warning messages like this in the kernel > log: genirq: Flags mismatch irq 1. (NCR-probe) vs. 0080 > (i8042) > > Move the IRQ

Re: [PATCH v3 09/12] ufs-qcom: phy/hcd: Refactoring phy clock handling

2016-11-02 Thread Vivek Gautam
Hi Subhash, On Wed, Nov 2, 2016 at 12:17 AM, Subhash Jadavani wrote: > On 2016-10-29 13:22, Vivek Gautam wrote: >> >> Add phy clock enable code to phy_power_on/off callbacks, and >> remove explicit calls to enable these phy clocks from the >> ufs-qcom hcd driver. >> >>