Hi Zhu & Co,
Thanks for the detailed logs. Comments below.
On Mon, 2016-10-31 at 16:51 +0800, Zhu Lingshan wrote:
> Hi Nicholas,
>
> (sorry it would be a long mail)
>
> Sorry for the delay, I spent some test and debug work. I find the patch
> http://www.spinics.net/lists/target-devel/msg13530
On 2016-11-01 11:42, Subhash Jadavani wrote:
On 2016-10-29 13:22, Vivek Gautam wrote:
The tx_iface_clk and rx_iface_clk no longer exist with UFS Phy
present on msm8996. So skip obtaining these clocks using
compatible match.
Signed-off-by: Vivek Gautam
---
New patch in v3 of this cleanup serie
On 2016-11-03 10:07, Vivek Gautam wrote:
Hi,
On Tue, Nov 1, 2016 at 2:41 AM, Subhash Jadavani
wrote:
On 2016-10-29 13:22, Vivek Gautam wrote:
Add a new compatible string for 14nm ufs phy present on msm8996
chipset. This phy is bit different from the legacy 14nm ufs phy
in terms of the clock
On 2016-11-03 10:30, Vivek Gautam wrote:
Add phy clock enable code to phy_power_on/off callbacks, and
remove explicit calls to enable these phy clocks from the
ufs-qcom hcd driver.
Signed-off-by: Vivek Gautam
---
Changes since v3:
- Moved phy_power_off() under *link not active* check
durin
On Thu, 3 Nov 2016, Ondrej Zary wrote:
> On Thursday 03 November 2016, Finn Thain wrote:
> > On Wed, 2 Nov 2016, Ondrej Zary wrote:
> > >
> > > The card is almost Plug&Play. The base address is already configured
> > > automatically by the driver so doing the same for IRQ makes sense.
> >
> > W
On 10/28/2016 08:08 PM, James Bottomley wrote:
> This is a deadlock caused by an inversion issue in kernfs (suicide vs
> non-suicide removes); so fixing it in SCSI alone really isn't
> appropriate. I count at least five other subsystems all using this
> mechanism, so they'll all be similarly affec
On 10/13/2016 08:00 AM, Johannes Thumshirn wrote:
> fc_bsg_jobdone() and bsg_job_done() are 1:1 copies now so use the bsg-lib one
> instead of the FC private implementation.
>
> Signed-off-by: Johannes Thumshirn
> Reviewed-by: Hannes Reinecke
For ibmvfc parts,
Acked-by: Tyrel Datwyler
--
To
On 10/13/2016 08:00 AM, Johannes Thumshirn wrote:
> Change FC drivers to use 'struct bsg_job' from bsg-lib.h instead of 'struct
> fc_bsg_job' from scsi_transport_fc.h and remove 'struct fc_bsg_job'.
>
> Signed-off-by: Johannes Thumshirn
> Reviewed-by: Hannes Reinecke
For ibmvfc parts,
Acked-by
On 10/13/2016 08:00 AM, Johannes Thumshirn wrote:
> Provide fc_bsg_to_rport() helper that will become handy when we're moving
> from struct fc_bsg_job to a plain struct bsg_job. Also move all LLDDs to use
> the new helper.
>
> Signed-off-by: Johannes Thumshirn
> Reviewed-by: Hannes Reinecke
Fo
On 10/13/2016 08:00 AM, Johannes Thumshirn wrote:
> Provide fc_bsg_to_shost() helper that will become handy when we're moving from
> struct fc_bsg_job to a plain struct bsg_job. Also use this little helper in
> the LLDDs.
>
> Signed-off-by: Johannes Thumshirn
> Reviewed-by: Hannes Reinecke
For
Testing. Please ignore.
Thanks,
Don.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11/03/2016 05:11 PM, Ewan D. Milne wrote:
On Wed, 2016-11-02 at 22:27 +0100, Hannes Reinecke wrote:
On 11/02/2016 04:44 PM, Ewan D. Milne wrote:
In this and other places the patch changes the code from submitting the
INQUIRY/EVPD command for the page it wants, to calling scsi_get_vpd_page().
On 10/13/2016 08:00 AM, Johannes Thumshirn wrote:
> Unify the interfaces of fc_bsg_jobdone and bsg_job_done. This will reduce the
> diff when moving from 'struct fc_bsg_job' to a plain 'struct bsg_job' later
> on.
>
> Signed-off-by: Johannes Thumshirn
> Reviewed-by: Hannes Reinecke
For ibmvfc p
On 10/13/2016 08:00 AM, Johannes Thumshirn wrote:
> Export fc_bsg_jobdone so drivers can use it directly instead of doing
> the round-trip via struct fc_bsg_job::job_done() and use it in the LLDDs.
>
> As we've converted all LLDDs over to use fc_bsg_jobdone() directly,
> we can remove the function
On Thu, Nov 3, 2016 at 1:34 AM, Jinpu Wang wrote:
> Hi Duc,
>
> On Thu, Nov 3, 2016 at 2:02 AM, Duc Dang wrote:
>> Hi Jack, Lindar and All,
>>
>> I was testing Adaptec PMC-Sierra PM8018 SAS HBA [Series 7H] card
>> [9005:8088] with our ARM64 server SoC and occasionally saw a hang in
>> pm8001_pci_
On Thu, Nov 03, 2016 at 08:17:51AM -0700, Christoph Hellwig wrote:
> On Fri, Oct 14, 2016 at 09:38:21AM +0200, Johannes Thumshirn wrote:
> > On Thu, Oct 13, 2016 at 05:55:11PM +0200, Steffen Maier wrote:
> > > Hm, still behaves for me like I reported for v2:
> > > http://marc.info/?l=linux-scsi&m=1
Add phy clock enable code to phy_power_on/off callbacks, and
remove explicit calls to enable these phy clocks from the
ufs-qcom hcd driver.
Signed-off-by: Vivek Gautam
---
Changes since v3:
- Moved phy_power_off() under *link not active* check
during aggressive clock gating.
Changes since v
Hi,
On Tue, Nov 1, 2016 at 2:41 AM, Subhash Jadavani
wrote:
> On 2016-10-29 13:22, Vivek Gautam wrote:
>>
>> Add a new compatible string for 14nm ufs phy present on msm8996
>> chipset. This phy is bit different from the legacy 14nm ufs phy
>> in terms of the clocks that are needed to be handled
On Wed, 2016-11-02 at 22:27 +0100, Hannes Reinecke wrote:
> On 11/02/2016 04:44 PM, Ewan D. Milne wrote:
> > In this and other places the patch changes the code from submitting the
> > INQUIRY/EVPD command for the page it wants, to calling scsi_get_vpd_page().
> > scsi_get_vpd_page() will return -E
On Fri, Oct 14, 2016 at 09:38:21AM +0200, Johannes Thumshirn wrote:
> On Thu, Oct 13, 2016 at 05:55:11PM +0200, Steffen Maier wrote:
> > Hm, still behaves for me like I reported for v2:
> > http://marc.info/?l=linux-scsi&m=147637177902937&w=2
>
> Hi Steffen,
>
> Can you please try the following o
On Thu, Oct 13, 2016 at 05:00:20PM +0200, Johannes Thumshirn wrote:
> Unify the interfaces of fc_bsg_jobdone and bsg_job_done. This will reduce the
> diff when moving from 'struct fc_bsg_job' to a plain 'struct bsg_job' later
> on.
>
> Signed-off-by: Johannes Thumshirn
> Reviewed-by: Hannes Reine
On Thu, Oct 13, 2016 at 05:00:19PM +0200, Johannes Thumshirn wrote:
> Export fc_bsg_jobdone so drivers can use it directly instead of doing
> the round-trip via struct fc_bsg_job::job_done() and use it in the LLDDs.
>
> As we've converted all LLDDs over to use fc_bsg_jobdone() directly,
> we can r
On Thu, Oct 13, 2016 at 05:00:17PM +0200, Johannes Thumshirn wrote:
> struct fc_bsg_buffer is just a clone of struct bsg_buffer from bsg-lib,
> so use this one instead.
>
> Signed-off-by: Johannes Thumshirn
> Reviewed-by: Hannes Reinecke
Looks good,
Reviewed-by: Christoph Hellwig
--
To unsubs
The following patch introduces an annoying WARN
when a device is removed from the SAS topology:
[SCSI] libsas: prevent domain rediscovery competing with ata error handling
A sample WARN is as follows:
[ 236.842227] WARNING: CPU: 7 PID: 1520 at fs/sysfs/group.c:237
sysfs_remove_group+0x90/0x98
[
-scsi_execute_req_flags/20161103-212623
base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
config: i386-randconfig-x014-201644 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make
-scsi_execute_req_flags/20161103-212623
base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
config: i386-randconfig-i0-201644 (attached as .config)
compiler: gcc-4.8 (Debian 4.8.4-1) 4.8.4
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All
Switch to scsi_execute_req_flags() instead of
using the block interface directly. This will set
REQ_QUIET and REQ_PREEMPT, but this is okay as
we're evaluating the errors anyway and should be
able to send the command even if the device is
quiesced.
Switch to scsi_execute_req_flags() instead of
usin
Hi all,
here's a patchset to switch to scsi_execute_req_flags() for
all SCSI device handlers. Originally we would be using
blk_execute_rq_nowait to allow the 'activate' function
to run asynchronously.
However, as we're now calling the 'activate' function
synchronously there's no point in using the
Switch to scsi_execute_req_flags() and
scsi_get_vpd_page() instead of open-coding it.
Using scsi_execute_req_flags() will set
REQ_QUIET and REQ_PREEMPT, but this is okay as
we're evaluating the errors anyway and should be
able to send the command even if the device is
quiesced.
Signed-off-by: Hann
Switch to scsi_execute_req_flags() and
scsi_get_vpd_page() instead of open-coding it.
Using scsi_execute_req_flags() will set
REQ_QUIET and REQ_PREEMPT, but this is okay as
we're evaluating the errors anyway and should be
able to send the command even if the device is
quiesced.
Signed-off-by: Hann
On 11/02/2016 04:06 PM, Christoph Hellwig wrote:
On Tue, Nov 01, 2016 at 10:49:36PM +0100, Hannes Reinecke wrote:
Switch to scsi_execute_req_flags() instead of
using the block interface directly. This will set
REQ_QUIET and REQ_PREEMPT, but this is okay as
we're evaluating the errors anyway and
Hi Duc,
On Thu, Nov 3, 2016 at 2:02 AM, Duc Dang wrote:
> Hi Jack, Lindar and All,
>
> I was testing Adaptec PMC-Sierra PM8018 SAS HBA [Series 7H] card
> [9005:8088] with our ARM64 server SoC and occasionally saw a hang in
> pm8001_pci_probe. It looks like the driver was trying to read nvmd
> inf
On Thursday 03 November 2016, Finn Thain wrote:
> On Wed, 2 Nov 2016, Ondrej Zary wrote:
> > > Also, you've ignored the irq module parameters. From the user's point
> > > of view, surely the least surprising thing is to attempt to configure
> > > the card for whatever irq the user asked for.
> >
>
33 matches
Mail list logo