RE: [PATCH] scsi_devinfo: remove synchronous ALUA for NETAPP/RDAC devices

2016-11-08 Thread George, Martin
As discussed with Hannes, this is not required for ONTAP's LUN C-Mode as well. So the ALUA blacklisting may be removed here as well, and not just for NetApp RDAC. -Martin -Original Message- From: Hannes Reinecke [mailto:h...@suse.de] Sent: Wednesday, November 9, 2016 12:20 PM To: Xose

Re: [PATCH] scsi_devinfo: remove synchronous ALUA for NETAPP/RDAC devices

2016-11-08 Thread Hannes Reinecke
On 11/08/2016 08:32 PM, Xose Vazquez Perez wrote: NetApp did confirm this is only required for ONTAP(LUN C-Mode). Cc: Martin George Cc: Robert Stankey Cc: Steven Schremmer Cc: Sean Stewart

RE: [PATCH v1] ufs: introcude UFSHCD_QUIRK_GET_VS_RESULT quirk

2016-11-08 Thread Kiwoong Kim
> > Some UFS host controllers may not report a result of UIC command > > completion properly. > > In such cases, they should get the result from UIC directly if their > > architectures support that. > > > > Signed-off-by: Kiwoong Kim > > --- > > drivers/scsi/ufs/ufshcd.c |

RE: [PATCH v1] ufs: introduce setup_hibern8 callback

2016-11-08 Thread Kiwoong Kim
> > Some UFS host controller may need to configure some things around > > hibern8 enter/exit > > > > Signed-off-by: Kiwoong Kim > > --- > > drivers/scsi/ufs/ufshcd.c | 10 -- drivers/scsi/ufs/ufshcd.h > > | 10 ++ > > 2 files changed, 18 insertions(+), 2

RE: [PATCH v1] ufs: introduce setup_xfer_req callback

2016-11-08 Thread Kiwoong Kim
> > Some UFS host controller may need to configure some things before any > > transfer request is issued. > > > > Signed-off-by: Kiwoong Kim > > --- > > drivers/scsi/ufs/ufshcd.c | 2 ++ > > drivers/scsi/ufs/ufshcd.h | 10 ++ > > 2 files changed, 12 insertions(+)

RE: [PATCH v1] ufs: introduce setup_task_mgmt

2016-11-08 Thread Kiwoong Kim
> > Some UFS host controller may need to configure some things before any > > task management request is issued > > > > Signed-off-by: Kiwoong Kim > > --- > > drivers/scsi/ufs/ufshcd.c | 1 + > > drivers/scsi/ufs/ufshcd.h | 10 ++ > > 2 files changed, 11

RE: [PATCH v1] ufs: introduce UFSHCI_QUIRK_SKIP_INTR_AGGR quirk

2016-11-08 Thread Kiwoong Kim
> > If UFS driver resets interrupt aggregation timer and counter > > when there is a pending doorbell, an interrupt of IO completion > > of a corresponding task may be missed. > > That would cause a command timeout. > > > > If UFS driver resets interrupt aggregation timer and counter > > when

RE: [PATCH v1] ufs: add a variety of definitions decribed in UFS spec

2016-11-08 Thread Kiwoong Kim
> > These things are defined to be used by some UFS Host controllers. > > > > Signed-off-by: Kiwoong Kim > > --- > > drivers/scsi/ufs/mphy.h | 38 ++ > > drivers/scsi/ufs/ufshci.h | 14 +++--- > > drivers/scsi/ufs/unipro.h | 24

Re: [PATCH 1/1] iscsi: fix regression caused by session lock patch

2016-11-08 Thread Chris Leech
On Mon, Nov 07, 2016 at 04:23:10PM -0200, Guilherme G. Piccoli wrote: > > Sure! Count on us to test any patches. I guess the first step is to > reproduce on upstream right? We haven't tested specifically this > scenario for long time. Will try to reproduce on 4.9-rc4 and update here. Great, I'm

Re: [PATCH v5 00/12] ufs-qcom: phy/hcd: Clean up qcom-ufs phy and ufs-qcom hcd

2016-11-08 Thread Vivek Gautam
On Wed, Nov 9, 2016 at 4:36 AM, Martin K. Petersen wrote: >> "Vivek" == Vivek Gautam writes: > > Vivek> Here's the rebased version of patches based on 4.10/scsi-queue > Vivek> branch as requested. The patches can now be applied and >

Re: Need some pointers to debug a target hang

2016-11-08 Thread Zhu Lingshan
On 11/04/2016 02:52 PM, Nicholas A. Bellinger wrote: Hi Zhu & Co, Thanks for the detailed logs. Comments below. On Mon, 2016-10-31 at 16:51 +0800, Zhu Lingshan wrote: Hi Nicholas, (sorry it would be a long mail) Sorry for the delay, I spent some test and debug work. I find the patch

Re: [REGRESSION] 4.9-rc4+ doesn't boot on my test box

2016-11-08 Thread Martin K. Petersen
> "Kashyap" == Kashyap Desai writes: Kashyap, >> Send a fix on top of current -git asap. The current tree is >> completely broken for any megaraid user. -rc4 is no time to send in >> untested patches, especially not something that claims to fix a 9 >> year old

RE: [PATCH v1] ufs: introduce UFSHCD_QUIRK_BROKEN_DWORD_UTRD quirk

2016-11-08 Thread Kiwoong Kim
> > Some UFS host controllers may think > > granularitys of PRDT length and offset as bytes, not double words. > > > > Signed-off-by: Kiwoong Kim > > --- > > drivers/scsi/ufs/ufshcd.c | 24 +++- > > drivers/scsi/ufs/ufshcd.h | 2 ++ > > 2 files changed,

RE: [REGRESSION] 4.9-rc4+ doesn't boot on my test box

2016-11-08 Thread Kashyap Desai
> -Original Message- > From: Jens Axboe [mailto:ax...@kernel.dk] > Sent: Wednesday, November 09, 2016 6:50 AM > To: Kashyap Desai; Martin K. Petersen > Cc: linux-scsi > Subject: Re: [REGRESSION] 4.9-rc4+ doesn't boot on my test box > > On 11/08/2016 05:20 PM, Kashyap Desai wrote: > >>

RE: [PATCH v1] ufs: introduce UFSHCD_QUIRK_USE_OF_HCE quirk

2016-11-08 Thread Kiwoong Kim
> On 2016-11-07 23:57, Kiwoong Kim wrote: > > Some host controller might not initialize itself by setting "Host > > Controller Enable" to 1. > > > They should do this to reset UIC. > > I am not sure if i understood this statment. can you give more details? UFSHCI spec says as follows: - When

Re: [PATCH] Avoid that SCSI device removal through sysfs triggers a deadlock

2016-11-08 Thread Eric W. Biederman
James Bottomley writes: > On Tue, 2016-11-08 at 18:57 -0600, Eric W. Biederman wrote: >> James Bottomley writes: >> >> > On Tue, 2016-11-08 at 13:13 -0600, Eric W. Biederman wrote: > [...] >> > > Is it really the dropping of the lock that is

Re: [PATCH] Avoid that SCSI device removal through sysfs triggers a deadlock

2016-11-08 Thread James Bottomley
On Tue, 2016-11-08 at 18:57 -0600, Eric W. Biederman wrote: > James Bottomley writes: > > > On Tue, 2016-11-08 at 13:13 -0600, Eric W. Biederman wrote: [...] > > > Is it really the dropping of the lock that is causing this? > > > I don't see that when I read those

RE: [PATCH v2 2/2] scsi: ufs: Use the resource-managed function to add devfreq device

2016-11-08 Thread MyungJoo Ham
> This patch uses the resource-managed to add the devfreq device. > This function will make it easy to handle the devfreq device. > > - struct devfreq *devm_devfreq_add_device(struct device *dev, > struct devfreq_dev_profile *profile, >

Re: [PATCH] Avoid that SCSI device removal through sysfs triggers a deadlock

2016-11-08 Thread Eric W. Biederman
Bart Van Assche writes: > On 11/08/2016 11:15 AM, Eric W. Biederman wrote: >> James Bottomley writes: >> >>> On Tue, 2016-11-08 at 08:52 -0800, Bart Van Assche wrote: On 11/08/2016 07:28 AM, James Bottomley wrote: > On Mon,

Re: [REGRESSION] 4.9-rc4+ doesn't boot on my test box

2016-11-08 Thread Jens Axboe
On 11/08/2016 05:20 PM, Kashyap Desai wrote: -Original Message- From: Martin K. Petersen [mailto:martin.peter...@oracle.com] Sent: Wednesday, November 09, 2016 4:45 AM To: Jens Axboe Cc: linux-scsi; Kashyap Desai; Martin K. Petersen Subject: Re: [REGRESSION] 4.9-rc4+ doesn't boot on my

Re: [PATCH] Avoid that SCSI device removal through sysfs triggers a deadlock

2016-11-08 Thread Eric W. Biederman
James Bottomley writes: > On Tue, 2016-11-08 at 13:13 -0600, Eric W. Biederman wrote: >> James Bottomley writes: >> >> > On Tue, 2016-11-08 at 08:52 -0800, Bart Van Assche wrote: >> > > On 11/08/2016 07:28 AM, James Bottomley wrote: >> > > > On

RE: [REGRESSION] 4.9-rc4+ doesn't boot on my test box

2016-11-08 Thread Kashyap Desai
> -Original Message- > From: Martin K. Petersen [mailto:martin.peter...@oracle.com] > Sent: Wednesday, November 09, 2016 4:45 AM > To: Jens Axboe > Cc: linux-scsi; Kashyap Desai; Martin K. Petersen > Subject: Re: [REGRESSION] 4.9-rc4+ doesn't boot on my test box > > > "Jens" == Jens

Re: [PATCH v2 2/2] scsi: ufs: Use the resource-managed function to add devfreq device

2016-11-08 Thread Martin K. Petersen
> "Chanwoo" == Chanwoo Choi writes: Chanwoo> This patch uses the resource-managed to add the devfreq device. Chanwoo> This function will make it easy to handle the devfreq device. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To

Re: [PATCH 0/2] qla2xxx: fix errors in PCI device remove with ongoing I/O

2016-11-08 Thread Martin K. Petersen
> "Mauricio" == Mauricio Faria de Oliveira > writes: Mauricio> This patchset addresses a couple of errors that might happen Mauricio> during PCI device remove (e.g., PCI hotplug, PowerVM DLPAR), Mauricio> which prevent the successful removal and re-addition

Re: [PATCH 4.9/scsi-fixes] libcxgbi: fix incorrect DDP resource cleanup

2016-11-08 Thread Martin K. Petersen
> "Varun" == Varun Prakash writes: Varun> Before calling task_release_itt() task data is memset to zero Varun> because of which DDP context information is lost resulting in Varun> incorrect DDP resource cleanup, to fix this call Varun> task_release_itt() before memset.

Re: [PATCH v2 3/6] qedi: Add QLogic FastLinQ offload iSCSI driver framework.

2016-11-08 Thread Martin K. Petersen
> "Arun" == Arun Easi writes: >> It's fine to post the patches split up to ease the review >> process. But whatever we commit must obviously be bisectable. Arun> If it is alright with you, we would like to have all of our Arun> initial patches for the driver (qedi)

Re: [PATCH v2 3/6] qedi: Add QLogic FastLinQ offload iSCSI driver framework.

2016-11-08 Thread Arun Easi
Martin, On Tue, 8 Nov 2016, 3:49pm -, Martin K. Petersen wrote: > > "Arun" == Arun Easi writes: > > Arun, > > Arun> qedi is the new iSCSI driver, which we are trying to submit, for > Arun> our 41000 series CNA. This patch series were broken up into > Arun>

Re: [PATCH v2 3/6] qedi: Add QLogic FastLinQ offload iSCSI driver framework.

2016-11-08 Thread Martin K. Petersen
> "Arun" == Arun Easi writes: Arun, Arun> qedi is the new iSCSI driver, which we are trying to submit, for Arun> our 41000 series CNA. This patch series were broken up into Arun> logical blocks for review purpose, but were not made to compile Arun> individually. It is

Re: Ordering problems with 3ware controller

2016-11-08 Thread Martin K. Petersen
> "Paul" == Paul Menzel writes: Paul, Paul> Updating from Linux 4.4.X to Linux 4.8.4, we noticed that the Paul> 3ware devices under `/dev` – `/dev/twa0`, `/dev/twa1`, … – map to Paul> the controllers differently. Paul> This unfortunately breaks quite a lot of our

Re: [PATCH] Avoid that SCSI device removal through sysfs triggers a deadlock

2016-11-08 Thread James Bottomley
On Tue, 2016-11-08 at 13:13 -0600, Eric W. Biederman wrote: > James Bottomley writes: > > > On Tue, 2016-11-08 at 08:52 -0800, Bart Van Assche wrote: > > > On 11/08/2016 07:28 AM, James Bottomley wrote: > > > > On Mon, 2016-11-07 at 16:32 -0800, Bart Van Assche wrote: >

Re: [PATCH v2 3/6] qedi: Add QLogic FastLinQ offload iSCSI driver framework.

2016-11-08 Thread Arun Easi
[also build test ERROR on v4.9-rc4] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Manish-Rangankar/qed-Add-support-for-hardware-offloaded-iSCSI/20161108-180027 > config: i

Re: [PATCH] Avoid that SCSI device removal through sysfs triggers a deadlock

2016-11-08 Thread Bart Van Assche
On 11/08/2016 11:15 AM, Eric W. Biederman wrote: James Bottomley writes: On Tue, 2016-11-08 at 08:52 -0800, Bart Van Assche wrote: On 11/08/2016 07:28 AM, James Bottomley wrote: On Mon, 2016-11-07 at 16:32 -0800, Bart Van Assche wrote: diff --git a/fs/kernfs/dir.c

Re: [PATCH] scsi: fix spelling mistake in error message

2016-11-08 Thread Martin K. Petersen
> "Colin" == Colin King writes: Colin> From: Colin Ian King Trivial fix to Colin> spelling mistake "operatio" to "operation" in critical error Colin> message Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux

Re: [REGRESSION] 4.9-rc4+ doesn't boot on my test box

2016-11-08 Thread Martin K. Petersen
> "Jens" == Jens Axboe writes: Jens> I wasted half a day on this, thinking it was something in my Jens> 4.10 branches. But it turns out it is not, the regression is in Jens> mainline. Kashyap, have you tested the stable fix without the remainder of the driver update in

Re: [PATCH v5 00/12] ufs-qcom: phy/hcd: Clean up qcom-ufs phy and ufs-qcom hcd

2016-11-08 Thread Martin K. Petersen
> "Vivek" == Vivek Gautam writes: Vivek> Here's the rebased version of patches based on 4.10/scsi-queue Vivek> branch as requested. The patches can now be applied and Vivek> pulled-in. Thanks! Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle

Re: [PATCH v3 8/8] megaraid_sas: driver version upgrade

2016-11-08 Thread Martin K. Petersen
> "Kashyap" == Kashyap Desai writes: Rebased on top of Linus' tree to get the JBOD SYNCHRONIZE CACHE fix pulled in and applied patches 5 through 8 to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the

Re: [PATCH v2 2/2] scsi: ufs: Use the resource-managed function to add devfreq device

2016-11-08 Thread Subhash Jadavani
On 2016-11-08 01:16, Chanwoo Choi wrote: This patch uses the resource-managed to add the devfreq device. This function will make it easy to handle the devfreq device. - struct devfreq *devm_devfreq_add_device(struct device *dev, struct devfreq_dev_profile

Re: [PATCH v1] ufs: add a variety of definitions decribed in UFS spec

2016-11-08 Thread Subhash Jadavani
On 2016-11-08 00:00, Kiwoong Kim wrote: These things are defined to be used by some UFS Host controllers. Signed-off-by: Kiwoong Kim --- drivers/scsi/ufs/mphy.h | 38 ++ drivers/scsi/ufs/ufshci.h | 14 +++---

Re: [PATCH v1] ufs: introduce UFSHCI_QUIRK_SKIP_INTR_AGGR quirk

2016-11-08 Thread Subhash Jadavani
On 2016-11-07 23:59, Kiwoong Kim wrote: If UFS driver resets interrupt aggregation timer and counter when there is a pending doorbell, an interrupt of IO completion of a corresponding task may be missed. That would cause a command timeout. If UFS driver resets interrupt aggregation timer and

Re: [PATCH v1] ufs: introduce UFSHCD_QUIRK_USE_OF_HCE quirk

2016-11-08 Thread Subhash Jadavani
On 2016-11-07 23:57, Kiwoong Kim wrote: Some host controller might not initialize itself by setting "Host Controller Enable" to 1. They should do this to reset UIC. I am not sure if i understood this statment. can you give more details? In such cases, 'DME reset' and 'DME enable' are

Re: [PATCH v1] ufs: introduce UFSHCD_QUIRK_BROKEN_REQ_LIST_CLR quirk

2016-11-08 Thread Subhash Jadavani
On 2016-11-07 23:50, Kiwoong Kim wrote: Some UFS host controllers may clear a transfer request slot by setting an associated bit in UTLRCLR/UTMLRCLR to 1, not 0. s/UTLRCLR/UTRLCLR s/UTMLRCLR/UTMRLCLR That's opposite to what UFS spec decribes. Signed-off-by: Kiwoong Kim

Re: [PATCH v1] ufs: introduce UFSHCD_QUIRK_BROKEN_DWORD_UTRD quirk

2016-11-08 Thread Subhash Jadavani
On 2016-11-07 23:49, Kiwoong Kim wrote: Some UFS host controllers may think granularitys of PRDT length and offset as bytes, not double words. Signed-off-by: Kiwoong Kim --- drivers/scsi/ufs/ufshcd.c | 24 +++- drivers/scsi/ufs/ufshcd.h | 2 ++ 2

[PATCH] scsi_devinfo: remove synchronous ALUA for NETAPP/RDAC devices

2016-11-08 Thread Xose Vazquez Perez
NetApp did confirm this is only required for ONTAP(LUN C-Mode). Cc: Martin George Cc: Robert Stankey Cc: Steven Schremmer Cc: Sean Stewart Cc: Hannes Reinecke Cc:

Re: [PATCH v1] ufs: introcude UFSHCD_QUIRK_GET_VS_RESULT quirk

2016-11-08 Thread Subhash Jadavani
On 2016-11-07 23:48, Kiwoong Kim wrote: Some UFS host controllers may not report a result of UIC command completion properly. In such cases, they should get the result from UIC directly if their architectures support that. Signed-off-by: Kiwoong Kim ---

Re: [PATCH] Avoid that SCSI device removal through sysfs triggers a deadlock

2016-11-08 Thread Eric W. Biederman
James Bottomley writes: > On Tue, 2016-11-08 at 08:52 -0800, Bart Van Assche wrote: >> On 11/08/2016 07:28 AM, James Bottomley wrote: >> > On Mon, 2016-11-07 at 16:32 -0800, Bart Van Assche wrote: >> > > diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c >> > > index

Re: [PATCH 2/4] qla2xxx: Fix mailbox command timeout due to starvation

2016-11-08 Thread Madhani, Himanshu
Hi Ewan, On 11/7/16, 7:53 AM, "Ewan D. Milne" wrote: >On Fri, 2016-11-04 at 09:33 -0700, himanshu.madh...@cavium.com wrote: >... >> @@ -2349,6 +2349,17 @@ uint32_t qla2x00_isp_reg_stat(struct qla_hw_data *ha) >> return atomic_read(>loop_state) == LOOP_READY; >> } >>

Re: [PATCH 3/4] qla2xxx: Add Block Multi Queue functionality.

2016-11-08 Thread Madhani, Himanshu
Hi Ewan, On 11/7/16, 8:43 AM, "Ewan D. Milne" wrote: >On Fri, 2016-11-04 at 09:33 -0700, himanshu.madh...@cavium.com wrote: >> From: Michael Hernandez >> >> Tell the SCSI layer how many hardware queues we have based on the >> number of max

Re: [PATCH v1] ufs: introduce setup_hibern8 callback

2016-11-08 Thread Subhash Jadavani
On 2016-11-07 23:48, Kiwoong Kim wrote: Some UFS host controller may need to configure some things around hibern8 enter/exit Signed-off-by: Kiwoong Kim --- drivers/scsi/ufs/ufshcd.c | 10 -- drivers/scsi/ufs/ufshcd.h | 10 ++ 2 files changed, 18

Re: [PATCH v1] ufs: introduce setup_task_mgmt

2016-11-08 Thread Subhash Jadavani
On 2016-11-07 23:47, Kiwoong Kim wrote: Some UFS host controller may need to configure some things before any task management request is issued Signed-off-by: Kiwoong Kim --- drivers/scsi/ufs/ufshcd.c | 1 + drivers/scsi/ufs/ufshcd.h | 10 ++ 2 files changed,

Re: [PATCH v1] ufs: introduce setup_xfer_req callback

2016-11-08 Thread Subhash Jadavani
On 2016-11-07 23:45, Kiwoong Kim wrote: Some UFS host controller may need to configure some things before any transfer request is issued. Signed-off-by: Kiwoong Kim --- drivers/scsi/ufs/ufshcd.c | 2 ++ drivers/scsi/ufs/ufshcd.h | 10 ++ 2 files changed, 12

Re: [PATCH] Avoid that SCSI device removal through sysfs triggers a deadlock

2016-11-08 Thread James Bottomley
On Tue, 2016-11-08 at 08:52 -0800, Bart Van Assche wrote: > On 11/08/2016 07:28 AM, James Bottomley wrote: > > On Mon, 2016-11-07 at 16:32 -0800, Bart Van Assche wrote: > > > diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c > > > index cf4c636..44ec536 100644 > > > --- a/fs/kernfs/dir.c > > > +++

Re: [PATCH 0/2] qla2xxx: fix errors in PCI device remove with ongoing I/O

2016-11-08 Thread Madhani, Himanshu
On 11/7/16, 11:53 AM, "Mauricio Faria de Oliveira" wrote: >This patchset addresses a couple of errors that might happen during >PCI device remove (e.g., PCI hotplug, PowerVM DLPAR), which prevent >the successful removal and re-addition of the adapter to the

[REGRESSION] 4.9-rc4+ doesn't boot on my test box

2016-11-08 Thread Jens Axboe
Hi, I wasted half a day on this, thinking it was something in my 4.10 branches. But it turns out it is not, the regression is in mainline. Looking at the recent fixes, turns out to be this one: commit 1e793f6fc0db920400574211c48f9157a37e3945 Author: Kashyap Desai

Re: [PATCH] Avoid that SCSI device removal through sysfs triggers a deadlock

2016-11-08 Thread Bart Van Assche
On 11/08/2016 07:28 AM, James Bottomley wrote: On Mon, 2016-11-07 at 16:32 -0800, Bart Van Assche wrote: diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c index cf4c636..44ec536 100644 --- a/fs/kernfs/dir.c +++ b/fs/kernfs/dir.c @@ -1410,7 +1410,7 @@ int kernfs_remove_by_name_ns(struct kernfs_node

[Bug 187231] kernel panic during hpsa MSI plus tg3 MSI

2016-11-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=187231 --- Comment #4 from Patrick Schaaf --- That problematic box, which showed the kernel panic with 4.8.6, and the resetting/reset-up-to-20-seconds pauses several times a day with both 4.8 and 4.4.x, has now been running on 3.14.79

Re: [PATCH] Avoid that SCSI device removal through sysfs triggers a deadlock

2016-11-08 Thread James Bottomley
On Tue, 2016-11-08 at 08:01 +0100, Greg KH wrote: > On Mon, Nov 07, 2016 at 04:32:18PM -0800, Bart Van Assche wrote: > > The SCSI core holds scan_mutex around SCSI device addition and > > removal operations. sysfs serializes attribute read and write > > operations against attribute removal through

Re: [PATCH] Avoid that SCSI device removal through sysfs triggers a deadlock

2016-11-08 Thread James Bottomley
On Mon, 2016-11-07 at 16:32 -0800, Bart Van Assche wrote: > The SCSI core holds scan_mutex around SCSI device addition and > removal operations. sysfs serializes attribute read and write > operations against attribute removal through s_active. Avoid that > grabbing scan_mutex during self-removal

Re: [PATCH] hpsa: switch to pci_alloc_irq_vectors

2016-11-08 Thread Hannes Reinecke
On 11/08/2016 03:58 PM, Christoph Hellwig wrote: On Tue, Nov 08, 2016 at 08:12:25AM +0100, Hannes Reinecke wrote: Use pci_alloc_irq_vectors and drop the hand-crafted interrupt affinity routines. There are a couple more things we can do here. I actually have a patch in my tree that goes a

Re: [PATCH] hpsa: switch to pci_alloc_irq_vectors

2016-11-08 Thread Christoph Hellwig
On Tue, Nov 08, 2016 at 04:02:54PM +0100, Hannes Reinecke wrote: >> I've also started playing with lpfc, something I'll need to send to >> you and James for testing and feedback soon. >> > Bah. Another duplicate then. > Let's see who is faster :-) lpfc depends on the series adding the post_vetors

Re: [PATCH] aacraid: switch to pci_alloc_irq_vectors

2016-11-08 Thread Christoph Hellwig
> @@ -1246,7 +1246,6 @@ struct aac_dev > u32 max_msix; /* max. MSI-X vectors */ > u32 vector_cap; /* MSI-X vector capab.*/ > int msi_enabled;/* MSI/MSI-X enabled */ > - struct msix_entry

Re: [PATCH] libfc: fix seconds_since_last_reset miscalculation

2016-11-08 Thread Bart Van Assche
On 11/08/16 00:45, Johannes Thumshirn wrote: > Commit 540eb1eef 'scsi: libfc: fix seconds_since_last_reset calculation' > removed the use of 'struct timespec' from fc_get_host_stats(). This broke the > output of 'fcoeadm -s' after kernel 4.8-rc1 as lport->boot_time - jiffies > could become

Re: [PATCH] hpsa: switch to pci_alloc_irq_vectors

2016-11-08 Thread Hannes Reinecke
On 11/08/2016 04:01 PM, Christoph Hellwig wrote: On Tue, Nov 08, 2016 at 04:00:46PM +0100, Hannes Reinecke wrote: Right. I'll wait for it. If you also happen to have patches for megaraid and mpt3sas I'd be very much interested in looking into them; I'm currently working on converting them,

Re: [PATCH] hpsa: switch to pci_alloc_irq_vectors

2016-11-08 Thread Christoph Hellwig
On Tue, Nov 08, 2016 at 04:00:46PM +0100, Hannes Reinecke wrote: > Right. I'll wait for it. > > If you also happen to have patches for megaraid and mpt3sas I'd be very > much interested in looking into them; I'm currently working on converting > them, too. I've looked at the them but haven't

Re: [PATCH] hpsa: switch to pci_alloc_irq_vectors

2016-11-08 Thread Christoph Hellwig
On Tue, Nov 08, 2016 at 08:12:25AM +0100, Hannes Reinecke wrote: > Use pci_alloc_irq_vectors and drop the hand-crafted > interrupt affinity routines. There are a couple more things we can do here. I actually have a patch in my tree that goes a little further, I'll post it in a bit. -- To

Re: [PATCH v3 6/8] MAINTAINERS: Update megaraid maintainers list

2016-11-08 Thread Tomas Henzl
On 21.10.2016 15:33, Kashyap Desai wrote: > Update MEGARAID drivers maintainers list. > > Signed-off-by: Sumit Saxena > Reviewed-by: Hannes Reinecke > --- > MAINTAINERS | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git

Re: Ordering problems with 3ware controller

2016-11-08 Thread Paul Menzel
Dear Linux SCSI folks, On 11/08/16 11:07, Paul Menzel wrote: Updating from Linux 4.4.X to Linux 4.8.4, we noticed that the 3ware devices under `/dev` – `/dev/twa0`, `/dev/twa1`, … – map to the controllers differently. This unfortunately breaks quite a lot of our scripts, as we depend on the

Re: [PATCH v2 3/6] qedi: Add QLogic FastLinQ offload iSCSI driver framework.

2016-11-08 Thread kbuild test robot
-for-hardware-offloaded-iSCSI/20161108-180027 config: parisc-allyesconfig (attached as .config) compiler: hppa-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin

Re: [PATCH v2 6/6] qedi: Add support for data path.

2016-11-08 Thread kbuild test robot
-for-hardware-offloaded-iSCSI/20161108-180027 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) include/linux/compiler.h:253:8: sparse: attribute 'no_sanitize_address': u

Re: [PATCH v2 3/6] qedi: Add QLogic FastLinQ offload iSCSI driver framework.

2016-11-08 Thread kbuild test robot
-iSCSI/20161108-180027 config: ia64-allmodconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 6.2.0 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached

[PATCH v2 0/6] Add QLogic FastLinQ iSCSI (qedi) driver.

2016-11-08 Thread Manish Rangankar
This series introduces hardware offload iSCSI initiator driver for the 41000 Series Converged Network Adapters (579xx chip) by Qlogic. The overall driver design includes a common module ('qed') and protocol specific dependent modules ('qedi' for iSCSI). This is an open iSCSI driver, modifications

Ordering problems with 3ware controller

2016-11-08 Thread Paul Menzel
Dear Linux SCSI folks, Updating from Linux 4.4.X to Linux 4.8.4, we noticed that the 3ware devices under `/dev` – `/dev/twa0`, `/dev/twa1`, … – map to the controllers differently. This unfortunately breaks quite a lot of our scripts, as we depend on the fact that the first controller is

[PATCH v5 08/12] phy: qcom-ufs-qmp-xx: Move clock and regulator init out of phy init

2016-11-08 Thread Vivek Gautam
The phy init is meant to do phy initialization rather than just getting the clock and regulator. Move these clock and regulator get to probe(), to make room for actual phy initialization sequence. Signed-off-by: Vivek Gautam Reviewed-by: Subhash Jadavani

[PATCH v5 10/12] phy: qcom-ufs: Remove common layer phy exit callback

2016-11-08 Thread Vivek Gautam
The common layer phy exit callback ufs_qcom_phy_exit() calls phy_power_off() that has no meaning when phy_power_off() callback is already registered with the phy provider and the consumer makes use of the same. Instead, add a no-op specific phy_exit() callback for now to add the exit sequence at a

[PATCH v5 07/12] phy: qcom-ufs: Remove unnecessary function declarations

2016-11-08 Thread Vivek Gautam
Move the functions' definitions to remove unnecessary declarations. Signed-off-by: Vivek Gautam Reviewed-by: Subhash Jadavani --- drivers/phy/phy-qcom-ufs.c | 131 + 1 file changed, 62

[PATCH v5 12/12] scsi/ufs: qcom: Don't free resource-managed kmalloc element

2016-11-08 Thread Vivek Gautam
Host is allocated by managed kmalloc (devm_kmalloc). The memory allocated with this function is automatically freed on driver detach. So, no need to make an exclusive free call over it. Signed-off-by: Vivek Gautam Reviewed-by: Subhash Jadavani

[PATCH v5 09/12] ufs-qcom: phy/hcd: Refactoring phy clock handling

2016-11-08 Thread Vivek Gautam
Add phy clock enable code to phy_power_on/off callbacks, and remove explicit calls to enable these phy clocks from the ufs-qcom hcd driver. Signed-off-by: Vivek Gautam Reviewed-by: Subhash Jadavani --- drivers/phy/phy-qcom-ufs.c | 36

[PATCH v5 11/12] scsi/ufs: qcom: Add phy_exit call in hcd exit path

2016-11-08 Thread Vivek Gautam
Do a phy_exit() over the ufs phy in the ufs qcom exit path to de-initialize the phy. Signed-off-by: Vivek Gautam Reviewed-by: Subhash Jadavani --- drivers/scsi/ufs/ufs-qcom.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v5 03/12] phy: qcom-ufs: Cleanup clock and regulator initialization

2016-11-08 Thread Vivek Gautam
Different menthods pass around generic phy pointer to extract device pointer. Instead, pass the device pointer directly between function calls. Signed-off-by: Vivek Gautam Reviewed-by: Subhash Jadavani --- drivers/phy/phy-qcom-ufs-i.h

[PATCH v5 04/12] phy: qcom-ufs-14nm: Add new compatible for msm8996 based phy

2016-11-08 Thread Vivek Gautam
Add a new compatible string for 14nm ufs phy present on msm8996 chipset. This phy is bit different from the legacy 14nm ufs phy in terms of the clocks that are needed to be handled in the driver. Signed-off-by: Vivek Gautam Reviewed-by: Subhash Jadavani

[PATCH v5 02/12] phy: qcom-ufs: Use devm sibling of kstrdup for regulator names

2016-11-08 Thread Vivek Gautam
This helps us in avoiding any requirement for kfree() operation to be called exclusively over the allocated string pointer. Signed-off-by: Vivek Gautam Reviewed-by: Subhash Jadavani --- drivers/phy/phy-qcom-ufs.c | 5 + 1 file changed,

[PATCH v5 05/12] phy: qcom-ufs: Skip obtaining rx/tx_iface_clk for msm8996 based phy

2016-11-08 Thread Vivek Gautam
The tx_iface_clk and rx_iface_clk no longer exist with UFS Phy present on msm8996. So skip obtaining these clocks using compatible match. Signed-off-by: Vivek Gautam Reviewed-by: Subhash Jadavani --- drivers/phy/phy-qcom-ufs.c | 5 + 1

[PATCH v5 01/12] phy: qcom-ufs: Remove unnecessary BUG_ON

2016-11-08 Thread Vivek Gautam
BUG_ON() are not preferred in the driver, plus the variable on which BUG_ON is asserted is already checked in the code before passing. Signed-off-by: Vivek Gautam Reviewed-by: Subhash Jadavani --- drivers/phy/phy-qcom-ufs.c | 2 -- 1 file

[PATCH v5 06/12] phy: qcom-ufs-qmp-xx: Discard remove callback for drivers.

2016-11-08 Thread Vivek Gautam
remove() callback does a phy_power_off() only over the phy, and nothing else now. The phy_power_off() over the generic phy is called from the phy consumer, and phy provider driver should not explicitly need to call any phy ops. So discard the remove callback for qcom-ufs phy platform drivers.

[PATCH v5 00/12] ufs-qcom: phy/hcd: Clean up qcom-ufs phy and ufs-qcom hcd

2016-11-08 Thread Vivek Gautam
Hi Martin, Here's the rebased version of patches based on 4.10/scsi-queue branch as requested. The patches can now be applied and pulled-in. Thanks These patches cleanup the ufs phy driver to an extent. Subsequent patches will target to clean the phy_init() of these qcom-ufs phy drivers in

[PATCH v2 2/6] qed: Add iSCSI out of order packet handling.

2016-11-08 Thread Manish Rangankar
From: Yuval Mintz This patch adds out of order packet handling for hardware offloaded iSCSI. Out of order packet handling requires driver buffer allocation and assistance. Signed-off-by: Arun Easi Signed-off-by: Yuval Mintz

[PATCH v2 3/6] qedi: Add QLogic FastLinQ offload iSCSI driver framework.

2016-11-08 Thread Manish Rangankar
The QLogic FastLinQ Driver for iSCSI (qedi) is the iSCSI specific module for 41000 Series Converged Network Adapters by QLogic. This patch consists of following changes: - MAINTAINERS Makefile and Kconfig changes for qedi, - PCI driver registration, - iSCSI host level initialization, -

[PATCH v2 4/6] qedi: Add LL2 iSCSI interface for offload iSCSI.

2016-11-08 Thread Manish Rangankar
This patch adds support for iscsiuio interface using Light L2 (LL2) qed interface. Signed-off-by: Nilesh Javali Signed-off-by: Adheer Chandravanshi Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap

[PATCH v2 1/6] qed: Add support for hardware offloaded iSCSI.

2016-11-08 Thread Manish Rangankar
From: Yuval Mintz This adds the backbone required for the various HW initalizations which are necessary for the iSCSI driver (qedi) for QLogic FastLinQ 4 line of adapters - FW notification, resource initializations, etc. Signed-off-by: Arun Easi

[PATCH v2 2/2] scsi: ufs: Use the resource-managed function to add devfreq device

2016-11-08 Thread Chanwoo Choi
This patch uses the resource-managed to add the devfreq device. This function will make it easy to handle the devfreq device. - struct devfreq *devm_devfreq_add_device(struct device *dev, struct devfreq_dev_profile *profile,

[PATCH v2 2/2] scsi: ufs: Use the resource-managed function to add devfreq device

2016-11-08 Thread Chanwoo Choi
This patch uses the resource-managed to add the devfreq device. This function will make it easy to handle the devfreq device. - struct devfreq *devm_devfreq_add_device(struct device *dev, struct devfreq_dev_profile *profile,

[PATCH] libfc: fix seconds_since_last_reset miscalculation

2016-11-08 Thread Johannes Thumshirn
Commit 540eb1eef 'scsi: libfc: fix seconds_since_last_reset calculation' removed the use of 'struct timespec' from fc_get_host_stats(). This broke the output of 'fcoeadm -s' after kernel 4.8-rc1 as lport->boot_time - jiffies could become negative as in this example: $ cat

[RESEND][PATCH v1] ufs: introduce setup_task_mgmt

2016-11-08 Thread Kiwoong Kim
Some UFS host controller may need to configure some things before any task management request is issued. Signed-off-by: Kiwoong Kim --- drivers/scsi/ufs/ufshcd.c | 1 + drivers/scsi/ufs/ufshcd.h | 10 ++ 2 files changed, 11 insertions(+) diff --git

[Bug 151631] "Synchronizing SCSI cache" fails during(and delays) reboot/shutdown

2016-11-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=151631 Gianpaolo changed: What|Removed |Added CC||gianpao...@gmail.com

[PATCH v1] ufs: add a variety of definitions decribed in UFS spec

2016-11-08 Thread Kiwoong Kim
These things are defined to be used by some UFS Host controllers. Signed-off-by: Kiwoong Kim --- drivers/scsi/ufs/mphy.h | 38 ++ drivers/scsi/ufs/ufshci.h | 14 +++--- drivers/scsi/ufs/unipro.h | 24

[PATCH v1] ufs: introduce UFSHCI_QUIRK_SKIP_INTR_AGGR quirk

2016-11-08 Thread Kiwoong Kim
If UFS driver resets interrupt aggregation timer and counter when there is a pending doorbell, an interrupt of IO completion of a corresponding task may be missed. That would cause a command timeout. If UFS driver resets interrupt aggregation timer and counter when there is a pending doorbell, a