On 11/22/2016 10:57 PM, Martin K. Petersen wrote:
>> "Hannes" == Hannes Reinecke writes:
>
> Hannes> With the recent patch to hpsa this warning is issued:
> Hannes> drivers/scsi/hpsa.c: In function 'hpsa_slave_alloc':
> Hannes> drivers/scsi/hpsa.c:2033:5: error: 'sd' may be used
> Hannes> uni
https://bugzilla.kernel.org/show_bug.cgi?id=179341
--- Comment #8 from Chaitra P B ---
(In reply to Badalyan Vyacheslav from comment #7)
> Help is needed. How to get a log FW?
>
> This is "SAS 9300-16i Host Bus Adapter" and not have any HW RAID.
>
> [root@nas sas3ircu_linux_x64_rel]# ./sas3ir
Hi Cathy,
[auto build test WARNING on scsi/for-next]
[also build test WARNING on v4.9-rc6 next-20161122]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Cathy-Avery/storvsc-Payload-buffer
drivers/scsi/storvsc_drv.c:1500:13-20: WARNING: kzalloc should be used for
payload, instead of kmalloc/memset
Use kzalloc rather than kmalloc followed by memset with 0
This considers some simple cases that are common and easy to validate
Note in particular that there are no ...s in the rule,
>>
>> The events are not lost.
>
> In sas_queue_event(), if there is a particular event pending for a port/PHY,
> we cannot queue further same event types for that port/PHY. I think my
> colleagues found issue where we try to enqueue multiple complementary events.
Yes， we found this issue in ou
Additionally, rename srp_wait_for_queuecommand() into
scsi_wait_for_queuecommand() and add a comment about the
queuecommand() call from scsi_send_eh_cmnd().
Note: this patch changes scsi_internal_device_block from a function
that did not sleep into a function that may sleep. This is fine for
all c
Ensure that if scsi-mq is enabled that scsi_internal_device_block()
waits until ongoing shost->hostt->queuecommand() calls have finished.
Signed-off-by: Bart Van Assche
Reviewed-by: Sagi Grimberg
Reviewed-by: Martin K. Petersen
Cc: James Bottomley
Cc: Christoph Hellwig
Cc: Doug Ledford
---
Hello James and Martin,
The SRP transport code must wait until ongoing .queuecommand() /
.queue_rq() callback function invocations have finished before
reconnecting at the transport layer level and also before invoking
.terminate_rport_io(). This is already the case for the single queue
path
> "Kiwoong" == Kiwoong Kim writes:
Hi Kiwoong,
Kiwoong> Some UFS host controllers may think granularities of PRDT
Kiwoong> length and offset as bytes, not double words.
Your patch still didn't apply cleanly to 4.10/scsi-queue. I did it by
hand. Please verify.
Thanks!
--
Martin K. Peterse
Ahoj.
Dobre rano, a jak to delate? Jen rychly jedno, je tu oficialni
prilezitosti bych chtel diskutovat s vami soukrome.
Ocenil bych vasi rychlou reakci tady na mem osobnim soukromeho e-mailu
nize pro dalsi komunikaci.
S pratelskym pozdravem,
Paní Ko May Leung
email: kmyleun...@gmail.
> "Quentin" == Quentin Lambert writes:
Quentin> Most error branches following the call to pmcraid_get_free_cmd
Quentin> contain a call to pmcraid_return_cmd. This patch add these
Quentin> calls where they are missing.
Quentin> Moreover, most error branches following the call to
Quentin> clas
> "John" == John Garry writes:
John,
John> Are you happy with this patchset now that I've got an external
John> review?
Zhangfei Geo asked a question about patch 1/11 that has yet to be
answered. Patch 5/11 is still unreviewed.
--
Martin K. Petersen Oracle Linux Engineering
--
To uns
> "Hannes" == Hannes Reinecke writes:
Hannes> With the recent patch to hpsa this warning is issued:
Hannes> drivers/scsi/hpsa.c: In function 'hpsa_slave_alloc':
Hannes> drivers/scsi/hpsa.c:2033:5: error: 'sd' may be used
Hannes> uninitialized in this function [-Werror=maybe-uninitialized]
I
On Tuesday, November 22, 2016 4:05:38 PM CET Hannes Reinecke wrote:
> With the recent patch to hpsa this warning is issued:
>
> drivers/scsi/hpsa.c: In function 'hpsa_slave_alloc':
> drivers/scsi/hpsa.c:2033:5: error: 'sd' may be used uninitialized in this
> function [-Werror=maybe-uninitialized]
On Tue, Nov 22, 2016 at 8:30 PM, Ewan D. Milne wrote:
>
> I see the behavior (zero byte) on the 4.4.34, 4.5.7, 4.6.7, and 4.7.10
> -stable kernels. But not (of course) on 4.8.10 -stable.
>
> It doesn't look like the sg driver, might be something in the mmap code?
A kernel guy colleague suggeste
Ich war ein normaler Bürger genauso wie Sie, bis ich auf dem Gehen Spende einen
Artikel corncerning abot ein lesen, die das Leben verändert, ich mit ihnen
Kontakt auf und es war leicht, sie gaben mir guidline und am nächsten Tag bekam
ich eine Spende von 2 Millionen Euro. Es ist einfach nur Ko
- Original Message -
> From: "Ewan D. Milne"
> To: "Johannes Thumshirn"
> Cc: dgilb...@interlog.com, "Eyal Ben David" , "Laurence
> Oberman" ,
> linux-scsi@vger.kernel.org
> Sent: Tuesday, November 22, 2016 1:30:07 PM
> Subject: Re: SG does not ignore dxferp (direct io + mmap)
>
> On
On Tue, 2016-11-22 at 09:37 +0100, Johannes Thumshirn wrote:
> On Mon, Nov 21, 2016 at 01:24:02PM -0500, Ewan Milne wrote:
> > On Mon, 2016-11-21 at 12:34 -0500, Douglas Gilbert wrote:
> > > There was also this change which seems closer to the problem area:
> > >
> > > commit 461c7fa126794157484dc
In blk_mq_map_swqueue, there is a memory optimization that frees the
tags of a queue that has gone unmapped. Later, if that hctx is remapped
after another topology change, the tags need to be reallocated.
If this allocation fails, a simple WARN_ON triggers, but the block layer
ends up with an act
While stressing memory and IO at the same time we changed SMT settings,
we were able to consistently trigger deadlocks in the mm system, which
froze the entire machine.
I think that under memory stress conditions, the large allocations
performed by blk_mq_init_rq_map may trigger a reclaim, which s
- All symbols which are only used within one .c file are marked static
and removed from the bnx2fc.h file if possible.
- the declarion of bnx2fc_percpu is moved into the header file
This patch was only compile-tested due to -ENODEV.
Cc: qlogic-storage-upstr...@qlogic.com
Cc: Christoph Hellwig
This is not driven by the hotplug conversation but while I am at it
looks like a good candidate. Converting the thread to a workqueue user
removes also the kthread member from struct fcoe_percpu_s.
This driver uses the struct fcoe_percpu_s but it does not need the
crc_eof_page member, only the wor
The caller of bnx2fc_abts_cleanup() holds the tgt->tgt_lock lock and it
is expected to release the lock during wait_for_completion() and acquire
the lock afterwards.
This patch was only compile-tested due to -ENODEV.
Cc: qlogic-storage-upstr...@qlogic.com
Cc: Christoph Hellwig
Signed-off-by: Seb
This is the a repost + fixups to get the patches applied against v4.9-rc4.
mkp's scsi for-next tree can be merged with no conflicts.
The last repost was not merged and stalled after Chad Dupuis said to hold on
because he is testing but never came back with the results [0]. Johannes
confirmed that
The driver creates its own per-CPU threads which are updated based on CPU
hotplug events. It is also possible to use kworkers and remove some of the
infrastructure get the same job done while saving a few lines of code.
The DECLARE_PER_CPU() definition is moved into the header file where it
belong
The driver creates its own per-CPU threads which are updated based on CPU
hotplug events. It is also possible to use kworkers and remove some of the
infrastructure get the same job done while saving a few lines of code.
bnx2fc_percpu_io_thread() becomes bnx2fc_percpu_io_work() which is
mostly the
On a 32 bit kernel sizeof(void *) is not 64 bits as hv_mpb_array
requires. Also the buffer needs to be cleared or the upper bytes
could contain junk.
Suggested-by: Vitaly Kuznets
Signed-off-by: Cathy Avery
---
drivers/scsi/storvsc_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
d
On 21/11/2016 17:13, Dan Williams wrote:
On Mon, Nov 21, 2016 at 7:16 AM, John Garry wrote:
@Maintainers, would you be willing to accept this patch as an interim
fix
for the dastardly WARN while we try to fix the flutter issue?
To me this adds a bug to quiet a benign, albeit noisy, warning.
On 14/11/2016 23:49, Martin K. Petersen wrote:
"John" == John Garry writes:
John> This patchset introduces some misc bug fixes, improvements, and
John> new features to the HiSilicon SAS driver.
This series needs review.
Hi Martin,
Are you happy with this patchset now that I've got an exte
On 22.11.2016 16:05, Hannes Reinecke wrote:
> With the recent patch to hpsa this warning is issued:
>
> drivers/scsi/hpsa.c: In function 'hpsa_slave_alloc':
> drivers/scsi/hpsa.c:2033:5: error: 'sd' may be used uninitialized in this
> function [-Werror=maybe-uninitialized]
>
> The patch that cause
> @Eyal is this with a physical or virtual host? And what kind of HBA do you
> have? Just in case it makes a difference.
All physical hosts,
Original problem was detected on qlogic FC HBA (Ubuntu 16.04)
To check if this is transport related, we reproduced the 0 byte
corruption on iSCSI too.
To
On 19.11.2016 18:43, Quentin Lambert wrote:
> Most error branches following the call to pmcraid_get_free_cmd contain
> a call to pmcraid_return_cmd. This patch add these calls where they are
> missing.
>
> Moreover, most error branches following the call to class_create contain
> a call to class_de
On Tue, Nov 22, 2016 at 10:31:23AM -0500, Laurence Oberman wrote:
[...]
> Its not failing on 4.8-rc2 so working on tracing rgw ioctl SG_DXFER_FROM_DEV
> as well and will bisect this weekend and/or add some kernel probes.
> Just need to get some time.
> Johannes or Ewan may beat me to it.
Sounds
On 11/11/2016 05:05 AM, Ming Lei wrote:
Hi,
This patchset cleans up direct access to bvec table.
The 1st patch passes bvec table to bio_init(), so that
direct access to bvec table in bio initialization is avoided.
For other patches, most of them uses bio_add_page()
to replace hardcode style of
On 19.11.2016 18:40, Quentin Lambert wrote:
> Most error branches following the call to kzalloc contain
> a call to kfree. This patch add these calls where they are
> missing.
>
> This issue was found with Hector.
Hi Quentin,
most error branches also do set the freed pointer to NULL,
please do the
- Original Message -
> From: "Eyal Ben David"
> To: "Johannes Thumshirn"
> Cc: "Ewan D. Milne" , dgilb...@interlog.com, "Laurence
> Oberman" ,
> linux-scsi@vger.kernel.org
> Sent: Tuesday, November 22, 2016 8:48:06 AM
> Subject: Re: SG does not ignore dxferp (direct io + mmap)
>
> Sam
With the recent patch to hpsa this warning is issued:
drivers/scsi/hpsa.c: In function 'hpsa_slave_alloc':
drivers/scsi/hpsa.c:2033:5: error: 'sd' may be used uninitialized in this
function [-Werror=maybe-uninitialized]
The patch that caused this is marked for stable backports,
so this one has t
On Tuesday, November 22, 2016 3:47:09 PM CET Hannes Reinecke wrote:
> index 05f7782..ee6f852 100644
> --- a/drivers/scsi/hpsa.c
> +++ b/drivers/scsi/hpsa.c
> @@ -2031,7 +2031,7 @@ static struct hpsa_scsi_dev_t
> *lookup_hpsa_scsi_dev(struct ctlr_info *h,
>
> static int hpsa_slave_alloc(struct scs
A bugfix has left the 'sd' variable uninitialized:
drivers/scsi/hpsa.c: In function 'hpsa_slave_alloc':
drivers/scsi/hpsa.c:2033:5: error: 'sd' may be used uninitialized in this
function [-Werror=maybe-uninitialized]
This reverts back to calling lookup_hpsa_scsi_dev() for the
HPSA_PHYSICAL_DEVIC
On 11/22/2016 03:32 PM, Arnd Bergmann wrote:
> A bugfix has left the 'sd' variable uninitialized:
>
> drivers/scsi/hpsa.c: In function 'hpsa_slave_alloc':
> drivers/scsi/hpsa.c:2033:5: error: 'sd' may be used uninitialized in this
> function [-Werror=maybe-uninitialized]
>
> This reverts back to
Same problem on Fedora 23
$ uname -r
4.7.10-100.fc23.x86_64
$ sudo ./sg_mmap_read -d /dev/sg0 -l 0 | od -t x1
000 eb 63 90 10 8e d0 bc 00 b0 b8 00 00 8e d8 8e c0
...
$ sudo ./sg_mmap_read -d /dev/sg0 -l 0 -m | od -t x1
000 eb 63 90 10 8e d0 bc 00 b0 b8 00 00 8e d8 8e c0
...
$ sudo ./sg_
On Fri, 2016-11-18 at 08:32 +0100, Hannes Reinecke wrote:
> Older SmartArray controller do not support the extended REPORT PHYS
> command, so fallback to use the legacy version here.
>
> Signed-off-by: Hannes Reinecke
Tested-by: Martin Wilck
> ---
> drivers/scsi/hpsa.c | 28 ++
https://bugzilla.kernel.org/show_bug.cgi?id=179341
--- Comment #7 from Badalyan Vyacheslav ---
Help is needed. How to get a log FW?
This is "SAS 9300-16i Host Bus Adapter" and not have any HW RAID.
[root@nas sas3ircu_linux_x64_rel]# ./sas3ircu 0 LOGIR
Avago Technologies SAS3 IR Configuration
https://bugzilla.kernel.org/show_bug.cgi?id=179341
Chaitra P B changed:
What|Removed |Added
CC||chaitra.basa...@broadcom.co
On Mon, Nov 21, 2016 at 01:24:02PM -0500, Ewan Milne wrote:
> On Mon, 2016-11-21 at 12:34 -0500, Douglas Gilbert wrote:
> > There was also this change which seems closer to the problem area:
> >
> > commit 461c7fa126794157484dca48e88effa4963e3af3
> > Author: Kirill A. Shutemov
> > Date: Tue Feb
On Mon, Nov 21, 2016 at 10:47:20PM -0500, Martin K . Petersen wrote:
> > "Johannes" == Johannes Thumshirn writes:
>
> Johannes> I don't think the SUSE bugzilla tag is of relevance upstream.
>
> Nope. I'd rather have really comprehensive patch descriptions.
>
> Johannes> But for sake of comp
Some UFS host controllers may think
granularities of PRDT length and offset as bytes, not double words.
Signed-off-by: Kiwoong Kim
---
V2: change the name of the quirk
(UFSHCD_QUIRK_BROKEN_DWORD_UTRD -> UFSHCD_QUIRK_PRDT_BYTE_GRAN)
V3: (rebased to for-next tip)
V4: (rebased to 4.10/scsi-queue tip
47 matches
Mail list logo
