Re: [PATCH] csiostor: switch to pci_alloc_irq_vectors

2017-01-20 Thread Martin K. Petersen
> "Christoph" == Christoph Hellwig writes: Christoph> And get automatic MSI-X affinity for free. Chelsio folks: Please review and test! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of

Re: [PATCH] be2iscsi: switch to pci_alloc_irq_vectors

2017-01-20 Thread Martin K. Petersen
> "Christoph" == Christoph Hellwig writes: Christoph> And get automatic MSI-X affinity for free. Jitendra? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to

Re: [PATCH] scsi_debug: Add OPTIMAL TRANSFER LENGTH GRANULARITY option.

2017-01-20 Thread Martin K. Petersen
> "Lukas" == Lukas Herbolt writes: Lukas, Lukas> I have been playing with scsi_debug and found that there is no Lukas> way how to change the minimum_io_size (OPTIMAL TRANSFER LENGTH Lukas> GRANULARITY reported by VPD 0xb0). Lukas> The current module has minimum_io_size

Re: [PATCH v2] virtio_scsi: Reject commands when virtqueue is broken

2017-01-20 Thread Martin K. Petersen
> "Eric" == Eric Farman writes: Eric> In the case of a graceful set of detaches, where the Eric> virtio-scsi-ccw disk is removed from the guest prior to the Eric> controller, the guest behaves quite normally. Specifically, the Eric> detach gets us into

Re: [PATCH v2 0/7] hisi_sas: SATA IO workaround and other misc patches

2017-01-20 Thread Martin K. Petersen
> "John" == John Garry writes: John> This patchset introduces some misc fixes and improvements. Most John> signifigantly this patchset includes a workaround for a SATA IO John> issue on v2 hw (hip06/7). John> Differences v1->v2: - Add macro for SMP TIMEOUT in ITCT

[Bug 193041] New: iSCSI initiator: mkfs.ext4 + mount triggers kernel oops

2017-01-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=193041 Bug ID: 193041 Summary: iSCSI initiator: mkfs.ext4 + mount triggers kernel oops Product: IO/Storage Version: 2.5 Kernel Version: v4.10-rc4 Hardware: All

Re: [PATCH v4 00/12] qla2xxx: Feature updates for target.

2017-01-20 Thread Bart Van Assche
On Thu, 2017-01-19 at 22:27 -0800, Himanshu Madhani wrote: > Please consider this updated series for inclusion in target-pending. Hello Himanshu, These patches have been applied on my scsi-target-for-v4.11 branch. Thank you for all the work you have done on addressing review comments. Bart. --

Re: [PATCH] sd: Cleaned up comment references to @sdp argument explanation.

2017-01-20 Thread Martin K. Petersen
> "John" == John Pittman writes: John> In sd.c there are two comment references to 'struct scsi_device John> *sdp' as an argument. One of the references has a typo and the John> other should be a reference to 'struct device *dev' instead. Applied to 4.11/scsi-queue.

Re: [PATCH -next] scsi: be2iscsi: Use GFP_ATOMIC under spin lock

2017-01-20 Thread Martin K. Petersen
> "Wei" == Wei Yongjun writes: Wei> From: Wei Yongjun A spin lock is taken Wei> here so we should use GFP_ATOMIC. Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line

Re: [PATCH] Set elsiocb contexts to NULL after freeing it

2017-01-20 Thread Martin K. Petersen
> "Martin" == Martin K Petersen writes: > "Johannes" == Johannes Thumshirn writes: Johannes> Set the elsiocb contexts to NULL after freeing as others Johannes> depend on it. Martin> Applied to 4.11/scsi-queue. Replied to the wrong mail,

Re: [PATCH] Set elsiocb contexts to NULL after freeing it

2017-01-20 Thread Martin K. Petersen
> "Johannes" == Johannes Thumshirn writes: Johannes> Set the elsiocb contexts to NULL after freeing as others Johannes> depend on it. Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line

Re: [PATCH] scsi: lpfc: Replace BUG() with BUG_ON()

2017-01-20 Thread Martin K. Petersen
> "Shyam" == Shyam Saini writes: Shyam> Replace BUG() with BUG_ON() using coccinelle Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to

Re: [PATCH v2 1/4] mpt3sas: Added print to notify cable running at a degraded speed.

2017-01-20 Thread Joe Perches
On Fri, 2017-01-20 at 09:55 -0800, Joe Perches wrote: > I believe MPT3SAS_FMT is unnecessary obfuscation and > it should just be replaced by "%s: " everywhere. Here's a trivial command that could be used one day: $ git grep --name-only MPT3SAS_FMT -- "*.c" | \ xargs perl -p -i -e 'local $/;

Re: [PATCH v2 1/4] mpt3sas: Added print to notify cable running at a degraded speed.

2017-01-20 Thread Joe Perches
On Fri, 2017-01-20 at 20:12 +0530, Chaitra P B wrote: > Driver processes the event MPI26_EVENT_ACTIVE_CABLE_DEGRADED > when a cable is present and is running at a degraded speed > (below the SAS3 12 Gb/s rate). Prints added > to inform the user that the cable is not running at > optimal speed. []

Re: [lkp-robot] [rcu] b332151a29: kernel_BUG_at_mm/slab.c

2017-01-20 Thread Jens Axboe
On 01/20/2017 09:09 AM, Sebastian Andrzej Siewior wrote: > On 2017-01-20 08:32:37 [-0800], Jens Axboe wrote: >> That's alright, sounds like it's not a -next regression, but rather something >> that is already broken. I can reproduce a lot of breakage if I enable >> CONFIG_DEBUG_TEST_DRIVER_REMOVE,

Re: [lkp-robot] [rcu] b332151a29: kernel_BUG_at_mm/slab.c

2017-01-20 Thread Sebastian Andrzej Siewior
On 2017-01-20 08:32:37 [-0800], Jens Axboe wrote: > That's alright, sounds like it's not a -next regression, but rather something > that is already broken. I can reproduce a lot of breakage if I enable > CONFIG_DEBUG_TEST_DRIVER_REMOVE, in fact my system doesn't boot at all. This > is the first

Re: [lkp-robot] [rcu] b332151a29: kernel_BUG_at_mm/slab.c

2017-01-20 Thread Sebastian Andrzej Siewior
On 2017-01-20 08:09:36 [-0800], Jens Axboe wrote: > Is there a full trace of this? [3.654003] scsi host0: scsi_debug: version 1.86 [20160430] [3.654003] dev_size_mb=8, opts=0x0, submit_queues=1, statistics=0 [3.660755] scsi 0:0:0:0: Direct-Access Linuxscsi_debug 0186

Re: [lkp-robot] [rcu] b332151a29: kernel_BUG_at_mm/slab.c

2017-01-20 Thread Jens Axboe
On 01/20/2017 08:23 AM, Sebastian Andrzej Siewior wrote: >>> yes. With and without the patch there is a lot of wrong stuff like >>> complains about a kobject initialized again. This leads to a double free >>> at some point. >> >> And what patch are we talking about? I don't mind being CC'ed into a

Re: [PATCH v2 2/4] mpt3sas: Fix for Crusader to achieve product targets with SAS devices.

2017-01-20 Thread Sreekanth Reddy
On Fri, Jan 20, 2017 at 8:30 PM, Johannes Thumshirn wrote: > On Fri, Jan 20, 2017 at 08:12:11PM +0530, Chaitra P B wrote: >> Small glitch/degraded performance in Crusader is improved with SAS >> drives by removing unnecessary spinlocks while clearing scsi command >> in drivers

Re: [PATCH v2 3/4] mpt3sas: Fix Firmware fault state 0x2100 during heavy 4K RR FIO stress test.

2017-01-20 Thread Sreekanth Reddy
On Fri, Jan 20, 2017 at 8:40 PM, Johannes Thumshirn wrote: > On Fri, Jan 20, 2017 at 08:12:12PM +0530, Chaitra P B wrote: >> Due existence of loop in the IO path our HBA will receive heavy IOs and >> also as driver is not updating the Reply Post Host Index frequently, So >>

Re: [lkp-robot] [rcu] b332151a29: kernel_BUG_at_mm/slab.c

2017-01-20 Thread Jens Axboe
On 01/20/2017 08:01 AM, Sebastian Andrzej Siewior wrote: > On 2017-01-19 09:02:16 [+0800], kernel test robot wrote: >> test-description: Trinity is a linux system call fuzz tester. > > you don't even get to fire up trinity. With and without the patch you > crash very early. > >>

Re: [lkp-robot] [rcu] b332151a29: kernel_BUG_at_mm/slab.c

2017-01-20 Thread Sebastian Andrzej Siewior
On 2017-01-19 09:02:16 [+0800], kernel test robot wrote: > test-description: Trinity is a linux system call fuzz tester. you don't even get to fire up trinity. With and without the patch you crash very early. > +-+++ > |

Re: [PATCH v2 3/4] mpt3sas: Fix Firmware fault state 0x2100 during heavy 4K RR FIO stress test.

2017-01-20 Thread Johannes Thumshirn
On Fri, Jan 20, 2017 at 08:12:12PM +0530, Chaitra P B wrote: > Due existence of loop in the IO path our HBA will receive heavy IOs and > also as driver is not updating the Reply Post Host Index frequently, So > there will be a high chance that our Firmware unable to find any free entry > in the

Re: [PATCH v2 4/4] mpt3sas: Updating driver version to v15.100.00.00

2017-01-20 Thread Johannes Thumshirn
On Fri, Jan 20, 2017 at 08:12:13PM +0530, Chaitra P B wrote: > > Signed-off-by: Chaitra P B > Signed-off-by: Suganath Prabu S > --- Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn

Re: [PATCH v2 1/4] mpt3sas: Added print to notify cable running at a degraded speed.

2017-01-20 Thread Johannes Thumshirn
On Fri, Jan 20, 2017 at 08:12:10PM +0530, Chaitra P B wrote: > Driver processes the event MPI26_EVENT_ACTIVE_CABLE_DEGRADED > when a cable is present and is running at a degraded speed > (below the SAS3 12 Gb/s rate). Prints added > to inform the user that the cable is not running at > optimal

Re: [PATCH v2 2/4] mpt3sas: Fix for Crusader to achieve product targets with SAS devices.

2017-01-20 Thread Johannes Thumshirn
On Fri, Jan 20, 2017 at 08:12:11PM +0530, Chaitra P B wrote: > Small glitch/degraded performance in Crusader is improved with SAS > drives by removing unnecessary spinlocks while clearing scsi command > in drivers internal lookup table. > > Signed-off-by: Chaitra P B

[PATCH v2 0/4] mpt3sas driver Enhancements and

2017-01-20 Thread Chaitra P B
Here is the change list: Posting 4 patches for mpt3sas driver enhancement and defect fixes. * Handle cable event for notifying degraded speed. * Performance improvement for Crusader. * Fix Firmware fault state 0x2100 during heavy 4K RR FIO stress test. * Updated driver version to

[PATCH v2 2/4] mpt3sas: Fix for Crusader to achieve product targets with SAS devices.

2017-01-20 Thread Chaitra P B
Small glitch/degraded performance in Crusader is improved with SAS drives by removing unnecessary spinlocks while clearing scsi command in drivers internal lookup table. Signed-off-by: Chaitra P B Signed-off-by: Suganath Prabu S

[PATCH v2 4/4] mpt3sas: Updating driver version to v15.100.00.00

2017-01-20 Thread Chaitra P B
Signed-off-by: Chaitra P B Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_base.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h

[PATCH v2 3/4] mpt3sas: Fix Firmware fault state 0x2100 during heavy 4K RR FIO stress test.

2017-01-20 Thread Chaitra P B
Due existence of loop in the IO path our HBA will receive heavy IOs and also as driver is not updating the Reply Post Host Index frequently, So there will be a high chance that our Firmware unable to find any free entry in the Reply Post Descriptor Queue (i.e. Queue overflow occurs) and can

[PATCH v2 1/4] mpt3sas: Added print to notify cable running at a degraded speed.

2017-01-20 Thread Chaitra P B
Driver processes the event MPI26_EVENT_ACTIVE_CABLE_DEGRADED when a cable is present and is running at a degraded speed (below the SAS3 12 Gb/s rate). Prints added to inform the user that the cable is not running at optimal speed. Signed-off-by: Chaitra P B

Re: [LSF/MM TOPIC][LSF/MM ATTEND] NAPI polling for block drivers

2017-01-20 Thread Johannes Thumshirn
On Tue, Jan 17, 2017 at 05:45:53PM +0200, Sagi Grimberg wrote: > > >-- > >[1] > >queue = b'nvme0q1' > > usecs : count distribution > > 0 -> 1 : 7310 || > > 2 -> 3 : 11 | | > > 4 -> 7

[PATCH v2] ata: xgene: Enable NCQ support for APM X-Gene SATA controller hardware v1.1

2017-01-20 Thread Rameshwar Prasad Sahu
This patch enables NCQ support for APM X-Gene SATA controller hardware v1.1 that was broken with hardware v1.0. Second thing, here we should not assume XGENE_AHCI_V2 always in case of having valid _CID in ACPI table. I need to remove this assumption because V1_1 also has a valid _CID for backward

[PATCH v2 5/7] scsi: hisi_sas: downgrade internal abort exit print

2017-01-20 Thread John Garry
Downgrade the exit print in hisi_sas_internal_task_abort() to dbg level, as info is not required. Signed-off-by: John Garry Reviewed-by: Xiang Chen Reviewed-by: Johannes Thumshirn --- drivers/scsi/hisi_sas/hisi_sas_main.c |

[PATCH v2 3/7] scsi: hisi_sas: downgrade refclk message

2017-01-20 Thread John Garry
The message to inform that the controller has no refclk is currently at warning level, which is unnecessary, so downgrade to debug. Signed-off-by: John Garry Reviewed-by: Xiang Chen Reviewed-by: Johannes Thumshirn ---

[PATCH v2 2/7] scsi: hisi_sas: modify some values of ITCT table

2017-01-20 Thread John Garry
From: Xiang Chen Set SMP connection timeout and continue AWT timer; Clear ITCT table when dev gone. Signed-off-by: Xiang Chen Signed-off-by: John Garry Reviewed-by: Johannes Thumshirn ---

[PATCH v2 0/7] hisi_sas: SATA IO workaround and other misc patches

2017-01-20 Thread John Garry
This patchset introduces some misc fixes and improvements. Most signifigantly this patchset includes a workaround for a SATA IO issue on v2 hw (hip06/7). Differences v1->v2: - Add macro for SMP TIMEOUT in ITCT struct John Garry (2): scsi: hisi_sas: downgrade refclk message scsi: hisi_sas:

[PATCH v2 1/7] scsi: hisi_sas: workaround v2 hw SATA IO timeout issue

2017-01-20 Thread John Garry
From: Xiang Chen The v2 SAS controller needs more time to detect channel idle and send setup link request than SATA disk does, so it is difficult for the SAS controller to setup an STP link. Therefore it may cause some IO timeouts. We need to periodically configure

[PATCH v2 6/7] scsi: hisi_sas: fix probe ordering problem

2017-01-20 Thread John Garry
From: Xiang Chen There is a potential probe issue in how we trigger the hw initialisation. Although we use 1s timer to delay hw initialisation, there is still a potential that sas_register_ha() is not be finished before we start the PHY init from hw->hw_init(). To

[PATCH v2 4/7] scsi: hisi_sas: modify hard reset for directed-attached disk

2017-01-20 Thread John Garry
From: Xiang Chen Correctly set registers in v2 for root PHY hardreset for directly attached disk. Signed-off-by: Xiang Chen Signed-off-by: John Garry Reviewed-by: Johannes Thumshirn ---

[PATCH v2 7/7] scsi: hisi_sas: decrease running_req in hisi_sas_slot_task_free()

2017-01-20 Thread John Garry
From: Xiang Chen There is an issue that hisi_sas_dev.running_req is not decremented properly for internal abort and TMF. To resolve, only decrease running_req in hisi_sas_slot_task_free() Signed-off-by: Xiang Chen Signed-off-by: John Garry

Re: [PATCH 2/2] scsi: storvsc: Add support for FC lightweight host.

2017-01-20 Thread Dan Carpenter
On Thu, Jan 19, 2017 at 12:55:27PM -0500, Cathy Avery wrote: > > > On 01/18/2017 06:15 PM, Dan Carpenter wrote: > >On Wed, Jan 18, 2017 at 03:28:58PM -0500, Cathy Avery wrote: > >>Enable FC lightweight host option so that the luns exposed by > >>the driver may be manually scanned. > >> >

Re: [PATCH 0/4] mpt3sas driver Enhancements and

2017-01-20 Thread Johannes Thumshirn
On Thu, Jan 19, 2017 at 09:19:06PM +0530, Chaitra P B wrote: > Here is the change list: > Posting 4 patches for mpt3sas driver enhancement and defect fixes. > * Handle cable event for notifying degraded speed. > * Performance improvement for Crusader. > * Fix Firmware fault state 0x2100

Re: [PATCH 1/4] mpt3sas: Added print to notify cable running at a degraded speed.

2017-01-20 Thread Johannes Thumshirn
On Thu, Jan 19, 2017 at 09:19:07PM +0530, Chaitra P B wrote: > Driver processes the event MPI26_EVENT_ACTIVE_CABLE_DEGRADED > when a cable is present and is running at a degraded speed > (below the SAS3 12 Gb/s rate). Prints added > to inform the user that the cable is not running at > optimal