https://bugzilla.kernel.org/show_bug.cgi?id=195285
--- Comment #3 from Anthony (anthony.blood...@gmail.com) ---
Two cards installed in new test machine: QLE2462 and QLE2560
qle2560 spam with errors (without starting a target)
scsi host8: qla2xxx
qla2xxx [:05:00.1]-00fb:8: QLogic QLE2462 - PCI
On Mon, 2017-05-15 at 23:32 +, Long Li wrote:
> Thanks for looking! Yes this is for chasing a bug.
>
> With the patch, we also zero the private data used by lower layer driver, in
> addition to the private data in scsi_cmnd.
Hello Long,
What bug did you encounter, with which combination of
> -Original Message-
> From: Bart Van Assche [mailto:bart.vanass...@sandisk.com]
> Sent: Monday, May 15, 2017 4:03 PM
> To: j...@linux.vnet.ibm.com; linux-scsi@vger.kernel.org; linux-
> ker...@vger.kernel.org; Long Li ;
> martin.peter...@oracle.com
> Cc: Long Li
> Subject: Re: [Possible Ph
> -Original Message-
> From: Long Li
> Sent: Monday, May 15, 2017 3:48 PM
> To: Long Li ; James E.J. Bottomley
> ; Martin K. Petersen
> ; linux-scsi@vger.kernel.org; linux-
> ker...@vger.kernel.org
> Cc: KY Srinivasan ; Stephen Hemminger
>
> Subject: RE: [PATCH] scsi: zero per-cmd driver
On Wed, 2017-05-10 at 14:07 -0700, Long Li wrote:
> From: Long Li
>
> Lower layer driver may not initialize private data before use. Zero them
> out to prevent use of stale data.
>
> Signed-off-by: Long Li
> ---
> drivers/scsi/scsi_lib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> -Original Message-
> From: Long Li [mailto:lon...@exchange.microsoft.com]
> Sent: Wednesday, May 10, 2017 2:07 PM
> To: James E.J. Bottomley ; Martin K. Petersen
> ; linux-scsi@vger.kernel.org; linux-
> ker...@vger.kernel.org
> Cc: Long Li
> Subject: [PATCH] scsi: zero per-cmd driver dat
On 5/11/2017 12:49 AM, Hannes Reinecke wrote:
If this is a fix to a previous patch (Patch 6/15 ?), please merge it
with that.
It was, in some areas. Split those areas out and merged into the prior
patches. Affected patches 0004, 0006, and 0008.
-- james
On 5/11/2017 12:35 AM, Hannes Reinecke wrote:
On 05/10/2017 09:07 PM, James Smart wrote:
When the driver send the RPA command, it does not
send supported FC4 Type NVME to the management server.
Encode NVME (type x28) in the AttribEntry in the
RPA command.
Signed-off-by: Dick Kennedy
Signed-of
On 5/10/2017 11:18 PM, Hannes Reinecke wrote:
On 05/10/2017 09:07 PM, James Smart wrote:
Large block writes to the nvme target were failing because
the default number of RQs posted was insufficient.
Expand the NVMET RQs to 2048 RQEs and ensure a minimun of 2048
Bart,
>> So, are you suggesting we change all the other sysfs store routines?
>
> I will leave it to Martin and James to comment on this.
As I mentioned a few weeks ago, I have a patch that converts all these
to sysfs_match_string(). Now that the latter is upstream I intend to
post the patch.
-
On Mon, 2017-05-15 at 17:02 -0400, Ewan D. Milne wrote:
> I think it's the '\n' that actually causes the problem.
Agreed, and that's why I proposed to strip trailing whitespace.
> But, what I think we should do is use the same technique everywhere.
If you have a look at the block layer you will
On Mon, 2017-05-15 at 20:14 +, Bart Van Assche wrote:
> On Mon, 2017-05-15 at 15:13 -0400, Ewan D. Milne wrote:
> > From: "Ewan D. Milne"
> >
> > Change to use strlen() of the desired string for the length
> > parameter to strncmp(). Otherwise one cannot simply use a
> > command like 'echo "
On Mon, 2017-05-15 at 15:13 -0400, Ewan D. Milne wrote:
> From: "Ewan D. Milne"
>
> Change to use strlen() of the desired string for the length
> parameter to strncmp(). Otherwise one cannot simply use a
> command like 'echo "writesame_16" > .../provisioning_mode'.
> This patch makes sysfs write
Hi James and Dick, thanks for this patch. We were investigating a pretty
similar issue, and we raised a patch that looks like yours.
Since you sent this one, we reviewed and seems it's missing a hunk to
prevent the issue we are dealing here, in PCI error recovery.
Please see the attached patch. Ba
From: "Ewan D. Milne"
Change to use strlen() of the desired string for the length
parameter to strncmp(). Otherwise one cannot simply use a
command like 'echo "writesame_16" > .../provisioning_mode'.
This patch makes sysfs writes consistent with other usage.
Signed-off-by: Ewan D. Milne
---
d
On Mon, 2017-05-15 at 16:03 +, Bart Van Assche wrote:
> On Mon, 2017-05-15 at 10:16 +0200, Martin Wilck wrote:
> > On Fri, 2017-05-12 at 16:24 +, Bart Van Assche wrote:
> > > Allowing races like the one this patch tries to address to exist
> > > makes the ALUA code harder to maintain than n
> On May 15, 2017, at 5:31 AM, Ewan D. Milne wrote:
>
> On Mon, 2017-05-15 at 08:04 +0200, Hannes Reinecke wrote:
>> In general I like the idea; however, the 'filter' thingie is somewhat
>> odd. I could somewhat buy into the idea of filtering for sense keys, but
>> then I would have expected to
> On May 14, 2017, at 11:04 PM, Hannes Reinecke wrote:
>
> On 05/12/2017 09:02 PM, Song Liu wrote:
>>
>>> On May 3, 2017, at 5:50 PM, Song Liu wrote:
>>>
>>> This patch adds capability for SCSI layer to generate uevent for SCSI
>>> sense code. The feature is gated by CONFIG_SCSI_SENSE_UEVENT.
On Mon, 2017-05-15 at 10:16 +0200, Martin Wilck wrote:
> On Fri, 2017-05-12 at 16:24 +, Bart Van Assche wrote:
> > Allowing races like the one this patch tries to address to exist
> > makes the ALUA code harder to maintain than necessary. Have you
> > considered to make alua_bus_detach() wait u
Make sure to drop the reference to the dma device taken by
of_find_device_by_node() on probe errors and on driver unbind.
Fixes: 334ae614772b ("sparc: Kill SBUS DVMA layer.")
Signed-off-by: Johan Hovold
---
drivers/scsi/sun_esp.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
dif
On Fri, 2017-05-12 at 16:24 +, Bart Van Assche wrote:
>
> Hello Martin,
>
> Allowing races like the one this patch tries to address to exist
> makes
> the ALUA code harder to maintain than necessary. Have you considered
> to
> make alua_bus_detach() wait until ALUA work has finished by using
Am 15.05.2017 16:56, schrieb Colin King:
> From: Colin Ian King
>
> The fields sense_data_size and sense_data are unitialized garbage from
> the stack and are being copied back to userspace. Fix this leak of
> stack information by ensuring they are zero'd.
>
> Detected by CoverityScan, CID#14
From: Colin Ian King
The fields sense_data_size and sense_data are unitialized garbage from
the stack and are being copied back to userspace. Fix this leak of
stack information by ensuring they are zero'd.
Detected by CoverityScan, CID#1435473 ("Uninitialized scalar variable")
Fixes: 423400e64
On Mon, 2017-05-15 at 08:04 +0200, Hannes Reinecke wrote:
> In general I like the idea; however, the 'filter' thingie is somewhat
> odd. I could somewhat buy into the idea of filtering for sense keys, but
> then I would have expected to use the 'sense_event_filter' as a bitmap
> of allowed sense ke
24 matches
Mail list logo
