mpt3sas: driver got task abort request just after it's .shutdown() function is invoked

2017-06-13 Thread Sreekanth Reddy
Hi All, I am using 4.9 kernel and I am observing NULL pointer deference type kernel panic in the below scenario, * Hotplug (i.e. hot add) the HBA (with a set of drives attached to it) to the system just few seconds before issuing "poweroff" command. * Observed that during drives discovery proces

[PATCH v2 07/15] qla2xxx: move fields from qla_hw_data to qla_qpair

2017-06-13 Thread Himanshu Madhani
From: Quinn Tran - Move chip_reset, enable_class_2 fields from qla_hw_data to qla_qpair to reduce cache thrash for target MQ. - Optimizations to reduce unnecessary memory load for good path io. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c |

[PATCH v2 03/15] qla2xxx: Enable Target Multi Queue

2017-06-13 Thread Himanshu Madhani
From: Quinn Tran Enable Multi Queue for Target mode. At Initiator LUN scan time, each LUN is assign to a QPair. Each QPair is affinitize to certain CPU. When new cmd arrives from the wire, the lunid is used to search for qpair. The qpair's affinitized cpuid will be used to queue up the work eleme

[PATCH v2 14/15] qla2xxx: Include Exchange offload/Extended Login into FW dump

2017-06-13 Thread Himanshu Madhani
From: Quinn Tran Add missing memory dump of Exchange Offload and Extended login into FW dump. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_dbg.c | 49 + drivers/scsi/qla2xxx/qla_dbg.h | 11 + drivers/s

[PATCH v2 06/15] qla2xxx: Add fw_started flags to qpair

2017-06-13 Thread Himanshu Madhani
From: Quinn Tran Add fw_started flag to qpair to reduce cache thrash. This reduce access to qla_hw_data structure by each qpair. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h| 21 + drivers/scsi/qla2xxx/qla_init.c | 4 +

[PATCH v2 04/15] qla2xxx: Fix mailbox failure while deleting Queue pairs

2017-06-13 Thread Himanshu Madhani
From: Sawan Chandak In target mode driver, queue pairs are not created during driver load time, instead they are created at the configuration time after chip reset. If a user tries to load/unload driver after queue pairs are created, then there would be mailbox failure, while deleting queue pairs

[PATCH v2 11/15] qla2xxx: Remove unused tgt_enable_64bit_addr flag

2017-06-13 Thread Himanshu Madhani
From: Quinn Tran By default this flag is forced to true. Remove this flag and unneccessary check for this flag. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_target.c | 44 --- drivers/scsi/qla2xxx/qla_target.h | 1

[PATCH v2 08/15] qla2xxx: use shadow register for ISP27XX

2017-06-13 Thread Himanshu Madhani
From: Quinn Tran For ISP27XX, use shadow register to read FW provided REQQ's consumer index. The shadow register is dma'ed by firmware. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h| 1 + drivers/scsi/qla2xxx/qla_init.c | 1 + drivers/scsi

[PATCH v2 05/15] qla2xxx: Add debug knob for user control workload

2017-06-13 Thread Himanshu Madhani
From: Quinn Tran For Target mode, user can control the work load by placing qla2xxx's irq vector on certain CPU via the smp_affinity knob. This patch allows user to control the number of QPair's irq to be active. The irqs are allocated at driver load time until unload. The work itself is placed o

[PATCH v2 10/15] qla2xxx: Add debug logging routine for qpair

2017-06-13 Thread Himanshu Madhani
From: Quinn Tran For target main path io routines that uses qpair, create new logging & debugging routines to use qpair instead of reaching for scsi_qla_host to reduce cache thrash. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_dbg.c| 101 +

[PATCH v2 15/15] qla2xxx: Update driver version to 9.01.00.00-k

2017-06-13 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani Signed-off-by: Giridhar Malavali --- drivers/scsi/qla2xxx/qla_version.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 45bc84e8e3bf..dcbb9bb05e99 100644 --- a/d

[PATCH v2 13/15] qla2xxx: Move target stat counters from vha to qpair.

2017-06-13 Thread Himanshu Madhani
From: Quinn Tran Move counters to qpair to reduce cache miss. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 27 +++-- drivers/scsi/qla2xxx/qla_dfs.c | 48 +++--- drivers/scsi/qla2xxx/qla_i

[PATCH v2 09/15] qla2xxx: Add function call to qpair for door bell

2017-06-13 Thread Himanshu Madhani
From: Quinn Tran Add call back to door bell for qpair. This help reduce access to qla_hw_data structure, in order to reduce cach thrash. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h| 3 ++ drivers/scsi/qla2xxx/qla_init.c | 3 ++ drivers/

[PATCH v2 02/15] qla2xxx: Preparation for Target MQ.

2017-06-13 Thread Himanshu Madhani
From: Quinn Tran In Current code, Req Q 0, RespQ 0 & hardware_lock are the main resources for sending and process completion of Target IO. These resources are now referenced behind a new qpair/"struct qla_qpair base_qpair". Main path IO handle will access those resources via the qpair pointer in

[PATCH v2 12/15] qla2xxx: Remove datasegs_per_cmd and datasegs_per_cont field

2017-06-13 Thread Himanshu Madhani
From: Quinn Tran These fields only hold one set of value. Replace it with macros to reduce cache thrash. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_target.c | 12 +--- drivers/scsi/qla2xxx/qla_target.h | 2 +- 2 files changed, 6 insertions(

[PATCH v2 00/15] qla2xxx: Add Target Multiqueue support

2017-06-13 Thread Himanshu Madhani
Hi Martin, Nic, This patch series adds support for multiqueue for qla2xxx target mode driver. This series depends on the seris applied to Martin's scsi/for-next branch (https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/log/?h=for-next) I've also added followig patch ("qla2xxx: Include

[PATCH v2 01/15] qla2xxx: Combine Active command arrays.

2017-06-13 Thread Himanshu Madhani
From: Quinn Tran Merge active/outstanding cmd arrays from target side and initiator side together in prepration for Target Multi Queue support. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h| 15 +++- drivers/scsi/qla2xxx/qla_gbl.h| 2 -

[PATCH v2] storvsc: use default I/O timeout handler for FC devices

2017-06-13 Thread Long Li
From: Long Li FC disks issue I/O directly to the host storage port driver, this is diffirent to VHD disks where I/O is virtualized and timeout is handled by the host VSP (Virtualization Service Provider). FC disks are usually setup in a multipath system, and they don't want to reset timer on I/O

RE: [PATCH] scsi: aacraid: fix leak of data from stack back to userspace

2017-06-13 Thread Dave Carroll
> -Original Message- > From: Colin King [mailto:colin.k...@canonical.com] > Sent: Monday, May 15, 2017 8:56 AM > To: Raghava Aditya Renukunta ; > dl-esc-Aacraid Linux Driver ; James E . J . Bottomley > ; Martin K . Petersen > ; linux-scsi@vger.kernel.org > Cc: kernel-janit...@vger.kernel.or

RE: [Possible Phish Fraud][PATCH] storvsc: use default I/O timeout handler for FC devices

2017-06-13 Thread Long Li
> -Original Message- > From: Bart Van Assche [mailto:bart.vanass...@sandisk.com] > Sent: Tuesday, June 13, 2017 8:38 AM > To: linux-ker...@vger.kernel.org; KY Srinivasan ; > martin.peter...@oracle.com; linux-scsi@vger.kernel.org; Stephen Hemminger > ; Long Li ; > j...@linux.vnet.ibm.com;

Re: [PATCH 0/7] Enable iSCSI offload drivers to use information from iface.

2017-06-13 Thread Robert LeBlanc
On Wed, Jun 7, 2017 at 12:30 PM, Robert LeBlanc wrote: > On Wed, Jun 7, 2017 at 10:28 AM, Chris Leech wrote: >> On Tue, Jun 06, 2017 at 12:07:10PM -0600, Robert LeBlanc wrote: >>> This patchset enables iSCSI offload drivers to have access to the iface >>> information provided by iscsid. This allo

Re: [Possible Phish Fraud][PATCH] storvsc: use default I/O timeout handler for FC devices

2017-06-13 Thread Bart Van Assche
On Mon, 2017-06-12 at 17:23 -0700, Long Li wrote: > From: Long Li > > FC disks are usually setup in a multipath system, and they don't want to > unconditionaly reset I/O on timeout. I/O timeout is detected by multipath > as a good time to failover and recover. > > Signed-off-by: Long Li > ---

Re: [ANNOUNCE]: Broadcom (Emulex) FC Target driver - efct

2017-06-13 Thread Martin K. Petersen
James, > To start this effort, I'd like a bcmlpfc directory to be made within > the drivers staging tree. The directory would be populated with the > efct driver and a copy of the existing lpfc driver. Work can then > commence on refactoring lpfc and creating the libraries and > integrating the

Re: [PATCH 6/6] sd: add support for TCG OPAL self encrypting disks

2017-06-13 Thread Martin K. Petersen
Christoph, >> But as we already set no_report_opcodes for all usb-storage and >> quirked uas devices I think the worst offenders are already covered >> anyway. > > Martin, how do we want to move ahead on this patch? I was suggesting the VPD because that may be easier for the SAS HBA vendors to a

Re: [PATCH 20/22] scsi: hisi_sas: Add v3 code to support ECC and AXI bus fatal error

2017-06-13 Thread John Garry
On 17/05/2017 13:38, John Garry wrote: On 17/05/2017 13:27, Arnd Bergmann wrote: On Wed, May 17, 2017 at 12:49 PM, John Garry wrote: > From: Xiang Chen > > For ECC 1bit error, logic can recover it, so we only print a warning. > For ECC multi-bit and AXI bus fatal error, we panic. > > Signed-o

RE: Application stops due to ext4 filesytsem IO error

2017-06-13 Thread Sumit Saxena
Gentle ping. I have opened kernel BZ for this. Here is the BZ link- https://bugzilla.kernel.org/show_bug.cgi?id=196057 Thanks, Sumit >-Original Message- >From: Sumit Saxena [mailto:sumit.sax...@broadcom.com] >Sent: Tuesday, June 06, 2017 9:05 PM >To: 'Jens Axboe' >Cc: 'linux-bl...@vger.ke

[PATCH][V2][target-devel-next] tcmu: make array tcmu_attrib_attrs static const

2017-06-13 Thread Colin King
From: Colin Ian King The array tcmu_attrib_attrs does not need to be in global scope, so make it static. Cleans up sparse warning: "symbol 'tcmu_attrib_attrs' was not declared. Should it be static?" Signed-off-by: Colin Ian King --- drivers/target/target_core_user.c | 2 +- 1 file changed, 1

[PATCH][target-devel-next] tcmu: make array tcmu_attrib_attrs static const

2017-06-13 Thread Colin King
From: Colin Ian King The guid intel_dsm_guid does not need to be in global scope, so make it static. Cleans up sparse warning: "symbol 'tcmu_attrib_attrs' was not declared. Should it be static?" Signed-off-by: Colin Ian King --- drivers/target/target_core_user.c | 2 +- 1 file changed, 1 inse

Re: [ANNOUNCE]: Broadcom (Emulex) FC Target driver - efct

2017-06-13 Thread Johannes Thumshirn
On 06/13/2017 01:08 AM, James Smart wrote: > Here's what I'd like to propose for a direction: > 1) Create an initiator driver and a target driver. For now, initiator > would support both SCSI and NVME initiator. Target would support SCSI > and NVME target. > 2) SLI3 support would be contained only

Re: [PATCH] storvsc: use default I/O timeout handler for FC devices

2017-06-13 Thread Johannes Thumshirn
On 06/13/2017 02:23 AM, Long Li wrote: > From: Long Li > > FC disks are usually setup in a multipath system, and they don't want to > unconditionaly reset I/O on timeout. I/O timeout is detected by multipath > as a good time to failover and recover. > > Signed-off-by: Long Li > --- Looks goo