Re: [PATCH 21/29] scsi: nsp32: constify pci_device_id.

2017-07-30 17:43 GMT+09:00 Arvind Yadav : > > pci_device_id are not supposed to change at runtime. All functions > working with pci_device_id provided by work with > const pci_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav

Re: [PATCH] tcmu: Oops in unmap_thread_fn()

On Tue, 2017-08-01 at 23:09 +0300, Dan Carpenter wrote: > Calling list_del() on the iterator pointer in list_for_each_entry() will > cause an oops. We need to user the _safe() version for that. > > Fixes: c73d02f63c16 ("tcmu: Add fifo type waiter list support to avoid > starvation") >

[PATCH] scsi: mpt3sas: Fix memory allocation failure test in 'mpt3sas_base_attach()'

In the lines above this test, 8 'kzalloc' are performed, but only 7 results are tested. Add the missing one (i.e. '!ioc->port_enable_cmds.reply'). Signed-off-by: Christophe JAILLET --- drivers/scsi/mpt3sas/mpt3sas_base.c | 8 1 file changed, 4

[PATCH 0/3] power: supply: charger-manager: 1 fix and 2 minor clean-ups

This patch series improves 'charger_manager_probe()'. The first patch is about a missing memory allocation failure test. The 2 others are just things spotted in this function: - a comment that is no more up to date - a style issue (which saves 1 line) Christophe JAILLET (3): power:

Re: [PATCH v06 04/36] uapi scsi/scsi_netlink_fc.h: use __u16, __u32 and __u64 from linux/types.h

On Sun, 2017-08-06 at 23:42 +0300, Mikko Rapeli wrote: > Hi, > > On Sun, Aug 06, 2017 at 11:22:53AM -0700, James Bottomley wrote: > > > > On Sun, 2017-08-06 at 18:43 +0200, Mikko Rapeli wrote: > > > > > > Fixes userspace compilation errors like: > > > > > > scsi/scsi_netlink_fc.h:60:2: error:

[PATCH] iscsi-target: Fix iscsi_np reset hung task during parallel delete

From: Nicholas Bellinger This patch fixes a bug associated with iscsit_reset_np_thread() that can occur during parallel configfs rmdir of a single iscsi_np used across multiple iscsi-target instances, that would result in hung task(s) similar to below where configfs rmdir

Re: [PATCH v06 04/36] uapi scsi/scsi_netlink_fc.h: use __u16, __u32 and __u64 from linux/types.h

Hi, On Sun, Aug 06, 2017 at 11:22:53AM -0700, James Bottomley wrote: > On Sun, 2017-08-06 at 18:43 +0200, Mikko Rapeli wrote: > > Fixes userspace compilation errors like: > > > > scsi/scsi_netlink_fc.h:60:2: error: expected specifier-qualifier-list > > before ‘uint64_t’ > > Rather than

Re: [PATCH v06 04/36] uapi scsi/scsi_netlink_fc.h: use __u16, __u32 and __u64 from linux/types.h

On Sun, 2017-08-06 at 18:43 +0200, Mikko Rapeli wrote: > Fixes userspace compilation errors like: > > scsi/scsi_netlink_fc.h:60:2: error: expected specifier-qualifier-list > before ‘uint64_t’ Rather than patching the kernel, why not #include in your userspace programme? James

Re: [Regression 4.13-rc1] Resume does not work on Lenovo X60t

Dear Christoph, On 2017-08-05 11:30, Christoph Hellwig wrote: On Thu, Aug 03, 2017 at 07:42:15PM +0200, Paul Menzel wrote: Since the merge windows opened for Linux 4.13, I am unable to resume from ACPI S3 suspend on a Lenovo X60t. The graphics comes back, but I am unable to enter anything,

[PATCH v06 02/36] uapi scsi/scsi_bsg_fc.h: use __u8, __u32 and __u64 from linux/types.h

Fixes userspace compilation errors like: scsi/scsi_bsg_fc.h:83:2: error: unknown type name ‘uint8_t’ Signed-off-by: Mikko Rapeli Cc: linux-scsi@vger.kernel.org --- include/uapi/scsi/scsi_bsg_fc.h | 54 + 1 file changed, 28

[PATCH v06 03/36] uapi scsi/scsi_netlink.h: use __u8, __u16 and __u64 from linux/types.h

Fixes userspace compilation errors like: scsi/scsi_netlink.h:43:2: error: unknown type name ‘uint8_t’ Signed-off-by: Mikko Rapeli Cc: linux-scsi@vger.kernel.org --- include/uapi/scsi/scsi_netlink.h | 22 +++--- 1 file changed, 11 insertions(+), 11

[PATCH v06 04/36] uapi scsi/scsi_netlink_fc.h: use __u16, __u32 and __u64 from linux/types.h

Fixes userspace compilation errors like: scsi/scsi_netlink_fc.h:60:2: error: expected specifier-qualifier-list before ‘uint64_t’ Signed-off-by: Mikko Rapeli Cc: linux-scsi@vger.kernel.org --- include/uapi/scsi/scsi_netlink_fc.h | 16 1 file changed, 8

Re: [PATCH 0/5] block-cciss: Fine-tuning for two function implementations

> Date: Thu, 18 Aug 2016 11:40:04 +0200 > > Some update suggestions were taken into account > from static source code analysis. > > Markus Elfring (5): > Use memdup_user() > Less function calls after error detection > Delete unnecessary initialisations > Move an assignment for the