While the 'state' attribute can (and will) change occasionally,
calling 'poll()' or 'select()' on it fails as sysfs is never
notified that the state has changed.
With this patch calling 'poll()' or 'select()' will work
properly.
Signed-off-by: Hannes Reinecke
Reviewed-by: Christoph Hellwig
Revie
Rework scsi_internal_device_unblock_nowait() into using a
switch statement.
No functional changes.
Signed-off-by: Hannes Reinecke
Reviewed-by: Christoph Hellwig
Reviewed-by: Johannes Thumshirn
---
drivers/scsi/scsi_lib.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
Hi all,
here's a small patchset to make the 'state' device attribute pollable.
It was supposed to be a small patch, but then hch suggested a rework.
So there you go.
Changes to v2:
- Removed duplicate case value found by kbuild robot
- Dropped state update patch
Hannes Reinecke (2):
scsi_lib:
On 08/11/2017 02:43 AM, Martin K. Petersen wrote:
>
> Hannes,
>
>> Each scsi device is scanned according to the found blacklist flags,
>> but this information is never presented to sysfs. This makes it quite
>> hard to figure out if blacklisting worked as expected. With this
>> patch we're expo
On 08/10/2017 09:15 PM, Don Brace wrote:
>> -Original Message-
>> From: Hannes Reinecke [mailto:h...@suse.de]
>> Sent: Thursday, August 10, 2017 9:11 AM
>> To: James Bottomley ;
>> Christoph Hellwig
>> Cc: Don Brace ; Martin K. Petersen
>> ; Meelis Roos ; linux-
>> s...@vger.kernel.org
>>
Hi Hannes,
[auto build test ERROR on mkp-scsi/for-next]
[also build test ERROR on v4.13-rc4 next-20170810]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Hannes-Reinecke/scsi-pollable-state
Bart Van Assche writes:
> On Thu, 2017-08-10 at 20:32 +1000, Michael Ellerman wrote:
>> "Martin K. Petersen" writes:
>> > > One of the two scsi-mq functions that requeue a request unprepares a
>> > > request before requeueing (scsi_io_completion()) but the other
>> > > function not (__scsi_queue_
Hannes,
> Each scsi device is scanned according to the found blacklist flags,
> but this information is never presented to sysfs. This makes it quite
> hard to figure out if blacklisting worked as expected. With this
> patch we're exporting an additional attribute 'blacklist' containing
> the b
Hannes,
> For testing purposes we need to be able to pass in the inquiry
> vendor and model.
This looks fine to me.
--
Martin K. Petersen Oracle Linux Engineering
Damien,
> Releasing a zone write lock only when the write commnand that acquired
> the lock completes can cause deadlocks due to potential command
> reordering if the lock owning request is requeued and not
> executed. This problem exists only with the scsi-mq path as, unlike
> the legacy path, r
Richard,
> v1 was here:
>
> https://lkml.org/lkml/2017/8/10/689
>
> v1 -> v2:
>
> Remove .can_queue field from the templates.
Applied to 4.14/scsi-queue. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
Manish,
> [qed_sp_iscsi_func_start:189(host_7-0)]Cannot satisfy CQ amount. Queues
> requested 8, CQs available 4. Aborting function start
>
> Above condition will resolve as management firmware is capable of telling
> us the number of CQs available for a given PF, qed will communicate the
> same
John,
> This patchset introduces an array of misc changes, most significantly
> including:
There were a couple of patches that did multiple things. In the future,
please make sure you only make one logical change per patch.
Applied to 4.14/scsi-queue. Thanks!
--
Martin K. Petersen Oracle
Pan,
> In function pm8001_pci_probe(), on errors that the control flow jumps to
> label err_out_ha_free, function pm8001_free() is called. In pm8001_free(),
> scsi_host_put() is called to release shost, which keeps the return value
> of scsi_host_alloc(). After pm8001_free() returns, kfree() is c
Pan,
> The return value of dma_map_single() should be checked by
> dma_mapping_error(). However, in function qla26xx_dport_diagnostics(),
> its return value is checked against NULL, which could result in
> failures.
Applied to 4.14/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineerin
Pan,
> The return value of scsi_host_alloc() should be released by
> scsi_host_put(). However, in function mvs_pci_init(), kfree()
> is used. This patch replaces kfree() with scsi_host_put() to avoid
> possible memory leaks.
Applied to 4.14/scsi-queue.
--
Martin K. Petersen Oracle Linux E
weiping,
> fix allocate instance->pd_info twice which was introduced by
> 96188a89cc6d.
Applied to 4.14/scsi-queue, thank you!
--
Martin K. Petersen Oracle Linux Engineering
Vivek,
> Can you kindly review this patch series (for UFS controller changes)
> and consider giving your Ack so that Kishon can pull in the series
> through phy tree.
SCSI piece looks OK.
Would still like Subhash to review the rest.
--
Martin K. Petersen Oracle Linux Engineering
Don,
> These patches are based on Linus's tree
>
> The changes are:
>
> - smartpqi-add-pqi-reset-quiesce-support
>- allow driver to confirm completion of a reset.
> - smartpqi-enhance-bmic-cache-flush
>- can now distinguish between shutdown and power
> management operation.
> - sm
Finn,
> This series has been tested on m68k Macs (ESP236 equivalent).
>
> Some more testing with different targets and devices (FAS236 etc)
> might be nice. Being that the esp_scsi fixes are on error paths, more
> review may actually be more valuable than more testing...
Applied to 4.14/scsi-que
Christoph,
> Looks good,
>
> Reviewed-by: Christoph Hellwig
Applied to 4.14/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Michał,
> Please drop this patch (only this one). I didn't notice, that the file
> is needed by modpost:
OK, done.
--
Martin K. Petersen Oracle Linux Engineering
On Fri, Aug 11, 2017 at 12:10:38AM +0200, Benjamin Block wrote:
> On Thu, Aug 10, 2017 at 11:32:17AM +0200, Christoph Hellwig wrote:
> > We can't use an on-stack buffer for the sense data, as drivers will
> > dma to it. So we should reuse the SCSI init_rq_fn() for the BSG
> > queues and/or impleme
On Thu, Aug 10, 2017 at 11:35:31AM +0200, Christoph Hellwig wrote:
> On Wed, Aug 09, 2017 at 04:11:19PM +0200, Benjamin Block wrote:
> > Since struct bsg_command is now used in every calling case, we don't
> > need separation of arguments anymore that are contained in the same
> > bsg_command.
> >
On Thu, Aug 10, 2017 at 10:24:56AM +0200, Johannes Thumshirn wrote:
> On Wed, Aug 09, 2017 at 04:11:18PM +0200, Benjamin Block wrote:
> > + return 0 == (bc->hdr.flags & BSG_FLAG_Q_AT_TAIL);
>
> return !(bc->hdr.flags & BSG_FLAG_Q_AT_TAIL); and make the function return
> bool? I have to admit, th
On Thu, Aug 10, 2017 at 11:32:17AM +0200, Christoph Hellwig wrote:
> We can't use an on-stack buffer for the sense data, as drivers will
> dma to it. So we should reuse the SCSI init_rq_fn() for the BSG
> queues and/or implement the same scheme.
>
BSG is odd in this regard. Here is the data mode
[cc's snipped to linux-scsi ]
On Thu, 2017-08-10 at 17:05 +, man...@openmail.cc wrote:
> Hello,
>
> I'd like to report this rare panic I experienced today. I've been on
> 4.12.3 since it was released and got this panic totally unexpected,
> probably when terminating my WL compositor. I at
On Fri, Aug 11, 2017 at 12:41:47AM +0300, Michael S. Tsirkin wrote:
> On Thu, Aug 10, 2017 at 10:35:11PM +0100, Richard W.M. Jones wrote:
> > On Fri, Aug 11, 2017 at 12:31:44AM +0300, Michael S. Tsirkin wrote:
> > > Then we probably should fail probe if vq size is too small.
> >
> > What does this
On Thu, Aug 10, 2017 at 10:35:11PM +0100, Richard W.M. Jones wrote:
> On Fri, Aug 11, 2017 at 12:31:44AM +0300, Michael S. Tsirkin wrote:
> > Then we probably should fail probe if vq size is too small.
>
> What does this mean?
>
> Rich.
We must prevent driver from submitting s/g lists > vq size
On Fri, Aug 11, 2017 at 12:31:44AM +0300, Michael S. Tsirkin wrote:
> Then we probably should fail probe if vq size is too small.
What does this mean?
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.
On Thu, Aug 10, 2017 at 10:30:38PM +0100, Richard W.M. Jones wrote:
> On Fri, Aug 11, 2017 at 12:21:16AM +0300, Michael S. Tsirkin wrote:
> > On Thu, Aug 10, 2017 at 05:40:34PM +0100, Richard W.M. Jones wrote:
> > > If using indirect descriptors, you can make the total_sg as large as
> > > you want
On Fri, Aug 11, 2017 at 12:21:16AM +0300, Michael S. Tsirkin wrote:
> On Thu, Aug 10, 2017 at 05:40:34PM +0100, Richard W.M. Jones wrote:
> > If using indirect descriptors, you can make the total_sg as large as
> > you want.
>
> That would be a spec violation though, even if it happens to
> work o
On Thu, Aug 10, 2017 at 05:40:34PM +0100, Richard W.M. Jones wrote:
> If using indirect descriptors, you can make the total_sg as large as
> you want.
That would be a spec violation though, even if it happens to
work on current QEMU.
The spec says:
A driver MUST NOT create a descriptor ch
> -Original Message-
> From: Hannes Reinecke [mailto:h...@suse.de]
> Sent: Thursday, August 10, 2017 9:11 AM
> To: James Bottomley ;
> Christoph Hellwig
> Cc: Don Brace ; Martin K. Petersen
> ; Meelis Roos ; linux-
> s...@vger.kernel.org
> Subject: Re: [PATCH RESEND 0/6] hpsa: support lega
Looks good.
Acked-by: Bradley Grove
On 07/30/2017 04:40 AM, Arvind Yadav wrote:
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav
---
On parisc I see this UBSAN warning with a sym53c896:
UBSAN: Undefined behaviour in ./drivers/scsi/sym53c8xx_2/sym_hipd.c:762:24
index -1903078336 is out of range for type 'u32 [7]'
Avoid this warning by switching to dev64_ul().
Signed-off-by: Helge Deller
diff --git a/drivers/scsi/sym53c8xx_
From: Kevin Barnett
Reviewed-by: Scott Benesh
Signed-off-by: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/smartpqi/smartpqi_init.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/smartpqi/smartpqi_init.c
b/drivers/scsi/smartpqi/smartpqi_
From: Kevin Barnett
Update the driver’s PCI IDs to match the latest
Microsemi controllers
Reviewed-by: Scott Benesh
Signed-off-by: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/smartpqi/smartpqi_init.c | 36 +
1 file changed, 14 insertions(+), 22 d
From: Kevin Barnett
Reviewed-by: Scott Benesh
Signed-off-by: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/smartpqi/smartpqi.h | 23 +
drivers/scsi/smartpqi/smartpqi_init.c | 58 ++---
drivers/scsi/smartpqi/smartpqi_sis.c | 30
From: Kevin Barnett
add PQI reset to driver shutdown callback to
work around controller bug.
During an 1.) OS shutdown or 2.) kexec outside of a kdump,
the Linux kernel will clear BME on our controller.
If BME is cleared during a controller/host PCIe transfer,
the controller will lock up.
So w
From: Kevin Barnett
Reviewed-by: Scott Benesh
Signed-off-by: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/smartpqi/smartpqi_init.c | 11 ++-
drivers/scsi/smartpqi/smartpqi_sis.c | 105 +++--
drivers/scsi/smartpqi/smartpqi_sis.h |3 -
3 files cha
From: Kevin Barnett
- make pass-thru requests bi-directional
Reviewed-by: Scott Benesh
Signed-off-by: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/smartpqi/smartpqi_init.c |4
1 file changed, 4 insertions(+)
diff --git a/drivers/scsi/smartpqi/smartpqi_init.c
b/drivers/
From: Kevin Barnett
- distinguish between shutdown and non-shutdown.
Reviewed-by: Scott Benesh
Signed-off-by: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/smartpqi/smartpqi.h | 21 +++--
drivers/scsi/smartpqi/smartpqi_init.c | 27 ++---
These patches are based on Linus's tree
The changes are:
- smartpqi-add-pqi-reset-quiesce-support
- allow driver to confirm completion of a reset.
- smartpqi-enhance-bmic-cache-flush
- can now distinguish between shutdown and power
management operation.
- smartpqi-update-pqi-passthr
if scsi_host_template->host_reset is NULL, when user
"echo adapter > /sys/class/scsi_host/hostx/host_reset",
-EINVAL will return even string compare successfully. It make user confuse.
change to:
-EINVAL if string not match "adapter" / "firmware";
-EOPNOTSUPP if string match but not im
On 08/10/17 10:05, man...@openmail.cc wrote:
> I'd like to report this rare panic I experienced today. I've been on
> 4.12.3 since it was released and got this panic totally unexpected,
> probably when terminating my WL compositor. I attach to this message a
> capture of the screen. The problem
On 10/08/2017 18:56, Richard W.M. Jones wrote:
> Since switching to blk-mq as the default in commit 5c279bd9e406
> ("scsi: default to scsi-mq"), virtio-scsi LUNs consume about 10x as
> much kernel memory.
>
> qemu currently allocates a fixed 128 entry virtqueue. can_queue
> currently is set to 10
If using indirect descriptors, you can make the total_sg as large as
you want. If not, BUG is too serious because the function later
returns -ENOSPC.
Thanks Paolo Bonzini, Christoph Hellwig.
Signed-off-by: Richard W.M. Jones
Reviewed-by: Paolo Bonzini
---
drivers/virtio/virtio_ring.c | 5 +++-
Since switching to blk-mq as the default in commit 5c279bd9e406
("scsi: default to scsi-mq"), virtio-scsi LUNs consume about 10x as
much kernel memory.
qemu currently allocates a fixed 128 entry virtqueue. can_queue
currently is set to 1024. But with indirect descriptors, each command
in the que
v1 was here:
https://lkml.org/lkml/2017/8/10/689
v1 -> v2:
Remove .can_queue field from the templates.
Rich.
#753: LSHW Causing Rewinds On LTO7 Drives
--+-
Reporter: a.richman@… | Owner: lyonel
Type: defect | Status: new
Priority: major| Milestone:
Component: lshw |Version:
Resolution: |
#753: LSHW Causing Rewinds On LTO7 Drives
-+
Reporter: a.richman@… | Owner: lyonel
Type: defect | Status: new
Priority: major| Milestone:
Component: lshw |Version:
Keywords: lto lto7
On 10/08/2017 18:40, Richard W.M. Jones wrote:
> Since switching to blk-mq as the default in commit 5c279bd9e406
> ("scsi: default to scsi-mq"), virtio-scsi LUNs consume about 10x as
> much kernel memory.
>
> qemu currently allocates a fixed 128 entry virtqueue. can_queue
> currently is set to 10
On 10/08/2017 18:40, Richard W.M. Jones wrote:
> If using indirect descriptors, you can make the total_sg as large as
> you want. If not, BUG is too serious because the function later
> returns -ENOSPC.
>
> Thanks Paolo Bonzini, Christoph Hellwig.
>
> Signed-off-by: Richard W.M. Jones
> ---
>
Earlier discussion:
https://lkml.org/lkml/2017/8/4/601
"Increased memory usage with scsi-mq"
Downstream bug report:
https://bugzilla.redhat.com/show_bug.cgi?id=1478201
If using indirect descriptors, you can make the total_sg as large as
you want. If not, BUG is too serious because the function later
returns -ENOSPC.
Thanks Paolo Bonzini, Christoph Hellwig.
Signed-off-by: Richard W.M. Jones
---
drivers/virtio/virtio_ring.c | 5 +++--
1 file changed, 3 inserti
Since switching to blk-mq as the default in commit 5c279bd9e406
("scsi: default to scsi-mq"), virtio-scsi LUNs consume about 10x as
much kernel memory.
qemu currently allocates a fixed 128 entry virtqueue. can_queue
currently is set to 1024. But with indirect descriptors, each command
in the que
On 10/08/2017 17:40, Richard W.M. Jones wrote:
> OK this is looking a bit better now.
>
> With scsi-mq enabled: 175 disks
> virtqueue_size=64: 318 disks *
> virtqueue_size=16: 775 disks *
> With scsi-mq disabled: 1755 disks
> * = new results
On 08/10/2017 10:26 AM, Bart Van Assche wrote:
> On Thu, 2017-08-10 at 20:32 +1000, Michael Ellerman wrote:
>> "Martin K. Petersen" writes:
One of the two scsi-mq functions that requeue a request unprepares a
request before requeueing (scsi_io_completion()) but the other
function no
From: Xiang Chen
This patch removes some repeated configurations:
(1) The device id of the device is already set in the
alloc function, so we don't need to modify in free
device function.
(2) Field dev_type and dev_status are configured in
hisi_sas_dev_gone(), so there is no need for repeated
con
The code to print ECC errors in v2 hw driver is very
repetitive.
This patch condensed the code by looping an array of
errors.
Signed-off-by: John Garry
Signed-off-by: Shiju Jose
---
drivers/scsi/hisi_sas/hisi_sas.h | 8 +
drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 368 +---
From: Xiang Chen
This patch is a fix related to free'ing a device in
v2 hw driver.
Before, we polled to ITCT CLR interrupt to check if
a device is free.
This was error prone, as if the interrupt doesn't occur
in 10us, we miss processing it.
To avoid this situation, service this interrupt and
s
From: Xiaofei Tan
This patch provides fixes for the following issues:
1. Fix issue of controller reset required to send
commands. For reset process, it may be required to send
commands to the controller, but not during soft reset.
So add HISI_SAS_NOT_ACCEPT_CMD_BIT to prevent executing a
task dur
From: Xiang Chen
The value dw0 is the residual bytes when UNDERFLOW error
happens, but we filled the residual with the value of dw3
before. So change the residual from dw3 to dw0.
Signed-off-by: Xiang Chen
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 4 ++--
1 file c
From: Xiang Chen
Modify STP link timer from 10ms to 500ms. Also add
the register address.
Signed-off-by: Xiang Chen
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
b/drivers/scs
From: Xiang Chen
This patch updates some register setting according
to recommendation from HW designer and experiment.
Signed-off-by: Xiang Chen
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --
From: Xiang Chen
For v3 hw, internal abort function required status and command buffer
to be set, so add necessary code for this.
Signed-off-by: Xiang Chen
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas_main.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
From: Xiaofei Tan
Add two ATA commands, ATA_CMD_ZAC_MGMT_IN and ATA_CMD_ZAC_MGMT_OUT
in hisi_sas_get_ata_protocol(), to support SATA SMR disk.
Signed-off-by: Xiaofei Tan
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas_main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/d
From: Xiang Chen
When some interrupts happen together, we need to process
every interrupt one-by-one, and should not return
immediately when one interrupt process is finished being
processed.
Signed-off-by: Xiang Chen
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 19 +
From: Xiang Chen
This patch adds support to clean-up allocated IRQs and
kill tasklets when probe fails and for driver removal.
Signed-off-by: Xiang Chen
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 96 +-
1 file changed, 49 insertions(
From: Xiang Chen
The channel interrupt is to process all the interrupts
except PHY UP/DOWN and broadcast interrupt. So we need to
clear all the interrupts except those 3 interrupts after
processing channel interrupts.
Signed-off-by: Xiang Chen
Signed-off-by: John Garry
---
drivers/scsi/hisi_s
From: Xiaofei Tan
Add DFX feature for v2 hw. We are adding support for
the following errors:
- loss_of_dword_sync_count
- invalid_dword_count
- phy_reset_problem_count
- running_disparity_error_count
Signed-off-by: Xiaofei Tan
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas.h
Variable res only holds value 0, so remove it.
This cleans up a coccicheck warning.
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
b/drivers/scsi/hisi_sas/hisi_sas
From: Xiang Chen
This patch adds calls to kill CQ takslets v3 hw during
probe failure.
Signed-off-by: Xiang Chen
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
b/drivers/scsi/hisi
The driver version is not updated with changes to the driver,
so it has no value, so just get rid of it.
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas.h | 2 --
drivers/scsi/hisi_sas/hisi_sas_main.c | 3 ---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 1 -
3 files changed, 6 d
From: Xiang Chen
Add function to set linkrate for v3 hw.
Signed-off-by: Xiang Chen
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 39 ++
1 file changed, 39 insertions(+)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
b/drivers/scs
From: Xiang Chen
Use ACPI "_RST" method to reset the controller, since
FLR is not supported.
Function hisi_sas_stop_phys() is introduced to remove
some code duplication.
Signed-off-by: Xiang Chen
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas.h | 2 +
drivers/scsi/hisi_
Instances of kfree(shost) should be replaced with
scsi_host_put().
In addition, a missing scsi_host_put() is added for
error path in hisi_sas_shost_alloc_pci() and v3 driver
removal.
Signed-off-by: Pan Bian # For main.c changes
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas_main.
This patchset introduces an array of misc changes, most
significantly including:
- v2 hw reset function
- core driver reset handler fixes
- DFX feature
- some interrupt/tasklet/probe+removal error path cleanup
John Garry (4):
scsi: hisi_sas: use array for v2 hw ECC errors
scsi: hisi_sas: remov
OK this is looking a bit better now.
With scsi-mq enabled: 175 disks
virtqueue_size=64: 318 disks *
virtqueue_size=16: 775 disks *
With scsi-mq disabled: 1755 disks
* = new results
I also ran the whole libguestfs test suite with virtqueue_si
On Thu, 2017-08-10 at 11:14 +0900, Damien Le Moal wrote:
> I am currently trying different approaches for this. In the mean time, I
> would like to see the unlock change patch be applied to fix the deadlock
> problem.
Hello Damien,
That approach sounds fine to me.
Bart.
On Thu, 2017-08-10 at 20:32 +1000, Michael Ellerman wrote:
> "Martin K. Petersen" writes:
> > > One of the two scsi-mq functions that requeue a request unprepares a
> > > request before requeueing (scsi_io_completion()) but the other
> > > function not (__scsi_queue_insert()). Make sure that a req
Hi Tejun, Kay,
I'm investigating a customer report which manifests itself all the way
up in gnome-session when a BMC hotplug-adds a simulated DVD device. The
user logs into their server's BMC and enables "media redirection", an
emulated DVD device + .iso is dynamically added to the bus... in the
On 10/08/2017 16:16, Richard W.M. Jones wrote:
> On Thu, Aug 10, 2017 at 02:53:58PM +0200, Paolo Bonzini wrote:
>> can_queue and cmd_per_lun are different. can_queue should be set to the
>> value of vq->vring.num where vq is the command virtqueue (the first one
>> is okay if there's >1).
>>
>> If
On Thu, 2017-08-10 at 09:05 +0200, Hannes Reinecke wrote:
> scsi_internal_device_unblock_nowait() allows a state transition
> SDEV_CREATED_BLOCK -> SDEV_TRANSPORT_OFFLINE/SDEV_OFFLINE,
> scsi_device_set_state() does not.
> So add the missing state transition to scsi_device_set_state().
>
> Signed-
On Thu, Aug 10, 2017 at 02:53:58PM +0200, Paolo Bonzini wrote:
> can_queue and cmd_per_lun are different. can_queue should be set to the
> value of vq->vring.num where vq is the command virtqueue (the first one
> is okay if there's >1).
>
> If you want to change it, you'll have to do so in QEMU.
On 08/10/2017 04:06 PM, James Bottomley wrote:
> On Thu, 2017-08-10 at 09:09 +0200, Christoph Hellwig wrote:
>> No device support in Linux is unsupported, sorry. I think we're
>> getting into the corporate bullshit game a little too much here.
>
> I think there are two different definitions of su
On Thu, 2017-08-10 at 09:09 +0200, Christoph Hellwig wrote:
> No device support in Linux is unsupported, sorry. I think we're
> getting into the corporate bullshit game a little too much here.
I think there are two different definitions of supported here. To us,
any device to which the driver at
[qed_sp_iscsi_func_start:189(host_7-0)]Cannot satisfy CQ amount. Queues
requested 8, CQs available 4. Aborting function start
Above condition will resolve as management firmware is capable of telling
us the number of CQs available for a given PF, qed will communicate the
same number to qedi, So th
On 10/08/2017 14:22, Richard W.M. Jones wrote:
> On Wed, Aug 09, 2017 at 06:50:10PM +0200, Paolo Bonzini wrote:
>> On 09/08/2017 18:01, Christoph Hellwig wrote:
>>> On Mon, Aug 07, 2017 at 03:07:48PM +0200, Paolo Bonzini wrote:
can_queue should depend on the virtqueue size, which unfortunately
On 08/10/2017 06:16 AM, Christoph Hellwig wrote:
> On Mon, Aug 07, 2017 at 02:29:47PM -0300, Guilherme G. Piccoli wrote:
>> Thanks for your feedback Hannes, agreed!
>
> And btw, you'll see similar results with the SCSI target or nbd,
> so it's not really nvme specific.
Thanks, I agree - noticed t
On Wed, Aug 09, 2017 at 06:50:10PM +0200, Paolo Bonzini wrote:
> On 09/08/2017 18:01, Christoph Hellwig wrote:
> > On Mon, Aug 07, 2017 at 03:07:48PM +0200, Paolo Bonzini wrote:
> >> can_queue should depend on the virtqueue size, which unfortunately can
> >> vary for each virtio-scsi device in theo
Looks good,
Reviewed-by: Christoph Hellwig
On Wed, Aug 09, 2017 at 04:11:19PM +0200, Benjamin Block wrote:
> Since struct bsg_command is now used in every calling case, we don't
> need separation of arguments anymore that are contained in the same
> bsg_command.
>
> Signed-off-by: Benjamin Block
> ---
> block/bsg.c | 13 ++---
>
On Thu, Aug 10, 2017 at 10:24:56AM +0200, Johannes Thumshirn wrote:
> On Wed, Aug 09, 2017 at 04:11:18PM +0200, Benjamin Block wrote:
> > + return 0 == (bc->hdr.flags & BSG_FLAG_Q_AT_TAIL);
>
> return !(bc->hdr.flags & BSG_FLAG_Q_AT_TAIL); and make the function return
> bool? I have to admit, th
Looks fine,
Reviewed-by: Christoph Hellwig
Looks fine,
Reviewed-by: Christoph Hellwig
We can't use an on-stack buffer for the sense data, as drivers will
dma to it. So we should reuse the SCSI init_rq_fn() for the BSG
queues and/or implement the same scheme.
Looks good,
Reviewed-by: Christoph Hellwig
On Thu, Aug 10, 2017 at 09:05:30AM +0200, Hannes Reinecke wrote:
> Rework scsi_internal_device_unblock_nowait() into using a
> switch statement.
> No functional changes.
>
> Signed-off-by: Hannes Reinecke
> ---
> drivers/scsi/scsi_lib.c | 18 --
> 1 file changed, 12 insertions(+)
1 - 100 of 120 matches
Mail list logo
