Re: [v4.13-rc BUG] system lockup when running big buffered write(4M) to IB SRP via mpath

2017-08-23 Thread Bart Van Assche
On Wed, 2017-08-23 at 19:35 +0800, Ming Lei wrote: > soft lockup still can be observed easily with patch d4acf3650c7c( > block: Make blk_mq_delay_kick_requeue_list() rerun the queue at a quiet time), > but no hard lockup. Hello Ming, I never claimed that commit d4acf3650c7c was a full solution to

Re: [GIT PULL] SCSI fixes for 4.13-rc6

2017-08-23 Thread Bart Van Assche
On Wed, 2017-08-23 at 07:42 +0100, James Bottomley wrote: > Six minor and error leg fixes, plus one major change: the reversion of > scsi-mq as the default. We're doing the latter temporarily (with a > backport to stable) to give us time to fix all the issues that turned > up with this default bef

[PATCH] scsi: lpfc: avoid false-positive gcc-8 warning

2017-08-23 Thread Arnd Bergmann
This is an interesting regression with gcc-8, showing a harmless warning for correct code: In file included from include/linux/kernel.h:13:0, ... from drivers/scsi/lpfc/lpfc_debugfs.c:23: include/linux/printk.h:301:2: error: 'eq' may be used uninitialized in this

Re: [PATCH] storvsc: do not assume SG list is continuous when doing bounce buffers (for 4.1 stable only)

2017-08-23 Thread Greg KH
On Tue, Aug 22, 2017 at 11:43:19PM -0700, Christoph Hellwig wrote: > Ok. If the stable maintainers are ok with your small fix > I'm not going to complain too loudly. But I'm always worried about > stable trees divering too much from mainline. Given that 90% of the time we do this, something brea

Re: [v4.13-rc BUG] system lockup when running big buffered write(4M) to IB SRP via mpath

2017-08-23 Thread Ming Lei
On Wed, Aug 23, 2017 at 07:35:26PM +0800, Ming Lei wrote: > On Wed, Aug 09, 2017 at 05:10:01PM +, Bart Van Assche wrote: > > On Wed, 2017-08-09 at 12:43 -0400, Laurence Oberman wrote: > > > Your latest patch on stock upstream without Ming's latest patches is > > > behaving for me. > > > > > >

Re: [Regression 4.13-rc1] Resume does not work on Lenovo X60t

2017-08-23 Thread Paul Menzel
Dear Christoph, On 08/23/17 13:48, Christoph Hellwig wrote: Are you running with blk-mq enabled? Also this never occured with 4.12, right? Were you also running with or without blk-mq for scsi there? To my knowledge, I am using the defaults from Debian 9. I’ll check in one week, as I am aw

Re: [Regression 4.13-rc1] Resume does not work on Lenovo X60t

2017-08-23 Thread Christoph Hellwig
Are you running with blk-mq enabled? Also this never occured with 4.12, right? Were you also running with or without blk-mq for scsi there?

[PATCH v3 13/14] megaraid_sas: call megasas_dump_frame with correct IO frame size

2017-08-23 Thread Shivasharan S
Signed-off-by: Kashyap Desai Signed-off-by: Shivasharan S Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl --- drivers/scsi/megaraid/megaraid_sas_base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/m

[PATCH v3 12/14] megaraid_sas: modified few prints in OCR and IOC INIT path

2017-08-23 Thread Shivasharan S
Signed-off-by: Kashyap Desai Signed-off-by: Shivasharan S Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion

[PATCH v3 14/14] megaraid_sas: driver version upgrade

2017-08-23 Thread Shivasharan S
Signed-off-by: Shivasharan S Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl --- drivers/scsi/megaraid/megaraid_sas.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h index 6d9f111..a6722c9

[PATCH v3 11/14] megaraid_sas: replace internal FALSE/TRUE definitions with false/true

2017-08-23 Thread Shivasharan S
Signed-off-by: Kashyap Desai Signed-off-by: Shivasharan S Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl --- drivers/scsi/megaraid/megaraid_sas_fp.c | 40 + 1 file changed, 15 insertions(+), 25 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas

[PATCH v3 10/14] megaraid_sas: Return pended IOCTLs with cmd_status MFI_STAT_WRONG_STATE in case adapter is dead

2017-08-23 Thread Shivasharan S
Fix - After a kill adapter, since the cmd_status is not set the IOCTLs will be hung in driver resulting in application hang. Set cmd_status MFI_STAT_WRONG_STATE when completing pended IOCTLs. Signed-off-by: Kashyap Desai Signed-off-by: Shivasharan S Cc: sta...@vger.kernel.org Reviewed-by: Hannes

[PATCH v3 07/14] megaraid_sas: Check valid aen class range to avoid kernel panic

2017-08-23 Thread Shivasharan S
Signed-off-by: Kashyap Desai Signed-off-by: Shivasharan S Cc: sta...@vger.kernel.org Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl --- drivers/scsi/megaraid/megaraid_sas_base.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/driv

[PATCH v3 09/14] megaraid_sas: use vmalloc for crash dump buffers and driver's local RAID map

2017-08-23 Thread Shivasharan S
Driver's local RAID map is accessed frequently. We will first try to get memory from __get_free_pages. If this fails, fall back to using vmalloc. For crash dump buffers always prefer vmalloc. Signed-off-by: Kashyap Desai Signed-off-by: Shivasharan S Reviewed-by: Hannes Reinecke Reviewed-by: Tom

[PATCH v3 08/14] megaraid_sas: Use SMID for Task abort case only

2017-08-23 Thread Shivasharan S
Fix - In TM code, smid_task is valid only in case of task aborts. Signed-off-by: Kashyap Desai Signed-off-by: Shivasharan S Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff -

[PATCH v3 06/14] megaraid_sas: Fix endianness issues in DCMD handling

2017-08-23 Thread Shivasharan S
Signed-off-by: Kashyap Desai Signed-off-by: Shivasharan S Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl --- drivers/scsi/megaraid/megaraid_sas_base.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/m

[PATCH v3 04/14] megaraid_sas: Call megasas_complete_cmd_dpc_fusion every 1 second while there are pending commands

2017-08-23 Thread Shivasharan S
Fix - megasas_wait_for_outstanding_fusion checks for pending commands every 1second. But megasas_complete_cmd_dpc_fusion is only called every 5seconds. If the commands are already completed by firmware, there is an additional delay of 5seconds before driver will process completion for these command

[PATCH v3 05/14] megaraid_sas: Do not re-fire shutdown DCMD after OCR

2017-08-23 Thread Shivasharan S
Signed-off-by: Kashyap Desai Signed-off-by: Shivasharan S Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/mega

[PATCH v3 03/14] megaraid_sas: Use synchronize_irq in target reset case

2017-08-23 Thread Shivasharan S
Similar to task abort case, use synchronize_irq API in target reset case. Also, remove redundant call to megasas_complete_cmd_dpc_fusion after calling megasas_sync_irqs in task abort case. Signed-off-by: Kashyap Desai Signed-off-by: Shivasharan S Reviewed-by: Hannes Reinecke Reviewed-by: Tomas

[PATCH v3 01/14] megaraid_sas: mismatch of allocated MFI frame size and length exposed in MFI MPT pass through command

2017-08-23 Thread Shivasharan S
Fix - Driver allocated 256 byte MFI frames bytes but while sending MFI frame (embedded inside chain frame of MPT frame) to firmware, driver sets the length as 4k. This results in DMA read error messages during boot. Signed-off-by: Kashyap Desai Signed-off-by: Shivasharan S Cc: sta...@vger.ke

[PATCH v3 02/14] megaraid_sas: set minimum value of resetwaittime to be 1 secs

2017-08-23 Thread Shivasharan S
Setting resetwaittime to 0 during a FW fault will result in driver not calling the OCR. Signed-off-by: Kashyap Desai Signed-off-by: Shivasharan S Cc: sta...@vger.kernel.org Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl --- drivers/scsi/megaraid/megaraid_sas_base.c | 3 ++- 1 file chan

[PATCH v3 00/14] megaraid_sas: Updates for scsi-next

2017-08-23 Thread Shivasharan S
Changes from v2: - Patch 9: Updated patch description - Dropped patch 11 of the last series. As per discussion with Christoph Hellwig, there was concern over the blk-mq specific hack in the changes. Also this needs to be tested with latest blk-mq performance improvements patchset from Ming.

Re: [v4.13-rc BUG] system lockup when running big buffered write(4M) to IB SRP via mpath

2017-08-23 Thread Ming Lei
On Wed, Aug 09, 2017 at 05:10:01PM +, Bart Van Assche wrote: > On Wed, 2017-08-09 at 12:43 -0400, Laurence Oberman wrote: > > Your latest patch on stock upstream without Ming's latest patches is > > behaving for me. > > > > As already mentioned, the requeue -11 and clone failure messages are

Re: possible circular locking dependency detected [was: linux-next: Tree for Aug 22]

2017-08-23 Thread Peter Zijlstra
On Wed, Aug 23, 2017 at 09:03:04AM +0900, Byungchul Park wrote: > On Tue, Aug 22, 2017 at 09:43:56PM +, Bart Van Assche wrote: > The report is talking about the following lockup: > > A work in a worker A task work on exit to user > -- --

<    1   2