[PATCH] scsi: fix the issue that iscsi_if_rx doesn't parse nlmsg properly

2017-08-27 Thread Xin Long
ChunYu found a kernel crash by syzkaller: [ 651.617875] kasan: CONFIG_KASAN_INLINE enabled [ 651.618217] kasan: GPF could be caused by NULL-ptr deref or user memory access [ 651.618731] general protection fault: [#1] SMP KASAN [ 651.621543] CPU: 1 PID: 9539 Comm: scsi Not tainted 4.11.0.

Re: [PATCH] scsi: fix the issue that iscsi_if_rx doesn't parse nlmsg properly

2017-08-27 Thread Xin Long
cc j...@linux.vnet.ibm.com On Mon, Aug 28, 2017 at 12:25 AM, Xin Long wrote: > ChunYu found a kernel crash by syzkaller: > > [ 651.617875] kasan: CONFIG_KASAN_INLINE enabled > [ 651.618217] kasan: GPF could be caused by NULL-ptr deref or user memory > access > [ 651.618731] general protection

Re: No I/O errors reported after SATA link hard reset

2017-08-27 Thread Gionatan Danti
Il 26-08-2017 22:58 sonofa...@openmailbox.org ha scritto: Hello guys, this is a very interesting thread but I will join it tomorrow! I have read a similar discussion for SSDs some time ago. That took place here [1]. Corruption of such devices can lead to complete data loss and not just corrupti

RE: [PATCH 07/19] Fix RCU handling of scsi_device.vpd_pg8[03]

2017-08-27 Thread Seymour, Shane M
> Hello Shane, > > You have either misinterpret my statement or the SCSI VPD handling code. If > you have a look at the SCSI VPD handling code you will see that an > rcu_read_lock() / > rcu_read_unlock() pair is sufficient to prevent that the VPD buffer > rcu_dereference() points at is being modif

Re: [PATCH] scsi: qedi: off by one in qedi_get_cmd_from_tid()

2017-08-27 Thread Rangankar, Manish
On 25/08/17 4:06 PM, "Dan Carpenter" wrote: >The > here should be >= or we end up reading one element beyond the end >of the qedi->itt_map[] array. The qedi->itt_map[] array is allocated in >qedi_alloc_itt(). > >Fixes: ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI >driver framew

RE: [PATCH 1/2] Introduce scsi_get_vpd_buf()

2017-08-27 Thread Seymour, Shane M
Reviewed-by: Shane Seymour > -Original Message- > From: Bart Van Assche [mailto:bart.vanass...@wdc.com] > Sent: Saturday, August 26, 2017 6:36 AM > To: Martin K . Petersen ; James E . J . > Bottomley > Cc: linux-scsi@vger.kernel.org; Bart Van Assche ; > Christoph Hellwig ; Hannes Reineck

RE: [PATCH 2/2] Rework handling of scsi_device.vpd_pg8[03]

2017-08-27 Thread Seymour, Shane M
Hi Bart, Comments inline below about the show_vpd_##_page macro. > -Original Message- > From: Bart Van Assche [mailto:bart.vanass...@wdc.com] > Sent: Saturday, August 26, 2017 6:36 AM > To: Martin K . Petersen ; James E . J . > Bottomley > Cc: linux-scsi@vger.kernel.org; Bart Van Assche