Hi, Matt,
I found that 4ee34ea3a12396f35b26d90a094c75db ("libata: Align ata_device's id
on a cacheline") can resolve everything. Because the size of id[ATA_ID_WORDS]
is already aligned and devslp_timing needn't to be aligned. So, In V9 of this
series I will drop this patch. Why I had problems b
Hello Himanshu,
If I load the qla2xxx driver
(git://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git,
4.15/scsi-queue) then a new kernel warning appears. This did not happen with
kernel v4.13.
Can you have a look?
qla2xxx [:00:00.0]-0005: : QLogic Fibre Channel HBA Driver: 10.00.00.02-k
Hi Huacai,
[auto build test ERROR on linus/master]
[also build test ERROR on v4.14-rc5 next-20171018]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Huacai-Chen/dma-mapping-Rework-dma_get_cache_
> On Tue, Oct 17, 2017 at 01:35:21PM -0400, Cathy Avery wrote:
> > + /*
> > +* Set the error handler work queue.
> > +*/
> > + snprintf(host_dev->work_q_name, sizeof(host_dev-
> >work_q_name),
> > +"storvsc_error_wq_%d", host->host_no);
> > + host_dev->handle_error_wq =
>
Hey Christoph,
better late than never I guess.
On Tue, Oct 03, 2017 at 12:48:45PM +0200, Christoph Hellwig wrote:
> The current BSG design tries to shoe-horn the transport-specific passthrough
> commands into the overall framework for SCSI passthrough requests. This
> has a couple problems:
>
>
On Tue, Oct 17, 2017 at 01:35:21PM -0400, Cathy Avery wrote:
> + /*
> + * Set the error handler work queue.
> + */
> + snprintf(host_dev->work_q_name, sizeof(host_dev->work_q_name),
> + "storvsc_error_wq_%d", host->host_no);
> + host_dev->handle_error_wq =
> +
On Tue, Oct 17, 2017 at 01:55:43PM +0200, Marek Szyprowski wrote:
> If I remember correctly, kernel guarantees that each kmalloced buffer is
> always at least aligned to the CPU cache line, so CPU cache can be
> invalidated on the allocated buffer without corrupting anything else.
Yes, from slab.h
On Tue, Oct 17, 2017 at 04:05:40PM +0800, Huacai Chen wrote:
> In non-coherent DMA mode, kernel uses cache flushing operations to
> maintain I/O coherency, so scsi's block queue should be aligned to
> ARCH_DMA_MINALIGN. Otherwise, If a DMA buffer and a kernel structure
> share a same cache line, an
On Wed, Oct 18, 2017 at 10:23:36AM -0700, Mark Greer wrote:
> > #defineMPSC_RXR_ENTRIES32
> > -#defineMPSC_RXRE_SIZE dma_get_cache_alignment()
> > +#defineMPSC_RXRE_SIZE dma_get_cache_alignment(dma_dev)
>
> I would much prefer that you add a parameter to the
Hi Christoph,
On Thursday, 19 October 2017 17:06:57 EEST Christoph Hellwig wrote:
> > Now we have 9 const instances of the config_item_type structure that are
> > identical, with only the .ct_owner field set. Should they be all merged
> > into a single structure ?
>
> I think that's a good idea.
---
Documentation/scsi/scsi-parameters.txt | 8
1 file changed, 8 insertions(+)
diff --git a/Documentation/scsi/scsi-parameters.txt
b/Documentation/scsi/scsi-parameters.txt
index 8477655..5b87a11 100644
--- a/Documentation/scsi/scsi-parameters.txt
+++ b/Documentation/scsi/scsi-parameter
>
> Now we have 9 const instances of the config_item_type structure that are
> identical, with only the .ct_owner field set. Should they be all merged into
> a
> single structure ?
I think that's a good idea.
But I'm about to slurp up this whole series into my tree, how about making
that an i
Hello,
I need your partnership in this project that requires trust and confidentiality.
An American, Mr. Charles Balassi who worked with the Egyptian General
Petroleum Corporation (EGPC), made a fixed deposit of Twenty Two
Million United States Dollars($22,000,000) for 17 Years in my
bank(Dubai I
Earlier, driver load fails if memory allocation for request frame pool
fails due to the higher queue_depth requirement. Patch 0016 in this
series allows dynamically reducing queue_depth if memory allocations
fail rather than failing load.
With this, there is no need to limit queue_depth to 1k now.
The latest MegaRAID Firmware (for Invader series) have support for
64bit DMA for both streaming and consistent DMA buffers.
All Ventura series controller FW always support 64 bit consistent DMA.
Also on few architectures 32bit DMA is not supported.
Current driver always prefers 32bit for consisten
Code fix - cmd->frame->dcmd.opcode will be valid only for MFI_CMD_DCMD
IOCTL frames. Currently driver check for cmd->frame->dcmd.opcode without
checking cmd type. Ensure we check dcmd opcode only for MFI_CMD_DCMD
commands. Separate handling of MFI_CMD_SMP/STP commands from
MFI_CMD_DCMD in completio
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas.h
b/drivers/scsi/megaraid/megaraid_sas.h
index b34fc68c14c9..f5a36ccb8606 100644
--- a/drivers/scsi/megaraid/megaraid_s
In certain cases, the host memory is limited and with FW supporting higher
queue depths there are increasing chances of IO request frame allocation
failures that we are seeing. In case of request frame allocation failures,
retry allocation with reduced queue depth (in steps of 64) to continue
to co
Increase Code readability. No Functional Change
Signed-off-by: Kashyap Desai
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_base.c | 64 ++-
1 file changed, 37 insertions(+), 27 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
Signed-off-by: Kashyap Desai
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c
b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index cd997ccf5ebf..340
fusion_context structure is very large around 180kB
and most of the size is contributed by log_to_span
array. Move log_to_span out of fusion context and have
separate allocation for log_to_span. And use kmalloc
to allocate fusion_context.
Currently kmemleak reports 1000s of false positives for
fusi
Code refactoring - create separate functions to allocate and free
controller DMA buffers
Signed-off-by: Kashyap Desai
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_base.c | 186 +-
1 file changed, 103 insertions(+), 83 deletions(-)
diff --git a
Older firmware version unconditionally pulls 4k frame for
IOC INIT MFA frame.
But driver allocates 1k or 4k max_chain_frame_sz based on FW capability.
During boot time, this results in DMA read errors.
Workaround fix in driver by allocating separate ioc_init frame of 4k size
to support older firmwa
No functional change.
Refactor adapter_type to set for all generation controllers, not
just for fusion controllers.
Signed-off-by: Kashyap Desai
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas.h| 8 +++
drivers/scsi/megaraid/megaraid_sas_base.c | 88 ++
Code refactoring, no functional change - Create new function to initialize
all the controller parameters during load time.
Signed-off-by: Kashyap Desai
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_base.c | 119 +++---
1 file changed, 61 insertions(
No functional change.
Signed-off-by: Kashyap Desai
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas.h| 1 -
drivers/scsi/megaraid/megaraid_sas_base.c | 9 -
drivers/scsi/megaraid/megaraid_sas_fp.c | 10 +-
drivers/scsi/megaraid/megaraid_sas_fus
Add support for PCI VID/DID 0x1000/0x0015 based MegaRAID controllers.
Since the DID 0x0015 conflicts with DELL PERC5 controllers,
add vendor ID based check specific for DELL PERC5.
Signed-off-by: Kashyap Desai
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas.h | 1 +
dr
No functional change. Code refactoring to improve readability.
Move the code to allocate and free controller memory into
separate functions.
Signed-off-by: Kashyap Desai
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_base.c | 122 +++---
1 file chang
Re-use the pre-allocated ctrl_info DMA buffer.
Signed-off-by: Kashyap Desai
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas.h | 1 -
drivers/scsi/megaraid/megaraid_sas_base.c | 43 ++-
2 files changed, 14 insertions(+), 30 deletions(-)
diff
Shivasharan S (19):
megaraid_sas: use adapter_type for all gen controllers
megaraid_sas: Add support for Crusader controllers
megaraid_sas: replace instance->ctrl_context checks with
instance->adapter_type
megaraid_sas: Remove redundant checks for ctrl_context
megaraid_sas: replace is
Pre-allocate few of the frequently used DMA buffers during load time.
Signed-off-by: Kashyap Desai
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas.h| 13 +++
drivers/scsi/megaraid/megaraid_sas_base.c | 147 ++--
drivers/scsi/megaraid/megara
Driver needs to send current host time to firmware during init.
Signed-off-by: Kashyap Desai
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c
b/drivers/scsi/megara
Signed-off-by: Kashyap Desai
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_base.c | 43 ---
1 file changed, 28 insertions(+), 15 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
b/drivers/scsi/megaraid/megaraid_sas_base.c
ind
On 18/10/17 14:03, Tejun Heo wrote:
On Tue, Oct 17, 2017 at 04:05:42PM +0800, Huacai Chen wrote:
In non-coherent DMA mode, kernel uses cache flushing operations to
maintain I/O coherency, so in ata_do_dev_read_id() the DMA buffer
should be aligned to ARCH_DMA_MINALIGN. Otherwise, If a DMA buff
34 matches
Mail list logo
