It is very expensive to atomic_inc/atomic_dec the host wide counter of
host->busy_count, and it should have been avoided via blk-mq's mechanism
of getting driver tag, which uses the more efficient way of sbitmap queue.
Also we don't check atomic_read(&sdev->device_busy) in scsi_mq_get_budget()
and
Sayın ilgili,
Biz 20 yılı aşkın bir süredir internet üzerinden profesyonel olarak
TERCÜME HİZMETLERİ veren bir kuruluşuz. 2017 başında firmalara özel, sayfası 20
TL+KDV'lik bir kampanya hazırladık.
Sadece İNGİLİZCE - TÜRKÇE ve TÜRKÇE - İNGİLİZCE çevirilerde geçerli olan ve
kısa bir süre
devam
Add 64GBIT and 128GBIT port speed definitions.
Upcoming hardware will reference these speeds.
Signed-off-by: James Smart
---
drivers/scsi/scsi_transport_fc.c | 2 ++
include/scsi/scsi_transport_fc.h | 2 ++
2 files changed, 4 insertions(+)
diff --git a/drivers/scsi/scsi_transport_fc.c b/driver
The driver currently registers any remote port that has NVME support.
It should only be registering target ports.
Register only target ports.
Signed-off-by: Dick Kennedy
Signed-off-by: James Smart
---
drivers/scsi/lpfc/lpfc_hbadisc.c | 20
drivers/scsi/lpfc/lpfc_nvme.c
The driver's interaction with the host nvme transport has been
incorrect for a while. The driver did not wait for the unregister
callbacks (waited only 5 jiffies). Thus the driver may remove
objects that may be referenced by subsequent abort commands from
the transport, and the actual unregister ca
Update the driver version to 11.4.0.5
Signed-off-by: Dick Kennedy
Signed-off-by: James Smart
---
drivers/scsi/lpfc/lpfc_version.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h
index e0181371af09..cc2f5cec9
The current default for async hw receive queues is 1, which presents
issues under heavy load as number of queues influence the available
async receive buffer limits.
Raise the default to the either the current hw limit (16) or the number
of hw qs configured (io channel value).
Revise the attribut
The logic for sg_seg_cnt is a bit convoluted. This patch tries to
clean up a couple of areas, especially around the +2 and +1 logic.
This patch:
- cleans up the lpfc_sg_seg_cnt attribute to specify a real minimum
rather than making the minimum be whatever the default is.
- Remove the hardcoding
During RSCN storms, the driver does not rediscover some targets.
The driver marks some RSCN as to be handled after the ones it's
working on. The driver missed processing some deferred RSCN.
Move where the driver checks for deferred RSCNs and initiate
deferred RSCN handling if the flag was set. Als
pt2pt ndlp ref count prematurely goes to 0. There was reference
removed that should only be removed if connected to a switch,
not if in point-to-point mode.
Add a mode check before the reference remove.
Signed-off-by: Dick Kennedy
Signed-off-by: James Smart
---
drivers/scsi/lpfc/lpfc_els.c | 4
During driver unload, the driver may crash due to NULL pointers.
The NULL pointers were due to the driver not protecting itself
sufficiently during some of the teardown paths.
Additionally, the driver was not waiting for and cleanup up nvme
io resources. As such, the driver wasn't making the callba
performing an LS abort results in the following message being seen:
0603 Invalid CQ subtype 6: 0300 2202 0016 d005
and the associated exchange is not properly freed.
The code did not recognize the exchange type that was aborted, thus
it was not properly handled.
Correct by addin
Display for lpfc/fnX/iDiag/queInfo isn't formatted perfectly.
Corrected the format strings for the queue info debug messages.
Signed-off-by: Dick Kennedy
Signed-off-by: James Smart
---
drivers/scsi/lpfc/lpfc_debugfs.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --
When the HBA is connected to a private loop, the driver
reports FLOGI loop-open failure as functional error. This is
an expected condition.
Mark loop-open failure as a warning instead of error.
Signed-off-by: Dick Kennedy
Signed-off-by: James Smart
---
drivers/scsi/lpfc/lpfc_els.c | 35 +++
When the driver is unloading, the nvme transport could be in the
process of submitting new requests, will send abort requests to
terminate associations, or may make LS-related requests.
The driver's abort and request entry points currently is ignorant
of the unloading state and is starting the requ
In test cases where an instance of the driver is detached and
reattached, the driver will crash on reattachment. There is a
compound if statement that will skip over the bar setup if
the pci_resource_start call is not successful. The driver
erroneously returns success to its bar setup in this scena
XRI_ABORTED_CQE completions were not being handled in the fast path.
They were being queued and deferred to the lpfc worker thread
for processing. This is an artifact of the driver design prior
to moving queue processing out of the isr and into a workq
element. Now that queue processing is already
This patch set provides a number of bug fixes and additions to
the driver.
The patches were cut against the Martin's 4.15/scsi-queue tree.
There are no outside dependencies.
James Smart (17):
lpfc: FLOGI failures are reported when connected to a private loop.
lpfc: Expand WQE capability of ev
The driver does not respond to PLOGI from the direct attach target.
The driver uses incorrect S_ID in CONFIG_LINK, after FLOGI completion
Correct by issuing CONFIG_LINK with the correct S_ID after receiving
the PLOGI from the target
Signed-off-by: Dick Kennedy
Signed-off-by: James Smart
---
dr
Hardware queues are a fast staging area to push commands into the adapter.
The adapter should drain them extremely quickly. However, under heavy
io load, the host cpu is pushing commands faster than the drain rate of
the adapter causing the driver to resource busy commands.
Enlarge the hardware qu
Raise the maximum NVME sg list size allowed to 256 elements.
Signed-off-by: Dick Kennedy
Signed-off-by: James Smart
---
drivers/scsi/lpfc/lpfc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/lpfc/lpfc.h b/drivers/scsi/lpfc/lpfc.h
index 7219b6ce5dc7..46a89bdff8
Use the sgl_alloc_order() and sgl_free_order() functions instead
of open coding these functions.
Signed-off-by: Bart Van Assche
Acked-by: Brian King
Reviewed-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
Cc: Martin K. Petersen
Cc: linux-scsi@vger.kernel.org
---
drivers/scsi/Kconfig |
Signed-off-by: Bart Van Assche
Reviewed-by: Johannes Thumshirn
Cc: linux-scsi@vger.kernel.org
Cc: Martin K. Petersen
Cc: Anil Ravindranath
---
drivers/scsi/pmcraid.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/pmcraid.h b/drivers/scsi/pmcraid.h
index 8bfac72a242b..44da91712
Use the sgl_alloc_order() and sgl_free_order() functions instead
of open coding these functions.
Signed-off-by: Bart Van Assche
Reviewed-by: Johannes Thumshirn
Cc: linux-scsi@vger.kernel.org
Cc: Martin K. Petersen
Cc: Anil Ravindranath
---
drivers/scsi/Kconfig | 1 +
drivers/scsi/pmcraid.c
From: Markus Elfring
Date: Fri, 3 Nov 2017 22:20:38 +0100
Add a jump target so that a bit of exception handling can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/target/iscsi/iscsi_target_param
Make use of the swap macro and remove unnecessary variable tmp.
This makes the code easier to read and maintain.
This code was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva
---
drivers/scsi/bnx2i/bnx2i_hwi.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
head: 1c356ec5e932c8d4c83d9782ab3c4164b6471d5d
commit: 016d5c35e27824f31c394009dd0f72f2c6b0dc85 [182/194] scsi: mpt3sas: SGL
to PRP Translation for I/Os to NVMe devices
config: i386-randconfig-x071-201744 (attached as
Make use of the swap macro and remove unnecessary variable keep_nlp_flag.
This makes the code easier to read and maintain.
This code was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva
---
drivers/scsi/lpfc/lpfc_els.c | 6 ++
1 file changed, 2 insertions(+), 4 delet
One minor fix in the error leg of the qla2xxx driver (it oopses the
system if we get an error trying to start the internal kernel thread).
The fix is minor because the problem isn't often encountered in the
field (although it can be induced by inserting the module in a low
memory environment).
Th
This patch calls the new nvme transport routine for dev_loss_tmo
whenever the SCSI fc transport calls the lldd to make a dynamic
change to a remote ports dev_loss_tmo.
Signed-off-by: James Smart
---
This lpfc patch, as dependent upon the new nvme transport
nvme_fc_set_remoteport_devloss() call,
sorry or the noise. disregard. didn't pick up the chg
Suganath,
> Ventura Series controller are Tri-mode. The controller and firmware
> are capable of supporting NVMe devices and PCIe switches to be
> connected with the controller. This patch set adds driver level
> support for NVMe devices and PCIe switches.
Applied to 4.15/scsi-queue. Thanks!
--
This patch calls the new nvme transport routine for dev_loss_tmo
whenever the SCSI fc transport calls the lldd to make a dynamic
change to a remote ports dev_loss_tmo.
Signed-off-by: James Smart
---
This lpfc patch, as dependent upon the new nvme transport
nvme_fc_set_remoteport_devloss() call,
please disregard. A v2 that ensures CONFIG_NVME_FC is enabled is on its way
-- james
On 11/3/2017 9:12 AM, James Smart wrote:
This patch calls the new nvme transport routine for dev_loss_tmo
whenever the SCSI fc transport calls the lldd to make a dynamic
change to a remote ports dev_loss_tmo.
Cathy,
> When running multipath on a VM if all available paths go down the
> driver can schedule large amounts of storvsc_remove_lun work items to
> the same lun. In response to the failing paths typically storvsc
> responds by taking host->scan_mutex and issuing a TUR per lun. If
> there has bee
Vasyl,
> drivers/scsi/lpfc/lpfc_debugfs.c:5460:22-29: WARNING: kzalloc should be used
> for phba -> nvmeio_trc, instead of kmalloc/memset
> drivers/scsi/lpfc/lpfc_debugfs.c:2230:20-27: WARNING: kzalloc should be used
> for phba -> nvmeio_trc, instead of kmalloc/memset
>
> Use kzalloc rather th
Himanshu,
>> It is not. It needs a review/ack from the driver maintainers.
>
> What about Kyle Fortin's review ?
Kyle's review is fine. But when a driver is actively maintained, like
be2iscsi is, I always give ack/nack rights to the relevant maintainers.
In this case that's Jitendra.
--
Martin
This patch calls the new nvme transport routine for dev_loss_tmo
whenever the SCSI fc transport calls the lldd to make a dynamic
change to a remote ports dev_loss_tmo.
Signed-off-by: James Smart
---
This lpfc patch, as dependent upon the new nvme transport
nvme_fc_set_remoteport_devloss() call,
On Fri, Nov 03, 2017 at 11:25:05AM -0400, Martin K. Petersen wrote:
Hi Martin,
>
> Himanshu,
>
> > Just a reminder, is my patch in our queue ?
>
> It is not. It needs a review/ack from the driver maintainers.
What about Kyle Fortin's review ?
> --
> Martin K. PetersenOracle Linux Enginee
On 10/11/2017 12:42 PM, Vasyl Gomonovych wrote:
drivers/scsi/lpfc/lpfc_debugfs.c:5460:22-29: WARNING: kzalloc should be used for
phba -> nvmeio_trc, instead of kmalloc/memset
drivers/scsi/lpfc/lpfc_debugfs.c:2230:20-27: WARNING: kzalloc should be used for
phba -> nvmeio_trc, instead of kmalloc/
On 10/12/2017 1:30 PM, Dan Carpenter wrote:
The ! has higher precedence than the & operation. I've added
parenthesis so this works as intended.
Fixes: 952c303b329c ("scsi: lpfc: Ensure io aborts interlocked with the
target.")
Signed-off-by: Dan Carpenter
diff --git a/drivers/scsi/lpfc/lpfc_n
Colin,
> Trivial fix to spelling mistake in dev_info message
Applied to 4.15/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
Yisheng,
> megasas_alloc_cmds is to alloc cmd_list of instance instead of fusion,
> and fusion is useless in this function. Just remove it.
Applied to 4.15/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
Himanshu,
> Just a reminder, is my patch in our queue ?
It is not. It needs a review/ack from the driver maintainers.
--
Martin K. Petersen Oracle Linux Engineering
John,
> Actually this interface is intended for logging UEFI CPER non-standard
> records from kernel RAS/APEI framework to userspace. It is not intended
> for kernel peripheral driver logging (like this case). Until we get a
> community concensus on whether this is acceptable, I would rather reve
On Wed, Oct 11, 2017 at 09:06:14PM +0530, Himanshu Jha wrote:
Hi James,
Just a reminder, is my patch in our queue ?
Thanks
Himanshu Jha
> Use kasprintf instead of combination of kmalloc and sprintf.
> Also, remove BEISCSI_MSI_NAME macro used to specify size of string as
> kasprintf handles s
On Thu, Nov 02, 2017 at 04:31:07PM +0530, Rameshwar Prasad Sahu wrote:
> When tracing ata link error event, the kernel crashes when the disk is
> removed due to NULL pointer access by trace_ata_eh_link_autopsy API.
> This occurs as the dev is NULL when the disk disappeared. This patch
> fixes this
On 03/11/2017 10:19, Arnd Bergmann wrote:
On Fri, Nov 3, 2017 at 11:14 AM, John Garry wrote:
+ Shiju, who authored the original patch
index d42f29a5eb65..6ad8a6251d21 100644
--- a/drivers/scsi/hisi_sas/Kconfig
+++ b/drivers/scsi/hisi_sas/Kconfig
@@ -4,6 +4,7 @@ config SCSI_HISI_SAS
On Fri, Nov 3, 2017 at 6:59 PM, Hannes Reinecke wrote:
> On 11/03/2017 04:38 AM, Gavin Guo wrote:
>> On Sat, Oct 28, 2017 at 11:35 AM, Gavin Guo wrote:
>>> On Fri, Oct 27, 2017 at 10:53 PM, Hannes Reinecke wrote:
On 10/27/2017 04:02 PM, Gavin Guo wrote:
> Hi Hannes,
>
> Thank yo
On 11/03/2017 04:38 AM, Gavin Guo wrote:
> On Sat, Oct 28, 2017 at 11:35 AM, Gavin Guo wrote:
>> On Fri, Oct 27, 2017 at 10:53 PM, Hannes Reinecke wrote:
>>> On 10/27/2017 04:02 PM, Gavin Guo wrote:
Hi Hannes,
Thank you for looking into the issue. If there is anything I can help
>>
On Fri, Nov 3, 2017 at 11:14 AM, John Garry wrote:
> + Shiju, who authored the original patch
>
>> index d42f29a5eb65..6ad8a6251d21 100644
>> --- a/drivers/scsi/hisi_sas/Kconfig
>> +++ b/drivers/scsi/hisi_sas/Kconfig
>> @@ -4,6 +4,7 @@ config SCSI_HISI_SAS
>> depends on ARM64 || COMPILE_T
+ Shiju, who authored the original patch
Hi Arnd,
Thanks for this.
On 02/11/2017 16:50, Arnd Bergmann wrote:
The driver now uses the RAS infrastructure, and fails to link if that
is disabled:
drivers/scsi/hisi_sas/hisi_sas_v2_hw.o: In function `fatal_ecc_int_v2_hw':
hisi_sas_v2_hw.c:(.text+0x
52 matches
Mail list logo
