Re: [PATCH 1/3] scsi: arcmsr: Add driver module parameter msi_enable

Hello Dan, On Thu, 2017-11-23 at 13:44 +0300, Dan Carpenter wrote: > On Thu, Nov 23, 2017 at 09:27:19AM +0800, Ching Huang wrote: > > From: Ching Huang > > > > Add module parameter msi_enable to has a chance to disable msi interrupt if > > it does not work properly. > >

Re: [PATCH 0/3] scsi: arcmsr: add driver module parameter - msi_enable, msix_enable

On Thu, 2017-11-23 at 04:57 -0800, Christoph Hellwig wrote: > On Thu, Nov 23, 2017 at 09:22:03AM +0800, Ching Huang wrote: > > From: Ching Huang > > > > Hi all, > > > > The following patches apply to Martin's 4.16/scsi-queue. > > > > Patch 1: Add module parameter

Re: [PATCH 2/3] scsi: arcmsr: Add driver module parameter msix_enable

On Thu, 2017-11-23 at 14:43 +0300, Dan Carpenter wrote: > On Thu, Nov 23, 2017 at 09:31:14AM +0800, Ching Huang wrote: > > @@ -829,12 +833,15 @@ arcmsr_request_irq(struct pci_dev *pdev, > > unsigned long flags; > > int nvec, i; > > > > + if (msix_enable == 0) > > + goto

[GIT PULL] target updates for v4.15-rc1

Hello Linus, Here are the target-pending updates for v4.15-rc1. Please go ahead and pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git for-next This series is predominantly bug-fixes, with a few small improvements that have been outstanding over the last release

[PATCH] scsi: scsi_devinfo: replace "Dell PV 650F" with "EMC CLARiiON"

The Dell PV650F is a re-branded CLARiiON FC5700. And DGC/RAID,DISK identifies all CLARiiON family. Cc: Martin K. Petersen Cc: James E.J. Bottomley Cc: SCSI ML Signed-off-by: Xose Vazquez Perez

Re: [PATCH 0/3] scsi: arcmsr: add driver module parameter - msi_enable, msix_enable

On Thu, Nov 23, 2017 at 09:22:03AM +0800, Ching Huang wrote: > From: Ching Huang > > Hi all, > > The following patches apply to Martin's 4.16/scsi-queue. > > Patch 1: Add module parameter msi_enable to has a chance to disable msi > interrupt if it does not work

Re: [PATCH 2/3] scsi: arcmsr: Add driver module parameter msix_enable

On Thu, Nov 23, 2017 at 09:31:14AM +0800, Ching Huang wrote: > @@ -829,12 +833,15 @@ arcmsr_request_irq(struct pci_dev *pdev, > unsigned long flags; > int nvec, i; > > + if (msix_enable == 0) > + goto msi_int0; I feel like this goto is not very beautiful, but I can't

Re: [PATCH 1/3] scsi: arcmsr: Add driver module parameter msi_enable

On Thu, Nov 23, 2017 at 09:27:19AM +0800, Ching Huang wrote: > From: Ching Huang > > Add module parameter msi_enable to has a chance to disable msi interrupt if > it does not work properly. > > Signed-off-by: Ching Huang > --- > > diff -uprN

Re: [PATCH] Ensure that the SCSI error handler gets woken up

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

[PATCH 3/3] scsi: arcmsr: Update driver version to v1.40.00.03-20171121

From: Ching Huang Update driver version to v1.40.00.03-20171121 Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2017-11-23 14:29:46.0 +0800

[PATCH 2/3] scsi: arcmsr: Add driver module parameter msix_enable

From: Ching Huang Add module parameter msix_enable to has a chance to disable msix interrupt if it does not work properly. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c ---

[PATCH 1/3] scsi: arcmsr: Add driver module parameter msi_enable

From: Ching Huang Add module parameter msi_enable to has a chance to disable msi interrupt if it does not work properly. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c ---

[PATCH 0/3] scsi: arcmsr: add driver module parameter - msi_enable, msix_enable

From: Ching Huang Hi all, The following patches apply to Martin's 4.16/scsi-queue. Patch 1: Add module parameter msi_enable to has a chance to disable msi interrupt if it does not work properly. Patch 2: Add module parameter msix_enable to has a chance to disable msix

Re: [PATCH] Ensure that the SCSI error handler gets woken up

> diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c > index 5e89049e9b4e..f7f014c755d7 100644 > --- a/drivers/scsi/scsi_error.c > +++ b/drivers/scsi/scsi_error.c > @@ -61,9 +61,10 @@ static int scsi_eh_try_stu(struct scsi_cmnd *scmd); > static int scsi_try_to_abort_cmd(struct