[PATCH v3] scsi: libsas: fix length error in sas_smp_handler()

2017-12-10 Thread Jason Yan
The return value of smp_execute_task_sg() is the untransferred residual, but bsg_job_done() requires the length of payload received. This makes SMP passthrough commands from userland by sg ioctl to libsas get a wrong response. The userland tools such as smp_utils failed becuase of these wrong respo

Re: [bug report] scsi: arcmsr: Add a function to set date and time to firmware

2017-12-10 Thread 黃清隆
Dan, Yeah, secs is never be negative. This checking is redundant and have to be removed. Thanks Colin Ian King has done this patch for me on [next]. Thanks, Ching 2017-12-09 20:47 GMT+08:00 Dan Carpenter : > Hello Ching Huang, > > The patch b416c099472a: "scsi: arcmsr: Add a function to set date

Re: [PATCH][next] scsi: arcmsr: remove redundant check for secs < 0

2017-12-10 Thread 黃清隆
Colin, You are right. That's checking is redundant. secs is never be negative. Thanks for your correction and patch. Regards, Ching 2017-12-09 8:34 GMT+08:00 Colin King : > From: Colin Ian King > > The check for secs being less than zero is redundant for two reasons. > Firstly, secs is unsigned

Re: [PATCH] sbp-target: Delete an error message for a failed memory allocation in three functions

2017-12-10 Thread Chris Boot
On 10/12/2017 19:10, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 10 Dec 2017 19:54:11 +0100 > > Omit an extra message for a memory allocation failure in these functions. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring [snip] Loo

[PATCH 1/1] scsi: fnic: add a space after %p in printf format

2017-12-10 Thread Nicolas Iooss
fnic_fcpio_icmnd_cmpl_handler() displays the value of sc with: FNIC_SCSI_DBG(KERN_INFO... "... sc = 0x%p" "scsi_status ..." ... As the literal strings get merged, the function uses %ps instead of the intended raw %p format. Fix this by inserting a space. Signed-off-by

[PATCH] sbp-target: Delete an error message for a failed memory allocation in three functions

2017-12-10 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 10 Dec 2017 19:54:11 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/target/sbp/sbp_target.c | 13 - 1 file changed,

[PATCH] documentation: add scsi_common.c to SCSI driver-api

2017-12-10 Thread Randy Dunlap
From: Randy Dunlap Add exported functions from scsi_common.c to the SCSI driver API documentation. Signed-off-by: Randy Dunlap Cc: Nicholas Bellinger --- Documentation/driver-api/scsi.rst |8 1 file changed, 8 insertions(+) --- lnx-415-rc2.orig/Documentation/driver-api/scsi.rst

[PATCH] scsi: doc. fixes to scsi_common.c

2017-12-10 Thread Randy Dunlap
From: Randy Dunlap Clean up some comment typos and fix some errors in documentation. Signed-off-by: Randy Dunlap Cc: Nicholas Bellinger Cc: Sagi Grimberg Cc: Bart Van Assche --- drivers/scsi/scsi_common.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) --- lnx-415-rc

Re: [PATCH] sd: Increase SCSI disk probing concurrency

2017-12-10 Thread Hannes Reinecke
On 12/08/2017 06:21 PM, Bart Van Assche wrote: > The scsi_sd_probe_domain allows to wait until all disk-probing > activity has finished system-wide. This slows down SCSI host removal > that occurs concurrently with SCSI disk probing because sd_remove() > waits on scsi_sd_probe_domain. Additionally,