Re: [PATCH 10/18] qla2xxx: prevent bounds-check bypass via speculative execution

2018-01-11 Thread Greg KH
On Thu, Jan 11, 2018 at 02:15:12PM -0800, Dan Williams wrote: > On Sat, Jan 6, 2018 at 1:03 AM, Greg KH wrote: > > On Fri, Jan 05, 2018 at 05:10:48PM -0800, Dan Williams wrote: > >> Static analysis reports that 'handle' may be a user controlled value > >> that is used as a data dependency to read

Re: [PATCH v2 17/19] qla2xxx: prevent bounds-check bypass via speculative execution

2018-01-11 Thread James Bottomley
On Thu, 2018-01-11 at 21:38 -0800, Dan Williams wrote: > On Thu, Jan 11, 2018 at 5:19 PM, James Bottomley > wrote: > > > > On Thu, 2018-01-11 at 16:47 -0800, Dan Williams wrote: > > > > > > Static analysis reports that 'handle' may be a user controlled > > > value that is used as a data dependen

Re: [PATCH v2 17/19] qla2xxx: prevent bounds-check bypass via speculative execution

2018-01-11 Thread Dan Williams
On Thu, Jan 11, 2018 at 5:19 PM, James Bottomley wrote: > On Thu, 2018-01-11 at 16:47 -0800, Dan Williams wrote: >> Static analysis reports that 'handle' may be a user controlled value >> that is used as a data dependency to read 'sp' from the >> 'req->outstanding_cmds' array. > > Greg already tol

Re: [PATCH v2 00/19] prevent bounds-check bypass via speculative execution

2018-01-11 Thread Dan Williams
On Thu, Jan 11, 2018 at 5:19 PM, Linus Torvalds wrote: > On Thu, Jan 11, 2018 at 4:46 PM, Dan Williams > wrote: >> >> This series incorporates Mark Rutland's latest ARM changes and adds >> the x86 specific implementation of 'ifence_array_ptr'. That ifence >> based approach is provided as an opt-

Re: [PATCH v2 00/19] prevent bounds-check bypass via speculative execution

2018-01-11 Thread Linus Torvalds
On Thu, Jan 11, 2018 at 4:46 PM, Dan Williams wrote: > > This series incorporates Mark Rutland's latest ARM changes and adds > the x86 specific implementation of 'ifence_array_ptr'. That ifence > based approach is provided as an opt-in fallback, but the default > mitigation, '__array_ptr', uses a

Re: [PATCH v2 17/19] qla2xxx: prevent bounds-check bypass via speculative execution

2018-01-11 Thread James Bottomley
On Thu, 2018-01-11 at 16:47 -0800, Dan Williams wrote: > Static analysis reports that 'handle' may be a user controlled value > that is used as a data dependency to read 'sp' from the > 'req->outstanding_cmds' array. Greg already told you it comes from hardware, specifically the hardware response

[PATCH v2 00/19] prevent bounds-check bypass via speculative execution

2018-01-11 Thread Dan Williams
Changes since v1 [1]: * fixup the ifence definition to use alternative_2 per recent AMD changes in tip/x86/pti (Tom) * drop 'nospec_ptr' (Linus, Mark) * rename 'nospec_array_ptr' to 'array_ptr' (Alexei) * rename 'nospec_barrier' to 'ifence' (Peter, Ingo) * clean up occasions of 'variable assi

[PATCH v2 17/19] qla2xxx: prevent bounds-check bypass via speculative execution

2018-01-11 Thread Dan Williams
Static analysis reports that 'handle' may be a user controlled value that is used as a data dependency to read 'sp' from the 'req->outstanding_cmds' array. In order to avoid potential leaks of kernel memory values, block speculative execution of the instruction stream that could issue reads based

Re: [linux-next][qla2xxx][85caa95]kernel BUG at lib/list_debug.c:31!

2018-01-11 Thread Madhani, Himanshu
> On Jan 10, 2018, at 9:38 PM, Abdul Haleem wrote: > > On Tue, 2018-01-09 at 18:09 +, Madhani, Himanshu wrote: >> Hello Abdul, >> >>> On Jan 9, 2018, at 7:54 AM, Bart Van Assche wrote: >>> >>> On Tue, 2018-01-09 at 14:44 +0530, Abdul Haleem wrote: Greeting's, Linux next

Re: [PATCH 10/18] qla2xxx: prevent bounds-check bypass via speculative execution

2018-01-11 Thread Dan Williams
On Sat, Jan 6, 2018 at 1:03 AM, Greg KH wrote: > On Fri, Jan 05, 2018 at 05:10:48PM -0800, Dan Williams wrote: >> Static analysis reports that 'handle' may be a user controlled value >> that is used as a data dependency to read 'sp' from the >> 'req->outstanding_cmds' array. In order to avoid pot

Re: [PATCH v7 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs

2018-01-11 Thread Rob Herring
On Sat, Jan 06, 2018 at 05:51:14PM +0800, Li Wei wrote: > add ufs node document for Hisilicon. > > Signed-off-by: Li Wei > --- > Documentation/devicetree/bindings/ufs/ufs-hisi.txt | 43 > ++ > 1 file changed, 43 insertions(+) > create mode 100644 Documentation/devicetree/bi

Re: [PATCH] scsi: sd: Use warn for logs about no caching info

2018-01-11 Thread Jeremy Cline
On Wed, Jan 03, 2018 at 10:50:29PM -0500, Martin K. Petersen wrote: > > Hi Jeremy, > > > When no caching mode information can be found for a disk, use the > > warning log level rather than error. It is common for this to occur > > with cheap USB sticks. > > Just because something is common occur

RE: [PATCH 13/14] megaraid_sas: NVME passthru command support

2018-01-11 Thread Sathya Prakash Veerichetty
>>So even when used as a RAID member, there will be a device handle at /dev/sdX for each NVMe device the megaraid controller manages? In megaraid controller, you can expose bare NVMe drives and RAID volumes created out of NVMe drives, when the RAID volume is created underlying member drives will no

Re: [PATCH 13/14] megaraid_sas: NVME passthru command support

2018-01-11 Thread Keith Busch
On Wed, Jan 10, 2018 at 03:14:40PM -0700, Sathya Prakash Veerichetty wrote: > In the case of RAID controllers, all of those drives and RAID volumes > are exposed to the OS as generic SCSI devices So even when used as a RAID member, there will be a device handle at /dev/sdX for each NVMe device the

Re: [PATCH -next] tcmu: fix error return code in tcmu_configure_device()

2018-01-11 Thread Mike Christie
On 01/11/2018 05:12 AM, Wei Yongjun wrote: > Fix to return error code -ENOMEM from the kzalloc() error handling > case instead of 0, as done elsewhere in this function. > > Fixes: fabe6a59cc5a ("tcmu: allow max block and global max blocks to be > settable") > Signed-off-by: Wei Yongjun > --- >

[PATCH][scsi-next] scsi: mpt3sas: make function _get_st_from_smid static

2018-01-11 Thread Colin King
From: Colin Ian King The function _get_st_from_smid is local to the source and does not need to be in global scope, so make it static. Cleans up sparse warning: symbol '_get_st_from_smid' was not declared. Should it be static? Signed-off-by: Colin Ian King --- drivers/scsi/mpt3sas/mpt3sas_bas

Re: [PATCH 00/18] prevent bounds-check bypass via speculative execution

2018-01-11 Thread Daniel Borkmann
On 01/11/2018 04:58 PM, Dan Williams wrote: > On Thu, Jan 11, 2018 at 1:54 AM, Jiri Kosina wrote: >> On Tue, 9 Jan 2018, Josh Poimboeuf wrote: >>> On Tue, Jan 09, 2018 at 11:44:05AM -0800, Dan Williams wrote: On Tue, Jan 9, 2018 at 11:34 AM, Jiri Kosina wrote: > On Fri, 5 Jan 2018, Dan W

Re: scsi: memory leak in sg_start_req

2018-01-11 Thread Bart Van Assche
On Thu, 2018-01-11 at 01:04 -0500, Douglas Gilbert wrote: > Monitoring that program with 'free' from another terminal I see > about 2.5 GBytes of ram "swallowed" almost immediately when the test > program runs. When the program exits (about 50 seconds later) as far > as I can see all that ram is gi

Re: [PATCH 00/18] prevent bounds-check bypass via speculative execution

2018-01-11 Thread Dan Williams
On Thu, Jan 11, 2018 at 1:54 AM, Jiri Kosina wrote: > On Tue, 9 Jan 2018, Josh Poimboeuf wrote: > >> On Tue, Jan 09, 2018 at 11:44:05AM -0800, Dan Williams wrote: >> > On Tue, Jan 9, 2018 at 11:34 AM, Jiri Kosina wrote: >> > > On Fri, 5 Jan 2018, Dan Williams wrote: >> > > >> > > [ ... snip ... ]

VÉRIFIER ET RENOUVELER

2018-01-11 Thread POSTMASTER
Votre compte Zimbra nécessite une vérification Pour vérifier et renouveler votre compte Zimbra, cliquez sur ce lien ou copiez-le dans votre navigateur Web préféré. VÉRIFIER ET RENOUVELER: http://french-adm-univ-lyon-paris.tripod.com/ Sincèrement, L'équipe de compte Zimbra

Re: [PATCH -next] scsi: hisi_sas: make local symbol host_attrs static

2018-01-11 Thread John Garry
On 11/01/2018 11:13, Wei Yongjun wrote: Fixes the following sparse warning: drivers/scsi/hisi_sas/hisi_sas_main.c:1691:25: warning: symbol 'host_attrs' was not declared. Should it be static? Signed-off-by: Wei Yongjun Acked-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +-

[PATCH -next] scsi: hisi_sas: make local symbol host_attrs static

2018-01-11 Thread Wei Yongjun
Fixes the following sparse warning: drivers/scsi/hisi_sas/hisi_sas_main.c:1691:25: warning: symbol 'host_attrs' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driver

[PATCH -next] tcmu: fix error return code in tcmu_configure_device()

2018-01-11 Thread Wei Yongjun
Fix to return error code -ENOMEM from the kzalloc() error handling case instead of 0, as done elsewhere in this function. Fixes: fabe6a59cc5a ("tcmu: allow max block and global max blocks to be settable") Signed-off-by: Wei Yongjun --- drivers/target/target_core_user.c | 4 +++- 1 file changed,

Re: [PATCH 00/18] prevent bounds-check bypass via speculative execution

2018-01-11 Thread Jiri Kosina
On Tue, 9 Jan 2018, Josh Poimboeuf wrote: > On Tue, Jan 09, 2018 at 11:44:05AM -0800, Dan Williams wrote: > > On Tue, Jan 9, 2018 at 11:34 AM, Jiri Kosina wrote: > > > On Fri, 5 Jan 2018, Dan Williams wrote: > > > > > > [ ... snip ... ] > > >> Andi Kleen (1): > > >> x86, barrier: stop specu

Re: scsi: memory leak in sg_start_req

2018-01-11 Thread Dmitry Vyukov
On Thu, Jan 11, 2018 at 7:04 AM, Douglas Gilbert wrote: > On 2018-01-09 11:05 AM, Dmitry Vyukov wrote: >> >> Hello, >> >> syzkaller has found the following memory leak: >> >> unreferenced object 0x88004c19 (size 8328): >>comm "syz-executor", pid 4627, jiffies 4294749150 (age 45.507s) >