Hi Himanshu,
This is my progress.
First, I compiled 4.15-rc6, I found linux hang when booting, the stack
showed something wrong in qla2xxx driver.
Second, I want to find which commit introduced the issue. So I tried many
times via git bisect to linux kernel.
Finally, I found the commi
Test iscsi performance in unstable network. And hit kernel die.
Here are two different call trace, but they have the same RIP & RCX.
1>
CPU: 15 PID: 23529 Comm: lvm Tainted: G D W E 4.14.11 #1
task: 91a382b72e00 task.stack: b3928ade8000
RIP: 0010:scsi_device_dev_release_usercontext+0
Hi Chang,
> On Jan 15, 2018, at 4:27 PM, Changlimin wrote:
>
> Hi Himanshu,
> The issue is: When insmod the qla2xxx.ko from 4.15-rc6, linux hang.
>From the log file attached. I see that you are trying to load driver from
>4.9.x in 4.15.0-rc6.
[ 279.898704] qla2xxx [:00:00.0]-0005: : Q
This patch fixes regression added by commit d74595278f4ab
("scsi: qla2xxx: Add multiple queue pair functionality.").
When driver is not able to get reqeusted IRQs from the system, driver
will attempt tp clean up memory before failing hardware probe. During
this cleanup, driver assigns NULL value t
During error test case where switch port status is toggled
from enable to disable, following stack trace is seen which
indicates recursion trying to send terminate exchange.
This regression was introduced by commit 82de802ad46e
("scsi: qla2xxx: Preparation for Target MQ.")
BUG: stack guard page wa
This patch fixes following Smatch warning
drivers/scsi/qla2xxx/qla_init.c:130 qla2x00_async_iocb_timeout() error: we
previously assumed 'fcport' could be null (see line 107)
Fixes: 5c25d451163c ("scsi: qla2xxx: Fix NULL pointer access for fcport
structure")
Reported by: Dan Carpenter
Signed-of
Hi Martin,
This series has fixes for smatch warnings. Patch 3 addresses
smatch warning reported by Dan Carpenter. We've also added a
patch for async abort handling for initiator multiqueue in the
driver along with a patch for NULL pointer access during probe
failure.
Please apply this series t
This patch fixes following smatch warning
drivers/scsi/qla2xxx/qla_iocb.c:2622 qla2x00_els_dcmd2_sp_done() error: '%pC'
expects argument of type 'struct clk*', argument 8 has type 'uchar[]'
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_iocb.c | 2 +-
1 file changed, 1 insertion(
From: Darren Trapp
Signed-off-by: Darren Trapp
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_def.h | 1 +
drivers/scsi/qla2xxx/qla_init.c | 9 +
drivers/scsi/qla2xxx/qla_iocb.c | 6 --
3 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/qla2
This patch fixes following smatch warning
drivers/scsi/qla2xxx/qla_init.c:1054 __qla24xx_handle_gpdb_event() warn:
inconsistent indenting
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_version.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_version.h
b/drivers/scsi/qla2xxx/qla_version.h
index 0843def08356..549bef9afddd 100644
--- a/drivers/scsi/qla2xxx/qla_version.h
+++
From: Anil Gurumurthy
Signed-off-by: Anil Gurumurthy
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_dfs.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/scsi/qla2xxx/qla_dfs.c b/drivers/scsi/qla2xxx/qla_dfs.c
index ddb53db61fd2..0b190082aa8d 100644
--- a/dri
Kashyap,
> This patch is not yet included because of the ongoing discussion.
>
> Chris H, Martin et all - How are we moving forward with this patch ?
Well, I guess I'll go ahead and queue it up even through I am no fan of
these dreadful driver-specific ioctl interfaces. I really wish the SCSI
C
For the storage track, I would like to propose a topic for differentiated
blk-mq hardware contexts. Today, blk-mq considers all hardware contexts
equal, and are selected based on the software's CPU context. There are
use cases that benefit from having hardware context selection criteria
beyond whic
Hi Himanshu,
The issue is: When insmod the qla2xxx.ko from 4.15-rc6, linux hang.
I have git bisect the commits.
The issue was introduced in commit: 726b85487067d7f5b23495bc33c484b8517c4074
qla2xxx: Add framework for async fabric discovery.
The previous commit is good: 5d964837c6a743193c63
Hi Max,
> On Jan 15, 2018, at 12:37 PM, Max Kellermann wrote:
>
> On 2018/01/15 20:58, "Madhani, Himanshu" wrote:
>> We have patch to prevent this double free in 4.16/scsi-queue
>> already.
>
> No, let me repeat: this is a different bug!
>
> Your bug is about the free call after waiting for
On 2018/01/15 20:58, "Madhani, Himanshu" wrote:
> We have patch to prevent this double free in 4.16/scsi-queue
> already.
No, let me repeat: this is a different bug!
Your bug is about the free call after waiting for completion
synchronously in qla24xx_els_dcmd_iocb(), after it was already freed
Dear Raghava,
Am 18.12.2017 um 19:09 schrieb Raghava Aditya Renukunta:
-Original Message- From: Paul Menzel
[mailto:pmen...@molgen.mpg.de] Sent: Saturday, December 16, 2017
1:39 AM
[…]
Am 17.02.2017 um 20:29 schrieb Raghava Aditya Renukunta:
[…]
Searching the vendor Web site, th
On Fujitsu ETERNUS systems, sense code ABORTED COMMAND with ASC/Q C1/01
is used to indicate temporary condition where the storage-internal path
to a target is switched from one controller to another. SCSI commands
that return with this error code must be retried unconditionally (i.e. without
the "m
Hi Max,
> On Jan 15, 2018, at 9:26 AM, Max Kellermann wrote:
>
> When the qla2xxx firmware is unavailable, eventually
> qla2x00_sp_timeout() is reached, which calls the timeout function and
> frees the srb_t instance.
>
> The timeout function always resolves to qla2x00_async_iocb_timeout(),
>
On Fri, Jan 12, 2018 at 5:09 PM, Bart Van Assche wrote:
> On Fri, 2018-01-12 at 15:45 +0200, Andy Shevchenko wrote:
>> On Fri, Jan 12, 2018 at 1:46 PM, Wang wrote:
>> This one is false positive.
>> > + strlcpy (karg.name, ioc->name, MPT_MAX_NAME);
>> > + strlcpy (karg.product, ioc
When the qla2xxx firmware is unavailable, eventually
qla2x00_sp_timeout() is reached, which calls the timeout function and
frees the srb_t instance.
The timeout function always resolves to qla2x00_async_iocb_timeout(),
which invokes another callback function called "done". All of these
qla2x00_*_
Numbers up to 100 snprintf() prints without using a division.
Besides that the code looks more readable.
Signed-off-by: Andy Shevchenko
---
drivers/message/fusion/mptctl.c | 25 +++--
1 file changed, 7 insertions(+), 18 deletions(-)
diff --git a/drivers/message/fusion/mptctl
Hi Nic, Chang,
> On Jan 12, 2018, at 9:28 PM, Nicholas A. Bellinger
> wrote:
>
> Hi Chang & Co,
>
> (Adding list + Himanshu CC')
>
> On Sun, 2018-01-07 at 10:21 +, Changlimin wrote:
>> Hi,
>> It seems the qla2xxx commit cause Linux no response, has not fixed in
>> lastest version 4.15-rc
Replace "" with NULL for product revision level, and
merge TEXEL duplicate entries.
Cc: Hannes Reinecke
Cc: Martin K. Petersen
Cc: James E.J. Bottomley
Cc: SCSI ML
Signed-off-by: Xose Vazquez Perez
---
drivers/scsi/scsi_devinfo.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
The annual Linux Storage, Filesystem and Memory Management (LSF/MM)
Summit for 2018 will be held from April 23-25 at the Deer Valley
Lodges in Park City, Utah. LSF/MM is an invitation-only technical
workshop to map out improvements to the Linux storage, filesystem and
memory management subsystems t
On Mon, 2018-01-15 at 07:01 -0800, Hellwig, Christoph wrote:
> Laurence, I'm a little confused. Is this the same issue we just
> fixed,
> or is this an issue showing up with the fix?
>
> E.g. what kernel versions or trees are affected?
Hello Christoph
This showed up on a combined tree of Mikes
On 1/14/18 3:00 PM, Douglas Gilbert wrote:
> During stress tests by syzkaller on the sg driver the block layer
> infrequently returns EINVAL. Closer inspection shows the block
> layer was trying to return ENOMEM (which is much more
> understandable) but for some reason overroad that useful error.
>
On Mon, Jan 15 2018 at 7:46am -0500,
Lars Ellenberg wrote:
> As I understood it,
> blkdev_issue_zeroout() was supposed to "always try to unmap",
> deprovision, the relevant region, and zero-out any unaligned
> head or tail, just like my work around above was doing.
>
> And that device mapper t
Laurence, I'm a little confused. Is this the same issue we just fixed,
or is this an issue showing up with the fix?
E.g. what kernel versions or trees are affected?
On Sat, Jan 13, 2018 at 12:46:40AM +, Eric Wheeler wrote:
> Hello All,
>
> We just noticed that discards to DRBD devices backed by dm-thin devices
> are fully allocating the thin blocks.
>
> This behavior does not exist before
> ee472d83 block: add a flags argument to (__)blkdev_issue_zeroo
On Mon, 2018-01-15 at 20:17 +0800, Ming Lei wrote:
> On Sun, Jan 14, 2018 at 06:40:40PM -0500, Laurence Oberman wrote:
> > On Thu, 2018-01-04 at 14:32 -0800, Vinson Lee wrote:
> > > Hi.
> > >
> > > HP ProLiant DL360p Gen8 with Smart Array P420i boots to the login
> > > prompt and hangs with Linux
> -Original Message-
> From: Johannes Thumshirn [mailto:jthumsh...@suse.de]
> Sent: Monday, January 15, 2018 5:49 PM
> To: Kashyap Desai
> Cc: linux-scsi@vger.kernel.org; Peter Rivera
> Subject: Re: [RFC 1/2] mpt3sas/megaraid_sas : irq poll to avoid CPU hard
and
> soft lockups
>
> On Mon, J
On Mon, Jan 15, 2018 at 05:42:35PM +0530, Kashyap Desai wrote:
> Patch for Fix-1 explained in PATCH 0.
Ahm, PATCH 0 a.k.a the cover letter doesn't get merged so the git history
won't have an explanation at all. Please write a proper commit message.
Thanks,
Johannes
--
Johannes Thumshirn
On Sun, Jan 14, 2018 at 06:40:40PM -0500, Laurence Oberman wrote:
> On Thu, 2018-01-04 at 14:32 -0800, Vinson Lee wrote:
> > Hi.
> >
> > HP ProLiant DL360p Gen8 with Smart Array P420i boots to the login
> > prompt and hangs with Linux 4.13 or later. I cannot log in on console
> > or SSH into the m
This patch is not yet included because of the ongoing discussion.
Chris H, Martin et all - How are we moving forward with this patch ?
Thanks, Kashyap
> -Original Message-
> From: Sathya Prakash Veerichetty [mailto:sathya.prak...@broadcom.com]
> Sent: Thursday, January 11, 2018 11:37 PM
liramandoz...@gmail.com<>
Patch for Fix-2 explained in PATCH 0.
Signed-off-by: Kashyap Desai < kashyap.de...@broadcom.com>
---
mpt3sas/mpt3sas_base.c | 5 -
mpt3sas/mpt3sas_base.h | 1 +
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/mpt3sas/mpt3sas_base.c b/mpt3sas/mpt3sas_base.c index
0b351d4..20bf2ad
Patch for Fix-1 explained in PATCH 0.
Signed-off-by: Kashyap Desai < kashyap.de...@broadcom.com>
---
mpt3sas/mpt3sas_base.c | 67
++
mpt3sas/mpt3sas_base.h | 4 +++
2 files changed, 55 insertions(+), 17 deletions(-)
diff --git a/mpt3sas/mpt3sas_ba
Hi All -
We have seen cpu lock up issue from fields if system has greater (more
than 96) logical cpu count.
SAS3.0 controller (Invader series) supports at max 96 msix vector and
SAS3.5 product (Ventura) supports at max 128 msix vectors.
This may be a generic issue (if PCI device support completi
40 matches
Mail list logo