Re: [PATCH 0/5] blk-mq/scsi-mq: support global tags & introduce force_blk_mq

2018-02-06 Thread Hannes Reinecke
Hi all, [ .. ] >> >> Could you share us your patch for enabling global_tags/MQ on > megaraid_sas >> so that I can reproduce your test? >> >>> See below perf top data. "bt_iter" is consuming 4 times more CPU. >> >> Could you share us what the IOPS/CPU utilization effect is after > applying the >> p

[PATCH v2 09/13] lpfc: Add embedded data pointers for enhanced performance

2018-02-06 Thread James Smart
The current driver isn't taking advantage of a performance hint whereby the initial data buffer descriptor can be placed in the WQE as well as the SGL. Add the logic to detect support for the feature and to use it when supported. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drive

[PATCH v2 12/13] lpfc: update driver version to 12.0.0.0

2018-02-06 Thread James Smart
Update the driver version to 12.0.0.0 Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h index 4adbf07880a2..b1ae62a44

[PATCH v2 11/13] lpfc: Work around NVME cmd iu SGL type

2018-02-06 Thread James Smart
The hardware offload for NVME commands was created when the FC-NVME standard was setting SGL Descriptor Type to SGL Data Block Descriptor (0h) and SGL Descriptor Sub Type to Address (0h). A late change in NVMe-over-Fabrics obsoleted these values, creating a transport SGL descriptor type with new v

[PATCH v2 02/13] lpfc: Rework sli4 doorbell infrastructure

2018-02-06 Thread James Smart
Up until now, all SLI-4 devices had the same doorbells at the same bar locations. With newer hardware, there are now independent EQ and CQ doorbells and the bar locations differ. Prepare the code for new hardware by separating the eq/cq doorbell into separate components. The components can be set

[PATCH v2 03/13] lpfc: Add SLI-4 if_type=6 support to the code base

2018-02-06 Thread James Smart
New hardware supports a SLI-4 interface, but with a new if_type variant of 6. If_type=6 has a different PCI BAR map, separate EQ/CQ doorbells, and some changes in doorbell formats. Add the changes for the if_type into headers, adapter initialization and control flows. Add new eq and cq handlers.

[PATCH v2 04/13] lpfc: Add push-to-adapter support to sli4

2018-02-06 Thread James Smart
New if_type=6 adapters support an additional BAR that provides apertures to allow direct WQE to adapter push support - termed Direct Packet Push (DPP). WQ creation differs slightly to ask for a WQ to be DPP-ized. When submitting a WQE to a DPP WQ, it is submitted to the host memory for the WQ norma

[PATCH v2 06/13] lpfc: Add 64G link speed support

2018-02-06 Thread James Smart
The G7 adapter supports 64G link speeds. Add support to the driver. In addition, a small cleanup to replace the odd bitmap logic with a switch case. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- v2: address review comment of typo in define name. Define wasn't used anywhere yet

[PATCH v2 01/13] lpfc: Rework lpfc to allow different sli4 cq and eq handlers

2018-02-06 Thread James Smart
Up until now, an SLI-4 device had no variance in the way it handled its EQs and CQs. With newer hardware, there are now differences in doorbells and some differences in how entries are valid. Prepare the code for new hardware by creating a sli4-based callout table that can be set based on if_type.

[PATCH v2 13/13] lpfc: Update 12.0.0.0 modified files for 2018 Copyright

2018-02-06 Thread James Smart
Updated Copyright in files updated 12.0.0.0 Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_bsg.c | 2 +- drivers/scsi/lpfc/lpfc_ct.c | 2 +- drivers/scsi/lpfc/lpfc_debugfs.c | 2 +- drivers/scsi/lpfc/lpfc_debugfs.h | 2 +- drivers/scsi/lpfc/lpfc_hw.h

[PATCH v2 05/13] lpfc: Add PCI Ids for if_type=6 hardware

2018-02-06 Thread James Smart
Add PCI ids for the new G7 adapter Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_hw.h | 1 + drivers/scsi/lpfc/lpfc_ids.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_hw.h b/drivers/scsi/lpfc/lpfc_hw.h index bdc1f184f67a..d07

[PATCH v2 00/13] lpfc new hardware patches for 12.0.0.0

2018-02-06 Thread James Smart
This patch set adds support for Broadcom's new G7 product that supports G4G FC. The patches were cut against the Martin's 4.16/scsi-queue tree. The patches are dependent (layered on top of) the lpfc 11.4.0.7 patchset that was recently posted. See: https://www.spinics.net/lists/linux-scsi/msg116

[PATCH v2 08/13] lpfc: Enable fw download on if_type=6 devices

2018-02-06 Thread James Smart
Current code is very explicit in what it allows to be downloaded. The driver checking prevented G7 firmware download. The driver checking is unnecessary as the device will validate what it receives. Revise the firmware download interface checking. Added a little debug support in case there is stil

[PATCH v2 07/13] lpfc: Add if_type=6 support for cycling valid bits

2018-02-06 Thread James Smart
Traditional SLI4 required the driver to clear Valid bits on EQEs and CQEs after consuming them. The new if_type=6 hardware will cycle the value for what is valid on each queue itteration. The driver no longer has to touch the valid bits. This also means all the cpu cache dirtying and perhaps flush

[PATCH v2 10/13] lpfc: Fix nvme embedded io length on new hardware

2018-02-06 Thread James Smart
Newer hardware more strictly enforces buffer lenghts, causing an mis-set value to be identified. Older hardware won't catch it. The difference is benign on old hardware. Set the right embedded buffer length for nvme ios. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/l

Re: [PATCH 01/13] lpfc: Rework lpfc to allow different sli4 cq and eq handlers

2018-02-06 Thread James Smart
On 2/6/2018 4:26 PM, Martin K. Petersen wrote: James, I was on the verge of applying this as well but saw that you intended a re-spin. Found a few typos while poring over these patches: Prepare the code for new hardwre by creating a sli4-based callout hardware table that can be set based

Re: [PATCH] scsi: qedf: remove redundant initialization of 'fcport'

2018-02-06 Thread Martin K. Petersen
Colin, > Pointer fcport is initialized with a value that is never read, it is > re-assigned a new value later on, hence the initialization is redundant > and can be removed. Applied to 4.17/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 5/6] scsi: qedi: fix building with LTO

2018-02-06 Thread Martin K. Petersen
Arnd, > When link-time optimizations are enabled, qedi fails to build because > of mismatched prototypes: Applied to 4.17/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: libfc: remove redundant initialization of 'disc'

2018-02-06 Thread Martin K. Petersen
Colin, > Pointer disc is being intializated a value that is never read and then > re-assigned the same value later on, hence the initialization is redundant > and can be removed. Applied to 4.17/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi_debug: Add two new parameters to scsi_debug driver

2018-02-06 Thread Martin K. Petersen
Laurence, The patch description needs to go before the "---" separator. I fixed it up. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi_debug: Simplify request tag decoding

2018-02-06 Thread Martin K. Petersen
Bart, > Since commit 64d513ac31bd ("scsi: use host wide tags by default") all > SCSI requests have a tag, whether or not scsi-mq is enabled. > Additionally, it is safe to use blk_mq_unique_tag() and > blk_mq_unique_tag_to_hwq() for legacy SCSI queues. Since this means > that the sdebug_mq_active

Re: [PATCHv3 0/4] Deprecate DAC960 driver

2018-02-06 Thread Martin K. Petersen
Hannes, > as we're trying to get rid of the remaining request_fn drivers here's > a patchset to move the DAC960 driver to the SCSI stack. As per > request from hch I've split up the driver into two new SCSI drivers > called 'myrb' and 'myrs'. > > The 'myrb' driver only supports the earlier (V1)

Re: [PATCH 0/6] Six qla2xxx and qla4xxx patches

2018-02-06 Thread Martin K. Petersen
Bart, > The patches in this series are what I came up with after having > analyzed the source code of the qla[24]xxx drivers with several source > code analysis tools (scripts/kernel-doc, gcc, sparse and smatch). None > of the patches in this series have been tested. Yet I'm asking you to > consi

Re: [PATCH V2 5/8] scsi: introduce force_blk_mq

2018-02-06 Thread Ming Lei
On Tue, Feb 06, 2018 at 12:20:43PM -0800, Omar Sandoval wrote: > On Mon, Feb 05, 2018 at 11:20:32PM +0800, Ming Lei wrote: ... > > shost->use_blk_mq = scsi_use_blk_mq; > > Not sure if this is a patch formatting issue, but this old line wasn't > deleted. Good catch, the old line need to be re

Re: [PATCH V2 2/8] blk-mq: introduce BLK_MQ_F_GLOBAL_TAGS

2018-02-06 Thread Ming Lei
On Tue, Feb 06, 2018 at 04:18:20PM -0700, Jens Axboe wrote: > On 2/5/18 8:20 AM, Ming Lei wrote: ... > > GLOBAL implies that it's, strangely enough, global. That isn't really the > case. Why not call this BLK_MQ_F_HOST_TAGS or something like that? I'd > welcome better names, but global doesn't see

Re: [PATCH V2 2/8] blk-mq: introduce BLK_MQ_F_GLOBAL_TAGS

2018-02-06 Thread Ming Lei
On Tue, Feb 06, 2018 at 12:33:36PM -0800, Omar Sandoval wrote: > On Mon, Feb 05, 2018 at 11:20:29PM +0800, Ming Lei wrote: .. > > > > + /* need to restart all hw queues for global tags */ > > + if (hctx->flags & BLK_MQ_F_GLOBAL_TAGS) { > > + struct blk_mq_hw_ctx *hctx2; > > +

Re: [PATCH 0/2] qla2xxx: Bug fixes for driver

2018-02-06 Thread Martin K. Petersen
Himanshu, > Patch#1 is the issue reported by Max using KASAN tool. > Patch#2 fixes use of wrong queue handle for abort IOCB. Applied to 4.16/scsi-fixes, thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/1] scsi: storvsc: Increase cmd_per_lun for higher speed devices

2018-02-06 Thread Martin K. Petersen
Michael, > Increase cmd_per_lun to allow more I/Os in progress per device, > particularly for NVMe's. The Hyper-V host side can handle the higher > count with no issues. Applied to 4.16/scsi-fixes. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/1] scsi: storvsc: Spread interrupts when picking a channel for I/O requests

2018-02-06 Thread Martin K. Petersen
Michael, > Update the algorithm in storvsc_do_io to look for a channel starting > with the current CPU + 1 and wrap around (within the current NUMA > node). This spreads VMbus interrupts more evenly across CPUs. Previous > code always started with first CPU in the current NUMA node, skewing > the

Re: [PATCH 1/6] qla2xxx: Fix a locking imbalance in qlt_24xx_handle_els()

2018-02-06 Thread Martin K. Petersen
Bart, > Ensure that upon return the tgt->ha->tgt.sess_lock spin lock is > unlocked no matter which code path is taken through this function. > This was detected by sparse. Applied to 4.16/scsi-fixes. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 07/13] lpfc: Add if_type=6 support for cycling valid bits

2018-02-06 Thread Martin K. Petersen
James, > in accessng the EQ/CQ elements is eliminated. accessing -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 01/13] lpfc: Rework lpfc to allow different sli4 cq and eq handlers

2018-02-06 Thread Martin K. Petersen
James, I was on the verge of applying this as well but saw that you intended a re-spin. Found a few typos while poring over these patches: > Prepare the code for new hardwre by creating a sli4-based callout hardware > table that can be set based on if_type. -- Martin K. Petersen Oracle

Re: [PATCH 04/13] lpfc: Add push-to-adapter support to sli4

2018-02-06 Thread Martin K. Petersen
James, > New if_type=6 adapters support and additional BAR that provides s/and/an/ -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3 00/19] lpfc updates for 11.4.0.7

2018-02-06 Thread Martin K. Petersen
James, > This patch set provides a number of fixes for the driver. Applied to my 4.17/scsi-queue staging tree. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/3] scsi: aacraid: Multi controller Kdump IOP reset handling

2018-02-06 Thread Martin K. Petersen
Raghava, > During Kdump aacraid controller IOP reset is invoked, IOP reset > takes approx 40 seconds to bring the controller back up and running. > with timeout of 120 seconds and anything more than 2 controllers > will cause kdump to timeout. > > This patchset implements a new reset mechanism ca

Re: [PATCH V2 2/8] blk-mq: introduce BLK_MQ_F_GLOBAL_TAGS

2018-02-06 Thread Jens Axboe
On 2/5/18 8:20 AM, Ming Lei wrote: > Quite a few HBAs(such as HPSA, megaraid, mpt3sas, ..) support multiple > reply queues, but tags is often HBA wide. > > These HBAs have switched to use pci_alloc_irq_vectors(PCI_IRQ_AFFINITY) > for automatic affinity assignment. > > Now 84676c1f21e8ff5(genirq/a

Re: [PATCH V2 0/8] blk-mq/scsi-mq: support global tags & introduce force_blk_mq

2018-02-06 Thread Jens Axboe
On 2/5/18 8:20 AM, Ming Lei wrote: > Hi All, > > This patchset supports global tags which was started by Hannes originally: > > https://marc.info/?l=linux-block&m=149132580511346&w=2 > > Also inroduce 'force_blk_mq' and 'host_tagset' to 'struct scsi_host_template', > so that driver can avo

Re: [PATCH] scsi: qedf: remove redundant initialization of 'fcport'

2018-02-06 Thread Chad Dupuis
On Tue, 6 Feb 2018, 9:03am, Colin King wrote: > From: Colin Ian King > > Pointer fcport is initialized with a value that is never read, it is > re-assigned a new value later on, hence the initialization is redundant > and can be removed. > > Cleans up clang warning: > drivers/scsi/qedf/qedf_io

Re: [PATCH V2 4/8] block: null_blk: introduce module parameter of 'g_global_tags'

2018-02-06 Thread Omar Sandoval
On Mon, Feb 05, 2018 at 11:20:31PM +0800, Ming Lei wrote: > This patch introduces the parameter of 'g_global_tags' so that we can > test this feature by null_blk easiy. > > Not see obvious performance drop with global_tags when the whole hw > depth is kept as same: > > 1) no 'global_tags', each h

Re: [PATCH V2 1/8] blk-mq: tags: define several fields of tags as pointer

2018-02-06 Thread Omar Sandoval
On Mon, Feb 05, 2018 at 11:20:28PM +0800, Ming Lei wrote: > This patch changes tags->breserved_tags, tags->bitmap_tags and > tags->active_queues as pointer, and prepares for supporting global tags. > > No functional change. > > Tested-by: Laurence Oberman > Reviewed-by: Hannes Reinecke Assumin

Re: [PATCH V2 2/8] blk-mq: introduce BLK_MQ_F_GLOBAL_TAGS

2018-02-06 Thread Omar Sandoval
On Mon, Feb 05, 2018 at 11:20:29PM +0800, Ming Lei wrote: > Quite a few HBAs(such as HPSA, megaraid, mpt3sas, ..) support multiple > reply queues, but tags is often HBA wide. > > These HBAs have switched to use pci_alloc_irq_vectors(PCI_IRQ_AFFINITY) > for automatic affinity assignment. > > Now 8

Re: [PATCH V2 5/8] scsi: introduce force_blk_mq

2018-02-06 Thread Omar Sandoval
On Mon, Feb 05, 2018 at 11:20:32PM +0800, Ming Lei wrote: > From scsi driver view, it is a bit troublesome to support both blk-mq > and non-blk-mq at the same time, especially when drivers need to support > multi hw-queue. > > This patch introduces 'force_blk_mq' to scsi_host_template so that driv

Re: [PATCH v5 08/11] scsi: host template attribute groups

2018-02-06 Thread Bart Van Assche
On Tue, 2018-02-06 at 18:06 +0200, Stanislav Nijnikov wrote: > + if (sdev->host->hostt->sdev_groups) { > + error = sysfs_create_groups(&sdev->sdev_gendev.kobj, > + sdev->host->hostt->sdev_groups); > + if (error) > +

[PATCH v5 09/11] scsi: ufs: sysfs: unit descriptor

2018-02-06 Thread Stanislav Nijnikov
This patch introduces a sysfs group entry for the UFS unit descriptor parameters. The group adds "unit_descriptor" folder under the corresponding SCSI device sysfs entry (/sys/class/scsi_device/*/device/). The parameters are shown as hexadecimal numbers. The full information about the parameters co

[PATCH v5 08/11] scsi: host template attribute groups

2018-02-06 Thread Stanislav Nijnikov
The patch introduces an additional field in the scsi_host_template structure - struct attribute_group **sdev_group. This field allows to define groups of attributes. It will provide an ability to use binary attributes as well as device attributes and to group them under subfolders if necessary. Si

[PATCH v5 07/11] scsi: ufs: sysfs: string descriptors

2018-02-06 Thread Stanislav Nijnikov
This patch introduces a sysfs group entry for the UFS string descriptors. The group adds "string_descriptors" folder under the UFS driver sysfs entry (/sys/bus/platform/drivers/ufshcd/*). The folder will contain 5 files that will show string values defined by the UFS spec: a manufacturer name, a pr

[PATCH v5 03/11] scsi: ufs: sysfs: interconnect descriptor

2018-02-06 Thread Stanislav Nijnikov
This patch introduces a sysfs group entry for the UFS interconnect descriptor parameters. The group adds "interconnect_descriptor" folder under the UFS driver sysfs entry (/sys/bus/platform/drivers/ufshcd/*). The parameters are shown as hexadecimal numbers. The full information about the parameters

[PATCH v5 11/11] scsi: ufs: sysfs: attributes

2018-02-06 Thread Stanislav Nijnikov
This patch introduces a sysfs group entry for the UFS attributes. The group adds "attributes" folder under the UFS driver sysfs entry (/sys/bus/platform/drivers/ufshcd/*). The attributes are shown as hexadecimal numbers. The full information about the attributes could be found at UFS specifications

[PATCH v5 10/11] scsi: ufs: sysfs: flags

2018-02-06 Thread Stanislav Nijnikov
This patch introduces a sysfs group entry for the UFS flags. The group adds "flags" folder under the UFS driver sysfs entry (/sys/bus/platform/drivers/ufshcd/*). The flags are shown as boolean value ("true" or "false"). The full information about the UFS flags could be found at UFS specifications 2

[PATCH v5 06/11] scsi: ufs: sysfs: power descriptor

2018-02-06 Thread Stanislav Nijnikov
This patch introduces a sysfs group entry for the UFS power descriptor parameters. The group adds "power_descriptor" folder under the UFS driver sysfs entry (/sys/bus/platform/drivers/ufshcd/*). The parameters are shown as hexadecimal numbers. The full information about the parameters could be foun

[PATCH v5 05/11] scsi: ufs: sysfs: health descriptor

2018-02-06 Thread Stanislav Nijnikov
This patch introduces a sysfs group entry for the UFS health descriptor parameters. The group adds "health_descriptor" folder under the UFS driver sysfs entry (/sys/bus/platform/drivers/ufshcd/*). The parameters are shown as hexadecimal numbers. The full information about the parameters could be fo

[PATCH v5 04/11] scsi: ufs: sysfs: geometry descriptor

2018-02-06 Thread Stanislav Nijnikov
This patch introduces a sysfs group entry for the UFS geometry descriptor parameters. The group adds "geometry_descriptor" folder under the UFS driver sysfs entry (/sys/bus/platform/drivers/ufshcd/*). The parameters are shown as hexadecimal numbers. The full information about the parameters could b

[PATCH v5 02/11] scsi: ufs: sysfs: device descriptor

2018-02-06 Thread Stanislav Nijnikov
This patch introduces a sysfs group entry for the UFS device descriptor parameters. The group adds "device_descriptor" folder under the UFS driver sysfs entry (/sys/bus/platform/drivers/ufshcd/*). The parameters are shown as hexadecimal numbers. The full information about the parameters could be fo

[PATCH v5 00/11] ufs: sysfs: read-only access to device

2018-02-06 Thread Stanislav Nijnikov
This patch introduces sysfs entries that will provide read-only access to device management data that could be received with UFS query requests. User-space applications will be able to read UFS device descriptors, flags and attributes. This will allow to get full UFS device configuration and its st

[PATCH v5 01/11] scsi: ufs: sysfs: attribute group for existing sysfs entries.

2018-02-06 Thread Stanislav Nijnikov
This patch introduces attribute group to show existing sysfs entries. Signed-off-by: Stanislav Nijnikov --- drivers/scsi/ufs/Makefile| 3 +- drivers/scsi/ufs/ufs-sysfs.c | 156 +++ drivers/scsi/ufs/ufs-sysfs.h | 14 drivers/scsi/ufs/ufshcd.c

Re: [PATCH 0/5] blk-mq/scsi-mq: support global tags & introduce force_blk_mq

2018-02-06 Thread Ming Lei
Hi Kashyap, On Tue, Feb 06, 2018 at 07:57:35PM +0530, Kashyap Desai wrote: > > -Original Message- > > From: Ming Lei [mailto:ming@redhat.com] > > Sent: Tuesday, February 6, 2018 6:02 PM > > To: Kashyap Desai > > Cc: Hannes Reinecke; Jens Axboe; linux-bl...@vger.kernel.org; Christoph >

Re: [PATCH/RFC 0/6] Allow compile-testing NO_DMA

2018-02-06 Thread Arnd Bergmann
On Tue, Feb 6, 2018 at 2:05 PM, Robin Murphy wrote: > > It looks like we have only one real arch (score) without IOMEM, and two > (s390 and tile) where it is possible to configure out, so it does seem like > a reasonable feature to assume. Maybe we could have something like > asm-generic/no-io.h t

Re: [PATCH V2 1/2] qedi: Fix truncation of CHAP name and secret

2018-02-06 Thread Bart Van Assche
On Tue, 2018-02-06 at 05:12 -0800, Nilesh Javali wrote: > From: Andrew Vasquez > > The data in NVRAM is not guaranteed to be NUL terminated. > Copy the data upto the element size or to the first NUL > in the byte-stream and then append a NUL. > > Signed-off-by: Andrew Vasquez > Signed-off-by: N

Re: [PATCH/RFC 0/6] Allow compile-testing NO_DMA

2018-02-06 Thread Arnd Bergmann
On Tue, Feb 6, 2018 at 11:14 AM, Geert Uytterhoeven wrote: > Hi all, > > If NO_DMA=y, get_dma_ops() returns a reference to the non-existing > symbol bad_dma_ops, thus causing a link failure if it is ever used. > > The intention of this is twofold: > 1. To catch users of the DMA API on sy

Re: [PATCH] scsi: libfc: remove redundant initialization of 'disc'

2018-02-06 Thread Johannes Thumshirn
Looks good, Acked-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürn

[PATCH] scsi: pmcraid: remove redundant initializations of pointer 'ioadl'

2018-02-06 Thread Colin King
From: Colin Ian King There are several occurrances where pointer ioadl is initialized with a value that is never read and where it is re-assigned a new value later on, hence the initialization is redundant and can be removed. Cleans up clang warnings: drivers/scsi/pmcraid.c:1028:29: warning: Val

RE: [PATCH 0/5] blk-mq/scsi-mq: support global tags & introduce force_blk_mq

2018-02-06 Thread Kashyap Desai
> -Original Message- > From: Ming Lei [mailto:ming@redhat.com] > Sent: Tuesday, February 6, 2018 6:02 PM > To: Kashyap Desai > Cc: Hannes Reinecke; Jens Axboe; linux-bl...@vger.kernel.org; Christoph > Hellwig; Mike Snitzer; linux-scsi@vger.kernel.org; Arun Easi; Omar Sandoval; > Martin

[PATCH] scsi: libfc: remove redundant initialization of 'disc'

2018-02-06 Thread Colin King
From: Colin Ian King Pointer disc is being intializated a value that is never read and then re-assigned the same value later on, hence the initialization is redundant and can be removed. Cleans up clang warning: drivers/scsi/libfc/fc_disc.c:734:18: warning: Value stored to 'disc' during its init

[PATCH] scsi: isci: remove redundant initialization to 'bit'

2018-02-06 Thread Colin King
From: Colin Ian King Variable bit is initialized with a value that is never read and is being updated immediately after the initialization, hence the initialization is redundant and can be removed. Cleans up clang warning: drivers/scsi/isci/host.c:2769:8: warning: Value stored to 'bit' during it

Re: [PATCH] scsi_debug: Add two new parameters to scsi_debug driver

2018-02-06 Thread Douglas Gilbert
On 2018-02-03 01:38 PM, Laurence Oberman wrote: --- This patch adds two new parameters to the scsi_debug driver. During various fault injection scenarios it would be useful to be able to pick a specific starting sector and number of follow on sectors where a MEDIUM ERROR for reads would be return

[PATCH] scsi: qedf: remove redundant initialization of 'fcport'

2018-02-06 Thread Colin King
From: Colin Ian King Pointer fcport is initialized with a value that is never read, it is re-assigned a new value later on, hence the initialization is redundant and can be removed. Cleans up clang warning: drivers/scsi/qedf/qedf_io.c:920:21: warning: Value stored to 'fcport' during its initiali

[PATCH V2 1/2] qedi: Fix truncation of CHAP name and secret

2018-02-06 Thread Nilesh Javali
From: Andrew Vasquez The data in NVRAM is not guaranteed to be NUL terminated. Copy the data upto the element size or to the first NUL in the byte-stream and then append a NUL. Signed-off-by: Andrew Vasquez Signed-off-by: Nilesh Javali --- drivers/scsi/qedi/qedi_main.c | 45 ++

[PATCH 2/2] qedi: Cleanup local str variable

2018-02-06 Thread Nilesh Javali
Signed-off-by: Nilesh Javali --- drivers/scsi/qedi/qedi_main.c | 43 --- 1 file changed, 20 insertions(+), 23 deletions(-) diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c index f3dd438..701bc72 100644 --- a/drivers/scsi/qedi/qedi

[PATCH 0/2] Code cleanup and bug fix for truncated CHAP name and secret

2018-02-06 Thread Nilesh Javali
Bart, Lee, This patch set consists of v2 solution for the bug fix for CHAP name and secret. Please review and let know the comments. Martin, Please consider below patch set for next 'scsi-fixes' submission. Thanks, Nilesh Andrew Vasquez (1): qedi: Fix truncation of CHAP name and secret Nilesh

Re: [PATCH/RFC 0/6] Allow compile-testing NO_DMA

2018-02-06 Thread Robin Murphy
On 06/02/18 10:14, Geert Uytterhoeven wrote: Hi all, If NO_DMA=y, get_dma_ops() returns a reference to the non-existing symbol bad_dma_ops, thus causing a link failure if it is ever used. The intention of this is twofold: 1. To catch users of the DMA API on systems that do no support

Re: [PATCH/RFC 4/6] mm: Add NO_DMA dummies for DMA pool API

2018-02-06 Thread Robin Murphy
Hi Geert, On 06/02/18 10:14, Geert Uytterhoeven wrote: Add dummies for dma{,m}_pool_{create,destroy,alloc,free}(), to allow compile-testing if NO_DMA=y. This prevents the following from showing up later: ERROR: "dma_pool_destroy" [drivers/usb/mtu3/mtu3.ko] undefined! ERROR: "dma_pool

Re: [PATCH 0/5] blk-mq/scsi-mq: support global tags & introduce force_blk_mq

2018-02-06 Thread Ming Lei
Hi Kashyap, On Tue, Feb 06, 2018 at 04:59:51PM +0530, Kashyap Desai wrote: > > -Original Message- > > From: Ming Lei [mailto:ming@redhat.com] > > Sent: Tuesday, February 6, 2018 1:35 PM > > To: Kashyap Desai > > Cc: Hannes Reinecke; Jens Axboe; linux-bl...@vger.kernel.org; Christoph >

Re: [PATCH/RFC 0/6] Allow compile-testing NO_DMA

2018-02-06 Thread Mark Brown
On Tue, Feb 06, 2018 at 11:14:46AM +0100, Geert Uytterhoeven wrote: > The intention of this is twofold: > 1. To catch users of the DMA API on systems that do no support the DMA > mapping API, > 2. To avoid building drivers that cannot work on such systems anyway. > > However, the disadva

RE: [PATCH 0/5] blk-mq/scsi-mq: support global tags & introduce force_blk_mq

2018-02-06 Thread Kashyap Desai
> -Original Message- > From: Ming Lei [mailto:ming@redhat.com] > Sent: Tuesday, February 6, 2018 1:35 PM > To: Kashyap Desai > Cc: Hannes Reinecke; Jens Axboe; linux-bl...@vger.kernel.org; Christoph > Hellwig; Mike Snitzer; linux-scsi@vger.kernel.org; Arun Easi; Omar Sandoval; > Martin

[PATCH/RFC 2/6] dma-coherent: Add NO_DMA dummies for managed DMA API

2018-02-06 Thread Geert Uytterhoeven
Add dummies for dmam_{alloc,free}_coherent(), to allow compile-testing if NO_DMA=y. This prevents the following from showing up later: ERROR: "dmam_alloc_coherent" [drivers/net/ethernet/arc/arc_emac.ko] undefined! ERROR: "dmam_free_coherent" [drivers/net/ethernet/apm/xgene/xgene-enet.ko]

[PATCH/RFC 0/6] Allow compile-testing NO_DMA

2018-02-06 Thread Geert Uytterhoeven
Hi all, If NO_DMA=y, get_dma_ops() returns a reference to the non-existing symbol bad_dma_ops, thus causing a link failure if it is ever used. The intention of this is twofold: 1. To catch users of the DMA API on systems that do no support the DMA mapping API, 2. To avoid buildin

[PATCH/RFC 1/6] dma-mapping: Convert NO_DMA get_dma_ops() into a real dummy

2018-02-06 Thread Geert Uytterhoeven
If NO_DMA=y, get_dma_ops() returns a reference to the non-existing symbol bad_dma_ops, thus causing a link failure if it is ever used. Make get_dma_ops() return NULL instead, to avoid the link failure. This allows to improve compile-testing, and limits the need to keep on sprinkling dependencies o

[PATCH/RFC 6/6] Treewide: Remove depends on HAS_DMA in case of platform dependency

2018-02-06 Thread Geert Uytterhoeven
Remove dependencies on HAS_DMA where a Kconfig symbol depends on another symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST". In most cases this other symbol is an architecture or platform specific symbol, or PCI. Generic symbols and drivers without platform dependencies keep their

[PATCH/RFC 4/6] mm: Add NO_DMA dummies for DMA pool API

2018-02-06 Thread Geert Uytterhoeven
Add dummies for dma{,m}_pool_{create,destroy,alloc,free}(), to allow compile-testing if NO_DMA=y. This prevents the following from showing up later: ERROR: "dma_pool_destroy" [drivers/usb/mtu3/mtu3.ko] undefined! ERROR: "dma_pool_free" [drivers/usb/mtu3/mtu3.ko] undefined! ERROR: "dma

[PATCH/RFC 5/6] scsi: Add NO_DMA dummies for SCSI DMA mapping API

2018-02-06 Thread Geert Uytterhoeven
Add dummies for scsi_dma_{,un}map(), to allow compile-testing if NO_DMA=y. This prevents the following from showing up later: ERROR: "scsi_dma_unmap" [drivers/firewire/firewire-sbp2.ko] undefined! ERROR: "scsi_dma_map" [drivers/firewire/firewire-sbp2.ko] undefined! Signed-off-by: Geert U

[PATCH/RFC 3/6] usb: gadget: Add NO_DMA dummies for DMA mapping API

2018-02-06 Thread Geert Uytterhoeven
Add dummies for usb_gadget_{,un}map_request{,_by_dev}(), to allow compile-testing if NO_DMA=y. This prevents the following from showing up later: ERROR: "usb_gadget_unmap_request_by_dev" [drivers/usb/renesas_usbhs/renesas_usbhs.ko] undefined! ERROR: "usb_gadget_map_request_by_dev" [driv

Re: [PATCH V2 8/8] scsi: hpsa: use blk_mq to solve irq affinity issue

2018-02-06 Thread Ming Lei
On Tue, Feb 06, 2018 at 09:39:26AM +0100, Hannes Reinecke wrote: > On 02/05/2018 04:20 PM, Ming Lei wrote: > > This patch uses .force_blk_mq to drive HPSA via SCSI_MQ, meantime maps > > each reply queue to blk_mq's hw queue, then .queuecommand can always > > choose the hw queue as the reply queue.

Re: [PATCH V2 8/8] scsi: hpsa: use blk_mq to solve irq affinity issue

2018-02-06 Thread Hannes Reinecke
On 02/05/2018 04:20 PM, Ming Lei wrote: > This patch uses .force_blk_mq to drive HPSA via SCSI_MQ, meantime maps > each reply queue to blk_mq's hw queue, then .queuecommand can always > choose the hw queue as the reply queue. And if no any online CPU is > mapped to one hw queue, request can't be su

Re: [PATCH V2 7/8] scsi: hpsa: call hpsa_hba_inquiry() after adding host

2018-02-06 Thread Hannes Reinecke
On 02/05/2018 04:20 PM, Ming Lei wrote: > So that we can decide the default reply queue by the map created > during adding host. > > Cc: Hannes Reinecke > Cc: Arun Easi > Cc: Omar Sandoval , > Cc: "Martin K. Petersen" , > Cc: James Bottomley , > Cc: Christoph Hellwig , > Cc: Don Brace > Cc: Kas

[Bug 198689] Setro has no effect for SCSI device

2018-02-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=198689 Li Ning (yzlin...@foxmail.com) changed: What|Removed |Added Component|AACRAID |Other -- You are receiv

Re: [PATCH V2 8/8] scsi: hpsa: use blk_mq to solve irq affinity issue

2018-02-06 Thread Ming Lei
Hello chenxiang, On Tue, Feb 06, 2018 at 10:18:19AM +0800, chenxiang (M) wrote: > 在 2018/2/5 23:20, Ming Lei 写道: > > This patch uses .force_blk_mq to drive HPSA via SCSI_MQ, meantime maps > > each reply queue to blk_mq's hw queue, then .queuecommand can always > > choose the hw queue as the reply

[Bug 198689] New: Setro has no effect for SCSI device

2018-02-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=198689 Bug ID: 198689 Summary: Setro has no effect for SCSI device Product: SCSI Drivers Version: 2.5 Kernel Version: all Hardware: All OS: Linux Tree: Mainline

Re: [PATCH 0/5] blk-mq/scsi-mq: support global tags & introduce force_blk_mq

2018-02-06 Thread Ming Lei
Hi Kashyap, On Tue, Feb 06, 2018 at 11:33:50AM +0530, Kashyap Desai wrote: > > > We still have more than one reply queue ending up completion one CPU. > > > > pci_alloc_irq_vectors(PCI_IRQ_AFFINITY) has to be used, that means > > smp_affinity_enable has to be set as 1, but seems it is the default