I first though of renameing:
lpfc_sli4_eq_clr_intr -> lpfc_sli4_t2_eq_clr_intr
lpfc_sli4_eq_release -> lpfc_sli4_t2_eq_release
lpfc_sli4_cq_release -> lpfc_sli4_t2_cq_release
and then make lpfc_sli4_eq_clr_intr, etc... wrappers over the new function
pointers so and you could keep the callsites,
> diff --git a/drivers/scsi/lpfc/lpfc_sli4.h b/drivers/scsi/lpfc/lpfc_sli4.h
> index 0c0cbe296fed..e2f06c92c4dd 100644
> --- a/drivers/scsi/lpfc/lpfc_sli4.h
> +++ b/drivers/scsi/lpfc/lpfc_sli4.h
> @@ -569,7 +569,8 @@ struct lpfc_sli4_hba {
> /* IF type 0, BAR 0 and if type 2, BAR 0 doorbell r
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG N
> + if ((if_type == LPFC_SLI_INTF_IF_TYPE_6) &&
> + (pci_resource_start(pdev, PCI_64BIT_BAR4))) {
The above contains a lot of unneeded parenthesis.
[...]
> + /* Enable combined writes for DPP aperture */
> + pg_addr = (unsigned long)(wq->dpp_re
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG N
On Tue, Feb 06, 2018 at 06:28:44PM -0800, James Smart wrote:
> lpfc_printf_log(phba, KERN_ERR, LOG_INIT,
> - "0469 lpfc_link_speed attribute cannot be set to %d, "
> - "allowed values are ["LPFC_LINK_SPEED_STRING"]\n", val);
> + "0469 lpfc_link_spee
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG N
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG N
On Tue, Feb 06, 2018 at 06:28:47PM -0800, James Smart wrote:
> + if (do_pbde && (i == 0)) {
Nit:
if (do_pde && i == 0) {
Else:
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de
On Wed, Feb 07, 2018 at 10:51:57AM +0100, Johannes Thumshirn wrote:
> > + /* Enable combined writes for DPP aperture */
> > + pg_addr = (unsigned long)(wq->dpp_regaddr) & PAGE_MASK;
> > +#ifdef CONFIG_X86
> > + rc = set_memory_wc(pg_addr, 1);
>
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG N
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG N
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG N
Looks good,
Reviewed-by: Johannes Thumshirn
Although I'd change the subject to:
"lpfc: Change Copyright of Update 12.0.0.0 modified files to 2018"
Reads easier for the non-native english speaker (like me).
--
Johannes Thumshirn Storage
jthumsh...@suse.d
This configures shost max sector to 128, single reply descriptor
post queue, sgl table size to 16 and 32 bit DMA for MPI Endpoint
and it supports 64K as max IO.
Signed-off-by: Suganath Prabu S
---
drivers/scsi/mpt3sas/mpt3sas_base.c | 47 +++-
drivers/scsi/mpt3sa
Add device ID and flag for Andromeda/MPI Emdpont.
Signed-off-by: Suganath Prabu S
---
drivers/scsi/mpt3sas/mpi/mpi2_cnfg.h | 1 +
drivers/scsi/mpt3sas/mpt3sas_base.h | 1 +
drivers/scsi/mpt3sas/mpt3sas_scsih.c | 14 --
3 files changed, 14 insertions(+), 2 deletions(-)
diff --git
For MPI Endpoint/Mcpu, Driver should double buffer data buffer/sgl's.
This is normally copied from host to internal memory of IOC by
DMA engine of PCI Device. Since the interface to DMA from host
to mCPU is not present for Mcpu/MPI Endpoint device,
Driver does double copy of those buffer direct
If the posted request has an error of any type, the IOC writes
a Reply message into a host-based system reply message frame.
This functions clone it in the BAR0 mapped region.
Signed-off-by: Suganath Prabu S
---
drivers/scsi/mpt3sas/mpt3sas_base.c | 37 -
1 fi
V1 Change info:
* Few sparse warning fixes over initial patch set.
* For 32 bit Arch,_base_writeq function is identical
to _base_mpi_ep_writeq, Removed duplicate code as suggested by Martin.
Andromeda is a PCIe switch, and it has a dedicated management
CPU (mCPU), nonvolatile flash memory, RAM e
1) Added function _base_clone_mpi_to_sys_mem to clone
MPI request into system BAR0 mapped region.
2) Separate out MPI Endpoint IO submissions to function
_base_put_smid_mpi_ep_scsi_io.
3) MPI EP requests are submitted in two 32 bit MMIO writes.
from _base_mpi_ep_writeq.
For 32 bit Arch,_base_wr
All scsi IO's and config requests data buffer and
sgl are cloned to system memory in _clone_sg_entries
before submitting it to Firmware.
Signed-off-by: Suganath Prabu S
---
drivers/scsi/mpt3sas/mpt3sas_base.c | 215 +-
drivers/scsi/mpt3sas/mpt3sas_base.h | 3
On 30/01/2018 10:33, John Garry wrote:
On 30/01/2018 01:24, Ming Lei wrote:
On Mon, Jan 29, 2018 at 12:56:30PM -0800, James Bottomley wrote:
On Mon, 2018-01-29 at 23:46 +0800, Ming Lei wrote:
[...]
2. When to enable SCSI_MQ at default again?
I'm not sure there's much to discuss ... I think t
On Wed, Feb 07, 2018 at 07:50:21AM +0100, Hannes Reinecke wrote:
> Hi all,
>
> [ .. ]
> >>
> >> Could you share us your patch for enabling global_tags/MQ on
> > megaraid_sas
> >> so that I can reproduce your test?
> >>
> >>> See below perf top data. "bt_iter" is consuming 4 times more CPU.
> >>
>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git misc
head: 16a628faa63c8149d9a8f433e5c6548f6cff98e4
commit: 2439bec3bf084ab6cbc69a66797a4612042be6ca [327/330] scsi: storvsc:
Spread interrupts when picking a channel for I/O requests
config: x86_64-randconfig-s1-02071932 (att
On 2/6/18, 8:53 PM, "Bart Van Assche" wrote:
>On Tue, 2018-02-06 at 05:12 -0800, Nilesh Javali wrote:
>> From: Andrew Vasquez
>>
>> The data in NVRAM is not guaranteed to be NUL terminated.
>> Copy the data upto the element size or to the first NUL
>> in the byte-stream and then append a NUL.
> -Original Message-
> From: Ming Lei [mailto:ming@redhat.com]
> Sent: Wednesday, February 7, 2018 5:53 PM
> To: Hannes Reinecke
> Cc: Kashyap Desai; Jens Axboe; linux-bl...@vger.kernel.org; Christoph
> Hellwig; Mike Snitzer; linux-scsi@vger.kernel.org; Arun Easi; Omar
Sandoval;
> Marti
On 2/7/2018 1:58 AM, Johannes Thumshirn wrote:
On Tue, Feb 06, 2018 at 06:28:44PM -0800, James Smart wrote:
lpfc_printf_log(phba, KERN_ERR, LOG_INIT,
- "0469 lpfc_link_speed attribute cannot be set to %d, "
- "allowed values are ["LPFC_LINK_SPEED_STRING"]\n",
On Fri, 2 Feb 2018, 8:12am, Arnd Bergmann wrote:
> The prototype for qedf_dbg_fops/qedf_debugfs_ops doesn't match the definition,
> which causes the final link to fail with link-time optimizations:
>
> drivers/scsi/qedf/qedf_main.c:34: error: type of 'qedf_dbg_fops' does not
> match original de
On Wed, Feb 07, 2018 at 07:38:39AM -0800, James Smart wrote:
> On 2/7/2018 1:58 AM, Johannes Thumshirn wrote:
> > On Tue, Feb 06, 2018 at 06:28:44PM -0800, James Smart wrote:
> > > lpfc_printf_log(phba, KERN_ERR, LOG_INIT,
> > > - "0469 lpfc_link_speed attribute cannot be set to %
On 2/7/2018 2:27 AM, Johannes Thumshirn wrote:
On Wed, Feb 07, 2018 at 10:51:57AM +0100, Johannes Thumshirn wrote:
+ /* Enable combined writes for DPP aperture */
+ pg_addr = (unsigned long)(wq->dpp_regaddr) & PAGE_MASK;
+#ifdef CONFIG_X86
+
> -Original Message-
> From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
> ow...@vger.kernel.org] On Behalf Of Martin K. Petersen
> Sent: Tuesday, February 6, 2018 4:21 PM
> To: Raghava Aditya Renukunta
>
> Cc: j...@linux.vnet.ibm.com; martin.peter...@oracle.com; linux-
> s...@v
On 02/06/18 15:18, Jens Axboe wrote:
GLOBAL implies that it's, strangely enough, global. That isn't really the
case. Why not call this BLK_MQ_F_HOST_TAGS or something like that? I'd
welcome better names, but global doesn't seem to be a great choice.
BLK_MQ_F_SET_TAGS?
I like the name BLK_MQ_F_
Signed-off-by: Nilesh Javali
---
drivers/scsi/qedi/qedi_main.c | 43 ---
1 file changed, 20 insertions(+), 23 deletions(-)
diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
index deaed93..47c45a5 100644
--- a/drivers/scsi/qedi/qedi
From: Andrew Vasquez
The data in NVRAM is not guaranteed to be NUL terminated.
Since snprintf expects byte-stream to accommodate null byte,
the CHAP secret is truncated.
Use sprintf instead of snprintf to fix the truncation of
CHAP name and secret.
Signed-off-by: Andrew Vasquez
Signed-off-by: N
Martin,
Please consider below patch set for next 'scsi-fixes' submission.
Thanks,
Nilesh
Andrew Vasquez (1):
qedi: Fix truncation of CHAP name and secret
Nilesh Javali (1):
qedi: Cleanup local str variable
drivers/scsi/qedi/qedi_main.c | 55 ---
1 fi
On Fri, 2 Feb 2018, 8:12am, Arnd Bergmann wrote:
> gcc-8 warns during link-time optimization that the strncpy() call
> passes the size of the source buffer rather than the destination:
>
> drivers/scsi/qedf/qedf_dbg.c: In function 'qedf_uevent_emit':
> include/linux/string.h:253: error: 'strncpy
On 02/07/18 08:12, Nilesh Javali wrote:
The data in NVRAM is not guaranteed to be NUL terminated.
Since snprintf expects byte-stream to accommodate null byte,
the CHAP secret is truncated.
Use sprintf instead of snprintf to fix the truncation of
CHAP name and secret.
Reviewed-by: Bart Van Assch
On 02/07/18 08:12, Nilesh Javali wrote:
Signed-off-by: Nilesh Javali
Reviewed-by: Bart Van Assche
During Kdump aacraid controller IOP reset is invoked, IOP reset
takes approx 40 seconds to bring the controller back up and running.
with timeout of 120 seconds and anything more than 2 controllers
will cause kdump to timeout.
This patchset implements a new reset mechanism called DropIO, that
indu
Preserve the current MSIX mode value in the OMR before
rewriting the OMR to initiate the IOP or Soft Reset.
Signed-off-by: Prasad B Munirathnam
Signed-off-by: Raghava Aditya Renukunta
Reviewed-by: Dave Carroll
---
Changes in V2:
Re based on Linus Master
drivers/scsi/aacraid/src.c | 22 ++
During sync command processing if legacy INTx status indicates
command is not completed, sample the MSIx register and check if
it indicates command completion, set controller MSIx enabled flag.
Signed-off-by: Prasad B Munirathnam
Signed-off-by: Raghava Aditya Renukunta
Reviewed-by: Dave Carroll
IOP_RESET takes longer time to complete, if controller
is in a state where we can bring it back with init struct,
controller DropIO sync command is implemented.
- If controller is faulted perform standard IOP_RESET in aac_srcv_init.
- If controller is not faulted get adapter properties and exten
On Mon, 2018-02-05 at 23:20 +0800, Ming Lei wrote:
> diff --git a/block/blk-mq-sched.c b/block/blk-mq-sched.c
> index 55c0a745b427..385bbec73804 100644
> --- a/block/blk-mq-sched.c
> +++ b/block/blk-mq-sched.c
> @@ -81,6 +81,17 @@ static bool blk_mq_sched_restart_hctx(struct blk_mq_hw_ctx
> *hctx)
On Wed, Feb 07, 2018 at 08:12:35AM -0800, Nilesh Javali wrote:
> From: Andrew Vasquez
>
> The data in NVRAM is not guaranteed to be NUL terminated.
> Since snprintf expects byte-stream to accommodate null byte,
> the CHAP secret is truncated.
> Use sprintf instead of snprintf to fix the truncatio
On Wed, Feb 07, 2018 at 08:12:36AM -0800, Nilesh Javali wrote:
> Signed-off-by: Nilesh Javali
Signed-off-by: Chris Leech
> ---
> drivers/scsi/qedi/qedi_main.c | 43
> ---
> 1 file changed, 20 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/scsi
On 02/05/2018 01:13 PM, Lee Duncan wrote:
> The libiscsi code was using both spin_lock()/spin_unlock()
> and spin_lock_bh()/spin_unlock_bh() on its session lock.
It does this because the lock was only taken between bottom halves and
process contexts. If we are already in a bh then there is no need
On 02/05/2018 01:13 PM, Lee Duncan wrote:
> diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
> index 82c3fd4bc938..055357b2fe9e 100644
> --- a/drivers/scsi/libiscsi.c
> +++ b/drivers/scsi/libiscsi.c
> @@ -1248,9 +1248,9 @@ int iscsi_complete_pdu(struct iscsi_conn *conn, struct
> iscs
On 02/07/2018 04:41 PM, Mike Christie wrote:
>
>> static int iscsi_exec_task_mgmt_fn(struct iscsi_conn *conn,
>> @@ -1908,7 +1908,7 @@ static enum blk_eh_timer_return
>> iscsi_eh_cmd_timed_out(struct scsi_cmnd *sc)
>>
>> ISCSI_DBG_EH(session, "scsi cmd %p timedout\n", sc);
>>
>> -s
Hi Kashyap,
On Wed, Feb 07, 2018 at 07:44:04PM +0530, Kashyap Desai wrote:
> > -Original Message-
> > From: Ming Lei [mailto:ming@redhat.com]
> > Sent: Wednesday, February 7, 2018 5:53 PM
> > To: Hannes Reinecke
> > Cc: Kashyap Desai; Jens Axboe; linux-bl...@vger.kernel.org; Christoph
On Mon, Feb 05, 2018 at 11:13:23AM -0800, Lee Duncan wrote:
> The libiscsi code was using both spin_lock()/spin_unlock()
> and spin_lock_bh()/spin_unlock_bh() on its session lock.
> In addition, lock validation found that libiscsi.c was
> taking a HARDIRQ-unsafe lock while holding an HARDIRQ-
> irq
I overlooked it by mentally swapping out the session->lock in the patch
for session->frwd_lock from the warning when looking at this, but what
kernel was this patch built against? It doesn't have the
frwd_lock/back_lock split stuff.
- Chris
On Mon, Feb 05, 2018 at 11:13:23AM -0800, Lee Duncan wr
On 02/07/2018 03:14 PM, Kashyap Desai wrote:
>> -Original Message-
>> From: Ming Lei [mailto:ming@redhat.com]
>> Sent: Wednesday, February 7, 2018 5:53 PM
>> To: Hannes Reinecke
>> Cc: Kashyap Desai; Jens Axboe; linux-bl...@vger.kernel.org; Christoph
>> Hellwig; Mike Snitzer; linux-scsi
52 matches
Mail list logo
