Re: [PATCH v2] scsi: Avoid that .queuecommand() gets called for a quiesced SCSI device

2018-03-17 Thread James Bottomley
On Fri, 2018-03-16 at 23:10 +, Bart Van Assche wrote: > On Fri, 2018-03-16 at 15:49 -0700, James Bottomley wrote: > > > > In your new code you have > > > > +   if (sdev->sdev_state != SDEV_QUIESCE) > > +   rtn = shost->hostt->queuecommand(shost, scmd); > > +   else > > +  

Compliment of the day to you Dear Friend

2018-03-17 Thread Mrs.Natacha.Farouk
Compliment of the day to you Dear Friend. for security reason contact me Through this email (mrsnatacha.far...@barid.com) Dear Friend. I am Mrs.Natacha Farouk. am sending this brief letter to solicit your partnership to transfer $5.5 million US Dollars. I shall send you more information and

Re: [PATCH] scsi: scsi_transport_iscsi: use put_device() instead of kfree()

2018-03-17 Thread arvindY
On Thursday 15 March 2018 11:14 PM, Chris Leech wrote: On Wed, Mar 07, 2018 at 05:07:33PM +0530, Arvind Yadav wrote: Never directly free @dev after calling device_register(), even if it returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind

Re: [PATCH] [RFC] target/file: add support of direct and async I/O

2018-03-17 Thread Christoph Hellwig
On Fri, Mar 16, 2018 at 05:13:25PM -0700, Andrei Vagin wrote: > > Please call the methods directly instead of through the wrappers. > > Do you mean to call file->f_op->write_iter(kio, iter) instead of > call_write_iter()? What is wrong with these wrappers? Yes. They are completely pointless and