RE: [PATCH v2 10/21] lightnvm: Remove depends on HAS_DMA in case of platform dependency

2018-03-18 Thread Madalin-cristian Bucur
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Geert Uytterhoeven > Sent: Friday, March 16, 2018 3:52 PM > To: Christoph Hellwig ; Marek Szyprowski > ; Robin Murphy

[PATCH v2 6/6] scsi_io_completion convert BUGs to WARNs

2018-03-18 Thread Douglas Gilbert
The scsi_io_completion function contains three BUG() and BUG_ON() calls. Replace them with WARN variants. Signed-off-by: Douglas Gilbert --- This was done at a reviewer's request. This patchset did not change those BUG() lines but the git-diff suggested it did. Then the

[PATCH v2 2/6] scsi_io_completion rename variables

2018-03-18 Thread Douglas Gilbert
Change some variable names and associated comments for clarity. Correct some misleading comments. Signed-off-by: Douglas Gilbert Reviewed-by: Johannes Thumshirn --- drivers/scsi/scsi_lib.c | 57 ++--- 1 file

[PATCH v2 1/6] scsi_io_completion comment on end_request return

2018-03-18 Thread Douglas Gilbert
scsi_end_request() is called multiple times from scsi_io_completion() which branches on its bool returned value. Add comment before the static definition of scsi_end_request() about the meaning of that return. Signed-off-by: Douglas Gilbert Reviewed-by: Johannes Thumshirn

[PATCH v2 4/6] scsi_io_completion_action helper added

2018-03-18 Thread Douglas Gilbert
Place scsi_io_completion()'s complex error processing associated with a local enumeration into a static helper function. That enumeration's values start with "ACTION_" so use the suffix "_action" in the helper function's name. Signed-off-by: Douglas Gilbert Reviewed-by:

[PATCH v2 0/6] scsi_io_completion cleanup

2018-03-18 Thread Douglas Gilbert
While working of this "[PATCH v4] Make SCSI Status CONDITION MET equivalent to GOOD" the author had trouble finding how to add another corner case check in the scsi_io_completion() function (scsi_lib.c). That function is executed at the completion of every SCSI command but only 20 or so of its

[PATCH v2 5/6] scsi_io_completion hints on fastpatch

2018-03-18 Thread Douglas Gilbert
Add likely() and unlikely() hints to conditionals on or near the fastpath. Signed-off-by: Douglas Gilbert Reviewed-by: Johannes Thumshirn --- A reviewer wanted any performance improvement (or otherwise) quantified. The improvement was so small, that

[PATCH v2 3/6] scsi_io_completion_nz_result function added

2018-03-18 Thread Douglas Gilbert
Break out several interwined paths when cmd->result is non zero and place them in scsi_io_completion_nz_result helper function. The logic is not changed. Signed-off-by: Douglas Gilbert --- A reviewer requested the original helper function's two return values be reduced to

Re: [PATCH v2 10/21] lightnvm: Remove depends on HAS_DMA in case of platform dependency

2018-03-18 Thread Matias Bjørling
On 03/16/2018 02:51 PM, Geert Uytterhoeven wrote: Remove dependencies on HAS_DMA where a Kconfig symbol depends on another symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST". In most cases this other symbol is an architecture or platform specific symbol, or PCI. Generic symbols

Patch "scsi: devinfo: apply to HP XP the same flags as Hitachi VSP" has been added to the 4.9-stable tree

2018-03-18 Thread gregkh
This is a note to let you know that I've just added the patch titled scsi: devinfo: apply to HP XP the same flags as Hitachi VSP to the 4.9-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "scsi: dh: add new rdac devices" has been added to the 4.9-stable tree

2018-03-18 Thread gregkh
This is a note to let you know that I've just added the patch titled scsi: dh: add new rdac devices to the 4.9-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Re: [PATCH v4] m68k/amiga - Amiga Zorro NCR53C9x boards: new zorro_esp.c

2018-03-18 Thread Kars de Jong
Hi Michael, 2018-03-17 2:16 GMT+01:00 Michael Schmitz : > From: Michael Schmitz > > New combined SCSI driver for all ESP based Zorro SCSI boards for > m68k Amiga. > > Code largely based on board specific parts of the old drivers (blz1230.c, > blz2060.c,